alexandria-book-collection-manager 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0ee9c80a67f5db92fba609abcc676763cea3caa7
-  data.tar.gz: 845f6aada1d8241f8b9401cee1964e0d5a411b7f
+SHA256:
+  metadata.gz: 68616d81acb2df9a9457285c4393b569a4d217c9e5b25371ad0e2addf3e24d93
+  data.tar.gz: 2f3f920293bfc91c7d23cb380c2b0a9806ca0eecf3112639ff859db8fee10faf
 SHA512:
-  metadata.gz: 6e4f738354ff4521abd4fafb0c70cb6467991083ca2b1d641070c2dbfaa0d516c93e79f98507c8500726447c9d03a284f94e3193b8e9c5d40c5fbd94a11a8f7a
-  data.tar.gz: cbf664f9496c5703da2892f935b93836f6eec3688ffc1f45c6772b28c35f036f4ca1a1744238a2b7f731821b25e9dd4e3bc433a12ed52046cee9ffa2ffaa2c9e
+  metadata.gz: e80f5e730a5d0e81e776968853974043cd672abf8e9aaffd568a9ae82c80c70c5a6ff86a6306072809690743e96fb473b32c292a09f2fc349b6a5b60abdbf07c
+  data.tar.gz: a7a037e7ac5cb5c91cf2f707fa77a34996fd1935cce22113fd0555868d146e47da892d64206bc61f065a3c853e4603d6e80c1e117be347d378e0ee9c989a4f32

data/.gitignore

@@ -10,6 +10,5 @@ share/locale/
 share/omf/alexandria/*.omf
 pkg/
 coverage/
-doc/
 tmp/
 *.gem

data/.rubocop.yml

@@ -1,18 +1,44 @@
 AllCops:
   Exclude:
+    - 'lib/alexandria/default_preferences.rb'
     - 'pkg/**/*'
+  TargetRubyVersion: 2.3
+
+# Dot at end of line makes it clearer that the line is not done
+Layout/DotPosition:
+  EnforcedStyle: trailing
+
+# Multi-line assignment should be simply indented. Aligning them makes it even
+# harder to keep a sane line length.
+Layout/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
+Layout/MultilineMethodCallBraceLayout:
+  EnforcedStyle: same_line
+
+# Multi-line method calls should be simply indented. Aligning them makes it
+# even harder to keep a sane line length.
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+# Make syntax for empty and filled blocks consistent
+Layout/SpaceBeforeBlockBraces:
+  EnforcedStyleForEmptyBraces: space
 
 # Allow if (foo = get_foo) style
 Lint/AssignmentInCondition:
   AllowSafeAssignment: true
 
-# Require lines to fit in pull requests.
-# This config is commented out temporarily to allow .rubocop_todo.yml to
-# configure this cop.
-#Metrics/LineLength:
-  #Max: 92
+# Blocks in specs can be any size
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*'
+
+# Be lenient with line length
+Metrics/LineLength:
+  Max: 110
 
-Style/AccessorMethodName:
+Naming/AccessorMethodName:
   Enabled: false
 
 # Allow multi-line blocks of all sorts
@@ -23,31 +49,14 @@ Style/BlockDelimiters:
 Style/AndOr:
   Enabled: conditionals
 
-# Dot at end of line makes it clearer that the line is not done
-Style/DotPosition:
-  EnforcedStyle: trailing
+# Prefer old school format strings
+Style/FormatStringToken:
+  EnforcedStyle: unannotated
 
 # Require at least two dependent lines before suggesting a guard clause
 Style/GuardClause:
   MinBodyLength: 2
 
-# Don't use if or unless as modifier if the line gets too long
-Style/IfUnlessModifier:
-  MaxLineLength: 60
-
-# Multi-line assignment should be simply indented. Aligning them makes it even
-# harder to keep a sane line length.
-Style/MultilineOperationIndentation:
-  EnforcedStyle: indented
-
-Style/MultilineMethodCallBraceLayout:
-  EnforcedStyle: same_line
-
-# Multi-line method calls should be simply indented. Aligning them makes it
-# even harder to keep a sane line length.
-Style/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
-
 # Not all objects that handle #== 0 also handle #zero?
 Style/NumericPredicate:
   Enabled: false
@@ -56,6 +65,11 @@ Style/NumericPredicate:
 Style/Next:
   Enabled: false
 
+# Use older RuboCop default
+Style/PercentLiteralDelimiters:
+  PreferredDelimiters:
+    '%w': ()
+
 # Allow explicit return with multiple return values
 Style/RedundantReturn:
   AllowMultipleReturnValues: true
@@ -67,12 +81,16 @@ Style/SignalException:
 Style/SingleLineBlockParams:
   Enabled: false
 
+# I like to have symbols always look like symbols
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
 # Accessors are only trivial if they match the ivar name.
 Style/TrivialAccessors:
   ExactNameMatch: true
 
 # Allow semantic choice of trailing comma
-Style/TrailingCommaInLiteral:
+Style/TrailingCommaInArrayLiteral:
   Enabled: false
 
 # Alexandria uses regular arrays

data/.rubocop_todo.yml

@@ -1,11 +1,22 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-11-01 21:29:40 +0100 using RuboCop version 0.45.0.
+# on 2018-03-18 12:56:55 +0100 using RuboCop version 0.53.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 12
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
+Layout/IndentHeredoc:
+  Exclude:
+    - 'Rakefile'
+    - 'bin/alexandria'
+    - 'lib/alexandria/export_library.rb'
+    - 'lib/alexandria/ui/dialogs/about_dialog.rb'
+
 # Offense count: 6
 Lint/HandleExceptions:
   Exclude:
@@ -21,77 +32,130 @@ Lint/IneffectiveAccessModifier:
     - 'lib/alexandria/web_themes.rb'
 
 # Offense count: 1
-Lint/LiteralInCondition:
+Lint/UnreachableCode:
   Exclude:
-    - 'util/rake/gettextgenerate.rb'
+    - 'lib/alexandria/ui/dialogs/export_dialog.rb'
 
 # Offense count: 1
-Lint/UnreachableCode:
+Lint/UriEscapeUnescape:
   Exclude:
-    - 'lib/alexandria/ui/dialogs/export_dialog.rb'
+    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
 
 # Offense count: 2
-# Configuration parameters: ContextCreatingMethods.
+# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
 Lint/UselessAccessModifier:
   Exclude:
     - 'lib/alexandria/logging.rb'
 
-# Offense count: 172
+# Offense count: 2
+Lint/UselessAssignment:
+  Exclude:
+    - 'lib/alexandria/models/library.rb'
+    - 'lib/alexandria/smart_library.rb'
+
+# Offense count: 165
 Metrics/AbcSize:
   Max: 161
 
-# Offense count: 21
-# Configuration parameters: CountComments.
+# Offense count: 22
+# Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
-  Max: 68
+  Max: 67
 
-# Offense count: 14
+# Offense count: 13
+# Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5
 
-# Offense count: 33
+# Offense count: 32
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
   Max: 994
 
-# Offense count: 75
+# Offense count: 68
 Metrics/CyclomaticComplexity:
   Max: 28
 
-# Offense count: 353
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 294
-
-# Offense count: 228
+# Offense count: 219
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
-  Max: 113
+  Max: 109
 
 # Offense count: 2
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 356
+  Max: 348
 
 # Offense count: 10
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 7
 
-# Offense count: 74
+# Offense count: 69
 Metrics/PerceivedComplexity:
   Max: 29
 
-# Offense count: 3
-Style/ClassAndModuleCamelCase:
+# Offense count: 8
+Naming/BinaryOperatorParameterName:
+  Exclude:
+    - 'lib/alexandria/book_providers.rb'
+    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
+    - 'lib/alexandria/models/book.rb'
+    - 'lib/alexandria/models/library.rb'
+    - 'lib/alexandria/smart_library.rb'
+    - 'lib/alexandria/ui/multi_drag_treeview.rb'
+
+# Offense count: 15
+# Configuration parameters: Blacklist.
+# Blacklist: END, (?-mix:EO[A-Z]{1})
+Naming/HeredocDelimiterNaming:
   Exclude:
-    - 'lib/alexandria/book_providers/bol_it.rb'
-    - 'lib/alexandria/book_providers/ibs_it.rb'
-    - 'lib/alexandria/book_providers/webster_it.rb'
+    - 'Rakefile'
+    - 'bin/alexandria'
+    - 'lib/alexandria/export_library.rb'
+    - 'lib/alexandria/ui/dialogs/about_dialog.rb'
+
+# Offense count: 2
+Naming/MemoizedInstanceVariableName:
+  Exclude:
+    - 'lib/alexandria/logging.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: snake_case, camelCase
+Naming/MethodName:
+  Exclude:
+    - 'lib/alexandria/book_providers/mcu.rb'
+
+# Offense count: 4
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+# MethodDefinitionMacros: define_method, define_singleton_method
+Naming/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
+    - 'lib/alexandria/ui/dialogs/smart_library_properties_dialog_base.rb'
+    - 'lib/alexandria/web_themes.rb'
+
+# Offense count: 10
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id
+Naming/UncommunicativeMethodParamName:
+  Exclude:
+    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
+    - 'lib/alexandria/book_providers/proxis.rb'
+    - 'lib/alexandria/book_providers/pseudomarc.rb'
+    - 'lib/alexandria/smart_library.rb'
+    - 'lib/alexandria/ui/callbacks.rb'
+    - 'lib/alexandria/ui/init.rb'
+    - 'util/rake/fileinstall.rb'
 
 # Offense count: 8
-# Configuration parameters: EnforcedStyle, SupportedStyles.
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Exclude:
@@ -112,13 +176,23 @@ Style/ClassVars:
     - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
     - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
 
-# Offense count: 121
+# Offense count: 12
+Style/CommentedKeyword:
+  Exclude:
+    - 'lib/alexandria/book_providers.rb'
+    - 'lib/alexandria/book_providers/barnes_and_noble.rb'
+    - 'lib/alexandria/book_providers/worldcat.rb'
+    - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
+    - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
+    - 'util/rake/fileinstall.rb'
+
+# Offense count: 118
 Style/Documentation:
   Enabled: false
 
 # Offense count: 6
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: for, each
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: each, for
 Style/For:
   Exclude:
     - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
@@ -126,26 +200,6 @@ Style/For:
     - 'lib/alexandria/book_providers/renaud.rb'
     - 'spec/alexandria/library_spec.rb'
 
-# Offense count: 25
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: format, sprintf, percent
-Style/FormatString:
-  Exclude:
-    - 'lib/alexandria/book_providers.rb'
-    - 'lib/alexandria/book_providers/adlibris.rb'
-    - 'lib/alexandria/book_providers/barnes_and_noble.rb'
-    - 'lib/alexandria/book_providers/deastore.rb'
-    - 'lib/alexandria/book_providers/siciliano.rb'
-    - 'lib/alexandria/book_providers/thalia.rb'
-    - 'lib/alexandria/book_providers/worldcat.rb'
-    - 'lib/alexandria/export_library.rb'
-    - 'lib/alexandria/ui/dialogs/acquire_dialog.rb'
-    - 'lib/alexandria/ui/dialogs/misc_dialogs.rb'
-    - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
-    - 'lib/alexandria/ui/dndable.rb'
-    - 'lib/alexandria/ui/listview.rb'
-    - 'lib/alexandria/ui/ui_manager.rb'
-
 # Offense count: 34
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
@@ -171,50 +225,37 @@ Style/MethodMissing:
     - 'lib/alexandria/book_providers.rb'
     - 'lib/alexandria/preferences.rb'
 
-# Offense count: 1
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: snake_case, camelCase
-Style/MethodName:
-  Exclude:
-    - 'lib/alexandria/book_providers/mcu.rb'
-
 # Offense count: 1
 Style/MultilineTernaryOperator:
   Exclude:
     - 'lib/alexandria/ui/listview.rb'
 
-# Offense count: 1
-Style/NestedTernaryOperator:
-  Exclude:
-    - 'lib/alexandria/ui/ui_manager.rb'
-
-# Offense count: 8
-Style/OpMethod:
+# Offense count: 23
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
   Exclude:
-    - 'lib/alexandria/book_providers.rb'
+    - 'lib/alexandria/book_providers/adlibris.rb'
     - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/models/book.rb'
+    - 'lib/alexandria/book_providers/douban.rb'
+    - 'lib/alexandria/book_providers/mcu.rb'
+    - 'lib/alexandria/book_providers/proxis.rb'
+    - 'lib/alexandria/book_providers/pseudomarc.rb'
+    - 'lib/alexandria/book_providers/renaud.rb'
+    - 'lib/alexandria/book_providers/siciliano.rb'
+    - 'lib/alexandria/book_providers/thalia.rb'
     - 'lib/alexandria/models/library.rb'
-    - 'lib/alexandria/smart_library.rb'
-    - 'lib/alexandria/ui/multi_drag_treeview.rb'
-
-# Offense count: 4
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
-# NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
-Style/PredicateName:
-  Exclude:
-    - 'spec/**/*'
-    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
-    - 'lib/alexandria/ui/dialogs/smart_library_properties_dialog_base.rb'
-    - 'lib/alexandria/web_themes.rb'
+    - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
+    - 'lib/alexandria/ui/sidepane.rb'
+    - 'util/rake/fileinstall.rb'
+    - 'util/rake/gettextgenerate.rb'
 
-# Offense count: 41
+# Offense count: 78
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: implicit, explicit
+Style/RescueStandardError:
   Enabled: false
 
 # Offense count: 3

data/.simplecov

@@ -1,3 +1,4 @@
 SimpleCov.start do
   track_files 'lib/**/*.rb'
+  add_filter '/spec/'
 end

data/.yardopts

@@ -1 +1 @@
-- INSTALL.rdoc
+- INSTALL.md