alexandria-book-collection-manager 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3f036a94a542570c4cbd37330bc4e7a08cb4ef0e
-  data.tar.gz: 61f6af24a98abc4281bea6558b3c70c2ece62e75
+  metadata.gz: 0ee9c80a67f5db92fba609abcc676763cea3caa7
+  data.tar.gz: 845f6aada1d8241f8b9401cee1964e0d5a411b7f
 SHA512:
-  metadata.gz: b594225692a4cd2cfc511ab4e6835dff6cfe379d8e21a13694065d3b0eab20348766af0c9314230bdd15de8d2ab1ed2d21e82081c4ec77a20f26a8ebf4187a1a
-  data.tar.gz: f8d35bbf4005a7d6b016bfdc0f7474397d602f4491d67470211667babd7a5bd93aa8f6e54312d45556cd6aea94a5c257fdeb287862a982943b655681b2d6cee2
+  metadata.gz: 6e4f738354ff4521abd4fafb0c70cb6467991083ca2b1d641070c2dbfaa0d516c93e79f98507c8500726447c9d03a284f94e3193b8e9c5d40c5fbd94a11a8f7a
+  data.tar.gz: cbf664f9496c5703da2892f935b93836f6eec3688ffc1f45c6772b28c35f036f4ca1a1744238a2b7f731821b25e9dd4e3bc433a12ed52046cee9ffa2ffaa2c9e

data/.gitignore

@@ -5,7 +5,11 @@ alexandria.desktop.in.h
 .svn-authors
 lib/alexandria/default_preferences.rb
 Gemfile.lock
+.yardoc/
 share/locale/
 share/omf/alexandria/*.omf
 pkg/
+coverage/
+doc/
+tmp/
 *.gem

data/.reek

@@ -0,0 +1,3 @@
+exclude_paths:
+  - spec
+  - util

data/.rubocop.yml

@@ -48,6 +48,10 @@ Style/MultilineMethodCallBraceLayout:
 Style/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
+# Not all objects that handle #== 0 also handle #zero?
+Style/NumericPredicate:
+  Enabled: false
+
 # Sometimes an if statement just looks better than next with a guard clause
 Style/Next:
   Enabled: false
@@ -75,4 +79,8 @@ Style/TrailingCommaInLiteral:
 Style/WordArray:
   Enabled: false
 
+# Not all objects that handle #length also handle #empty?
+Style/ZeroLengthPredicate:
+  Enabled: false
+
 inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -1,19 +1,18 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-10-01 20:35:02 +0200 using RuboCop version 0.43.0.
+# on 2016-11-01 21:29:40 +0100 using RuboCop version 0.45.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 7
+# Offense count: 6
 Lint/HandleExceptions:
   Exclude:
     - 'lib/alexandria/import_library_csv.rb'
     - 'lib/alexandria/models/library.rb'
     - 'lib/alexandria/ui/dialogs/book_properties_dialog.rb'
     - 'lib/alexandria/ui/dialogs/import_dialog.rb'
-    - 'lib/alexandria/ui/sound.rb'
 
 # Offense count: 2
 Lint/IneffectiveAccessModifier:
@@ -37,30 +36,35 @@ Lint/UselessAccessModifier:
   Exclude:
     - 'lib/alexandria/logging.rb'
 
-# Offense count: 173
+# Offense count: 172
 Metrics/AbcSize:
-  Max: 163
+  Max: 161
+
+# Offense count: 21
+# Configuration parameters: CountComments.
+Metrics/BlockLength:
+  Max: 68
 
 # Offense count: 14
 Metrics/BlockNesting:
   Max: 5
 
-# Offense count: 34
+# Offense count: 33
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 1007
+  Max: 994
 
-# Offense count: 78
+# Offense count: 75
 Metrics/CyclomaticComplexity:
   Max: 28
 
-# Offense count: 352
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# Offense count: 353
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives.
 # URISchemes: http, https
 Metrics/LineLength:
-  Max: 392
+  Max: 294
 
-# Offense count: 232
+# Offense count: 228
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 113
@@ -75,7 +79,7 @@ Metrics/ModuleLength:
 Metrics/ParameterLists:
   Max: 7
 
-# Offense count: 76
+# Offense count: 74
 Metrics/PerceivedComplexity:
   Max: 29
 
@@ -108,7 +112,7 @@ Style/ClassVars:
     - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
     - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
 
-# Offense count: 126
+# Offense count: 121
 Style/Documentation:
   Enabled: false
 
@@ -142,13 +146,7 @@ Style/FormatString:
     - 'lib/alexandria/ui/listview.rb'
     - 'lib/alexandria/ui/ui_manager.rb'
 
-# Offense count: 4
-# Configuration parameters: AllowedVariables.
-Style/GlobalVars:
-  Exclude:
-    - 'lib/alexandria/export_library.rb'
-
-# Offense count: 36
+# Offense count: 34
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false
@@ -185,10 +183,9 @@ Style/MultilineTernaryOperator:
   Exclude:
     - 'lib/alexandria/ui/listview.rb'
 
-# Offense count: 2
+# Offense count: 1
 Style/NestedTernaryOperator:
   Exclude:
-    - 'lib/alexandria/ui/completion_models.rb'
     - 'lib/alexandria/ui/ui_manager.rb'
 
 # Offense count: 8

data/.simplecov

@@ -0,0 +1,3 @@
+SimpleCov.start do
+  track_files 'lib/**/*.rb'
+end

data/.yardopts

@@ -0,0 +1 @@
+- INSTALL.rdoc

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.7.1 / 2016-12-13
+
+* Various code cleanups
+* Update dependencies
+* Don't crash if smart library name uses non-UTF-8 encoding
+
 ## 0.7.0
 
 * Various small bug fixes

data/Gemfile

@@ -4,7 +4,8 @@ source 'https://rubygems.org'
 gemspec
 
 group :development, :test do
-  gem 'rdoc', '~> 4.0'
   gem 'pry'
-  gem 'rubocop', '~> 0.43.0'
+  gem 'rubocop', '~> 0.46.0'
+  gem 'simplecov'
+  gem 'yard', '~> 0.9.5'
 end

data/INSTALL.rdoc

@@ -65,8 +65,6 @@ Note that these files are pre-generated in tar.gz releases, so you'll
 only need them if you're building from the SVN version, or want to
 change the translations.
 
-== Optional Dependencies
-
 === Ruby/ZOOM and Yaz
 
 For Z39.50 support and and the <b>Library of Congress</b> and
@@ -88,12 +86,6 @@ You will need
 <tt>image_size</tt>[http://rubyforge.org/projects/imagesize/] for
 optimizing the cover images in exported libraries.
 
-=== Revolution
-
-If you want to auto-complete the names of people you loan books to
-from your Evolution contacts database, you can install
-+revolution+[ http://revolution.rubyforge.org/].
-
 == Build and Install
 
 To build Alexandria from a subversion checkout, go to the base project

data/README.md

@@ -86,3 +86,75 @@ or, to get verbose debugging information,
 
 If you are running GNOME, Alexandria should appear under the
 'Applications > Office' menu.
+
+## Contributors
+
+The following people have contributed to Alexandria over the years:
+
+### Authors
+
+* Alexander McCormmach <alexander@tunicate.org>
+* Aymeric Nys <aymeric@nnx.com>
+* Cathal Mc Ginley <cathal.alexandria@gnostai.org>
+* Claudio Belotti <bel8@lilik.it>
+* Constantine Evans <cevans@costinet.org>
+* Dafydd Harries <daf@muse.19inch.net>
+* Javier Fernandez-Sanguino Pena <jfs@debian.org>
+* Joseph Method <tristil@gmail.com>
+* Kevin Schultz <schultkl@ieee.org>
+* Laurent Sansonetti <lrz@gnome.org>
+* Marco Costantini <costanti@science.unitn.it>
+* Mathieu Leduc-Hamel <arrak@arrak.org>
+* Matijs van Zuijlen <matijs@matijs.net>
+* Owain Evans <o.evans@gmail.com>
+* Pascal Terjan <pterjan@linuxfr.org>
+* Rene Samselnig <sandman@sdm-net.org>
+* Robby Stephenson <robby@periapsis.org>
+* Sun Ning <classicning@gmail.com>
+* Takayuki Kusano <AE5T-KSN@asahi-net.or.jp>
+* Timothy Malone <timothy.malone@gmail.com>
+* Zachary P. Landau <kapheine@hypa.net>
+
+### Documenters
+
+* Cathal Mc Ginley <cathal.alexandria@gnostai.org>
+* Liam Davison <registrations@liamjdavison.info>
+
+### Translators
+
+* Adrián Chaves Fernández <adriyetichaves@gmail.com> (gl)
+* Cathal Mc Ginley <cathal.alexandria@gnostai.org> (ga)
+* CHIKAMA Masaki <masaki.chikama@gmail.com> (ja)
+* Dafydd Harries <daf@muse.19inch.net> (cy)
+* Damjan Dimitrioski <damjandimitrioski@gmail.com> (mk)
+* Giacomo Margarito <giacomomargarito@gmail.com> (it)
+* Jack Myrseh <jack@enkom.no> (nb)
+* Joachim Breitner <mail@joachim-breitner.de> (de)
+* José Ling <jlgdot369@gmail.com> (zh_TW)
+* Lennart Karssen <lennart@karssen.org> (nl)
+* Lígia Moreira <ligia.moreira@netvisao.pt> (fr, pt, pt_BR)
+* Martin Karlsson <martinkarlsson81@hotmail.com> (sv)
+* Michael Kotsarinis <mkotsari1@pre.forthnet.gr> (el)
+* Miguel Ángel García <magmax@ieee.org> (es)
+* Peter Kováč <kovac.peter@fotopriestor.sk> (sk)
+* Petr Vanek <vanous@penguin.cz> (cs)
+* Piotr Drąg <piotrdrag@gmail.com> (pl)
+* Serhij Dubyk <dubyk@library.lviv.ua> (uk)
+
+### Artists
+
+* Andreas Nilsson <nisses.mail@home.se>
+* Stefanie Dijoux <stefanie.dijoux@gmail.com>
+
+## License
+
+Unless otherwise noted, the following license applies to all files that are
+part of Alexandria:
+
+Copyright (C) 2004-2006 Laurent Sansonetti
+Copyright (C) 2007-2010,2014-2016 Alexandria Contributors
+
+Alexandria is free software; you can redistribute it and/or modify it under the
+terms of the GNU General Public License as published by the Free Software
+Foundation; either version 2 of the License, or (at your option) any later
+version. See the file COPYING for details.

data/Rakefile

@@ -85,7 +85,7 @@ task debian_install: :install_package_staging
 FileInstallTask.new(:package) do |j|
   install_common(j)
 
-  docs = %w(README.rdoc NEWS INSTALL.rdoc COPYING TODO)
+  docs = %w(README.rdoc NEWS INSTALL.rdoc COPYING TODO.md)
   devel_docs = ['doc/AUTHORS', 'doc/BUGS', 'doc/FAQ',
                 'doc/cuecat_support.rdoc']
   j.install('', docs, "#{SHARE}/doc/#{PROJECT}")
@@ -215,7 +215,7 @@ Rake::PackageTask.new(PROJECT, Alexandria::DISPLAY_VERSION) do |p|
   p.need_tar_gz = true
   p.package_files.include('README*', 'COPYING', 'CHANGELOG.md', 'INSTALL.rdoc',
                           'NEWS', 'Rakefile', 'util/**/*',
-                          'TODO', 'alexandria.desktop',
+                          'TODO.md', 'alexandria.desktop',
                           'alexandria.desktop.in',
                           'bin/**/*', 'data/**/*', 'misc/**/*',
                           'doc/**/*', 'lib/**/*', 'po/**/*',
@@ -261,3 +261,5 @@ task install: [:pre_install, :install_package, :post_install]
 
 desc 'Uninstall Alexandria'
 task uninstall: [:uninstall_package] # TODO: gconf etc...
+
+task default: [:spec, :dogtail]

data/TODO.md

@@ -0,0 +1,26 @@
+Alexandria's TODO list
+======================
+
+This is an old list of TODO's.
+
+For the next release:
+
+* [x] Drag-and-drop books within libraries
+* [x] Infinite Undo/Redo
+* [x] Smart libraries
+* [x] CueCat userland support
+* [ ] Threading of all operations
+
+Future releases:
+
+* [ ] Sort providers meaningfully according to the current locale
+* [ ] ONIX import
+* [ ] Import/export via GNOME-DB
+* [ ] Zoom in the current view, giving more or less details
+* [ ] PDA support
+* [ ] Win32 MinGW port
+* [ ] Show more details about books, like number of pages, price, topic, a user
+      defined field
+* [ ] Printing
+* [ ] Editable views; for icons, renaming their title, for list, editing each
+      field

data/alexandria-book-collection-manager.gemspec

@@ -46,12 +46,15 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency('gettext', ['~> 3.1'])
   s.add_runtime_dependency('hpricot', ['~> 0.8.5'])
   s.add_runtime_dependency('htmlentities', ['~> 4.3'])
-  s.add_runtime_dependency('gtk3', ['~> 3.0.9'])
-  s.add_runtime_dependency('gio2', ['~> 3.0.9'])
+  s.add_runtime_dependency('gtk3', ['~> 3.1.0'])
+  s.add_runtime_dependency('gio2', ['~> 3.1.0'])
   s.add_runtime_dependency('gstreamer', ['~> 3.0'])
+  s.add_runtime_dependency('image_size', ['~> 1.5.0'])
+  s.add_runtime_dependency('marc', ['~> 1.0.0'])
+  s.add_runtime_dependency('zoom', ['~> 0.5.0'])
 
   s.add_development_dependency('minitest', ['~> 5.0'])
-  s.add_development_dependency('rake', ['~> 11.1'])
+  s.add_development_dependency('rake', ['~> 12.0'])
   s.add_development_dependency('rspec', ['~> 3.0'])
 
   s.require_paths = ['lib']

data/bin/alexandria

@@ -20,12 +20,7 @@
 # write to the Free Software Foundation, Inc., 51 Franklin Street,
 # Fifth Floor, Boston, MA 02110-1301 USA.
 
-begin
-  require 'gettext'
-rescue LoadError
-  require 'rubygems'
-  require 'gettext'
-end
+require 'gettext'
 require 'alexandria'
 require 'optparse'
 require 'ostruct'

data/dogtail/basic_run_test.py

@@ -0,0 +1,9 @@
+#!/usr/bin/env python
+
+from dogtail.tree import *
+from dogtail.utils import run
+
+run('bin/alexandria', appName = 'alexandria')
+app = root.application('alexandria')
+quit_item = app.menuItem('Quit')
+quit_item.doActionNamed('click')

data/lib/alexandria/book_providers.rb

@@ -307,12 +307,8 @@ module Alexandria
     require 'alexandria/book_providers/thalia'
     require 'alexandria/book_providers/worldcat'
 
-    # Ruby/ZOOM is optional
-    begin
-      require 'alexandria/book_providers/z3950'
-    rescue LoadError
-      log.info { "Can't load Ruby/ZOOM, hence Z39.50 and providers Library of Congress, British Library not available" }
-    end
+    # Z39.50 based providers
+    require 'alexandria/book_providers/z3950'
 
     attr_reader :abstract_classes
 

data/lib/alexandria/book_providers/proxis.rb

@@ -90,7 +90,7 @@ module Alexandria
             node.to_html
           elsif node.elem?
             if node.children.nil?
-              return nil
+              nil
             else
               node_text = node.children.map { |n| text_of(n) }.join
               node_text.strip.squeeze(' ')

data/lib/alexandria/book_providers/web.rb

@@ -45,7 +45,7 @@ module Alexandria
             node.to_html
           elsif node.elem?
             if node.children.nil?
-              return nil
+              nil
             else
               node_text = node.children.map { |n| text_of(n) }.join
               node_text.strip.squeeze(' ')

data/lib/alexandria/book_providers/z3950.rb

@@ -59,7 +59,7 @@ module Alexandria
         conn_count = type == SEARCH_BY_ISBN ? 1 : 10 # results to retrieve
         resultset = search_records(criterion, type, conn_count)
         log.debug { "total #{resultset.length}" }
-        raise NoResultsError if resultset.empty?
+        raise NoResultsError if resultset.length == 0
         results = books_from_marc(resultset, isbn)
         type == SEARCH_BY_ISBN ? results.first : results
       end
@@ -214,7 +214,7 @@ module Alexandria
         prefs.variable_named('port').default_value = 7090
         prefs.variable_named('database').default_value = 'Voyager'
         prefs.variable_named('record_syntax').default_value = 'USMARC'
-        prefs.variable_named('charset').default_value = 'ISO_6937'
+        prefs.variable_named('charset').default_value = 'ISO-8859-1'
         prefs.read
       end
 
@@ -257,7 +257,7 @@ module Alexandria
         conn_count = type == SEARCH_BY_ISBN ? 1 : 10 # results to retrieve
         resultset = search_records(criterion, type, conn_count)
         log.debug { "total #{resultset.length}" }
-        raise NoResultsError if resultset.empty?
+        raise NoResultsError if resultset.length == 0
         results = books_from_sutrs(resultset)
         type == SEARCH_BY_ISBN ? results.first : results
       end
@@ -340,7 +340,7 @@ module Alexandria
         criterion = canonicalise_isbn_with_dashes(criterion)
         resultset = search_records(criterion, type, 0)
         log.debug { "total #{resultset.length}" }
-        raise NoResultsError if resultset.empty?
+        raise NoResultsError if resultset.length == 0
         results = books_from_marc(resultset, isbn)
         type == SEARCH_BY_ISBN ? results.first : results
       end