alexandria-book-collection-manager 0.6.9 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 61f908fe208ec98c1146db7ba2fd1ee4cdcc6f1a
-  data.tar.gz: 8ab9bcc4418de8c7059feeb91fa5e92c7b210cc1
+  metadata.gz: 3f036a94a542570c4cbd37330bc4e7a08cb4ef0e
+  data.tar.gz: 61f6af24a98abc4281bea6558b3c70c2ece62e75
 SHA512:
-  metadata.gz: aac0be4c035663bbeb556167a5a349962746d080378ac76f5559830ed006da58d2a6be4fe48bc9d6aa08c649d135015f59a04af1decfc5a42271ebf63b5f5efa
-  data.tar.gz: 8f90fa49fa4556b30602d6f75e43b3e20d6e703204081b0eceb7d0e681956660a7d76a514d66e0c4a1c47e3ea83bfee94825139db1c61aea582c236b1795c695
+  metadata.gz: b594225692a4cd2cfc511ab4e6835dff6cfe379d8e21a13694065d3b0eab20348766af0c9314230bdd15de8d2ab1ed2d21e82081c4ec77a20f26a8ebf4187a1a
+  data.tar.gz: f8d35bbf4005a7d6b016bfdc0f7474397d602f4491d67470211667babd7a5bd93aa8f6e54312d45556cd6aea94a5c257fdeb287862a982943b655681b2d6cee2

data/.gitignore

@@ -8,3 +8,4 @@ Gemfile.lock
 share/locale/
 share/omf/alexandria/*.omf
 pkg/
+*.gem

data/.rubocop.yml

@@ -6,33 +6,26 @@ AllCops:
 Lint/AssignmentInCondition:
   AllowSafeAssignment: true
 
-# Allow multi-line blocks of all sorts
-Style/BlockDelimiters:
-  Enabled: false
-
-# Dot at end of line makes it clearer that the line is not done
-Style/DotPosition:
-  EnforcedStyle: trailing
-
 # Require lines to fit in pull requests.
 # This config is commented out temporarily to allow .rubocop_todo.yml to
 # configure this cop.
-#Style/LineLength:
+#Metrics/LineLength:
   #Max: 92
 
-# Always use raise to raise exceptions
-Style/SignalException:
-  EnforcedStyle: only_raise
+Style/AccessorMethodName:
+  Enabled: false
 
-# Allow explicit return with multiple return values
-Style/RedundantReturn:
-  AllowMultipleReturnValues: true
+# Allow multi-line blocks of all sorts
+Style/BlockDelimiters:
+  Enabled: false
 
-# Offense count: 10
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/FirstParameterIndentation:
-  EnforcedStyle: consistent
+# Allow and/or for control flow only
+Style/AndOr:
+  Enabled: conditionals
+
+# Dot at end of line makes it clearer that the line is not done
+Style/DotPosition:
+  EnforcedStyle: trailing
 
 # Require at least two dependent lines before suggesting a guard clause
 Style/GuardClause:
@@ -42,29 +35,40 @@ Style/GuardClause:
 Style/IfUnlessModifier:
   MaxLineLength: 60
 
-# Visually mark multiline operations by indenting
+# Multi-line assignment should be simply indented. Aligning them makes it even
+# harder to keep a sane line length.
 Style/MultilineOperationIndentation:
   EnforcedStyle: indented
 
-Style/TrivialAccessors:
-  ExactNameMatch: true
+Style/MultilineMethodCallBraceLayout:
+  EnforcedStyle: same_line
 
-Style/SingleLineBlockParams:
-  Enabled: false
+# Multi-line method calls should be simply indented. Aligning them makes it
+# even harder to keep a sane line length.
+Style/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
 
 # Sometimes an if statement just looks better than next with a guard clause
 Style/Next:
   Enabled: false
 
-Style/AccessorMethodName:
-  Enabled: false
+# Allow explicit return with multiple return values
+Style/RedundantReturn:
+  AllowMultipleReturnValues: true
 
-# Support use of and and or for control flow.
-Style/AndOr:
+# Always use raise to raise exceptions
+Style/SignalException:
+  EnforcedStyle: only_raise
+
+Style/SingleLineBlockParams:
   Enabled: false
 
+# Accessors are only trivial if they match the ivar name.
+Style/TrivialAccessors:
+  ExactNameMatch: true
+
 # Allow semantic choice of trailing comma
-Style/TrailingComma:
+Style/TrailingCommaInLiteral:
   Enabled: false
 
 # Alexandria uses regular arrays

data/.rubocop_todo.yml

@@ -1,5 +1,6 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2015-07-11 13:17:41 +0200 using RuboCop version 0.32.1.
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-10-01 20:35:02 +0200 using RuboCop version 0.43.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -7,136 +8,220 @@
 
 # Offense count: 7
 Lint/HandleExceptions:
-  Enabled: false
+  Exclude:
+    - 'lib/alexandria/import_library_csv.rb'
+    - 'lib/alexandria/models/library.rb'
+    - 'lib/alexandria/ui/dialogs/book_properties_dialog.rb'
+    - 'lib/alexandria/ui/dialogs/import_dialog.rb'
+    - 'lib/alexandria/ui/sound.rb'
+
+# Offense count: 2
+Lint/IneffectiveAccessModifier:
+  Exclude:
+    - 'lib/alexandria/logging.rb'
+    - 'lib/alexandria/web_themes.rb'
 
-# Offense count: 185
+# Offense count: 1
+Lint/LiteralInCondition:
+  Exclude:
+    - 'util/rake/gettextgenerate.rb'
+
+# Offense count: 1
+Lint/UnreachableCode:
+  Exclude:
+    - 'lib/alexandria/ui/dialogs/export_dialog.rb'
+
+# Offense count: 2
+# Configuration parameters: ContextCreatingMethods.
+Lint/UselessAccessModifier:
+  Exclude:
+    - 'lib/alexandria/logging.rb'
+
+# Offense count: 173
 Metrics/AbcSize:
-  Max: 165
+  Max: 163
 
 # Offense count: 14
 Metrics/BlockNesting:
   Max: 5
 
-# Offense count: 35
+# Offense count: 34
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 1065
+  Max: 1007
 
-# Offense count: 79
+# Offense count: 78
 Metrics/CyclomaticComplexity:
   Max: 28
 
-# Offense count: 339
-# Configuration parameters: AllowURI, URISchemes.
+# Offense count: 352
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# URISchemes: http, https
 Metrics/LineLength:
   Max: 392
 
-# Offense count: 240
+# Offense count: 232
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
-  Max: 116
+  Max: 113
 
 # Offense count: 2
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 344
+  Max: 356
 
-# Offense count: 5
+# Offense count: 10
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 7
 
-# Offense count: 78
+# Offense count: 76
 Metrics/PerceivedComplexity:
   Max: 29
 
 # Offense count: 3
 Style/ClassAndModuleCamelCase:
-  Enabled: false
+  Exclude:
+    - 'lib/alexandria/book_providers/bol_it.rb'
+    - 'lib/alexandria/book_providers/ibs_it.rb'
+    - 'lib/alexandria/book_providers/webster_it.rb'
 
-# Offense count: 12
+# Offense count: 8
 # Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
-  Enabled: false
+  Exclude:
+    - 'lib/alexandria/ui/dialogs/import_dialog.rb'
+    - 'lib/alexandria/ui/dialogs/preferences_dialog.rb'
+    - 'lib/alexandria/ui/icons.rb'
+    - 'lib/alexandria/ui/init.rb'
 
 # Offense count: 17
 Style/ClassVars:
-  Enabled: false
-
-# Offense count: 28
-# Cop supports --auto-correct.
-# Configuration parameters: Keywords.
-Style/CommentAnnotation:
-  Enabled: false
-
-# Offense count: 135
+  Exclude:
+    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
+    - 'lib/alexandria/execution_queue.rb'
+    - 'lib/alexandria/logging.rb'
+    - 'lib/alexandria/models/library.rb'
+    - 'lib/alexandria/smart_library.rb'
+    - 'lib/alexandria/ui/dialogs/acquire_dialog.rb'
+    - 'lib/alexandria/ui/dialogs/book_properties_dialog_base.rb'
+    - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
+
+# Offense count: 126
 Style/Documentation:
   Enabled: false
 
-# Offense count: 7
+# Offense count: 6
 # Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: for, each
 Style/For:
-  Enabled: false
+  Exclude:
+    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
+    - 'lib/alexandria/book_providers/douban.rb'
+    - 'lib/alexandria/book_providers/renaud.rb'
+    - 'spec/alexandria/library_spec.rb'
 
 # Offense count: 25
 # Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: format, sprintf, percent
 Style/FormatString:
-  Enabled: false
+  Exclude:
+    - 'lib/alexandria/book_providers.rb'
+    - 'lib/alexandria/book_providers/adlibris.rb'
+    - 'lib/alexandria/book_providers/barnes_and_noble.rb'
+    - 'lib/alexandria/book_providers/deastore.rb'
+    - 'lib/alexandria/book_providers/siciliano.rb'
+    - 'lib/alexandria/book_providers/thalia.rb'
+    - 'lib/alexandria/book_providers/worldcat.rb'
+    - 'lib/alexandria/export_library.rb'
+    - 'lib/alexandria/ui/dialogs/acquire_dialog.rb'
+    - 'lib/alexandria/ui/dialogs/misc_dialogs.rb'
+    - 'lib/alexandria/ui/dialogs/new_book_dialog.rb'
+    - 'lib/alexandria/ui/dndable.rb'
+    - 'lib/alexandria/ui/listview.rb'
+    - 'lib/alexandria/ui/ui_manager.rb'
 
 # Offense count: 4
 # Configuration parameters: AllowedVariables.
 Style/GlobalVars:
-  Enabled: false
+  Exclude:
+    - 'lib/alexandria/export_library.rb'
 
-# Offense count: 23
+# Offense count: 36
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false
 
-# Offense count: 68
-# Cop supports --auto-correct.
-# Configuration parameters: MaxLineLength.
-Style/IfUnlessModifier:
-  Enabled: false
+# Offense count: 4
+Style/IdenticalConditionalBranches:
+  Exclude:
+    - 'lib/alexandria/book_providers/amazon_aws.rb'
+    - 'lib/alexandria/ui/ui_manager.rb'
 
 # Offense count: 4
+Style/IfInsideElse:
+  Exclude:
+    - 'lib/alexandria/book_providers/proxis.rb'
+    - 'lib/alexandria/book_providers/web.rb'
+    - 'lib/alexandria/preferences.rb'
+    - 'lib/alexandria/ui/ui_manager.rb'
+
+# Offense count: 2
+Style/MethodMissing:
+  Exclude:
+    - 'lib/alexandria/book_providers.rb'
+    - 'lib/alexandria/preferences.rb'
+
+# Offense count: 1
 # Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, camelCase
 Style/MethodName:
-  Enabled: false
+  Exclude:
+    - 'lib/alexandria/book_providers/mcu.rb'
 
 # Offense count: 1
 Style/MultilineTernaryOperator:
-  Enabled: false
+  Exclude:
+    - 'lib/alexandria/ui/listview.rb'
 
 # Offense count: 2
 Style/NestedTernaryOperator:
-  Enabled: false
+  Exclude:
+    - 'lib/alexandria/ui/completion_models.rb'
+    - 'lib/alexandria/ui/ui_manager.rb'
 
 # Offense count: 8
 Style/OpMethod:
-  Enabled: false
-
-# Offense count: 7
-# Cop supports --auto-correct.
-Style/ParallelAssignment:
-  Enabled: false
+  Exclude:
+    - 'lib/alexandria/book_providers.rb'
+    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
+    - 'lib/alexandria/models/book.rb'
+    - 'lib/alexandria/models/library.rb'
+    - 'lib/alexandria/smart_library.rb'
+    - 'lib/alexandria/ui/multi_drag_treeview.rb'
 
 # Offense count: 4
-# Configuration parameters: NamePrefix, NamePrefixBlacklist.
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
 Style/PredicateName:
-  Enabled: false
-
-# Offense count: 11
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/RaiseArgs:
-  Enabled: false
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/alexandria/book_providers/amazon_ecs_util.rb'
+    - 'lib/alexandria/ui/dialogs/smart_library_properties_dialog_base.rb'
+    - 'lib/alexandria/web_themes.rb'
 
 # Offense count: 41
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
 Style/RegexpLiteral:
   Enabled: false
 
 # Offense count: 3
 Style/StructInheritance:
-  Enabled: false
+  Exclude:
+    - 'lib/alexandria/smart_library.rb'
+    - 'lib/alexandria/ui/multi_drag_treeview.rb'

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.7.0
+
+* Various small bug fixes
+* Update to ruby-gnome2 3.0.9
+* Improve specs
+* Port to Gtk+ 3
+* Restore Barcode animation
+* Remove old String#convert monkey-patch
+* Simplify sound system and stop it from hanging Alexandria
+
 ## 0.6.9
 
 * Update/fix authorship information and other metadata

data/Gemfile

@@ -6,4 +6,5 @@ gemspec
 group :development, :test do
   gem 'rdoc', '~> 4.0'
   gem 'pry'
+  gem 'rubocop', '~> 0.43.0'
 end

data/Rakefile

@@ -1,7 +1,7 @@
 # -*- ruby -*-
 #--
 # Copyright (C) 2009 Cathal Mc Ginley
-# Copyright (C) 2011, 2014 Matijs van Zuijlen
+# Copyright (C) 2011, 2014, 2016 Matijs van Zuijlen
 #
 # This file is part of the Alexandria build system.
 #
@@ -39,7 +39,7 @@ require_relative 'lib/alexandria/version'
 stage_dir = ENV['DESTDIR'] || 'tmp'
 prefix_dir = ENV['PREFIX'] || '/usr'
 
-PROJECT = 'alexandria'
+PROJECT = 'alexandria'.freeze
 PREFIX = prefix_dir
 share_dir = ENV['SHARE'] || "#{PREFIX}/share"
 SHARE = share_dir
@@ -56,12 +56,12 @@ end
 
 SHARE_FILE_GLOBS = ['data/alexandria/**/*', 'data/gnome/**/*.*',
                     'data/locale/**/*.mo', 'data/omf/**/*.omf',
-                    'data/sounds/**/*.ogg'] # , 'data/menu/*']
+                    'data/sounds/**/*.ogg'].freeze # , 'data/menu/*']
 
 ICON_FILE_GLOBS = ['data/app-icon/**/*.png',
-                   'data/app-icon/scalable/*.svg']
+                   'data/app-icon/scalable/*.svg'].freeze
 
-PIXMAP_GLOBS = 'data/app-icon/32x32/*.xpm'
+PIXMAP_GLOBS = 'data/app-icon/32x32/*.xpm'.freeze
 
 def install_common(install_task)
   install_task.install_exe('bin', 'bin/*', "#{PREFIX}/bin")
@@ -92,8 +92,7 @@ FileInstallTask.new(:package) do |j|
   j.install('doc', devel_docs, "#{SHARE}/doc/#{PROJECT}")
 
   j.uninstall_empty_dirs(["#{SHARE}/**/#{PROJECT}/",
-                          "#{j.rubylib}/#{PROJECT}/"
-                         ])
+                          "#{j.rubylib}/#{PROJECT}/"])
 end
 
 task :clobberp do
@@ -134,7 +133,7 @@ def convert_with_type(value, type)
   end
 end
 
-SCHEMA_PATH = 'schemas/alexandria.schemas'
+SCHEMA_PATH = 'schemas/alexandria.schemas'.freeze
 
 # This generates default_preferences.rb by copying over values from
 # providers_priority key in alexandria.schemas (necessary?)
@@ -150,7 +149,7 @@ file 'lib/alexandria/default_preferences.rb' => [SCHEMA_PATH] do |f|
     varname = File.basename(element.elements['key'].text)
     type = element.elements['type'].text
 
-    if type == 'list' or type == 'pair'
+    if (type == 'list') || (type == 'pair')
       ary = default[1..-2].split(',')
       next if ary.empty?
       if type == 'list'
@@ -203,7 +202,7 @@ task default: [:build]
 
 # pre-release tasks
 
-ULTRA_CLOBBER = []
+ULTRA_CLOBBER = [].freeze
 task ultra_clobber: :clobber do
   ULTRA_CLOBBER.each do |file|
     FileUtils::Verbose.rm_f(file)
@@ -234,7 +233,7 @@ task :scrollkeeper do
   unless system('which scrollkeeper-update')
     raise 'scrollkeeper-update cannot be found, is Scrollkeeper correctly installed?'
   end
-  system('scrollkeeper-update -q') or raise 'Scrollkeeper update failed'
+  system('scrollkeeper-update -q') || raise('Scrollkeeper update failed')
 end
 
 task :gconf do