alexandria-book-collection-manager 0.6.9.pre1 → 0.6.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cd0d2c094422c6a5f3d6cbeba613f2e0df65ece9
-  data.tar.gz: d61c27345935794f64d12b9a267a5aedc378df86
+  metadata.gz: 61f908fe208ec98c1146db7ba2fd1ee4cdcc6f1a
+  data.tar.gz: 8ab9bcc4418de8c7059feeb91fa5e92c7b210cc1
 SHA512:
-  metadata.gz: 70881d7084827b547ce67317a9f062c2da9f77c73c75277d5978eff6d30820d80f31c348f81b29b3eb6dc4cfd4130439ded45455fa9063c90aa260f03e8359d0
-  data.tar.gz: 41d3b9fce3eb405ac53758cd38c7b744accb47b64a396aebbc0f80213b8541b2d0bcdcd8e0f44b0aaacd5c57144a540898d1c3118c00a1a39cd4c5bf6c819efb
+  metadata.gz: aac0be4c035663bbeb556167a5a349962746d080378ac76f5559830ed006da58d2a6be4fe48bc9d6aa08c649d135015f59a04af1decfc5a42271ebf63b5f5efa
+  data.tar.gz: 8f90fa49fa4556b30602d6f75e43b3e20d6e703204081b0eceb7d0e681956660a7d76a514d66e0c4a1c47e3ea83bfee94825139db1c61aea582c236b1795c695

data/.rubocop.yml

@@ -28,6 +28,12 @@ Style/SignalException:
 Style/RedundantReturn:
   AllowMultipleReturnValues: true
 
+# Offense count: 10
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/FirstParameterIndentation:
+  EnforcedStyle: consistent
+
 # Require at least two dependent lines before suggesting a guard clause
 Style/GuardClause:
   MinBodyLength: 2
@@ -36,6 +42,10 @@ Style/GuardClause:
 Style/IfUnlessModifier:
   MaxLineLength: 60
 
+# Visually mark multiline operations by indenting
+Style/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
 Style/TrivialAccessors:
   ExactNameMatch: true
 
@@ -53,10 +63,6 @@ Style/AccessorMethodName:
 Style/AndOr:
   Enabled: false
 
-# RuboCop has no setting to accept how vim aligns parameters.
-Style/AlignParameters:
-  Enabled: false
-
 # Allow semantic choice of trailing comma
 Style/TrailingComma:
   Enabled: false

data/.rubocop_todo.yml

@@ -1,49 +1,45 @@
 # This configuration was generated by `rubocop --auto-gen-config`
-# on 2015-04-27 09:14:49 +0200 using RuboCop version 0.30.0.
+# on 2015-07-11 13:17:41 +0200 using RuboCop version 0.32.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 4
-# Cop supports --auto-correct.
-Lint/BlockAlignment:
-  Enabled: false
-
 # Offense count: 7
 Lint/HandleExceptions:
   Enabled: false
 
-# Offense count: 2
-Lint/LiteralInCondition:
-  Enabled: false
-
 # Offense count: 185
 Metrics/AbcSize:
   Max: 165
 
-# Offense count: 15
+# Offense count: 14
 Metrics/BlockNesting:
   Max: 5
 
 # Offense count: 35
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 1071
+  Max: 1065
 
 # Offense count: 79
 Metrics/CyclomaticComplexity:
   Max: 28
 
-# Offense count: 332
+# Offense count: 339
 # Configuration parameters: AllowURI, URISchemes.
 Metrics/LineLength:
-  Max: 395
+  Max: 392
 
-# Offense count: 241
+# Offense count: 240
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
-  Max: 117
+  Max: 116
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 344
 
 # Offense count: 5
 # Configuration parameters: CountKeywordArgs.
@@ -54,11 +50,6 @@ Metrics/ParameterLists:
 Metrics/PerceivedComplexity:
   Max: 29
 
-# Offense count: 13
-# Cop supports --auto-correct.
-Style/BlockEndNewline:
-  Enabled: false
-
 # Offense count: 3
 Style/ClassAndModuleCamelCase:
   Enabled: false
@@ -73,6 +64,7 @@ Style/ClassVars:
   Enabled: false
 
 # Offense count: 28
+# Cop supports --auto-correct.
 # Configuration parameters: Keywords.
 Style/CommentAnnotation:
   Enabled: false
@@ -81,28 +73,6 @@ Style/CommentAnnotation:
 Style/Documentation:
   Enabled: false
 
-# Offense count: 3
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/EmptyElse:
-  Enabled: false
-
-# Offense count: 27
-# Cop supports --auto-correct.
-Style/EmptyLinesAroundAccessModifier:
-  Enabled: false
-
-# Offense count: 31
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/EmptyLinesAroundBlockBody:
-  Enabled: false
-
-# Offense count: 10
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/FirstParameterIndentation:
-  Enabled: false
-
 # Offense count: 7
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/For:
@@ -118,56 +88,23 @@ Style/FormatString:
 Style/GlobalVars:
   Enabled: false
 
-# Offense count: 22
+# Offense count: 23
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
-Style/HashSyntax:
-  Enabled: false
-
-# Offense count: 66
+# Offense count: 68
 # Cop supports --auto-correct.
 # Configuration parameters: MaxLineLength.
 Style/IfUnlessModifier:
   Enabled: false
 
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/InfiniteLoop:
-  Enabled: false
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/MethodDefParentheses:
-  Enabled: false
-
 # Offense count: 4
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/MethodName:
   Enabled: false
 
-# Offense count: 13
-# Cop supports --auto-correct.
-Style/MultilineBlockLayout:
-  Enabled: false
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/MultilineIfThen:
-  Enabled: false
-
-# Offense count: 23
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/MultilineOperationIndentation:
-  Enabled: false
-
-# Offense count: 11
+# Offense count: 1
 Style/MultilineTernaryOperator:
   Enabled: false
 
@@ -179,6 +116,11 @@ Style/NestedTernaryOperator:
 Style/OpMethod:
   Enabled: false
 
+# Offense count: 7
+# Cop supports --auto-correct.
+Style/ParallelAssignment:
+  Enabled: false
+
 # Offense count: 4
 # Configuration parameters: NamePrefix, NamePrefixBlacklist.
 Style/PredicateName:

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 0.6.9
+
+* Update/fix authorship information and other metadata
+* Fix crash opening preferences dialog
+* Fix crash opening book dialog
+* Clean up code
+* Merge tests into specs
+* Update dependencies to latest gtk2 and gstreamer gems
+
 ## 0.6.9.pre1
 
 * Start providing a gemspec to allow installation as a gem
@@ -7,7 +16,6 @@
 * Update specs and tests
 * Modernize build environment
 
-
 ## 0.6.8
 
 * Removed dependencies on deprecated Ruby/GNOME2 libraries, to get

data/README.md

@@ -19,7 +19,7 @@ Alexandria is written in Ruby using ruby-gnome2.
 Where can I get it?
 ===================
 
-An experimental gem release can be installed by running
+You can install alexandria as a gem by running
 
     gem install alexandria-book-collection-manager
 

data/Rakefile

@@ -220,7 +220,7 @@ Rake::PackageTask.new(PROJECT, Alexandria::DISPLAY_VERSION) do |p|
                           'alexandria.desktop.in',
                           'bin/**/*', 'data/**/*', 'misc/**/*',
                           'doc/**/*', 'lib/**/*', 'po/**/*',
-                          'schemas/**/*', 'spec/**/*', 'tests/**/*')
+                          'schemas/**/*', 'spec/**/*')
 end
 
 task tgz: [:build] do

data/alexandria-book-collection-manager.gemspec

@@ -8,7 +8,29 @@ Gem::Specification.new do |s|
   s.summary = 'GNOME application for managing collections of books'
   s.required_ruby_version = '>= 1.9.3'
 
-  s.authors = ['Matijs van Zuijlen']
+  s.authors = [
+    'Alexander McCormmach',
+    'Aymeric Nys',
+    'Cathal Mc Ginley',
+    'Claudio Belotti',
+    'Constantine Evans',
+    'Dafydd Harries',
+    'Javier Fernandez-Sanguino Pena',
+    'Joseph Method',
+    'Kevin Schultz',
+    'Laurent Sansonetti',
+    'Marco Costantini',
+    'Mathieu Leduc-Hamel',
+    'Matijs van Zuijlen',
+    'Owain Evans',
+    'Pascal Terjan',
+    'Rene Samselnig',
+    'Robby Stephenson',
+    'Sun Ning',
+    'Takayuki Kusano',
+    'Timothy Malone',
+    'Zachary P. Landau'
+  ]
   s.email = ['matijs@matijs.net']
   s.homepage = 'http://www.github.com/mvz/alexandria-book-collection-manager'
 
@@ -17,15 +39,15 @@ Gem::Specification.new do |s|
   s.files = `git ls-files -z`.split("\0") |
     ['lib/alexandria/default_preferences.rb']
 
-  s.executables = s.files.grep(%r{^bin/}).map { |path| File.basename(path) }
+  s.executables = ['alexandria']
 
   s.rdoc_options = ['--main', 'README.md']
 
   s.add_runtime_dependency('gettext', ['~> 3.1'])
   s.add_runtime_dependency('hpricot', ['~> 0.8.5'])
   s.add_runtime_dependency('htmlentities', ['~> 4.3'])
-  s.add_runtime_dependency('gtk2', ['~> 2.2'])
-  s.add_runtime_dependency('gstreamer', ['~> 2.2'])
+  s.add_runtime_dependency('gtk2', ['~> 3.0'])
+  s.add_runtime_dependency('gstreamer', ['~> 3.0'])
 
   s.add_development_dependency('minitest', ['~> 5.0'])
   s.add_development_dependency('rake', ['~> 10.0'])

data/bin/alexandria

@@ -74,7 +74,7 @@ Backtrace:
 Release: #{Alexandria::VERSION}(#{Alexandria::DISPLAY_VERSION})
 Uname -a: #{`uname -a`.chomp}
 --
-Please report this dump to '#{Alexandria::LIST}' with some additional
+Please report this dump to '#{Alexandria::BUGREPORT_URL}' with some additional
 information, such as the description of the crash and the steps to reproduce it
 (if it's possible).
 EOS

data/doc/AUTHORS

@@ -1,5 +1,5 @@
 Maintainer:
-Joseph Method <tristil@gmail.com>
+Matijs van Zuijlen <matijs@matijs.net>
 
 Contributors:
 Alexander McCormmach <alexander@tunicate.org>
@@ -9,6 +9,7 @@ Claudio Belotti <bel8@lilik.it>
 Constantine Evans <cevans@costinet.org>
 Dafydd Harries <daf@muse.19inch.net>
 Javier Fernandez-Sanguino Pena <jfs@debian.org>
+Joseph Method <tristil@gmail.com>
 Kevin Schultz <schultkl@ieee.org>
 Laurent Sansonetti <lrz@gnome.org>
 Marco Costantini <costanti@science.unitn.it>

data/lib/alexandria.rb

@@ -1,5 +1,5 @@
 # Copyright (C) 2004-2006 Laurent Sansonetti
-# Modifications Copyright (C) 2011 Matijs van Zuijlen
+# Copyright (C) 2011 Matijs van Zuijlen
 #
 # Alexandria is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License as

data/lib/alexandria/about.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # Copyright (C) 2004-2006 Laurent Sansonetti
 # Copyright (C) 2008 Joseph Method
+# Copyright (C) 2015 Matijs van Zuijlen
 #
 # Alexandria is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License as
@@ -23,8 +24,8 @@ module Alexandria
   extend GetText
   bindtextdomain(Alexandria::TEXTDOMAIN, charset: 'UTF-8')
   DESCRIPTION = _('A program to help you manage your book collection.')
-  COPYRIGHT = "Copyright (C) 2004,2005,2006 Laurent Sansonetti\n" \
-    'Copyright (C) 2007,2008,2009,2010 Alexandria Contributors'
+  COPYRIGHT = "Copyright (C) 2004-2006 Laurent Sansonetti\n" \
+    'Copyright (C) 2007-2010,2014,2015 Alexandria Contributors'
   AUTHORS = [
     'Alexander McCormmach <alexander@tunicate.org>',
     'Aymeric Nys <aymeric@nnx.com>',
@@ -38,6 +39,7 @@ module Alexandria
     'Laurent Sansonetti <lrz@gnome.org>',
     'Marco Costantini <costanti@science.unitn.it>',
     'Mathieu Leduc-Hamel <arrak@arrak.org>',
+    'Matijs van Zuijlen <matijs@matijs.net>',
     'Owain Evans <o.evans@gmail.com>',
     'Pascal Terjan <pterjan@linuxfr.org>',
     'Rene Samselnig <sandman@sdm-net.org>',
@@ -75,8 +77,6 @@ module Alexandria
     'Andreas Nilsson <nisses.mail@home.se>',
     'Stefanie Dijoux <stefanie.dijoux@gmail.com>'
   ]
-  LIST = 'alexandria-list@rubyforge.org'
-  BUGREPORT_URL = 'http://rubyforge.org/tracker/?func=add&group_id=205&atid=863'
-  WEBSITE_URL = 'http://alexandria.rubyforge.org'
-  DONATE_URL = ''
+  BUGREPORT_URL = 'http://www.github.com/mvz/alexandria-book-collection-manager/issues'
+  WEBSITE_URL = 'http://www.github.com/mvz/alexandria-book-collection-manager'
 end

data/lib/alexandria/book_providers.rb

@@ -131,7 +131,7 @@ module Alexandria
 
       class Variable
         attr_reader :name, :description,
-        :possible_values
+                    :possible_values
         attr_accessor :value
 
         def initialize(provider, name, description, default_value,

data/lib/alexandria/book_providers/adlibris.rb

@@ -105,7 +105,6 @@ module Alexandria
         return [] unless search_hit
 
         (search_hit / 'ul.ulSearch table').each do |t|
-
           result = {}
           if (title_data = (t % 'div.divTitle'))
             result[:title] = (title_data % :a).inner_text
@@ -114,7 +113,6 @@ module Alexandria
           result[:lookup_url] = "#{SITE}#{lookup_url}"
 
           book_search_results << result
-
         end
         book_search_results
       end
@@ -225,8 +223,10 @@ module Alexandria
         rescue => ex
           raise ex if ex.instance_of? NoResultsError
           trace = ex.backtrace.join("\n> ")
-          log.warn {'Failed parsing search results for AdLibris ' \
-            "#{ex.message} #{trace}" }
+          log.warn {
+            'Failed parsing search results for AdLibris ' \
+            "#{ex.message} #{trace}"
+          }
           raise NoResultsError
         end
       end

data/lib/alexandria/book_providers/barnes_and_noble.rb

@@ -1,7 +1,7 @@
 # -*- ruby -*-
 #
 # Copyright (C) 2009 Cathal Mc Ginley
-# Modifications Copyright (C) 2011, 2014 Matijs van Zuijlen
+# Copyright (C) 2011, 2014 Matijs van Zuijlen
 #
 # Alexandria is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License as
@@ -134,8 +134,10 @@ module Alexandria
           end
         rescue => ex
           trace = ex.backtrace.join("\n> ")
-          log.warn {'Failed parsing search results for Barnes & Noble ' \
-            "#{ex.message} #{trace}" }
+          log.warn {
+            'Failed parsing search results for Barnes & Noble ' \
+            "#{ex.message} #{trace}"
+          }
         end
         book_search_results
       end
@@ -219,8 +221,10 @@ module Alexandria
         rescue => ex
           raise ex if ex.instance_of? NoResultsError
           trace = ex.backtrace.join("\n> ")
-          log.warn {'Failed parsing search results for BarnesAndNoble ' \
-            "#{ex.message} #{trace}" }
+          log.warn {
+            'Failed parsing search results for BarnesAndNoble ' \
+            "#{ex.message} #{trace}"
+          }
           raise NoResultsError
         end
       end