alephant-broker 3.15.2 → 3.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a1d2a83b80e06b6997939b7ac7a05017d46ce02f
-  data.tar.gz: 5db2fd8af88502c3ee560b7c925ce80e2c8cc4bf
+  metadata.gz: 439cfba9dae34a1931b2bb86e829c3f6da30f268
+  data.tar.gz: a025262a57c2ad7d236456002f629aa0d64e0533
 SHA512:
-  metadata.gz: 61f971597070da6cf55911398e7124945d873b8420db7fea05f443dd666763e271abe4db86bac68601ee1ae73b50857f8c76b57af666108b5b43893a6d854c8c
-  data.tar.gz: 233504dc59be0a68487fc1e6670d3919194c266f5531773c3dd4c1e7d8cffd2be092b2aa72479037f1cfb1a35f86009b63846ecf5576d9424a1d45d0cd726798
+  metadata.gz: 5d0de2d1a911fda4e049e8f4a160ae3be58707b5edc9d9aecda62ccd4bd020287528b0065b2990e899cf6ee88467f88688f4a03567b577a40af3cc3b77fc615c
+  data.tar.gz: 9a0b598a6a517e7f2f4dc9146c7b197de5daa8d8c55238c54ffdaf650adf293152592bfe963d83a74d4857d1ff8591ef91339979d04e5d782884cdb304ca0030

data/lib/alephant/broker/load_strategy/revalidate/strategy.rb

@@ -21,6 +21,8 @@ module Alephant
 
             data = loaded_content.to_h
             data.fetch(:meta, {})[:status] = 200
+            add_revalidating_headers(data) if loaded_content.expired?
+
             data
           rescue *STORAGE_ERRORS
             update_content(component_meta)
@@ -59,6 +61,11 @@ module Alephant
             end
           end
 
+          def add_revalidating_headers(data)
+             data[:headers] ||= {}
+             data[:headers]['broker-cache'] = 'revalidating'
+          end
+
           def fetch_stored_content(component_meta)
             Fetcher.new(component_meta).fetch
           rescue *STORAGE_ERRORS

data/lib/alephant/broker/version.rb

@@ -1,5 +1,5 @@
 module Alephant
   module Broker
-    VERSION = "3.15.2".freeze
+    VERSION = "3.16.0".freeze
   end
 end

data/spec/alephant/broker/load_strategy/revalidate/strategy_spec.rb

@@ -28,6 +28,14 @@ RSpec.describe Alephant::Broker::LoadStrategy::Revalidate::Strategy do
     }
   end
 
+  let(:expected_revalidating_content) do
+    revalidating_content = expected_content.clone
+    revalidating_content[:headers] = {
+      'broker-cache' => 'revalidating'
+    }
+    revalidating_content
+  end
+
   let(:cached_obj) do
     Alephant::Broker::Cache::CachedObject.new(content)
   end
@@ -66,6 +74,13 @@ RSpec.describe Alephant::Broker::LoadStrategy::Revalidate::Strategy do
 
           subject.load(component_meta)
         end
+
+        it 'does NOT send the revalidating repsonse header' do
+          response = subject.load(component_meta)
+          response_headers = response[:headers] || {}
+
+          expect(response_headers['broker-cache']).to_not eq('revalidating')
+        end
       end
 
       context 'which has expired' do
@@ -88,7 +103,11 @@ RSpec.describe Alephant::Broker::LoadStrategy::Revalidate::Strategy do
         end
 
         it 'it gets fetched from the cache and returned to the user' do
-          expect(subject.load(component_meta)).to eq(expected_content)
+          expect(subject.load(component_meta)).to eq(expected_revalidating_content)
+        end
+
+        it 'should contain a revalidating reponse header' do
+          expect(subject.load(component_meta)[:headers]['broker-cache']).to eq('revalidating')
         end
 
         context 'in the background...' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alephant-broker
 version: !ruby/object:Gem::Version
-  version: 3.15.2
+  version: 3.16.0
 platform: ruby
 authors:
 - BBC News
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-08-11 00:00:00.000000000 Z
+date: 2016-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec