aleksi-after_commit 1.0.8

data/LICENSE

@@ -0,0 +1,20 @@
+Copyright (c) 2008 Nick Muerdter
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.textile

@@ -0,0 +1,64 @@
+h1. after_commit
+
+An ActiveRecord/Rails library to add @before_commit@, @after_commit@, @before_rollback@ and @after_rollback@ callbacks. These callbacks are focused on the transactions, instead of specific model actions. This is beneficial in situations where you are doing asynchronous processing and need committed objects.
+
+*Please note*: Rails 3 (and thus, ActiveRecord 3) "provides commit callbacks natively":http://github.com/rails/rails/commit/da840d13da865331297d5287391231b1ed39721b, so this library will remain just for versions 1.2.x to 2.x of ActiveRecord.
+
+h2. Installation
+
+<pre><code>gem install after_commit</code></pre>
+
+h2. Usage
+
+The following callbacks are provided:
+
+* before_commit
+* before_commit_on_create
+* before_commit_on_update
+* before_commit_on_destroy
+* after_commit
+* after_commit_on_create
+* after_commit_on_update
+* after_commit_on_destroy
+* before_rollback
+* after_rollback
+
+You can use these just like you would any other callback:
+
+<pre><code>class Article < ActiveRecord::Base
+  after_commit :method_to_call_after_commit
+  
+  # ...
+  
+  private
+  
+  def method_to_call_after_commit
+    # Do something knowing that the transaction is committed.
+  end
+end</code></pre>
+
+h2. In Tests
+
+Keep in mind that transactions are finicky at best in tests, and so there's a helper module to make @after_commit@ play nicely in your testing context. You'll need to add these two lines to your spec/test helper:
+
+<pre><code>ActiveRecord::Base.send(:include, AfterCommit::AfterSavepoint)
+ActiveRecord::Base.include_after_savepoint_extensions</code></pre>
+
+h2. Credits
+
+This code first appeared in a blog post "by Eli Miller":http://elimiller.blogspot.com/2007/06/proper-cache-expiry-with-aftercommit.html, and was then included in "Thinking Sphinx":http://ts.freelancing-gods.com by "Pat Allan":http://freelancing-gods.com, with modifications from Joost Hietbrink. The code was then "put on GitHub as a plugin":http://github.com/GUI/after_commit by Nick Muerdter, and many people forked and added their own contributions.
+
+This version (maintained by Pat Allan) includes the following patches:
+
+* Callbacks for specific types of actions (create, update, destroy) ("DeLynn Berry":http://delynnberry.com/)
+* Fixes to extra callbacks ("Xavier Shay":http://rhnh.net/)
+* Thread-safety ("Dmitry Galinsky":http://dima-exe.ru/)
+* after_rollback callback ("Justin Balthrop":http://github.com/ninjudd)
+* Test environment fix ("Pivotal Labs":http://pivotalblabs.com/)
+* Scoping callbacks to specific connections ("Mat Brown":http://outofti.me/)
+* before_* callbacks ("Trotter Cashion":http://trottercashion.com/)
+* Gemspec and extended tests, works as a plugin, doesn't load ActiveRecord hooks twice, doesn't add Test environment hook automatically. ("David Yip":http://github.com/yipdw)
+* Exception propagation ("George Ogata":http://github.com/oggy/)
+* Keeping callbacks focused on the correct transactions ("Benjamin Stein":http://benjaminste.in/)
+* Using savepoints for test helper ("Lars Klevan":http://www.linkedin.com/in/larsklevan and "Joel Chippindale":http://blog.monkeysthumb.org/)
+* Only tracking objects from classes that have appropriate callbacks; Adding @after/before_commit_on_save@ to cover creates and updates but not destroys ("Jason Weathered":http://jasoncodes.com/)

data/lib/after_commit.rb

@@ -0,0 +1,81 @@
+module AfterCommit
+  def self.record(connection, record)
+    prepare_collection :committed_records, connection
+    add_to_collection  :committed_records, connection, record
+  end
+
+  def self.record_created(connection, record)
+    prepare_collection :committed_records_on_create, connection
+    add_to_collection  :committed_records_on_create, connection, record
+  end
+
+  def self.record_updated(connection, record)
+    prepare_collection :committed_records_on_update, connection
+    add_to_collection  :committed_records_on_update, connection, record
+  end
+
+  def self.record_saved(connection, record)
+    prepare_collection :committed_records_on_save, connection
+    add_to_collection  :committed_records_on_save, connection, record
+  end
+
+  def self.record_destroyed(connection, record)
+    prepare_collection :committed_records_on_destroy, connection
+    add_to_collection  :committed_records_on_destroy, connection, record
+  end
+  
+  def self.records(connection)
+    collection :committed_records, connection
+  end
+
+  def self.created_records(connection)
+    collection :committed_records_on_create, connection
+  end
+
+  def self.updated_records(connection)
+    collection :committed_records_on_update, connection
+  end
+
+  def self.saved_records(connection)
+    collection :committed_records_on_save, connection
+  end
+
+  def self.destroyed_records(connection)
+    collection :committed_records_on_destroy, connection
+  end
+
+  def self.cleanup(connection)
+    [
+      :committed_records,
+      :committed_records_on_create,
+      :committed_records_on_update,
+      :committed_records_on_save,
+      :committed_records_on_destroy
+    ].each do |collection|
+      Thread.current[collection]                        ||= {}
+      Thread.current[collection][connection.old_transaction_key] = []
+    end
+  end
+  
+  def self.prepare_collection(collection, connection)
+    Thread.current[collection] ||= {}
+    Thread.current[collection][connection.unique_transaction_key] ||= []
+  end
+  
+  def self.add_to_collection(collection, connection, record)
+    Thread.current[collection][connection.unique_transaction_key] << record
+  end
+  
+  def self.collection(collection, connection)
+    Thread.current[collection] ||= {}
+    Thread.current[collection][connection.old_transaction_key] ||= []
+  end
+end
+
+require 'after_commit/active_support_callbacks'
+require 'after_commit/active_record'
+require 'after_commit/connection_adapters'
+require 'after_commit/after_savepoint'
+
+ActiveRecord::Base.send(:include, AfterCommit::ActiveRecord)
+ActiveRecord::Base.include_after_commit_extensions

data/lib/after_commit/active_record.rb

@@ -0,0 +1,87 @@
+module AfterCommit
+  module ActiveRecord
+    def self.included(base)
+      base.class_eval do
+        class << self
+          def establish_connection_with_after_commit(spec = nil)
+            result = establish_connection_without_after_commit spec
+            include_after_commit_extensions
+            result
+          end
+          alias_method_chain :establish_connection, :after_commit
+          
+          def include_after_commit_extensions
+            base = ::ActiveRecord::ConnectionAdapters::AbstractAdapter
+            Object.subclasses_of(base).each do |klass|
+              include_after_commit_extension klass
+            end
+            
+            if defined?(JRUBY_VERSION) and defined?(JdbcSpec::MySQL)
+              include_after_commit_extension JdbcSpec::MySQL
+            end
+          end
+          
+          private
+          
+          def include_after_commit_extension(adapter)
+            additions = AfterCommit::ConnectionAdapters
+            unless adapter.included_modules.include?(additions)
+              adapter.send :include, additions
+            end
+          end
+        end
+        
+        define_callbacks  :after_commit,
+                          :after_commit_on_create,
+                          :after_commit_on_update,
+                          :after_commit_on_save,
+                          :after_commit_on_destroy,
+                          :after_rollback,
+                          :before_commit,
+                          :before_commit_on_create,
+                          :before_commit_on_update,
+                          :before_commit_on_save,
+                          :before_commit_on_destroy,
+                          :before_rollback
+        
+        after_create  :add_committed_record_on_create
+        after_update  :add_committed_record_on_update
+        after_save    :add_committed_record_on_save
+        after_destroy :add_committed_record_on_destroy
+        
+        def add_committed_record
+          if have_callback? :before_commit, :after_commit, :before_rollback, :after_rollback
+            AfterCommit.record(self.class.connection, self)
+          end
+        end
+        
+        def add_committed_record_on_create
+          add_committed_record
+          if have_callback? :before_commit_on_create, :after_commit_on_create
+            AfterCommit.record_created(self.class.connection, self)
+          end
+        end
+        
+        def add_committed_record_on_update
+          add_committed_record
+          if have_callback? :before_commit_on_update, :after_commit_on_update
+            AfterCommit.record_updated(self.class.connection, self)
+          end
+        end
+        
+        def add_committed_record_on_save
+          if have_callback? :before_commit_on_save, :after_commit_on_save
+            AfterCommit.record_saved(self.class.connection, self)
+          end
+        end
+        
+        def add_committed_record_on_destroy
+          add_committed_record
+          if have_callback? :before_commit_on_destroy, :after_commit_on_destroy
+            AfterCommit.record_destroyed(self.class.connection, self)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/after_commit/active_support_callbacks.rb

@@ -0,0 +1,59 @@
+if defined? ActiveSupport::Callbacks
+  
+  module AfterCommit
+    module ActiveSupportCallbacks
+      def self.included(base)
+        
+        base::Callback.class_eval do
+          def have_callback?
+            true
+          end
+        end
+        
+        base::CallbackChain.class_eval do
+          def have_callback?
+            any? &:have_callback?
+          end
+        end
+        
+        base.class_eval do
+          def have_callback?(*callbacks)
+            self.class.observers.size > 0 or
+            self.class.count_observers > 0 or
+            callbacks.any? do |callback|
+              self.class.send("#{callback}_callback_chain").have_callback?
+            end
+          end
+        end
+        
+      end
+    end
+  end
+  ActiveSupport::Callbacks.send(:include, AfterCommit::ActiveSupportCallbacks)
+  
+else
+  
+  class ActiveRecord::Base
+    
+    def self.define_callbacks(*names)
+      names.each do |name|
+        instance_eval <<-RUBY
+          def #{name}(*callbacks, &block)
+            callbacks << block if block_given?
+            write_inheritable_array(:#{name}, callbacks)
+          end
+        RUBY
+      end
+    end
+    
+    def have_callback?(*names)
+      self.class.observers.size > 0 or
+      self.class.count_observers > 0 or
+      names.any? do |name|
+        !self.class.read_inheritable_attribute(name).blank?
+      end
+    end
+    
+  end
+  
+end

data/lib/after_commit/after_savepoint.rb

@@ -0,0 +1,85 @@
+# Fix problems caused because tests all run in a single transaction.
+
+# The single transaction means that after_commit callback never happens in tests.  Instead use savepoints.
+
+module AfterCommit
+  module AfterSavepoint
+    def self.included(klass)
+      klass.class_eval do
+        class << self
+          def include_after_savepoint_extensions
+            base = ::ActiveRecord::ConnectionAdapters::AbstractAdapter
+            Object.subclasses_of(base).each do |klass|
+              include_after_savepoint_extension klass
+            end
+        
+            if defined?(JRUBY_VERSION) and defined?(JdbcSpec::MySQL)
+              include_after_savepoint_extension JdbcSpec::MySQL
+            end
+          end
+
+          private
+      
+          def include_after_savepoint_extension(adapter)
+            additions = AfterCommit::TestConnectionAdapters
+            unless adapter.included_modules.include?(additions)
+              adapter.send :include, additions
+            end
+          end
+        end
+      end
+    end
+  end
+
+  module TestConnectionAdapters
+    def self.included(base)
+      base.class_eval do
+
+        # matches commit_db_transaction_with_callback
+        def release_savepoint_with_callback
+          increment_transaction_pointer
+          result    = nil
+          begin
+            trigger_before_commit_callbacks
+            trigger_before_commit_on_create_callbacks
+            trigger_before_commit_on_update_callbacks
+            trigger_before_commit_on_save_callbacks
+            trigger_before_commit_on_destroy_callbacks
+
+            result = release_savepoint_without_callback
+            @disable_rollback = true
+
+            trigger_after_commit_callbacks
+            trigger_after_commit_on_create_callbacks
+            trigger_after_commit_on_update_callbacks
+            trigger_after_commit_on_save_callbacks
+            trigger_after_commit_on_destroy_callbacks
+            result
+          ensure
+            AfterCommit.cleanup(self)
+            decrement_transaction_pointer
+          end
+        end
+        alias_method_chain :release_savepoint, :callback
+
+        # matches rollback_db_transaction_with_callback
+        def rollback_to_savepoint_with_callback
+          return if @disable_rollback
+          increment_transaction_pointer
+          begin
+            result = nil
+            trigger_before_rollback_callbacks
+            result = rollback_to_savepoint_without_callback
+            trigger_after_rollback_callbacks
+            result
+          ensure
+            AfterCommit.cleanup(self)
+            decrement_transaction_pointer
+          end
+          decrement_transaction_pointer
+        end
+        alias_method_chain :rollback_to_savepoint, :callback
+      end
+    end
+  end
+end

data/lib/after_commit/connection_adapters.rb

@@ -0,0 +1,179 @@
+module AfterCommit
+  module ConnectionAdapters
+    def self.included(base)
+      base.class_eval do
+        def transaction_with_callback(*args, &block)
+          # @disable_rollback is set to false at the start of the
+          # outermost call to #transaction.  After committing, it is
+          # set to true to prevent exceptions causing a spurious
+          # rollback.
+          outermost_call = @disable_rollback.nil?
+          @disable_rollback = false if outermost_call
+          transaction_without_callback(*args, &block)
+        ensure
+          @disable_rollback = nil if outermost_call
+        end
+        alias_method_chain :transaction, :callback
+
+        # The commit_db_transaction method gets called when the outermost
+        # transaction finishes and everything inside commits. We want to
+        # override it so that after this happens, any records that were saved
+        # or destroyed within this transaction now get their after_commit
+        # callback fired.
+        def commit_db_transaction_with_callback
+          increment_transaction_pointer
+          result    = nil
+          begin
+            trigger_before_commit_callbacks
+            trigger_before_commit_on_create_callbacks
+            trigger_before_commit_on_update_callbacks
+            trigger_before_commit_on_save_callbacks
+            trigger_before_commit_on_destroy_callbacks
+
+            result = commit_db_transaction_without_callback
+            @disable_rollback = true
+
+            trigger_after_commit_callbacks
+            trigger_after_commit_on_create_callbacks
+            trigger_after_commit_on_update_callbacks
+            trigger_after_commit_on_save_callbacks
+            trigger_after_commit_on_destroy_callbacks
+            result
+          ensure
+            AfterCommit.cleanup(self)
+            decrement_transaction_pointer
+          end
+        end 
+        alias_method_chain :commit_db_transaction, :callback
+
+        # In the event the transaction fails and rolls back, nothing inside
+        # should recieve the after_commit callback, but do fire the after_rollback
+        # callback for each record that failed to be committed.
+        def rollback_db_transaction_with_callback
+          return if @disable_rollback
+          increment_transaction_pointer
+          begin
+            result = nil
+            trigger_before_rollback_callbacks
+            result = rollback_db_transaction_without_callback
+            trigger_after_rollback_callbacks
+            result
+          ensure
+            AfterCommit.cleanup(self)
+            decrement_transaction_pointer
+          end
+          decrement_transaction_pointer
+        end
+        alias_method_chain :rollback_db_transaction, :callback
+        
+        def unique_transaction_key
+          [object_id, transaction_pointer]
+        end
+        
+        def old_transaction_key
+          [object_id, transaction_pointer - 1]
+        end
+        
+        protected
+        
+        def trigger_before_commit_callbacks
+          AfterCommit.records(self).each do |record|
+            record.send :callback, :before_commit
+          end 
+        end
+
+        def trigger_before_commit_on_create_callbacks
+          AfterCommit.created_records(self).each do |record|
+            record.send :callback, :before_commit_on_create
+          end 
+        end
+      
+        def trigger_before_commit_on_update_callbacks
+          AfterCommit.updated_records(self).each do |record|
+            record.send :callback, :before_commit_on_update
+          end 
+        end
+      
+        def trigger_before_commit_on_save_callbacks
+          AfterCommit.saved_records(self).each do |record|
+            record.send :callback, :before_commit_on_save
+          end
+        end
+        
+        def trigger_before_commit_on_destroy_callbacks
+          AfterCommit.destroyed_records(self).each do |record|
+            record.send :callback, :before_commit_on_destroy
+          end 
+        end
+
+        def trigger_before_rollback_callbacks
+          AfterCommit.records(self).each do |record|
+            record.send :callback, :before_rollback
+          end 
+        end
+
+        def trigger_after_commit_callbacks
+          # Trigger the after_commit callback for each of the committed
+          # records.
+          AfterCommit.records(self).each do |record|
+            record.send :callback, :after_commit
+          end
+        end
+            
+        def trigger_after_commit_on_create_callbacks
+          # Trigger the after_commit_on_create callback for each of the committed
+          # records.
+          AfterCommit.created_records(self).each do |record|
+            record.send :callback, :after_commit_on_create
+          end
+        end
+      
+        def trigger_after_commit_on_update_callbacks
+          # Trigger the after_commit_on_update callback for each of the committed
+          # records.
+          AfterCommit.updated_records(self).each do |record|
+            record.send :callback, :after_commit_on_update
+          end
+        end
+      
+        def trigger_after_commit_on_save_callbacks
+          # Trigger the after_commit_on_save callback for each of the committed
+          # records.
+          AfterCommit.saved_records(self).each do |record|
+            record.send :callback, :after_commit_on_save
+          end
+        end
+        
+        def trigger_after_commit_on_destroy_callbacks
+          # Trigger the after_commit_on_destroy callback for each of the committed
+          # records.
+          AfterCommit.destroyed_records(self).each do |record|
+            record.send :callback, :after_commit_on_destroy
+          end
+        end
+
+        def trigger_after_rollback_callbacks
+          # Trigger the after_rollback callback for each of the committed
+          # records.
+          AfterCommit.records(self).each do |record|
+            record.send :callback, :after_rollback
+          end 
+        end
+        
+        def transaction_pointer
+          Thread.current[:after_commit_pointer] ||= 0
+        end
+        
+        def increment_transaction_pointer
+          Thread.current[:after_commit_pointer] ||= 0
+          Thread.current[:after_commit_pointer] += 1
+        end
+        
+        def decrement_transaction_pointer
+          Thread.current[:after_commit_pointer] ||= 0
+          Thread.current[:after_commit_pointer] -= 1
+        end
+      end 
+    end 
+  end
+end

data/test/after_commit_test.rb

@@ -0,0 +1,282 @@
+require 'test_helper'
+
+class MockRecord < ActiveRecord::Base
+  
+  PHASES = %w(before after)
+  ACTIONS = %w(create update save destroy)
+  
+  PHASES.each do |phase|
+    ACTIONS.each do |action|
+      
+      class_eval <<-RUBY
+        
+        attr_accessor :#{phase}_commit_on_#{action}_called
+        
+        #{phase}_commit_on_#{action} :do_#{phase}_#{action}
+        def do_#{phase}_#{action}
+          self.#{phase}_commit_on_#{action}_called = true
+        end
+        
+      RUBY
+      
+    end
+  end
+  
+end
+
+class CountingRecord < ActiveRecord::Base
+  attr_accessor :after_commit_on_create_called
+  cattr_accessor :counter
+  @@counter=0
+  
+  after_commit_on_create :do_after_create
+  def do_after_create
+    @@counter+=1
+  end
+end
+
+class Foo < ActiveRecord::Base
+  attr_reader :creating
+  
+  after_commit :create_bar
+  
+  private
+  
+  def create_bar
+    @creating ||= 0
+    @creating += 1
+    
+    raise Exception, 'looping' if @creating > 1
+    Bar.create
+  end
+end
+
+class Bar < ActiveRecord::Base
+  #
+end
+
+class UnsavableRecord < ActiveRecord::Base
+  attr_accessor :after_commit_called, :after_rollback_called
+
+  set_table_name 'mock_records'
+
+  protected
+
+  def after_initialize
+    self.after_commit_called = false
+  end
+
+  def after_save
+    raise
+  end
+
+  after_commit :after_commit
+  def after_commit
+    self.after_commit_called = true
+  end
+
+  after_rollback :after_rollback
+  def after_rollback
+    self.after_rollback_called = true
+  end
+end
+
+class TrackCountRecord < ActiveRecord::Base
+  attr_accessor :total_count
+
+  set_table_name 'mock_records'
+
+  protected
+
+  after_commit :update_counts
+  after_rollback :update_counts
+
+  def update_counts
+    all_records =
+      AfterCommit.records(connection) +
+      AfterCommit.created_records(connection) +
+      AfterCommit.updated_records(connection) +
+      AfterCommit.saved_records(connection) +
+      AfterCommit.destroyed_records(connection)
+    all_records.uniq!
+    self.total_count = all_records.size
+  end
+end
+
+class AfterCommitTest < Test::Unit::TestCase
+  def test_before_commit_on_create_is_called
+    assert_equal true, MockRecord.create!.before_commit_on_create_called
+  end
+  
+  def test_before_commit_on_update_is_called
+    record = MockRecord.create!
+    record.before_commit_on_update_called = false
+    record.save
+    assert_equal true, record.before_commit_on_update_called
+  end
+  
+  def test_before_commit_on_update_is_not_called_for_create
+    assert_nil MockRecord.create!.before_commit_on_update_called
+  end
+  
+  def test_before_commit_on_save_is_called_for_create
+    assert_equal true, MockRecord.create!.before_commit_on_save_called
+  end
+  
+  def test_before_commit_on_save_is_called_for_update
+    record = MockRecord.create!
+    record.before_commit_on_save_called = false
+    record.save
+    assert_equal true, record.before_commit_on_save_called
+  end
+  
+  def test_before_commit_on_destroy_is_called
+    assert_equal true, MockRecord.create!.destroy.before_commit_on_destroy_called
+  end
+  
+  def test_after_commit_on_create_is_called
+    assert_equal true, MockRecord.create!.after_commit_on_create_called
+  end
+  
+  def test_after_commit_on_update_is_called
+    record = MockRecord.create!
+    record.after_commit_on_update_called = false
+    record.save
+    assert_equal true, record.after_commit_on_update_called
+  end
+  
+  def test_after_commit_on_update_is_not_called_for_create
+    assert_nil MockRecord.create!.after_commit_on_update_called
+  end
+  
+  def test_after_commit_on_save_is_called_for_create
+    assert_equal true, MockRecord.create!.after_commit_on_save_called
+  end
+  
+  def test_after_commit_on_save_is_called_for_update
+    record = MockRecord.create!
+    record.after_commit_on_save_called = false
+    record.save
+    assert_equal true, record.after_commit_on_save_called
+  end
+  
+  def test_after_commit_on_destroy_is_called
+    assert_equal true, MockRecord.create!.destroy.after_commit_on_destroy_called
+  end
+  
+  def test_after_commit_does_not_trigger_when_transaction_rolls_back
+    record = UnsavableRecord.new
+    begin; record.save; rescue; end
+
+    # Ensure that commit of another transaction doesn't then trigger the
+    # after_commit hook on previously rolled back record
+    another_record = MockRecord.create!
+    another_record.save
+
+    assert_equal false, record.after_commit_called
+  end
+
+  def test_after_commit_does_not_trigger_when_unrelated_transaction_commits
+    begin
+      CountingRecord.transaction do
+        CountingRecord.create!
+        raise "fail"
+      end
+    rescue
+    end
+    assert_equal 0, CountingRecord.counter
+    CountingRecord.create!
+    assert_equal 1, CountingRecord.counter
+  end
+  
+  def test_after_rollback_triggered_when_transaction_rolls_back
+    record = UnsavableRecord.new
+    begin; record.save; rescue; end
+
+    assert record.after_rollback_called
+  end
+
+  def test_two_transactions_are_separate
+    Bar.delete_all
+    foo = Foo.create
+    
+    assert_equal 1, foo.creating
+  end
+  
+  def test_records_with_callbacks_are_tracked
+    record = nil
+    MockRecord.transaction do
+      record = TrackCountRecord.create!
+      5.times.each { MockRecord.create! }
+    end
+    assert_equal 6, record.total_count
+  end
+  
+  def test_records_without_callbacks_are_not_tracked
+    record = nil
+    MockRecord.transaction do
+      record = TrackCountRecord.create!
+      5.times.each { Bar.create! }
+    end
+    assert_equal 1, record.total_count
+  end
+
+  TestError = Class.new(StandardError)
+
+  def test_exceptions_in_before_commit_on_create_are_not_swallowed
+    record = MockRecord.new
+    def record.do_before_create
+      raise TestError, 'catch me!'
+    end
+    assert_raises(TestError){record.save!}
+  end
+
+  def test_exceptions_in_after_commit_on_create_are_not_swallowed
+    record = MockRecord.new
+    def record.do_after_create
+      raise TestError, 'catch me!'
+    end
+    assert_raises(TestError){record.save!}
+  end
+
+  def test_exceptions_in_before_commit_on_update_are_not_swallowed
+    record = MockRecord.create
+    def record.do_before_update
+      raise TestError, 'catch me!'
+    end
+    assert_raises(TestError){record.update_attributes({})}
+  end
+
+  def test_exceptions_in_after_commit_on_update_are_not_swallowed
+    record = MockRecord.create
+    def record.do_after_update
+      raise TestError, 'catch me!'
+    end
+    assert_raises(TestError){record.update_attributes({})}
+  end
+
+  def test_exceptions_in_before_commit_on_destroy_are_not_swallowed
+    record = MockRecord.create
+    def record.do_before_destroy
+      raise TestError, 'catch me!'
+    end
+    assert_raises(TestError){record.destroy}
+  end
+
+  def test_exceptions_in_after_commit_on_destroy_are_not_swallowed
+    record = MockRecord.create
+    def record.do_after_destroy
+      raise TestError, 'catch me!'
+    end
+    assert_raises(TestError){record.destroy}
+  end
+
+  def test_transactions_in_hooks_do_not_cause_spurious_rollbacks
+    record = MockRecord.create
+    def record.do_after_destroy
+      MockRecord.transaction{}
+      raise TestError, 'catch me!'
+    end
+    assert_raises(TestError){record.destroy}
+  end
+end

data/test/observer_test.rb

@@ -0,0 +1,59 @@
+require 'test_helper'
+
+class ObservableMockRecord < ActiveRecord::Base
+  set_table_name 'mock_records'
+
+  attr_accessor :after_commit_called
+  attr_accessor :after_commit_on_create_called
+  attr_accessor :after_commit_on_update_called
+  attr_accessor :after_commit_on_destroy_called
+end
+
+class ObservableMockRecordObserver < ActiveRecord::Observer
+  def after_commit(model)
+    model.after_commit_called = true
+  end
+
+  def after_commit_on_create(model)
+    model.after_commit_on_create_called = true
+  end
+
+  def after_commit_on_update(model)
+    model.after_commit_on_update_called = true
+  end
+
+  def after_commit_on_destroy(model)
+    model.after_commit_on_destroy_called = true
+  end
+end
+
+class ObserverTest < Test::Unit::TestCase
+  def setup
+    ObservableMockRecord.add_observer ObservableMockRecordObserver.instance
+  end
+
+  def test_after_commit_is_called
+    record = ObservableMockRecord.create!
+
+    assert record.after_commit_called
+  end
+
+  def test_after_commit_on_create_is_called
+    record = ObservableMockRecord.create!
+
+    assert record.after_commit_on_create_called
+  end
+
+  def test_after_commit_on_update_is_called
+    record = ObservableMockRecord.create!
+    record.save
+
+    assert record.after_commit_on_update_called
+  end
+
+  def test_after_commit_on_destroy_is_called
+    record = ObservableMockRecord.create!.destroy
+
+    assert record.after_commit_on_destroy_called
+  end
+end

data/test/test_helper.rb

@@ -0,0 +1,21 @@
+$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
+require 'test/unit'
+require 'rubygems'
+require 'active_record'
+require 'sqlite3'
+
+ActiveRecord::Base.establish_connection({"adapter" => "sqlite3", "database" => 'test.sqlite3'})
+tables = %w( mock_records counting_records foos bars )
+
+begin
+  tables.each do |table|
+    ActiveRecord::Base.connection.execute("drop table #{table}");
+  end
+rescue
+end
+
+tables.each do |table|
+  ActiveRecord::Base.connection.execute("create table #{table}(id int, name string)");
+end
+
+require 'after_commit'

metadata

@@ -0,0 +1,108 @@
+--- !ruby/object:Gem::Specification 
+name: aleksi-after_commit
+version: !ruby/object:Gem::Version 
+  hash: 7
+  prerelease: false
+  segments: 
+  - 1
+  - 0
+  - 8
+  version: 1.0.8
+platform: ruby
+authors: 
+- Nick Muerdter
+- David Yip
+- Pat Allan
+autorequire: 
+bindir: bin
+cert_chain: []
+
+date: 2010-08-05 00:00:00 +04:00
+default_executable: 
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: activerecord
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :runtime
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
+  name: sqlite3-ruby
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id002
+description: "\n    A Ruby on Rails plugin to add an after_commit callback. This can be used to trigger methods only after the entire transaction is complete.\n  "
+email: pat@freelancing-gods.com
+executables: []
+
+extensions: []
+
+extra_rdoc_files: 
+- LICENSE
+- README.textile
+files: 
+- LICENSE
+- lib/after_commit.rb
+- lib/after_commit/active_record.rb
+- lib/after_commit/active_support_callbacks.rb
+- lib/after_commit/after_savepoint.rb
+- lib/after_commit/connection_adapters.rb
+- README.textile
+- test/after_commit_test.rb
+- test/observer_test.rb
+- test/test_helper.rb
+has_rdoc: true
+homepage: http://github.com/freelancing-god/after_commit
+licenses: []
+
+post_install_message: 
+rdoc_options: 
+- --charset=UTF-8
+require_paths: 
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+requirements: []
+
+rubyforge_project: 
+rubygems_version: 1.3.7
+signing_key: 
+specification_version: 3
+summary: after_commit callback for ActiveRecord
+test_files: 
+- test/after_commit_test.rb
+- test/observer_test.rb
+- test/test_helper.rb