alchemy_cms 6.1.5 → 7.0.0.pre.b

data/app/controllers/alchemy/pages_controller.rb

@@ -6,7 +6,7 @@ module Alchemy
       "action",
       "controller",
       "urlname",
-      "locale",
+      "locale"
     ]
 
     include OnPageLayout::CallbacksRunner
@@ -122,7 +122,7 @@ module Alchemy
 
       @page ||= Language.current.pages.contentpages.find_by(
         urlname: params[:urlname],
-        language_code: params[:locale] || Language.current.code,
+        language_code: params[:locale] || Language.current.code
       )
     end
 
@@ -142,7 +142,7 @@ module Alchemy
     def page_locale_redirect_url(options = {})
       options = {
         locale: prefix_locale? ? @page.language_code : nil,
-        urlname: @page.urlname,
+        urlname: @page.urlname
       }.merge(options)
 
       alchemy.show_page_path additional_params.merge(options)
@@ -168,7 +168,7 @@ module Alchemy
 
     # == Renders the page :show template
     #
-    # Handles html and rss requests (for pages containing a feed)
+    # Handles html requests
     #
     # Omits the layout, if the request is a XHR request.
     #
@@ -177,14 +177,6 @@ module Alchemy
         format.html do
           render action: :show, layout: !request.xhr?
         end
-
-        format.rss do
-          if @page.contains_feed?
-            render action: :show, layout: false, handlers: [:builder]
-          else
-            render xml: { error: "Not found" }, status: 404
-          end
-        end
       end
     end
 
@@ -220,10 +212,12 @@ module Alchemy
     # or the cache is stale, because it's been republished by the user.
     #
     def render_fresh_page?
-      must_not_cache? || stale?(etag: page_etag,
-                                last_modified: @page.published_at,
-                                public: !@page.restricted,
-                                template: "pages/show")
+      must_not_cache? || stale?(
+        etag: page_etag,
+        last_modified: @page.published_at,
+        public: !@page.restricted,
+        template: "pages/show"
+      )
     end
 
     # don't cache pages if we have flash message to display or the page has caching disabled

data/app/controllers/concerns/alchemy/admin/archive_overlay.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Alchemy
   module Admin
     module ArchiveOverlay

data/app/controllers/concerns/alchemy/admin/uploader_responses.rb

@@ -8,12 +8,11 @@ module Alchemy
       def successful_uploader_response(file:, status: :created)
         message = Alchemy.t(:upload_success,
           scope: [:uploader, file.class.model_name.i18n_key],
-          name: file.name,
-        )
+          name: file.name)
 
         {
           json: uploader_response(file: file, message: message),
-          status: status,
+          status: status
         }
       end
 
@@ -21,12 +20,11 @@ module Alchemy
         message = Alchemy.t(:upload_failure,
           scope: [:uploader, file.class.model_name.i18n_key],
           error: file.errors[:file].join,
-          name: file.name,
-        )
+          name: file.name)
 
         {
           json: uploader_response(file: file, message: message),
-          status: :unprocessable_entity,
+          status: :unprocessable_entity
         }
       end
 
@@ -35,7 +33,7 @@ module Alchemy
       def uploader_response(file:, message:)
         {
           files: [file.to_jq_upload],
-          growl_message: message,
+          growl_message: message
         }
       end
     end

data/app/controllers/concerns/alchemy/legacy_page_redirects.rb

@@ -36,18 +36,18 @@ module Alchemy
 
       alchemy.show_page_path(
         locale: prefix_locale? ? page.language_code : nil,
-        urlname: page.urlname,
+        urlname: page.urlname
       )
     end
 
     def legacy_urls
       # /slug/tree => slug/tree
-      urlname = (request.fullpath[1..-1] if request.fullpath[0] == "/") || request.fullpath
+      urlname = (request.fullpath[1..] if request.fullpath[0] == "/") || request.fullpath
       LegacyPageUrl.joins(:page).where(
-        urlname: urlname,
+        :urlname => urlname,
         Page.table_name => {
-          language_id: Language.current.id,
-        },
+          language_id: Language.current.id
+        }
       )
     end
 

data/app/decorators/alchemy/element_editor.rb

@@ -8,17 +8,6 @@ module Alchemy
       "alchemy/admin/elements/element"
     end
 
-    # Returns content editor instances for defined contents
-    #
-    # Creates contents on demand if the content is not yet present on the element
-    #
-    # @return Array<Alchemy::ContentEditor>
-    def contents
-      element.definition.fetch(:contents, []).map do |content|
-        Alchemy::ContentEditor.new(find_or_create_content(content[:name]))
-      end
-    end
-
     # Returns ingredient editor instances for defined ingredients
     #
     # Creates ingredient on demand if the ingredient is not yet present on the element
@@ -36,7 +25,7 @@ module Alchemy
       element.definition.fetch(:ingredients, []).any?
     end
 
-    # Returns the translated content/ingredient group for displaying in admin editor group headings
+    # Returns the translated ingredient group for displaying in admin editor group headings
     #
     # Translate it in your locale yml file:
     #
@@ -55,7 +44,7 @@ module Alchemy
       Alchemy.t(
         group,
         scope: "element_groups.#{element.name}",
-        default: Alchemy.t("element_groups.#{group}", default: group.humanize),
+        default: Alchemy.t("element_groups.#{group}", default: group.humanize)
       )
     end
 
@@ -63,14 +52,14 @@ module Alchemy
     def css_classes
       [
         "element-editor",
-        content_definitions.present? ? "with-contents" : "without-contents",
+        ingredient_definitions.present? ? "with-ingredients" : "without-ingredients",
         nestable_elements.any? ? "nestable" : "not-nestable",
         taggable? ? "taggable" : "not-taggable",
         folded ? "folded" : "expanded",
         compact? ? "compact" : nil,
         deprecated? ? "deprecated" : nil,
         fixed? ? "is-fixed" : "not-fixed",
-        public? ? "visible" : "hidden",
+        public? ? "visible" : "hidden"
       ].join(" ")
     end
 
@@ -78,12 +67,13 @@ module Alchemy
     def editable?
       return false if folded?
 
-      content_definitions.present? || ingredient_definitions.any? || taggable?
+      ingredient_definitions.any? || taggable?
     end
 
     # Fixes Rails partial renderer calling to_model on the object
     # which reveals the delegated element instead of this decorator.
-    def respond_to?(method_name)
+    def respond_to?(*args, **kwargs)
+      method_name = args.first
       return false if method_name == :to_model
 
       super
@@ -124,31 +114,21 @@ module Alchemy
       when String
         definition["deprecated"]
       when TrueClass
-        Alchemy.t(name,
-                  scope: :element_deprecation_notices,
-                  default: Alchemy.t(:element_deprecated))
+        Alchemy.t(
+          name,
+          scope: :element_deprecation_notices,
+          default: Alchemy.t(:element_deprecated)
+        )
       end
     end
 
     private
 
-    def find_or_create_content(name)
-      find_content(name) || create_content(name)
-    end
-
-    def find_content(name)
-      element.contents.find { |content| content.name == name }
-    end
-
-    def create_content(name)
-      Alchemy::Content.create(element: element, name: name)
-    end
-
     def find_or_create_ingredient(definition)
       element.ingredients.detect { |i| i.role == definition[:role] } ||
         element.ingredients.create!(
           role: definition[:role],
-          type: Alchemy::Ingredient.normalize_type(definition[:type]),
+          type: Alchemy::Ingredient.normalize_type(definition[:type])
         )
     end
   end

data/app/decorators/alchemy/ingredient_editor.rb

@@ -27,7 +27,7 @@ module Alchemy
       Alchemy.t(
         role,
         scope: "ingredient_roles.#{element.name}",
-        default: Alchemy.t("ingredient_roles.#{role}", default: role.humanize),
+        default: Alchemy.t("ingredient_roles.#{role}", default: role.humanize)
       )
     end
 
@@ -36,17 +36,17 @@ module Alchemy
         "ingredient-editor",
         partial_name,
         deprecated? ? "deprecated" : nil,
-        respond_to?(:level_options) && level_options.many? ? "with-level-select" : nil,
-        respond_to?(:size_options) && size_options.many? ? "with-size-select" : nil,
+        (respond_to?(:level_options) && level_options.many?) ? "with-level-select" : nil,
+        (respond_to?(:size_options) && size_options.many?) ? "with-size-select" : nil,
         settings[:linkable] ? "linkable" : nil,
-        settings[:anchor] ? "with-anchor" : nil,
+        settings[:anchor] ? "with-anchor" : nil
       ].compact
     end
 
     def data_attributes
       {
         ingredient_id: id,
-        ingredient_role: role,
+        ingredient_role: role
       }
     end
 
@@ -148,7 +148,7 @@ module Alchemy
         Alchemy.t(
           role,
           scope: [:ingredient_deprecation_notices, element.name],
-          default: Alchemy.t(:ingredient_deprecated),
+          default: Alchemy.t(:ingredient_deprecated)
         )
       end
     end

data/app/helpers/alchemy/admin/attachments_helper.rb

@@ -14,7 +14,7 @@ module Alchemy
         when "image" then "600x475"
         when "audio" then "600x190"
         when "video" then "600x485"
-        when "pdf"   then "600x500"
+        when "pdf" then "600x500"
         else
           "600x145"
         end

data/app/helpers/alchemy/admin/base_helper.rb

@@ -100,7 +100,7 @@ module Alchemy
       def js_filter_field(items, options = {})
         options = {
           class: "js_filter_field",
-          data: {"alchemy-list-filter" => items},
+          data: {"alchemy-list-filter" => items}
         }.merge(options)
         content_tag(:div, class: "js_filter_field_box") do
           concat text_field_tag(nil, nil, options)
@@ -140,10 +140,9 @@ module Alchemy
               title: Alchemy.t(:please_confirm),
               message: message,
               ok_label: Alchemy.t("Yes"),
-              cancel_label: Alchemy.t("No"),
-            }.to_json,
-          )
-        )
+              cancel_label: Alchemy.t("No")
+            }.to_json
+          ))
       end
 
       # Returns a form and a button that opens a modal confirm dialog.
@@ -170,7 +169,7 @@ module Alchemy
           message: Alchemy.t(:confirm_to_proceed),
           ok_label: Alchemy.t("Yes"),
           title: Alchemy.t(:please_confirm),
-          cancel_label: Alchemy.t("No"),
+          cancel_label: Alchemy.t("No")
         }.merge(options)
         form_tag url, {method: html_options.delete(:method), class: "button-with-confirm"} do
           button_tag value, html_options.merge("data-alchemy-confirm" => options.to_json)
@@ -190,26 +189,26 @@ module Alchemy
         options = {
           title: Alchemy.t("Delete"),
           message: Alchemy.t("Are you sure?"),
-          icon: :minus,
+          icon: :minus
         }.merge(options)
         button_with_confirm(
           render_icon(options[:icon]),
           url, {
-            message: options[:message],
+            message: options[:message]
           }, {
             method: "delete",
             title: options[:title],
-            class: "icon_button #{html_options.delete(:class)}".strip,
+            class: "icon_button #{html_options.delete(:class)}".strip
           }.merge(html_options)
         )
       end
 
       # (internal) Renders translated Module Names for html title element.
       def render_alchemy_title
-        if content_for?(:title)
-          title = content_for(:title)
+        title = if content_for?(:title)
+          content_for(:title)
         else
-          title = Alchemy.t(controller_name, scope: :modules)
+          Alchemy.t(controller_name, scope: :modules)
         end
         "Alchemy CMS - #{title}"
       end
@@ -259,11 +258,11 @@ module Alchemy
           active: false,
           link_options: {},
           dialog_options: {},
-          loading_indicator: false,
+          loading_indicator: false
         }.merge(options.symbolize_keys)
         button = render(
           "alchemy/admin/partials/toolbar_button",
-          options: options,
+          options: options
         )
         if options[:skip_permission_check] || can?(*permission_from_options(options))
           button
@@ -321,10 +320,10 @@ module Alchemy
         type = html_options.delete(:type) || "date"
         date = html_options.delete(:value) || object.send(method.to_sym).presence
         date = Time.zone.parse(date) if date.is_a?(String)
-        value = date ? date.iso8601 : nil
+        value = date&.iso8601
 
         text_field object.class.name.demodulize.underscore.to_sym,
-          method.to_sym, {type: "text", class: type, "data-datepicker-type" => type, value: value}.merge(html_options)
+          method.to_sym, {:type => "text", :class => type, "data-datepicker-type" => type, :value => value}.merge(html_options)
       end
 
       # Render a hint icon with tooltip for given object.
@@ -344,17 +343,17 @@ module Alchemy
           controller_name,
           action_name,
           content_for(:main_menu_style),
-          content_for(:alchemy_body_class),
+          content_for(:alchemy_body_class)
         ].compact
       end
 
       # (internal) Returns options for the clipboard select tag
       def clipboard_select_tag_options(items)
         options = items.map do |item|
-          if item.respond_to?(:display_name_with_preview_text)
-            name = item.display_name_with_preview_text
+          name = if item.respond_to?(:display_name_with_preview_text)
+            item.display_name_with_preview_text
           else
-            name = item.name
+            item.name
           end
           [name, item.id]
         end
@@ -386,7 +385,7 @@ module Alchemy
       # that explains the user that the page layout is missing
       def page_layout_missing_warning
         hint_with_tooltip(
-          Alchemy.t(:page_definition_missing),
+          Alchemy.t(:page_definition_missing)
         )
       end
 
@@ -404,7 +403,7 @@ module Alchemy
         action_controller = options[:url].gsub(/\A\//, "").split("/")
         [
           action_controller.last.to_sym,
-          action_controller[0..action_controller.length - 2].join("_").to_sym,
+          action_controller[0..action_controller.length - 2].join("_").to_sym
         ]
       end
     end

data/app/helpers/alchemy/admin/elements_helper.rb

@@ -4,8 +4,6 @@ module Alchemy
   module Admin
     module ElementsHelper
       include Alchemy::Admin::IngredientsHelper
-      include Alchemy::Admin::ContentsHelper
-      include Alchemy::Admin::EssencesHelper
 
       # Returns an elements array for select helper.
       #
@@ -18,7 +16,7 @@ module Alchemy
         elements.collect do |e|
           [
             Element.display_name_for(e["name"]),
-            e["name"],
+            e["name"]
           ]
         end
       end

data/app/helpers/alchemy/admin/form_helper.rb

@@ -19,7 +19,7 @@ module Alchemy
         options[:remote] = request.xhr?
         options[:html] = {
           id: options.delete(:id),
-          class: ["alchemy", options.delete(:class)].compact.join(" "),
+          class: ["alchemy", options.delete(:class)].compact.join(" ")
         }
         simple_form_for(object, *(args << options), &block)
       end

data/app/helpers/alchemy/admin/navigation_helper.rb

@@ -14,7 +14,7 @@ module Alchemy
         render(
           "alchemy/admin/partials/main_navigation_entry",
           alchemy_module: alchemy_module,
-          navigation: alchemy_module["navigation"],
+          navigation: alchemy_module["navigation"]
         )
       end
 
@@ -37,7 +37,7 @@ module Alchemy
       def navigate_module(navigation)
         [
           navigation["action"].to_sym,
-          navigation["controller"].to_s.gsub(/\A\//, "").gsub(/\//, "_").to_sym,
+          navigation["controller"].to_s.gsub(/\A\//, "").tr("/", "_").to_sym
         ]
       end
 
@@ -47,7 +47,7 @@ module Alchemy
         [
           "main_navi_entry",
           admin_mainnavi_active?(navigation) ? "active" : nil,
-          navigation.key?("sub_navigation") ? "has_sub_navigation" : nil,
+          navigation.key?("sub_navigation") ? "has_sub_navigation" : nil
         ].compact
       end
 
@@ -75,7 +75,7 @@ module Alchemy
       def url_for_module(alchemy_module)
         route_from_engine_or_main_app(
           alchemy_module["engine_name"],
-          url_options_for_module(alchemy_module),
+          url_options_for_module(alchemy_module)
         )
       end
 
@@ -94,7 +94,7 @@ module Alchemy
 
         route_from_engine_or_main_app(
           alchemy_module["engine_name"],
-          url_options_for_navigation_entry(navigation),
+          url_options_for_navigation_entry(navigation)
         )
       end
 
@@ -126,7 +126,7 @@ module Alchemy
       #
       def route_from_engine_or_main_app(engine_name, url_options)
         if engine_name.present?
-          eval(engine_name).url_for(url_options)
+          eval(engine_name).url_for(url_options) # rubocop:disable Security/Eval
         else
           main_app.url_for(url_options)
         end
@@ -151,7 +151,7 @@ module Alchemy
           controller: entry["controller"],
           action: entry["action"],
           only_path: true,
-          params: entry["params"],
+          params: entry["params"]
         }.delete_if { |_k, v| v.nil? }
       end
 

data/app/helpers/alchemy/admin/pages_helper.rb

@@ -15,7 +15,7 @@ module Alchemy
           [Alchemy.t("480", scope: "preview_sizes"), 480],
           [Alchemy.t("768", scope: "preview_sizes"), 768],
           [Alchemy.t("1024", scope: "preview_sizes"), 1024],
-          [Alchemy.t("1280", scope: "preview_sizes"), 1280],
+          [Alchemy.t("1280", scope: "preview_sizes"), 1280]
         ])
       end
 
@@ -27,7 +27,7 @@ module Alchemy
         if page.persisted? && page.definition.blank?
           [
             page_layout_missing_warning,
-            Alchemy.t(:page_type),
+            Alchemy.t(:page_type)
           ].join(" ").html_safe
         else
           Alchemy.t(:page_type)

data/app/helpers/alchemy/admin/tags_helper.rb

@@ -20,10 +20,10 @@ module Alchemy
               "#{tag.name} (#{tag.taggings_count})",
               url_for(
                 search_filter_params.except(:page, :tagged_with).merge(
-                  tagged_with: tags_for_filter(current: tag).presence,
-                ),
+                  tagged_with: tags_for_filter(current: tag).presence
+                )
               ),
-              remote: request.xhr?,
+              remote: request.xhr?
             )
           end
         end.join.html_safe

data/app/helpers/alchemy/base_helper.rb

@@ -34,7 +34,7 @@ module Alchemy
         "fa#{options[:style].first}",
         options[:size] ? "fa-#{options[:size]}" : nil,
         options[:transform] ? "fa-#{options[:transform]}" : nil,
-        options[:class],
+        options[:class]
       ].compact
       content_tag("i", nil, class: classes)
     end
@@ -51,7 +51,7 @@ module Alchemy
     #
     def render_message(type = :info, msg = nil, &blk)
       icon_class = message_icon_class(type)
-      if block_given?
+      if blk
         content_tag :div, render_icon(icon_class) + capture(&blk), class: "#{type} message"
       else
         content_tag :div, render_icon(icon_class) + msg, class: "#{type} message"

data/app/helpers/alchemy/elements_block_helper.rb

@@ -24,41 +24,20 @@ module Alchemy
     # Block-level helper class for element views.
     #
     class ElementViewHelper < BlockHelper
-      # Renders one of the element's contents.
+      # Renders one of the element's ingredients.
       #
       # If the element uses +ingredients+ it renders the ingredient record.
       #
       def render(name, options = {}, html_options = {})
-        renderable = element.ingredient_by_role(name) || Alchemy::Deprecation.silence { content(name) }
+        renderable = element.ingredient_by_role(name)
         return if renderable.nil?
 
-        if Alchemy::DEPRECATED_ESSENCE_CLASSES.include?(renderable.try(:essence)&.class&.name)
-          Alchemy::Deprecation.warn(
-            "Using a '#{renderable.essence.class.name.demodulize}' content is deprecated. " \
-            "Please use a '#{Alchemy::DEPRECATED_ESSENCE_CLASS_MAPPING[renderable.essence.class.name].demodulize}' ingredient instead."
+        helpers.render(
+          renderable.as_view_component(
+            options: options,
+            html_options: html_options
           )
-        end
-
-        helpers.render(renderable, {
-          options: options,
-          html_options: html_options,
-        })
-      end
-
-      # Returns one of the element's contents (ie. essence instances).
-      #
-      def content(name)
-        element.content_by_name(name)
-      end
-
-      deprecate content: "Use `ingredient_by_role` instead", deprecator: Alchemy::Deprecation
-
-      # Returns the ingredient of one of the element's contents.
-      #
-      # If the element uses +ingredients+ it returns the +value+ of the ingredient record.
-      #
-      def ingredient(name)
-        element.ingredient(name)
+        )
       end
 
       # Returns the value of one of the element's ingredients.
@@ -67,26 +46,12 @@ module Alchemy
         element.value_for(name)
       end
 
-      # Returns true if the given content or ingredient has a value.
+      # Returns true if the given ingredient has a value.
       #
       def has?(name)
-        if element.ingredient_definitions.any?
-          element.has_value_for?(name)
-        else
-          Alchemy::Deprecation.silence do
-            element.has_ingredient?(name)
-          end
-        end
+        element.has_value_for?(name)
       end
 
-      # Return's the given content's essence.
-      #
-      def essence(name)
-        content(name).try(:essence)
-      end
-
-      deprecate essence: "Use `ingredient_by_role` instead", deprecator: Alchemy::Deprecation
-
       # Return's the ingredient record by given role.
       #
       def ingredient_by_role(role)
@@ -129,7 +94,7 @@ module Alchemy
     #   The HTML tag to be used for the wrapping element.
     # @option options :id (the element's dom_id)
     #   The wrapper tag's DOM ID.
-    # @option options :class (the element's essence name)
+    # @option options :class (the element's name)
     #   The wrapper tag's DOM class.
     # @option options :tags_formatter
     #   A lambda used for formatting the element's tags (see Alchemy::ElementsHelper::element_tags_attributes). Set to +false+ to not include tags in the wrapper element.
@@ -139,7 +104,7 @@ module Alchemy
         tag: :div,
         id: element.dom_id,
         class: element.name,
-        tags_formatter: ->(tags) { tags.join(" ") },
+        tags_formatter: ->(tags) { tags.join(" ") }
       }.merge(options)
 
       # capture inner template block
@@ -148,12 +113,12 @@ module Alchemy
       end
 
       # wrap output in a useful DOM element
-      if tag = options.delete(:tag)
+      if (tag = options.delete(:tag))
         # add preview attributes
         options.merge!(element_preview_code_attributes(element))
 
         # add tags
-        if tags_formatter = options.delete(:tags_formatter)
+        if (tags_formatter = options.delete(:tags_formatter))
           options.merge!(element_tags_attributes(element, formatter: tags_formatter))
         end