alchemy_cms 5.3.0 → 5.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b27eb5b4a0bdb143597a3e2cc33d0a8bfa4dd0d8febb2fd9261f2ad692716bc8
-  data.tar.gz: 7c67ed54f66b70419ac653421bdf3f8d38389bd3e67acfe70675bfcc8b357abd
+  metadata.gz: 0d0f346b9e40e791697acdf21d5e1193c72023f8f2570b777683ba2e781b67c1
+  data.tar.gz: b0c6a7f6e466bd0b134f9a7fdc76cb88ec1a56d0ca068209fa6b004619ed3a8e
 SHA512:
-  metadata.gz: aad3d674038b933605c7c8b5d11d74c707ed2687f9a5350e7762d56882a8994f85ea0a7e86e60ed4ee6cddb32aa46ecde70c42bcf91ceca62ad00e071195c497
-  data.tar.gz: c2f4a299345aafda98c2d40465ab8e011ee5d345104d32342503197afedccc4ed7bc527cce09afe8163dad148fe2019f3a2e18b0a0770eb48d971c9df51239dc
+  metadata.gz: e10199dcdc4b12d01bfebef27d23b752d1dd95c393263dac664c2d5588677aca80113c8b99ca281aefa130592767cc01304ab635d09273c63f3cc575ab2a1313
+  data.tar.gz: eaf3f967e1cb5ac4644cddf31ffdfcf3e931107be5508091fe94f61ceb7c096bacc4e39a8203ab8ba1ddf820992abfdae795774f91ac4ff571fc7687f7efd0ba

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+## 5.3.1 (2022-03-11)
+
+- Allow all pages in API again ([tvdeyen](https://github.com/tvdeyen))
+- New sortable page tree ([tvdeyen](https://github.com/tvdeyen))
+- Send language_id to Api::PagesController#index so Pages can be restricted to the language of the page. ([dbwinger](https://github.com/dbwinger))
+- Eager load in PageTree serializer ([tvdeyen](https://github.com/tvdeyen))
+
+## 5.3.0 (2022-03-09)
+
+- Allow parent page change ([tvdeyen](https://github.com/tvdeyen))
+- Precompile packs during test setup ([tvdeyen](https://github.com/tvdeyen))
+- Rework Sitemap JS ([tvdeyen](https://github.com/tvdeyen))
+- Fix rendering errors in page configure overlay ([tvdeyen](https://github.com/tvdeyen))
+
 ## 5.2.7 (2022-03-01)
 
 - Fix copying page with descendants to a different language ([dbwinger](https://github.com/dbwinger))

data/app/assets/javascripts/alchemy/admin.js

@@ -37,7 +37,6 @@
 //= require alchemy/alchemy.link_dialog
 //= require alchemy/alchemy.list_filter
 //= require alchemy/alchemy.initializer
-//= require alchemy/alchemy.page_sorter
 //= require alchemy/alchemy.uploader
 //= require alchemy/alchemy.preview_window
 //= require alchemy/alchemy.spinner

data/app/assets/javascripts/alchemy/templates/index.js

@@ -2,3 +2,4 @@
 //= require alchemy/templates/page
 //= require alchemy/templates/node_folder
 //= require alchemy/templates/node
+//= require alchemy/templates/page_folder

data/app/assets/javascripts/alchemy/templates/page.hbs

@@ -1,9 +1,19 @@
 <div class="page-select--page">
-  <i class="icon far fa-file fa-lg"></i>
-  <span class="page-select--page-name">
-    {{ page.name }}
-  </span>
-  <span class="page-select--page-urlname">
-    {{ page.url_path }}
-  </span>
+  <div class="page-select--top">
+    <i class="icon far fa-file fa-lg"></i>
+    <span class="page-select--page-name">
+      {{ page.name }}
+    </span>
+    <span class="page-select--page-urlname">
+      {{ page.url_path }}
+    </span>
+  </div>
+  <div class="page-select--bottom">
+    <span class="page-select--site-name">
+      {{ page.site.name }}
+    </span>
+    <span class="page-select--language-code">
+      {{ page.language.name }}
+    </span>
+  </div>
 </div>

data/app/assets/javascripts/alchemy/templates/page_folder.hbs

@@ -0,0 +1,3 @@
+<a class="page_folder" data-page-id="{{ page.id }}">
+  <i class="far fa-{{#if page.folded }}plus{{else}}minus{{/if}}-square fa-fw"></i>
+</a>

data/app/assets/stylesheets/alchemy/page-select.scss

@@ -7,24 +7,49 @@
 
 .page-select--page {
   display: flex;
-  align-items: center;
+  flex-direction: column;
 
   .icon {
     margin: 0 8px 0 4px;
 
     .select2-highlighted & {
-      color: $white
+      color: $white;
     }
   }
 }
 
+.page-select--top,
+.page-select--bottom {
+  display: flex;
+  flex-direction: row;
+  align-items: center;
+}
+
+.page-select--bottom {
+  font-size: $small-font-size;
+  padding-left: 6 * $default-padding;
+}
+
+.page-select--language-code {
+  display: inline-block;
+  background-color: $medium-gray;
+  margin-left: auto;
+  border-radius: $default-border-radius;
+  padding: $default-padding / 2 $default-padding;
+
+  .select2-highlighted & {
+    color: $select-hover-bg-color;
+    background-color: white;
+  }
+}
+
 .page-select--page-urlname {
   margin-left: auto;
-  padding: $default-padding 2*$default-padding;
+  padding: $default-padding 2 * $default-padding;
   color: $dark-gray;
   font-size: $small-font-size;
 
   .select2-highlighted & {
-    color: $white
+    color: $white;
   }
 }

data/app/assets/stylesheets/alchemy/sitemap.scss

@@ -142,12 +142,8 @@ $sitemap-url-xlarge-width: 350px;
 #sitemap {
   padding: 0 0 104px 0;
 
-  &.sorting {
-    padding-top: 100px;
-
-    .page_icon {
-      cursor: move;
-    }
+  .handle {
+    cursor: move;
   }
 
   .page_folder {

data/app/controllers/alchemy/admin/pages_controller.rb

@@ -7,7 +7,7 @@ module Alchemy
 
       helper "alchemy/pages"
 
-      before_action :load_resource, except: [:index, :flush, :new, :order, :create, :copy_language_tree, :link, :sort]
+      before_action :load_resource, except: [:index, :flush, :new, :order, :create, :copy_language_tree, :link]
 
       authorize_resource class: Alchemy::Page, except: [:index, :tree]
 
@@ -21,7 +21,7 @@ module Alchemy
         except: [:show]
 
       before_action :set_root_page,
-        only: [:index, :show, :sort, :order]
+        only: [:index, :show, :order]
 
       before_action :run_on_page_layout_callbacks,
         if: :run_on_page_layout_callbacks?,
@@ -173,9 +173,7 @@ module Alchemy
       def fold
         # @page is fetched via before filter
         @page.fold!(current_alchemy_user.id, !@page.folded?(current_alchemy_user.id))
-        respond_to do |format|
-          format.js
-        end
+        render json: serialized_page_tree
       end
 
       # Leaves the page editing mode and unlocks the page for other users
@@ -220,10 +218,6 @@ module Alchemy
         redirect_to admin_pages_path
       end
 
-      def sort
-        @sorting = true
-      end
-
       # Receives a JSON object representing a language tree to be ordered
       # and updates all pages in that language structure to their correct indexes
       def order
@@ -405,9 +399,11 @@ module Alchemy
       end
 
       def serialized_page_tree
-        PageTreeSerializer.new(@page, ability: current_ability,
-                                      user: current_alchemy_user,
-                                      full: params[:full] == "true")
+        PageTreeSerializer.new(
+          @page,
+          ability: current_ability,
+          user: current_alchemy_user,
+        )
       end
 
       def load_languages_and_layouts

data/app/controllers/alchemy/api/pages_controller.rb

@@ -2,17 +2,19 @@
 
 module Alchemy
   class Api::PagesController < Api::BaseController
+    serialization_scope :current_ability
     before_action :load_page, only: [:show]
 
     # Returns all pages as json object
     #
     def index
       # Fix for cancancan not able to merge multiple AR scopes for logged in users
-      if cannot? :edit_content, Alchemy::Page
-        @pages = Alchemy::Page.accessible_by(current_ability, :index)
-        @pages = @pages.where(language: Language.current)
+      if can? :edit_content, Alchemy::Page
+        @pages = Alchemy::Page.all
       else
-        @pages = Language.current&.pages.presence || Alchemy::Page.none
+        language = Alchemy::Language.find_by(id: params[:language_id]) || Alchemy::Language.current
+        @pages = Alchemy::Page.accessible_by(current_ability, :index)
+        @pages = @pages.where(language: language)
       end
       @pages = @pages.includes(*page_includes)
       @pages = @pages.ransack(params[:q]).result
@@ -49,6 +51,14 @@ module Alchemy
       respond_with @page
     end
 
+    def move
+      @page = Page.find(params[:id])
+      authorize! :update, @page
+      target_parent_page = Page.find(params[:target_parent_id])
+      @page.move_to_child_with_index(target_parent_page, params[:new_position])
+      render json: @page, serializer: PageSerializer
+    end
+
     private
 
     def load_page

data/app/serializers/alchemy/page_serializer.rb

@@ -14,8 +14,14 @@ module Alchemy
       :created_at,
       :updated_at,
       :status,
-      :url_path
+      :url_path,
+      :parent_id
 
     has_many :elements
+
+    with_options if: -> { scope.can?(:edit_content, object) } do
+      belongs_to :site
+      belongs_to :language
+    end
   end
 end

data/app/serializers/alchemy/page_tree_serializer.rb

@@ -3,13 +3,13 @@
 module Alchemy
   class PageTreeSerializer < BaseSerializer
     def attributes
-      {"pages" => nil}
+      { "pages" => nil }
     end
 
     def pages
       tree = []
-      path = [{id: object.parent_id, children: tree}]
-      page_list = object.self_and_descendants
+      path = [{ id: object.parent_id, children: tree }]
+      page_list = object.self_and_descendants.includes(language: :site)
       base_level = object.level - 1
       # Load folded pages in advance
       folded_user_pages = FoldedPage.folded_for_user(opts[:user]).pluck(:page_id)

data/app/views/alchemy/admin/pages/_page.html.erb

@@ -1,24 +1,7 @@
-<li id="page_{{id}}" class="page_level_{{level}} {{page_layout}}" data-slug="{{slug}}" data-restricted="{{restricted}}">
+<li id="page_{{id}}" class="sitemap-item {{page_layout}}" data-slug="{{slug}}" data-restricted="{{restricted}}" data-page-id="{{id}}" data-folded="{{folded}}">
   <div class="sitemap_page{{#if locked}} locked{{/if}}" name="{{name}}">
-    <div class="sitemap_left_images<% if @sorting %>{{#unless root}} handle{{/unless}}<% end %>">
-      <% unless @sorting %>
-        {{#unless root_or_leaf}}
-        <%= link_to(
-          alchemy.fold_admin_page_path(page),
-          remote: true,
-          method: :post,
-          class: "page_folder",
-          title: "{{#if folded}}#{Alchemy.t('Show childpages')}{{else}}#{Alchemy.t('Hide childpages')}{{/if}}",
-          id: "fold_button_{{id}}"
-        ) do %>
-          {{#if folded}}
-            <i class="far fa-plus-square fa-fw"></i>
-          {{else}}
-            <i class="far fa-minus-square fa-fw"></i>
-          {{/if}}
-        <% end %>
-        {{/unless}}
-      <% end %>
+    <div class="sitemap_left_images">
+      <span class="page_folder"></span>
       {{#if definition_missing}}
         <%= page_layout_missing_warning %>
       {{else}}
@@ -31,121 +14,121 @@
               </span>
             </span>
           {{else}}
+          <span class="{{#unless root}}handle{{/unless}}">
             <i class="icon far fa-file fa-lg"></i>
+          </span>
           {{/if}}
         {{else}}
           <span class="with-hint">
             <i class="icon fas fa-ban fa-fw"></i>
             <span class="hint-bubble">
-              <%= Alchemy.t('Your user role does not allow you to edit this page') %>
+              <%= Alchemy.t("Your user role does not allow you to edit this page") %>
             </span>
           </span>
         {{/if}}
       {{/if}}
     </div>
     <div class="sitemap_right_tools">
-      <%- unless @sorting -%>
-        {{#if permissions.info}}
-        <div class="button_with_label sitemap_tool">
-          <%= link_to_dialog(
-            render_icon('info-circle'),
-            alchemy.info_admin_page_path(page),
-            {
-              title: Alchemy.t(:page_infos),
-              size: '520x290'
-            }
-          ) %>
-          <label class="center"><%= Alchemy.t(:page_infos) %></label>
-        {{else}}
-        <div class="sitemap_tool disabled with-hint">
-          <%= render_icon('info-circle') %>
-          <span class="hint-bubble">
-            <%= Alchemy.t('Your user role does not allow you to edit this page') %>
-          </span>
-        {{/if}}
-        </div>
-        {{#if permissions.configure}}
-        <div class="button_with_label sitemap_tool">
-          <%= link_to_dialog(
-            render_icon(:cog),
-            alchemy.configure_admin_page_path(page),
-            {
-              title: Alchemy.t(:edit_page_properties),
-              size: '450x680'
-            }
-          ) -%>
-          <label class="center"><%= Alchemy.t(:edit_page_properties) %></label>
-        {{else}}
-        <div class="sitemap_tool disabled with-hint">
-          <%= render_icon(:cog) %>
-          <span class="hint-bubble">
-            <%= Alchemy.t('Your user role does not allow you to edit this page') %>
-          </span>
-        {{/if}}
-        </div>
-        {{#if permissions.copy}}
-        <div class="button_with_label sitemap_tool">
-          <%= link_to(
-            render_icon(:copy),
-            alchemy.insert_admin_clipboard_path(
-              remarkable_type: page.class.name.demodulize.underscore.pluralize,
-              remarkable_id: '__ID__',
-            ).gsub('__ID__', '{{id}}'),
-            remote: true,
-            method: 'post'
-          ) %>
-          <label class="center"><%= Alchemy.t(:copy_page) %></label>
-        {{else}}
-        <div class="sitemap_tool disabled with-hint">
-          <%= render_icon(:copy) %>
-          <span class="hint-bubble">
-            <%= Alchemy.t('Your user role does not allow you to edit this page') %>
-          </span>
-        {{/if}}
-        </div>
-        {{#if permissions.destroy}}
-        <div class="button_with_label sitemap_tool">
-          <%= link_to_confirm_dialog(
-            render_icon(:minus),
-            Alchemy.t(:confirm_to_delete_page),
-            url_for(
-              controller: 'pages',
-              action: 'destroy',
-              id: '__ID__'
-            ).gsub('__ID__', '{{id}}')
-          ) -%>
-          <label class="center"><%= Alchemy.t(:delete_page) %></label>
-        {{else}}
-        <div class="sitemap_tool disabled with-hint">
-          <%= render_icon(:minus) %>
-          <span class="hint-bubble">
-            <%= Alchemy.t('Your user role does not allow you to edit this page') %>
-          </span>
-        {{/if}}
-        </div>
-        {{#if permissions.create}}
-        <div class="button_with_label sitemap_tool">
-          <%= link_to_dialog(
-            render_icon(:plus),
-            alchemy.new_admin_page_path(parent_id: '__ID__').gsub('__ID__', '{{id}}'),
-            {
-              title: Alchemy.t(:create_page),
-              size: '340x165',
-              overflow: true
-            }
-          ) -%>
-          <label class="left"><%= Alchemy.t(:create_page) %></label>
-        {{else}}
-        <div class="sitemap_tool disabled with-hint">
-          <%= render_icon(:plus) %>
-          <span class="hint-bubble">
-            <%= Alchemy.t('Your user role does not allow you to edit this page') %>
-          </span>
-        {{/if}}
-        </div>
-      <%- end -%>
+      {{#if permissions.info}}
+      <div class="button_with_label sitemap_tool">
+        <%= link_to_dialog(
+          render_icon("info-circle"),
+          alchemy.info_admin_page_path(id: "__ID__"),
+          {
+            title: Alchemy.t(:page_infos),
+            size: "520x290"
+          }
+        ) %>
+        <label class="center"><%= Alchemy.t(:page_infos) %></label>
+      {{else}}
+      <div class="sitemap_tool disabled with-hint">
+        <%= render_icon("info-circle") %>
+        <span class="hint-bubble">
+          <%= Alchemy.t("Your user role does not allow you to edit this page") %>
+        </span>
+      {{/if}}
+      </div>
+      {{#if permissions.configure}}
+      <div class="button_with_label sitemap_tool">
+        <%= link_to_dialog(
+          render_icon(:cog),
+          alchemy.configure_admin_page_path(id: "__ID__"),
+          {
+            title: Alchemy.t(:edit_page_properties),
+            size: "450x680"
+          }
+        ) -%>
+        <label class="center"><%= Alchemy.t(:edit_page_properties) %></label>
+      {{else}}
+      <div class="sitemap_tool disabled with-hint">
+        <%= render_icon(:cog) %>
+        <span class="hint-bubble">
+          <%= Alchemy.t("Your user role does not allow you to edit this page") %>
+        </span>
+      {{/if}}
+      </div>
+      {{#if permissions.copy}}
+      <div class="button_with_label sitemap_tool">
+        <%= link_to(
+          render_icon(:copy),
+          alchemy.insert_admin_clipboard_path(
+            remarkable_type: :pages,
+            remarkable_id: "__ID__",
+          ),
+          remote: true,
+          method: :post
+        ) %>
+        <label class="center"><%= Alchemy.t(:copy_page) %></label>
+      {{else}}
+      <div class="sitemap_tool disabled with-hint">
+        <%= render_icon(:copy) %>
+        <span class="hint-bubble">
+          <%= Alchemy.t("Your user role does not allow you to edit this page") %>
+        </span>
+      {{/if}}
+      </div>
+      {{#if permissions.destroy}}
+      <div class="button_with_label sitemap_tool">
+        <%= link_to_confirm_dialog(
+          render_icon(:minus),
+          Alchemy.t(:confirm_to_delete_page),
+          url_for(
+            controller: "pages",
+            action: "destroy",
+            id: "__ID__"
+          )
+        ) -%>
+        <label class="center"><%= Alchemy.t(:delete_page) %></label>
+      {{else}}
+      <div class="sitemap_tool disabled with-hint">
+        <%= render_icon(:minus) %>
+        <span class="hint-bubble">
+          <%= Alchemy.t("Your user role does not allow you to edit this page") %>
+        </span>
+      {{/if}}
+      </div>
+      {{#if permissions.create}}
+      <div class="button_with_label sitemap_tool">
+        <%= link_to_dialog(
+          render_icon(:plus),
+          alchemy.new_admin_page_path(parent_id: "__ID__"),
+          {
+            title: Alchemy.t(:create_page),
+            size: "340x165",
+            overflow: true
+          }
+        ) -%>
+        <label class="left"><%= Alchemy.t(:create_page) %></label>
+      {{else}}
+      <div class="sitemap_tool disabled with-hint">
+        <%= render_icon(:plus) %>
+        <span class="hint-bubble">
+          <%= Alchemy.t("Your user role does not allow you to edit this page") %>
+        </span>
+      {{/if}}
+      </div>
     </div>
-    <div class="page_infos" id="page_<%= page.id %>_infos">
+    <div class="page_infos">
       <span class="page_status with-hint">
         <i class="icon fas fa-fw fa-compass {{#unless public}}disabled{{/unless}}" data-fa-transform="shrink-2"></i>
         <span class="hint-bubble">{{status_titles.public}}</span>
@@ -160,23 +143,18 @@
     </div>
     <div class="sitemap_sitename">
       {{#if permissions.edit_content}}
-        <%= link_to_unless(
-          @sorting,
-          '{{name}}',
-          alchemy.edit_admin_page_path(page),
+        <%= link_to(
+          "{{name}}",
+          alchemy.edit_admin_page_path(id: "__ID__"),
           title: Alchemy.t(:edit_page),
           class: "sitemap_pagename_link"
-        ) { content_tag('span', '{{name}}', class: "sitemap_pagename_link") } -%>
+        ) -%>
       {{else}}
-        <%= content_tag('span', '{{name}}', class: "sitemap_pagename_link") %>
+        <%= content_tag("span", "{{name}}", class: "sitemap_pagename_link") %>
       {{/if}}
     </div>
   </div>
-  {{#if children}}
-  <% unless @sorting %>{{#unless folded}}<% end %>
-  <ul id="page_{{id}}_children" class="level_{{level}}_children">
+  <ul id="page_{{id}}_children" class="children" data-parent-id="{{id}}">
     {{> list}}
   </ul>
-  <% unless @sorting %>{{/unless}}<% end %>
-  {{/if}}
 </li>

data/app/views/alchemy/admin/pages/_sitemap.html.erb

@@ -8,7 +8,7 @@
 </div>
 
 <script id="sitemap-template" type="text/x-handlebars-template">
-  <ul id="sitemap" class="list<%= @sorting ? ' sorting' : nil %>">
+  <ul id="sitemap" class="list">
     {{> list}}
   </ul>
 </script>
@@ -23,13 +23,7 @@
  $(function() {
    Alchemy.currentSitemap = new Alchemy.Sitemap({
      url: '<%= alchemy.tree_admin_pages_path %>',
-     page_root_id: <%= @page_root.id %>,
-     full: <%= full %>
-     <% if @sorting  %>
-     ,ready: function () {
-       Alchemy.PageSorter();
-     }
-     <% end %>
+     page_root_id: <%= @page_root.id %>
    });
    Alchemy.PagePublicationFields();
  });

data/app/views/alchemy/admin/pages/_toolbar.html.erb

@@ -28,18 +28,6 @@
       <label><%= Alchemy.t("Flush page cache") %></label>
     </div>
   <% end %>
-  <% if can?(:sort, Alchemy::Page) %>
-    <div class="button_with_label">
-      <%= link_to(
-        render_icon(:random),
-        alchemy.sort_admin_pages_path,
-        method: :get,
-        class: "icon_button",
-        title: Alchemy.t("Sort pages")
-      ) %>
-      <label><%= Alchemy.t("Sort pages") %></label>
-    </div>
-  <% end %>
   <div class="button_with_label" id="clipboard_button">
     <%= link_to_dialog(
       render_icon(clipboard_empty?("pages") ? :clipboard : :paste),

data/app/views/alchemy/admin/pages/index.html.erb

@@ -37,7 +37,7 @@
   <% else %>
     <% if @page_root %>
       <h2 id="page_filter_result"></h2>
-      <%= render "sitemap", page_partial: "page", full: !!@sorting %>
+      <%= render "sitemap", page_partial: "page" %>
     <% elsif can?(:create, Alchemy::Page) %>
       <%= render partial: "create_language_form" %>
     <% else %>

data/app/views/alchemy/admin/partials/_routes.html.erb

@@ -23,8 +23,15 @@
       return '<%= alchemy.move_api_node_path(id: 1) %>'.replace(/1/, id);
     },
 
+    move_admin_page_path: function(id) {
+      return '<%= alchemy.move_api_page_path(id: 1) %>'.replace(/1/, id);
+    },
+
+    fold_admin_page_path: function(id) {
+      return '<%= alchemy.fold_admin_page_path(id: 1) %>'.replace(/1/, id);
+    },
+
     order_admin_elements_path: '<%= alchemy.order_admin_elements_path %>',
-    order_admin_pages_path: '<%= alchemy.order_admin_pages_path %>',
     link_admin_pages_path: '<%= alchemy.link_admin_pages_path %>',
     api_pages_path: '<%= alchemy.api_pages_path %>',
     api_elements_path: '<%= alchemy.api_elements_path %>'

data/app/views/alchemy/essences/_essence_page_editor.html.erb

@@ -14,7 +14,7 @@
 <script>
   $('#<%= essence_page_editor.form_field_id %>').alchemyPageSelect({
     placeholder: "<%= Alchemy.t(:search_page) %>",
-    url: "<%= alchemy.api_pages_path %>",
+    url: "<%= alchemy.api_pages_path language_id: essence_page_editor.page&.language_id %>",
     query_params: <%== essence_page_editor.settings[:query_params].to_json %>,
     <% if essence_page_editor.essence.page %>
     initialSelection: {