alchemy_cms 5.1.4 → 6.0.0.b1

data/lib/alchemy/test_support/essence_shared_examples.rb

@@ -1,9 +1,6 @@
 # frozen_string_literal: true
 
 require "shoulda-matchers"
-require "alchemy/test_support/factories/page_factory"
-require "alchemy/test_support/factories/element_factory"
-require "alchemy/test_support/factories/content_factory"
 
 RSpec.shared_examples_for "an essence" do
   let(:element) { Alchemy::Element.new }
@@ -268,7 +265,6 @@ RSpec.shared_examples_for "an essence" do
 
   context "delegations" do
     it { should delegate_method(:restricted?).to(:page) }
-    it { should delegate_method(:trashed?).to(:element) }
     it { should delegate_method(:public?).to(:element) }
   end
 

data/lib/alchemy/test_support/factories/attachment_factory.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "factory_bot"
-
 FactoryBot.define do
   factory :alchemy_attachment, class: "Alchemy::Attachment" do
     file do

data/lib/alchemy/test_support/factories/content_factory.rb

@@ -1,11 +1,5 @@
 # frozen_string_literal: true
 
-require "factory_bot"
-require "alchemy/test_support/factories/element_factory"
-require "alchemy/test_support/factories/essence_file_factory"
-require "alchemy/test_support/factories/essence_picture_factory"
-require "alchemy/test_support/factories/essence_text_factory"
-
 FactoryBot.define do
   factory :alchemy_content, class: "Alchemy::Content" do
     name { "text" }

data/lib/alchemy/test_support/factories/dummy_user_factory.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "factory_bot"
-
 FactoryBot.define do
   factory :alchemy_dummy_user, class: "DummyUser" do
     sequence(:email) { |n| "john.#{n}@doe.com" }

data/lib/alchemy/test_support/factories/element_factory.rb

@@ -1,13 +1,11 @@
 # frozen_string_literal: true
 
-require "factory_bot"
-require "alchemy/test_support/factories/page_factory"
-
 FactoryBot.define do
   factory :alchemy_element, class: "Alchemy::Element" do
     name { "article" }
     autogenerate_contents { false }
-    association :page, factory: :alchemy_page
+    autogenerate_ingredients { false }
+    association :page_version, factory: :alchemy_page_version
 
     trait :fixed do
       fixed { true }
@@ -19,23 +17,22 @@ FactoryBot.define do
       name { "header" }
     end
 
-    trait :trashed do
-      after(:create) do |element|
-        element.update_column(:position, :null)
-      end
-    end
-
     trait :with_nestable_elements do
       name { "slider" }
     end
 
     trait :nested do
-      association :parent_element, factory: :alchemy_element, name: "slider"
+      parent_element { build(:alchemy_element, name: "slider", page_version: page_version) }
       name { "slide" }
     end
 
     trait :with_contents do
       autogenerate_contents { true }
     end
+
+    trait :with_ingredients do
+      name { "element_with_ingredients" }
+      autogenerate_ingredients { true }
+    end
   end
 end

data/lib/alchemy/test_support/factories/essence_audio_factory.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :alchemy_essence_audio, class: "Alchemy::EssenceAudio" do
+    attachment factory: :alchemy_attachment
+  end
+end

data/lib/alchemy/test_support/factories/essence_file_factory.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require "factory_bot"
-require "alchemy/test_support/factories/attachment_factory"
-
 FactoryBot.define do
   factory :alchemy_essence_file, class: "Alchemy::EssenceFile" do
     attachment factory: :alchemy_attachment

data/lib/alchemy/test_support/factories/essence_page_factory.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require "factory_bot"
-require "alchemy/test_support/factories/page_factory"
-
 FactoryBot.define do
   factory :alchemy_essence_page, class: "Alchemy::EssencePage" do
     page factory: :alchemy_page

data/lib/alchemy/test_support/factories/essence_picture_factory.rb

@@ -1,9 +1,5 @@
 # frozen_string_literal: true
 
-require "factory_bot"
-require "alchemy/test_support/factories/content_factory"
-require "alchemy/test_support/factories/picture_factory"
-
 FactoryBot.define do
   factory :alchemy_essence_picture, class: "Alchemy::EssencePicture" do
     picture factory: :alchemy_picture

data/lib/alchemy/test_support/factories/essence_text_factory.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "factory_bot"
-
 FactoryBot.define do
   factory :alchemy_essence_text, class: "Alchemy::EssenceText" do
     body { "This is a headline" }

data/lib/alchemy/test_support/factories/essence_video_factory.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :alchemy_essence_video, class: "Alchemy::EssenceVideo" do
+    attachment factory: :alchemy_attachment
+  end
+end

data/lib/alchemy/test_support/factories/ingredient_factory.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  %w[
+    audio
+    boolean
+    datetime
+    file
+    headline
+    html
+    link
+    node
+    page
+    picture
+    richtext
+    select
+    text
+  ].each do |ingredient|
+    factory :"alchemy_ingredient_#{ingredient}", class: "Alchemy::Ingredients::#{ingredient.classify}" do
+      role { ingredient }
+      type { "Alchemy::Ingredients::#{ingredient.classify}" }
+      association :element, name: "all_you_can_eat_ingredients", factory: :alchemy_element
+    end
+  end
+end

data/lib/alchemy/test_support/factories/language_factory.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require "factory_bot"
-require "alchemy/test_support/factories/site_factory"
-
 FactoryBot.define do
   factory :alchemy_language, class: "Alchemy::Language" do
     name { "Your Language" }

data/lib/alchemy/test_support/factories/node_factory.rb

@@ -1,9 +1,5 @@
 # frozen_string_literal: true
 
-require "factory_bot"
-require "alchemy/test_support/factories/language_factory"
-require "alchemy/test_support/factories/page_factory"
-
 FactoryBot.define do
   factory :alchemy_node, class: "Alchemy::Node" do
     language { Alchemy::Language.default || create(:alchemy_language) }

data/lib/alchemy/test_support/factories/page_factory.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require "factory_bot"
-require "alchemy/test_support/factories/language_factory"
-
 FactoryBot.define do
   factory :alchemy_page, class: "Alchemy::Page" do
     language do
@@ -32,7 +29,26 @@ FactoryBot.define do
 
     trait :public do
       sequence(:name) { |n| "A Public Page #{n}" }
-      public_on { Time.current }
+      transient do
+        public_on { Time.current }
+        public_until { nil }
+      end
+      after(:build) do |page, evaluator|
+        page.build_public_version(
+          public_on: evaluator.public_on,
+          public_until: evaluator.public_until,
+        )
+      end
+      after(:create) do |page|
+        if page.autogenerate_elements
+          page.definition["autogenerate"].each do |name|
+            create(:alchemy_element,
+              name: name,
+              page_version: page.public_version,
+              autogenerate_contents: true)
+          end
+        end
+      end
     end
 
     trait :layoutpage do

data/lib/alchemy/test_support/factories/page_version_factory.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :alchemy_page_version, class: "Alchemy::PageVersion" do
+    association :page, factory: :alchemy_page
+
+    trait :published do
+      public_on { Time.current }
+    end
+
+    transient do
+      element_count { 1 }
+    end
+
+    trait :with_elements do
+      after(:build) do |page_version, evaluator|
+        evaluator.element_count.times do
+          page_version.elements.build(name: "article")
+        end
+      end
+    end
+  end
+end

data/lib/alchemy/test_support/factories/picture_factory.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "factory_bot"
-
 FactoryBot.define do
   factory :alchemy_picture, class: "Alchemy::Picture" do
     image_file do

data/lib/alchemy/test_support/factories/picture_thumb_factory.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require "factory_bot"
-require "securerandom"
-
 FactoryBot.define do
   factory :alchemy_picture_thumb, class: "Alchemy::PictureThumb" do
     picture { create(:alchemy_picture) }

data/lib/alchemy/test_support/factories/site_factory.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "factory_bot"
-
 FactoryBot.define do
   factory :alchemy_site, class: "Alchemy::Site" do
     name { "A Site" }

data/lib/alchemy/test_support/having_crop_action_examples.rb

@@ -0,0 +1,170 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples_for "having crop action" do |args|
+  describe "#crop" do
+    let(:picture) { Alchemy::Picture.new }
+
+    before do
+      expect(args[:model_class]).to receive(:find).and_return(croppable_resource)
+    end
+
+    context "with no picture assigned" do
+      it "renders error message" do
+        get :crop, params: { id: 1 }
+        expect(assigns(:no_image_notice)).to eq(Alchemy.t(:no_image_for_cropper_found))
+      end
+    end
+
+    context "with picture assigned" do
+      subject { get :crop, params: { id: 1, picture_id: picture.id } }
+
+      let(:default_mask) do
+        [
+          0,
+          0,
+          300,
+          250,
+        ]
+      end
+
+      let(:settings) { {} }
+
+      before do
+        picture.image_file_width = 300
+        picture.image_file_height = 250
+        allow(croppable_resource).to receive(:settings) { settings }
+        expect(Alchemy::Picture).to receive(:find_by) { picture }
+      end
+
+      context "with no render_size present in croppable_resource" do
+        before do
+          expect(croppable_resource).to receive(:render_size).at_least(:once).and_return(nil)
+        end
+
+        context "with sizes in settings" do
+          let(:settings) do
+            { size: "300x250" }
+          end
+
+          it "sets sizes to given values" do
+            subject
+            expect(assigns(:settings)[:min_size]).to eq([300, 250])
+          end
+        end
+
+        context "with no sizes in settings" do
+          it "sets sizes to zero" do
+            subject
+            expect(assigns(:settings)[:min_size]).to eq([0, 0])
+          end
+        end
+      end
+
+      context "with render_size present in croppable_resource" do
+        it "sets sizes from these values" do
+          expect(croppable_resource).to receive(:render_size).at_least(:once).and_return("30x25")
+
+          subject
+          expect(assigns(:settings)[:min_size]).to eq([30, 25])
+        end
+
+        context "when width or height is not fixed" do
+          it "infers the height from the image file preserving the aspect ratio" do
+            expect(croppable_resource).to receive(:render_size).at_least(:once).and_return("30x")
+
+            subject
+            expect(assigns(:settings)[:min_size]).to eq([30, 25])
+          end
+
+          context "and aspect ratio set on the settings" do
+            let(:settings) do
+              { fixed_ratio: "2" }
+            end
+
+            it "does not infer the height from the image file preserving the aspect ratio" do
+              expect(croppable_resource).to receive(:render_size).at_least(:once).and_return("x25")
+
+              subject
+              expect(assigns(:settings)[:min_size]).to eq([50, 25])
+            end
+          end
+        end
+
+        context "when width or height is not fixed and an aspect ratio is given" do
+          context "and aspect ratio set on the settings" do
+            let(:settings) do
+              { fixed_ratio: "0.5" }
+            end
+
+            it "width is given, it infers the height from width and ratio" do
+              expect(croppable_resource).to receive(:render_size).at_least(:once).and_return("30x")
+
+              subject
+              expect(assigns(:settings)[:min_size]).to eq([30, 60])
+            end
+          end
+
+          it "infers the height from the image file preserving the aspect ratio" do
+            expect(croppable_resource).to receive(:render_size).at_least(:once).and_return("x25")
+
+            subject
+            expect(assigns(:settings)[:min_size]).to eq([30, 25])
+          end
+        end
+      end
+
+      context "no crop sizes present in croppable_resource" do
+        it "assigns default mask boxes" do
+          subject
+          expect(assigns(:settings)[:default_box]).to eq(default_mask)
+        end
+      end
+
+      context "crop sizes present in croppable_resource" do
+        let(:mask) { [0, 0, 120, 160] }
+
+        before do
+          allow(croppable_resource).to receive(:crop_from).and_return("0x0")
+          allow(croppable_resource).to receive(:crop_size).and_return("120x160")
+        end
+
+        it "assigns cropping boxes" do
+          subject
+          expect(assigns(:settings)[:default_box]).to eq(default_mask)
+        end
+      end
+
+      context "with fixed_ratio set to false" do
+        let(:settings) do
+          { fixed_ratio: false }
+        end
+
+        it "sets ratio to false" do
+          subject
+          expect(assigns(:settings)[:ratio]).to eq(false)
+        end
+      end
+
+      context "with fixed_ratio set to a non float string" do
+        let(:settings) do
+          { fixed_ratio: "123,45" }
+        end
+
+        it "raises error" do
+          expect { subject }.to raise_error(ArgumentError)
+        end
+      end
+
+      context "with no fixed_ratio set" do
+        let(:settings) do
+          { size: "80x60" }
+        end
+
+        it "sets a fixed ratio from sizes" do
+          subject
+          expect(assigns(:settings)[:ratio]).to eq(80.0 / 60.0)
+        end
+      end
+    end
+  end
+end