alchemy_cms 4.6.2 → 5.0.0.beta1

data/app/models/alchemy/element/presenters.rb

@@ -23,7 +23,7 @@ module Alchemy
       # If no translation is found a humanized name is used.
       #
       def display_name_for(name)
-        Alchemy.t(name, scope: 'element_names', default: name.to_s.humanize)
+        Alchemy.t(name, scope: "element_names", default: name.to_s.humanize)
       end
     end
 
@@ -32,7 +32,7 @@ module Alchemy
     # @see Alchemy::Element::Presenters#display_name_for
     #
     def display_name
-      self.class.display_name_for(definition['name'] || name)
+      self.class.display_name_for(definition["name"] || name)
     end
 
     # Returns a preview text for element.
@@ -97,6 +97,7 @@ module Alchemy
 
     def preview_text_from_nested_elements(maxlength)
       return if all_nested_elements.empty?
+
       all_nested_elements.first.preview_text(maxlength)
     end
 

data/app/models/alchemy/element_to_page.rb

@@ -3,7 +3,7 @@
 module Alchemy
   class ElementToPage
     def self.table_name
-      [Alchemy::Element.table_name, Alchemy::Page.table_name].join('_')
+      [Alchemy::Element.table_name, Alchemy::Page.table_name].join("_")
     end
   end
 end

data/app/models/alchemy/essence_boolean.rb

@@ -8,14 +8,12 @@
 #  value      :boolean
 #  created_at :datetime         not null
 #  updated_at :datetime         not null
-#  creator_id :integer
-#  updater_id :integer
 #
 
 # Stores boolean values.
 # Provides a checkbox in the editor views.
 module Alchemy
   class EssenceBoolean < BaseRecord
-    acts_as_essence ingredient_column: 'value'
+    acts_as_essence ingredient_column: "value"
   end
 end

data/app/models/alchemy/essence_date.rb

@@ -6,19 +6,18 @@
 #
 #  id         :integer          not null, primary key
 #  date       :datetime
-#  creator_id :integer
-#  updater_id :integer
 #  created_at :datetime         not null
 #  updated_at :datetime         not null
 #
 
 module Alchemy
   class EssenceDate < BaseRecord
-    acts_as_essence ingredient_column: 'date'
+    acts_as_essence ingredient_column: "date"
 
     # Returns self.date for the Element#preview_text method.
     def preview_text(_maxlength = nil)
       return "" if date.blank?
+
       ::I18n.l(date, format: :'alchemy.essence_date')
     end
   end

data/app/models/alchemy/essence_file.rb

@@ -8,8 +8,6 @@
 #  attachment_id :integer
 #  title         :string
 #  css_class     :string
-#  creator_id    :integer
-#  updater_id    :integer
 #  created_at    :datetime         not null
 #  updated_at    :datetime         not null
 #  link_text     :string
@@ -18,19 +16,21 @@
 module Alchemy
   class EssenceFile < BaseRecord
     belongs_to :attachment, optional: true
-    acts_as_essence ingredient_column: 'attachment'
+    acts_as_essence ingredient_column: "attachment"
 
     def attachment_url
       return if attachment.nil?
+
       routes.download_attachment_path(
         id: attachment.id,
         name: attachment.urlname,
-        format: attachment.suffix
+        format: attachment.suffix,
       )
     end
 
     def preview_text(max = 30)
       return "" if attachment.blank?
+
       attachment.name.to_s[0..max - 1]
     end
 

data/app/models/alchemy/essence_html.rb

@@ -6,15 +6,13 @@
 #
 #  id         :integer          not null, primary key
 #  source     :text
-#  creator_id :integer
-#  updater_id :integer
 #  created_at :datetime         not null
 #  updated_at :datetime         not null
 #
 
 module Alchemy
   class EssenceHtml < BaseRecord
-    acts_as_essence ingredient_column: 'source'
+    acts_as_essence ingredient_column: "source"
 
     # Returns the first x (default = 30) (HTML escaped) characters from self.source for the Element#preview_text method.
     def preview_text(maxlength = 30)

data/app/models/alchemy/essence_link.rb

@@ -11,12 +11,10 @@
 #  link_class_name :string
 #  created_at      :datetime         not null
 #  updated_at      :datetime         not null
-#  creator_id      :integer
-#  updater_id      :integer
 #
 
 module Alchemy
   class EssenceLink < BaseRecord
-    acts_as_essence ingredient_column: 'link'
+    acts_as_essence ingredient_column: "link"
   end
 end

data/app/models/alchemy/essence_node.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module Alchemy
+  class EssenceNode < BaseRecord
+    acts_as_essence(
+      ingredient_column: :node,
+      preview_text_column: :node_name,
+      belongs_to: {
+        class_name: "Alchemy::Node",
+        foreign_key: :node_id,
+        inverse_of: :essence_nodes,
+        optional: true,
+      },
+    )
+
+    delegate :name, to: :node, prefix: true, allow_nil: true
+  end
+end

data/app/models/alchemy/essence_page.rb

@@ -2,28 +2,15 @@
 
 module Alchemy
   class EssencePage < BaseRecord
-    PAGE_ID = /\A\d+\z/
-
     acts_as_essence(
       ingredient_column: :page,
       preview_text_method: :name,
       belongs_to: {
-        class_name: 'Alchemy::Page',
+        class_name: "Alchemy::Page",
         foreign_key: :page_id,
         inverse_of: :essence_pages,
-        optional: true
-      }
+        optional: true,
+      },
     )
-
-    def ingredient=(page)
-      case page
-      when PAGE_ID
-        self.page = Alchemy::Page.new(id: page)
-      when Alchemy::Page
-        self.page = page
-      else
-        super
-      end
-    end
   end
 end

data/app/models/alchemy/essence_picture.rb

@@ -14,8 +14,6 @@
 #  link_title      :string
 #  css_class       :string
 #  link_target     :string
-#  creator_id      :integer
-#  updater_id      :integer
 #  created_at      :datetime         not null
 #  updated_at      :datetime         not null
 #  crop_from       :string
@@ -26,10 +24,10 @@
 module Alchemy
   class EssencePicture < BaseRecord
     acts_as_essence ingredient_column: :picture, belongs_to: {
-      class_name: 'Alchemy::Picture',
+      class_name: "Alchemy::Picture",
       foreign_key: :picture_id,
       inverse_of: :essence_pictures,
-      optional: true
+      optional: true,
     }
 
     delegate :image_file_width, :image_file_height, :image_file, to: :picture
@@ -80,7 +78,7 @@ module Alchemy
         format: picture.default_render_format,
         crop_from: crop_from.presence,
         crop_size: crop_size.presence,
-        size: content.settings[:size]
+        size: content.settings[:size],
       }.with_indifferent_access
     end
 
@@ -90,11 +88,11 @@ module Alchemy
     # image displayed in the frontend.
     #
     # @return [String]
-    def thumbnail_url(options = {})
+    def thumbnail_url
       return if picture.nil?
 
-      crop = crop_values_present? || content.settings_value(:crop, options)
-      size = render_size || content.settings_value(:size, options)
+      crop = crop_values_present? || content.settings[:crop]
+      size = render_size || content.settings[:size]
 
       options = {
         size: thumbnail_size(size, crop),
@@ -102,7 +100,7 @@ module Alchemy
         crop_from: crop_from.presence,
         crop_size: crop_size.presence,
         flatten: true,
-        format: picture.image_file_format
+        format: picture.image_file_format,
       }
 
       picture.url(options)
@@ -116,6 +114,7 @@ module Alchemy
     # @return [String]
     def preview_text(max = 30)
       return "" if picture.nil?
+
       picture.name.to_s[0..max - 1]
     end
 
@@ -124,6 +123,7 @@ module Alchemy
     # @return [Hash]
     def cropping_mask
       return if crop_from.blank? || crop_size.blank?
+
       crop_from = point_from_string(read_attribute(:crop_from))
       crop_size = sizes_from_string(read_attribute(:crop_size))
 
@@ -137,12 +137,12 @@ module Alchemy
       picture_url(content.settings)
     end
 
-    # Show image cropping link for content and options?
-    def allow_image_cropping?(options = {})
-      content && content.settings_value(:crop, options) && picture &&
+    # Show image cropping link for content
+    def allow_image_cropping?
+      content && content.settings[:crop] && picture &&
         picture.can_be_cropped_to(
-          content.settings_value(:size, options),
-          content.settings_value(:upsample, options)
+          content.settings[:size],
+          content.settings[:upsample],
         )
     end
 
@@ -161,16 +161,17 @@ module Alchemy
     end
 
     def normalize_crop_value(crop_value)
-      self[crop_value].split('x').map { |n| normalize_number(n) }.join('x')
+      self[crop_value].split("x").map { |n| normalize_number(n) }.join("x")
     end
 
     def normalize_number(number)
       number = number.to_f.round
-      number < 0 ? 0 : number
+      number.negative? ? 0 : number
     end
 
     def replace_newlines
       return nil if caption.nil?
+
       caption.gsub!(/(\r\n|\r|\n)/, "<br/>")
     end
   end

data/app/models/alchemy/essence_picture_view.rb

@@ -13,7 +13,7 @@ module Alchemy
       show_caption: true,
       disable_link: false,
       srcset: [],
-      sizes: []
+      sizes: [],
     }.with_indifferent_access
 
     def initialize(content, options = {}, html_options = {})
@@ -33,12 +33,12 @@ module Alchemy
         output = link_to(output, url_for(essence.link), {
           title: essence.link_title.presence,
           target: essence.link_target == "blank" ? "_blank" : nil,
-          data: {link_target: essence.link_target.presence}
+          data: { link_target: essence.link_target.presence },
         })
       end
 
       if caption
-        content_tag(:figure, output, {class: essence.css_class.presence}.merge(html_options))
+        content_tag(:figure, output, { class: essence.css_class.presence }.merge(html_options))
       else
         output
       end
@@ -48,6 +48,7 @@ module Alchemy
 
     def caption
       return unless show_caption?
+
       @_caption ||= content_tag(:figcaption, essence.caption)
     end
 
@@ -57,8 +58,8 @@ module Alchemy
           alt: essence.alt_tag.presence,
           title: essence.title.presence,
           class: caption ? nil : essence.css_class.presence,
-          srcset: srcset.join(', ').presence,
-          sizes: options[:sizes].join(', ').presence
+          srcset: srcset.join(", ").presence,
+          sizes: options[:sizes].join(", ").presence,
         }.merge(caption ? {} : html_options)
       )
     end
@@ -74,7 +75,7 @@ module Alchemy
     def srcset
       options[:srcset].map do |size|
         url = essence.picture_url(size: size)
-        width, height = size.split('x')
+        width, height = size.split("x")
         width.present? ? "#{url} #{width}w" : "#{url} #{height}h"
       end
     end

data/app/models/alchemy/essence_richtext.rb

@@ -8,15 +8,13 @@
 #  body          :text
 #  stripped_body :text
 #  public        :boolean
-#  creator_id    :integer
-#  updater_id    :integer
 #  created_at    :datetime         not null
 #  updated_at    :datetime         not null
 #
 
 module Alchemy
   class EssenceRichtext < BaseRecord
-    acts_as_essence preview_text_column: 'stripped_body'
+    acts_as_essence preview_text_column: "stripped_body"
 
     before_save :strip_content
 

data/app/models/alchemy/essence_select.rb

@@ -8,13 +8,11 @@
 #  value      :string
 #  created_at :datetime         not null
 #  updated_at :datetime         not null
-#  creator_id :integer
-#  updater_id :integer
 #
 
 # Provides a select box that stores string values.
 module Alchemy
   class EssenceSelect < BaseRecord
-    acts_as_essence ingredient_column: 'value'
+    acts_as_essence ingredient_column: "value"
   end
 end

data/app/models/alchemy/essence_text.rb

@@ -11,8 +11,6 @@
 #  link_class_name :string
 #  public          :boolean          default(FALSE)
 #  link_target     :string
-#  creator_id      :integer
-#  updater_id      :integer
 #  created_at      :datetime         not null
 #  updated_at      :datetime         not null
 #

data/app/models/alchemy/folded_page.rb

@@ -17,6 +17,7 @@ module Alchemy
 
     def self.folded_for_user(user)
       return none unless Alchemy.user_class < ActiveRecord::Base
+
       where(user: user, folded: true)
     end
   end

data/app/models/alchemy/language.rb

@@ -20,15 +20,18 @@
 #  locale         :string
 #
 
-require_dependency 'alchemy/site'
+require_dependency "alchemy/site"
 
 module Alchemy
   class Language < BaseRecord
     belongs_to :site
-    has_many :pages
+    has_many :pages, inverse_of: :language
+    has_many :nodes, inverse_of: :language
 
     before_validation :set_locale, if: -> { locale.blank? }
 
+    has_one :root_page, -> { where(parent: nil, layoutpage: false) }, class_name: "Alchemy::Page"
+
     validates :name, presence: true
     validates :page_layout, presence: true
     validates :frontpage_name, presence: true
@@ -54,11 +57,13 @@ module Alchemy
     after_update :unpublish_pages,
       if: :should_unpublish_pages?
 
-    before_destroy :check_for_default
-    after_destroy :delete_language_root_page
+    before_destroy if: -> { pages.any? } do
+      errors.add(:pages, :still_present)
+      throw(:abort)
+    end
 
-    scope :published,       -> { where(public: true) }
-    scope :with_root_page,  -> { joins(:pages).where(Page.table_name => {language_root: true}) }
+    scope :published, -> { where(public: true) }
+    scope :with_root_page, -> { joins(:pages).where(Page.table_name => { language_root: true }) }
 
     class << self
       def on_site(site)
@@ -81,6 +86,8 @@ module Alchemy
 
       # The root page of the current language.
       def current_root_page
+        return unless current
+
         current.pages.language_roots.first
       end
 
@@ -100,16 +107,6 @@ module Alchemy
 
     include Alchemy::Language::Code
 
-    # Root page
-    def root_page
-      @root_page ||= pages.language_roots.first
-    end
-
-    # Layout root page
-    def layout_root_page
-      @layout_root_page ||= Page.layout_root_for(id)
-    end
-
     # All available locales matching this language
     #
     # Matching either the code (+language_code+ + +country_code+) or the +language_code+
@@ -118,10 +115,14 @@ module Alchemy
     #
     def matching_locales
       @_matching_locales ||= ::I18n.available_locales.select do |locale|
-        locale.to_s.split('-')[0] == language_code
+        locale.to_s.split("-")[0] == language_code
       end
     end
 
+    def available_menu_names
+      Alchemy::Node.available_menu_names - nodes.reject(&:parent_id).map(&:menu_type)
+    end
+
     private
 
     def set_locale
@@ -157,36 +158,21 @@ module Alchemy
     def remove_old_default
       lang = Language.on_site(site).default
       return true if lang.nil?
+
       lang.default = false
       lang.save(validate: false)
     end
 
     def should_set_pages_language?
-      if active_record_5_1?
-        saved_change_to_language_code? || saved_change_to_country_code?
-      else
-        language_code_changed? || country_code_changed?
-      end
+      saved_change_to_language_code? || saved_change_to_country_code?
     end
 
     def set_pages_language
       pages.update_all language_code: code
     end
 
-    def check_for_default
-      raise DefaultLanguageNotDeletable if default?
-    end
-
-    def delete_language_root_page
-      root_page.try(:destroy) && layout_root_page.try(:destroy)
-    end
-
     def should_unpublish_pages?
-      if active_record_5_1?
-        saved_changes[:public] == [true, false]
-      else
-        changes[:public] == [true, false]
-      end
+      saved_changes[:public] == [true, false]
     end
 
     def unpublish_pages