alchemy_cms 4.5.0 → 5.0.0.rc1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (388) hide show
  1. checksums.yaml +4 -4
  2. data/.github/workflows/ci.yml +56 -18
  3. data/.github/workflows/stale.yml +1 -1
  4. data/.gitignore +20 -2
  5. data/.hound.yml +2 -1
  6. data/.prettierrc +6 -0
  7. data/.rubocop.yml +33 -20
  8. data/CHANGELOG.md +117 -0
  9. data/Gemfile +24 -22
  10. data/README.md +32 -20
  11. data/Rakefile +11 -8
  12. data/alchemy_cms.gemspec +6 -5
  13. data/app/assets/javascripts/alchemy/admin.js +1 -5
  14. data/app/assets/javascripts/alchemy/alchemy.base.js.coffee +2 -1
  15. data/app/assets/javascripts/alchemy/alchemy.element_editors.js.coffee +0 -2
  16. data/app/assets/javascripts/alchemy/alchemy.link_dialog.js.coffee +5 -5
  17. data/app/assets/javascripts/alchemy/alchemy.page_sorter.js +17 -17
  18. data/app/assets/javascripts/alchemy/node_select.js +39 -0
  19. data/app/assets/javascripts/alchemy/templates/index.js +1 -0
  20. data/app/assets/javascripts/alchemy/templates/node.hbs +16 -0
  21. data/app/assets/javascripts/alchemy/templates/page.hbs +1 -1
  22. data/app/assets/stylesheets/alchemy/_mixins.scss +2 -3
  23. data/app/assets/stylesheets/alchemy/_variables.scss +2 -2
  24. data/app/assets/stylesheets/alchemy/admin.scss +3 -2
  25. data/app/assets/stylesheets/alchemy/base.scss +0 -1
  26. data/app/assets/stylesheets/alchemy/elements.scss +1 -1
  27. data/app/assets/stylesheets/alchemy/forms.scss +5 -0
  28. data/app/assets/stylesheets/alchemy/lists.scss +0 -8
  29. data/app/assets/stylesheets/alchemy/node-select.scss +43 -0
  30. data/app/assets/stylesheets/alchemy/nodes.scss +2 -2
  31. data/app/assets/stylesheets/alchemy/sitemap.scss +63 -21
  32. data/app/assets/stylesheets/alchemy/tables.scss +1 -24
  33. data/app/controllers/alchemy/admin/attachments_controller.rb +8 -7
  34. data/app/controllers/alchemy/admin/base_controller.rb +13 -33
  35. data/app/controllers/alchemy/admin/clipboard_controller.rb +5 -4
  36. data/app/controllers/alchemy/admin/contents_controller.rb +1 -2
  37. data/app/controllers/alchemy/admin/dashboard_controller.rb +10 -9
  38. data/app/controllers/alchemy/admin/elements_controller.rb +20 -20
  39. data/app/controllers/alchemy/admin/essence_pictures_controller.rb +12 -14
  40. data/app/controllers/alchemy/admin/languages_controller.rb +35 -2
  41. data/app/controllers/alchemy/admin/layoutpages_controller.rb +5 -2
  42. data/app/controllers/alchemy/admin/nodes_controller.rb +5 -4
  43. data/app/controllers/alchemy/admin/pages_controller.rb +50 -63
  44. data/app/controllers/alchemy/admin/pictures_controller.rb +16 -16
  45. data/app/controllers/alchemy/admin/resources_controller.rb +21 -13
  46. data/app/controllers/alchemy/admin/sites_controller.rb +18 -0
  47. data/app/controllers/alchemy/admin/styleguide_controller.rb +1 -0
  48. data/app/controllers/alchemy/admin/tags_controller.rb +5 -3
  49. data/app/controllers/alchemy/admin/trash_controller.rb +6 -6
  50. data/app/controllers/alchemy/api/base_controller.rb +2 -2
  51. data/app/controllers/alchemy/api/contents_controller.rb +4 -4
  52. data/app/controllers/alchemy/api/elements_controller.rb +8 -8
  53. data/app/controllers/alchemy/api/nodes_controller.rb +37 -1
  54. data/app/controllers/alchemy/api/pages_controller.rb +15 -22
  55. data/app/controllers/alchemy/attachments_controller.rb +5 -5
  56. data/app/controllers/alchemy/base_controller.rb +10 -9
  57. data/app/controllers/alchemy/messages_controller.rb +16 -23
  58. data/app/controllers/alchemy/pages_controller.rb +13 -11
  59. data/app/controllers/concerns/alchemy/admin/archive_overlay.rb +3 -2
  60. data/app/controllers/concerns/alchemy/admin/current_language.rb +23 -0
  61. data/app/controllers/concerns/alchemy/admin/uploader_responses.rb +5 -5
  62. data/app/controllers/concerns/alchemy/legacy_page_redirects.rb +4 -4
  63. data/app/controllers/concerns/alchemy/page_redirects.rb +2 -9
  64. data/app/controllers/concerns/alchemy/site_redirects.rb +2 -2
  65. data/app/decorators/alchemy/content_editor.rb +55 -0
  66. data/app/decorators/alchemy/element_editor.rb +39 -0
  67. data/app/helpers/alchemy/admin/attachments_helper.rb +6 -6
  68. data/app/helpers/alchemy/admin/base_helper.rb +36 -35
  69. data/app/helpers/alchemy/admin/contents_helper.rb +3 -3
  70. data/app/helpers/alchemy/admin/elements_helper.rb +3 -88
  71. data/app/helpers/alchemy/admin/essences_helper.rb +8 -117
  72. data/app/helpers/alchemy/admin/form_helper.rb +1 -1
  73. data/app/helpers/alchemy/admin/navigation_helper.rb +24 -23
  74. data/app/helpers/alchemy/admin/pages_helper.rb +12 -12
  75. data/app/helpers/alchemy/admin/pictures_helper.rb +4 -6
  76. data/app/helpers/alchemy/admin/tags_helper.rb +8 -7
  77. data/app/helpers/alchemy/base_helper.rb +13 -8
  78. data/app/helpers/alchemy/elements_block_helper.rb +2 -31
  79. data/app/helpers/alchemy/elements_helper.rb +12 -58
  80. data/app/helpers/alchemy/pages_helper.rb +24 -174
  81. data/app/helpers/alchemy/url_helper.rb +2 -1
  82. data/app/mailers/alchemy/base_mailer.rb +1 -1
  83. data/app/mailers/alchemy/messages_mailer.rb +1 -1
  84. data/app/models/alchemy/attachment.rb +20 -18
  85. data/app/models/alchemy/base_record.rb +2 -5
  86. data/app/models/alchemy/content.rb +33 -52
  87. data/app/models/alchemy/content/factory.rb +24 -31
  88. data/app/models/alchemy/element.rb +45 -53
  89. data/app/models/alchemy/element/definitions.rb +4 -4
  90. data/app/models/alchemy/element/element_contents.rb +9 -6
  91. data/app/models/alchemy/element/element_essences.rb +4 -3
  92. data/app/models/alchemy/element/presenters.rb +3 -2
  93. data/app/models/alchemy/element_to_page.rb +1 -1
  94. data/app/models/alchemy/essence_boolean.rb +1 -3
  95. data/app/models/alchemy/essence_date.rb +2 -3
  96. data/app/models/alchemy/essence_file.rb +4 -4
  97. data/app/models/alchemy/essence_html.rb +1 -3
  98. data/app/models/alchemy/essence_link.rb +1 -3
  99. data/app/models/alchemy/essence_node.rb +18 -0
  100. data/app/models/alchemy/essence_page.rb +3 -16
  101. data/app/models/alchemy/essence_picture.rb +17 -16
  102. data/app/models/alchemy/essence_picture_view.rb +7 -6
  103. data/app/models/alchemy/essence_richtext.rb +1 -3
  104. data/app/models/alchemy/essence_select.rb +1 -3
  105. data/app/models/alchemy/essence_text.rb +0 -2
  106. data/app/models/alchemy/folded_page.rb +1 -0
  107. data/app/models/alchemy/language.rb +21 -35
  108. data/app/models/alchemy/language/code.rb +4 -4
  109. data/app/models/alchemy/legacy_page_url.rb +1 -1
  110. data/app/models/alchemy/message.rb +3 -3
  111. data/app/models/alchemy/node.rb +34 -10
  112. data/app/models/alchemy/page.rb +53 -123
  113. data/app/models/alchemy/page/fixed_attributes.rb +3 -2
  114. data/app/models/alchemy/page/page_elements.rb +35 -44
  115. data/app/models/alchemy/page/page_naming.rb +20 -70
  116. data/app/models/alchemy/page/page_natures.rb +7 -34
  117. data/app/models/alchemy/page/page_scopes.rb +23 -29
  118. data/app/models/alchemy/page/url_path.rb +64 -0
  119. data/app/models/alchemy/picture.rb +40 -30
  120. data/app/models/alchemy/picture/preprocessor.rb +26 -0
  121. data/app/models/alchemy/picture/transformations.rb +9 -7
  122. data/app/models/alchemy/picture/url.rb +5 -5
  123. data/app/models/alchemy/site.rb +6 -36
  124. data/app/models/alchemy/site/layout.rb +2 -2
  125. data/app/models/concerns/alchemy/touch_elements.rb +24 -0
  126. data/app/serializers/alchemy/content_serializer.rb +0 -3
  127. data/app/serializers/alchemy/essence_boolean_serializer.rb +3 -3
  128. data/app/serializers/alchemy/essence_date_serializer.rb +3 -3
  129. data/app/serializers/alchemy/essence_file_serializer.rb +4 -2
  130. data/app/serializers/alchemy/essence_html_serializer.rb +3 -3
  131. data/app/serializers/alchemy/essence_link_serializer.rb +3 -3
  132. data/app/serializers/alchemy/essence_picture_serializer.rb +5 -4
  133. data/app/serializers/alchemy/essence_richtext_serializer.rb +3 -3
  134. data/app/serializers/alchemy/essence_select_serializer.rb +3 -3
  135. data/app/serializers/alchemy/essence_text_serializer.rb +5 -4
  136. data/app/serializers/alchemy/node_serializer.rb +2 -0
  137. data/app/serializers/alchemy/page_serializer.rb +2 -1
  138. data/app/serializers/alchemy/page_tree_serializer.rb +11 -14
  139. data/app/views/alchemy/admin/attachments/_archive_overlay.html.erb +1 -2
  140. data/app/views/alchemy/admin/attachments/_file_to_assign.html.erb +1 -2
  141. data/app/views/alchemy/admin/attachments/_files_list.html.erb +4 -4
  142. data/app/views/alchemy/admin/contents/create.js.erb +1 -3
  143. data/app/views/alchemy/admin/elements/_element.html.erb +9 -18
  144. data/app/views/alchemy/admin/elements/create.js.erb +1 -1
  145. data/app/views/alchemy/admin/elements/fold.js.erb +1 -1
  146. data/app/views/alchemy/admin/elements/index.html.erb +3 -3
  147. data/app/views/alchemy/admin/essence_files/assign.js.erb +1 -6
  148. data/app/views/alchemy/admin/essence_files/edit.html.erb +1 -1
  149. data/app/views/alchemy/admin/essence_pictures/assign.js.erb +1 -7
  150. data/app/views/alchemy/admin/essence_pictures/crop.html.erb +1 -1
  151. data/app/views/alchemy/admin/essence_pictures/edit.html.erb +7 -7
  152. data/app/views/alchemy/admin/essence_pictures/update.js.erb +1 -1
  153. data/app/views/alchemy/admin/languages/_form.html.erb +5 -5
  154. data/app/views/alchemy/admin/languages/_table.html.erb +3 -3
  155. data/app/views/alchemy/admin/languages/edit.html.erb +1 -0
  156. data/app/views/alchemy/admin/languages/index.html.erb +23 -4
  157. data/app/views/alchemy/admin/languages/new.html.erb +1 -0
  158. data/app/views/alchemy/admin/layoutpages/index.html.erb +6 -2
  159. data/app/views/alchemy/admin/nodes/_form.html.erb +20 -17
  160. data/app/views/alchemy/admin/nodes/_node.html.erb +1 -5
  161. data/app/views/alchemy/admin/nodes/index.html.erb +3 -4
  162. data/app/views/alchemy/admin/pages/_create_language_form.html.erb +0 -8
  163. data/app/views/alchemy/admin/pages/_form.html.erb +1 -2
  164. data/app/views/alchemy/admin/pages/_new_page_form.html.erb +1 -0
  165. data/app/views/alchemy/admin/pages/_page.html.erb +14 -25
  166. data/app/views/alchemy/admin/pages/_page_infos.html.erb +0 -4
  167. data/app/views/alchemy/admin/pages/_sitemap.html.erb +6 -0
  168. data/app/views/alchemy/admin/pages/edit.html.erb +1 -1
  169. data/app/views/alchemy/admin/pages/info.html.erb +0 -9
  170. data/app/views/alchemy/admin/pages/unlock.js.erb +13 -6
  171. data/app/views/alchemy/admin/partials/_remote_search_form.html.erb +0 -2
  172. data/app/views/alchemy/admin/pictures/_filter_and_size_bar.html.erb +1 -5
  173. data/app/views/alchemy/admin/pictures/_overlay_picture_list.html.erb +1 -1
  174. data/app/views/alchemy/admin/pictures/_picture_to_assign.html.erb +1 -2
  175. data/app/views/alchemy/admin/pictures/index.html.erb +18 -3
  176. data/app/views/alchemy/admin/resources/_resource.html.erb +1 -1
  177. data/app/views/alchemy/admin/resources/_table.html.erb +2 -2
  178. data/app/views/alchemy/admin/sites/_form.html.erb +8 -0
  179. data/app/views/alchemy/admin/sites/edit.html.erb +1 -0
  180. data/app/views/alchemy/admin/sites/index.html.erb +21 -9
  181. data/app/views/alchemy/admin/sites/new.html.erb +1 -0
  182. data/app/views/alchemy/admin/tags/index.html.erb +2 -2
  183. data/app/views/alchemy/essences/_essence_boolean_editor.html.erb +10 -12
  184. data/app/views/alchemy/essences/_essence_date_editor.html.erb +11 -8
  185. data/app/views/alchemy/essences/_essence_file_editor.html.erb +16 -17
  186. data/app/views/alchemy/essences/_essence_html_editor.html.erb +8 -5
  187. data/app/views/alchemy/essences/_essence_link_editor.html.erb +18 -15
  188. data/app/views/alchemy/essences/_essence_node_editor.html.erb +27 -0
  189. data/app/views/alchemy/essences/_essence_node_view.html.erb +1 -0
  190. data/app/views/alchemy/essences/_essence_page_editor.html.erb +14 -11
  191. data/app/views/alchemy/essences/_essence_picture_editor.html.erb +22 -20
  192. data/app/views/alchemy/essences/_essence_richtext_editor.html.erb +10 -7
  193. data/app/views/alchemy/essences/_essence_select_editor.html.erb +12 -16
  194. data/app/views/alchemy/essences/_essence_text_editor.html.erb +18 -17
  195. data/app/views/alchemy/essences/shared/_essence_picture_tools.html.erb +6 -11
  196. data/app/views/alchemy/pages/show.rss.builder +3 -2
  197. data/app/views/layouts/alchemy/admin.html.erb +1 -0
  198. data/babel.config.js +12 -0
  199. data/bin/rails +5 -4
  200. data/config/alchemy/config.yml +23 -22
  201. data/config/brakeman.ignore +1 -1
  202. data/config/initializers/assets.rb +2 -1
  203. data/config/initializers/dragonfly.rb +2 -1
  204. data/config/initializers/mime_types.rb +1 -0
  205. data/config/initializers/mini_profiler.rb +3 -2
  206. data/config/initializers/simple_form.rb +6 -6
  207. data/config/locales/alchemy.en.yml +29 -14
  208. data/config/routes.rb +25 -24
  209. data/config/spring.rb +3 -2
  210. data/db/migrate/20200226213334_alchemy_four_point_four.rb +313 -0
  211. data/db/migrate/20200423073425_create_alchemy_essence_nodes.rb +11 -0
  212. data/db/migrate/20200504210159_remove_site_id_from_nodes.rb +28 -0
  213. data/db/migrate/20200505215518_add_language_id_foreign_key_to_alchemy_pages.rb +8 -0
  214. data/db/migrate/20200511113603_add_menu_type_to_alchemy_nodes.rb +27 -0
  215. data/db/migrate/20200514091507_make_page_layoutpage_null_false.rb +6 -0
  216. data/db/migrate/20200519073500_remove_visible_from_alchemy_pages.rb +24 -0
  217. data/lib/alchemy/admin/locale.rb +3 -1
  218. data/lib/alchemy/admin/preview_url.rb +85 -0
  219. data/lib/alchemy/auth_accessors.rb +8 -7
  220. data/lib/alchemy/cache_digests/template_tracker.rb +5 -4
  221. data/lib/alchemy/config.rb +28 -2
  222. data/lib/alchemy/configuration_methods.rb +3 -1
  223. data/lib/alchemy/controller_actions.rb +6 -5
  224. data/lib/alchemy/deprecation.rb +2 -1
  225. data/lib/alchemy/elements_finder.rb +5 -5
  226. data/lib/alchemy/engine.rb +23 -8
  227. data/lib/alchemy/errors.rb +0 -7
  228. data/lib/alchemy/essence.rb +17 -16
  229. data/lib/alchemy/filetypes.rb +5 -5
  230. data/lib/alchemy/forms/builder.rb +4 -4
  231. data/lib/alchemy/hints.rb +1 -1
  232. data/lib/alchemy/i18n.rb +2 -1
  233. data/lib/alchemy/install/tasks.rb +41 -0
  234. data/lib/alchemy/modules.rb +12 -12
  235. data/lib/alchemy/name_conversions.rb +5 -5
  236. data/lib/alchemy/on_page_layout/callbacks_runner.rb +1 -0
  237. data/lib/alchemy/page_layout.rb +15 -12
  238. data/lib/alchemy/paths.rb +1 -1
  239. data/lib/alchemy/permissions.rb +7 -6
  240. data/lib/alchemy/resource.rb +23 -13
  241. data/lib/alchemy/resources_helper.rb +12 -18
  242. data/lib/alchemy/routing_constraints.rb +1 -1
  243. data/lib/alchemy/seeder.rb +42 -14
  244. data/lib/alchemy/shell.rb +13 -10
  245. data/lib/alchemy/taggable.rb +1 -0
  246. data/lib/alchemy/tasks/tidy.rb +4 -3
  247. data/lib/alchemy/test_support/config_stubbing.rb +1 -0
  248. data/lib/alchemy/test_support/essence_shared_examples.rb +72 -72
  249. data/lib/alchemy/test_support/factories.rb +1 -1
  250. data/lib/alchemy/test_support/factories/attachment_factory.rb +5 -5
  251. data/lib/alchemy/test_support/factories/content_factory.rb +6 -6
  252. data/lib/alchemy/test_support/factories/dummy_user_factory.rb +7 -7
  253. data/lib/alchemy/test_support/factories/element_factory.rb +9 -9
  254. data/lib/alchemy/test_support/factories/essence_file_factory.rb +3 -3
  255. data/lib/alchemy/test_support/factories/essence_page_factory.rb +3 -3
  256. data/lib/alchemy/test_support/factories/essence_picture_factory.rb +4 -4
  257. data/lib/alchemy/test_support/factories/essence_text_factory.rb +3 -3
  258. data/lib/alchemy/test_support/factories/language_factory.rb +21 -14
  259. data/lib/alchemy/test_support/factories/node_factory.rb +8 -8
  260. data/lib/alchemy/test_support/factories/page_factory.rb +15 -27
  261. data/lib/alchemy/test_support/factories/picture_factory.rb +5 -5
  262. data/lib/alchemy/test_support/factories/site_factory.rb +7 -6
  263. data/lib/alchemy/test_support/integration_helpers.rb +1 -0
  264. data/lib/alchemy/test_support/shared_contexts.rb +5 -4
  265. data/lib/alchemy/test_support/shared_uploader_examples.rb +4 -3
  266. data/lib/alchemy/tinymce.rb +15 -13
  267. data/lib/alchemy/upgrader.rb +8 -7
  268. data/lib/alchemy/upgrader/five_point_zero.rb +41 -0
  269. data/lib/alchemy/upgrader/tasks/element_views_updater.rb +4 -4
  270. data/lib/alchemy/upgrader/tasks/harden_gutentag_migrations.rb +29 -0
  271. data/lib/alchemy/version.rb +1 -1
  272. data/lib/alchemy_cms.rb +52 -50
  273. data/lib/{rails/generators → generators}/alchemy/base.rb +5 -4
  274. data/lib/{rails/generators → generators}/alchemy/elements/elements_generator.rb +13 -9
  275. data/lib/{rails/generators → generators}/alchemy/elements/templates/view.html.erb +0 -0
  276. data/lib/{rails/generators → generators}/alchemy/elements/templates/view.html.haml +0 -0
  277. data/lib/{rails/generators → generators}/alchemy/elements/templates/view.html.slim +0 -0
  278. data/lib/{rails/generators → generators}/alchemy/essence/essence_generator.rb +15 -13
  279. data/lib/generators/alchemy/essence/templates/editor.html.erb +17 -0
  280. data/lib/{rails/generators → generators}/alchemy/essence/templates/view.html.erb +0 -0
  281. data/lib/{rails/generators → generators}/alchemy/install/files/_article.html.erb +0 -0
  282. data/lib/{rails/generators → generators}/alchemy/install/files/_standard.html.erb +0 -0
  283. data/lib/{rails/generators → generators}/alchemy/install/files/alchemy.en.yml +0 -0
  284. data/lib/generators/alchemy/install/files/alchemy_admin.js +1 -0
  285. data/lib/{rails/generators → generators}/alchemy/install/files/all.css +0 -0
  286. data/lib/{rails/generators → generators}/alchemy/install/files/all.js +0 -0
  287. data/lib/{rails/generators → generators}/alchemy/install/files/application.html.erb +0 -0
  288. data/lib/{rails/generators → generators}/alchemy/install/files/article.scss +0 -0
  289. data/lib/generators/alchemy/install/install_generator.rb +169 -0
  290. data/lib/{rails/generators → generators}/alchemy/install/templates/dragonfly.rb.tt +0 -0
  291. data/lib/{rails/generators → generators}/alchemy/install/templates/elements.yml.tt +0 -0
  292. data/lib/{rails/generators → generators}/alchemy/install/templates/menus.yml.tt +0 -0
  293. data/lib/{rails/generators → generators}/alchemy/install/templates/page_layouts.yml.tt +0 -0
  294. data/lib/{rails/generators → generators}/alchemy/menus/menus_generator.rb +2 -2
  295. data/lib/{rails/generators → generators}/alchemy/menus/templates/node.html.erb +1 -4
  296. data/lib/{rails/generators → generators}/alchemy/menus/templates/node.html.haml +1 -4
  297. data/lib/{rails/generators → generators}/alchemy/menus/templates/node.html.slim +1 -4
  298. data/lib/{rails/generators → generators}/alchemy/menus/templates/wrapper.html.erb +1 -1
  299. data/lib/{rails/generators → generators}/alchemy/menus/templates/wrapper.html.haml +1 -1
  300. data/lib/{rails/generators → generators}/alchemy/menus/templates/wrapper.html.slim +1 -1
  301. data/lib/{rails/generators → generators}/alchemy/module/module_generator.rb +3 -2
  302. data/lib/{rails/generators → generators}/alchemy/module/templates/ability.rb.tt +0 -0
  303. data/lib/{rails/generators → generators}/alchemy/module/templates/controller.rb.tt +0 -0
  304. data/lib/{rails/generators → generators}/alchemy/module/templates/module_config.rb.tt +0 -0
  305. data/lib/{rails/generators → generators}/alchemy/page_layouts/page_layouts_generator.rb +5 -4
  306. data/lib/{rails/generators → generators}/alchemy/page_layouts/templates/layout.html.erb +0 -0
  307. data/lib/{rails/generators → generators}/alchemy/page_layouts/templates/layout.html.haml +0 -0
  308. data/lib/{rails/generators → generators}/alchemy/page_layouts/templates/layout.html.slim +0 -0
  309. data/lib/{rails/generators → generators}/alchemy/site_layouts/site_layouts_generator.rb +4 -2
  310. data/lib/{rails/generators → generators}/alchemy/site_layouts/templates/layout.html.erb +0 -0
  311. data/lib/{rails/generators → generators}/alchemy/site_layouts/templates/layout.html.haml +0 -0
  312. data/lib/{rails/generators → generators}/alchemy/site_layouts/templates/layout.html.slim +0 -0
  313. data/lib/{rails/generators → generators}/alchemy/views/views_generator.rb +7 -6
  314. data/lib/kaminari/scoped_pagination_url_helper.rb +1 -0
  315. data/lib/tasks/alchemy/db.rake +3 -19
  316. data/lib/tasks/alchemy/install.rake +5 -48
  317. data/lib/tasks/alchemy/tidy.rake +9 -8
  318. data/lib/tasks/alchemy/upgrade.rake +28 -105
  319. data/package.json +45 -0
  320. data/package/admin.js +14 -0
  321. data/package/src/__tests__/i18n.spec.js +70 -0
  322. data/package/src/i18n.js +48 -0
  323. data/package/src/node_tree.js +72 -0
  324. data/package/src/translations.js +32 -0
  325. data/package/src/utils/__tests__/ajax.spec.js +124 -0
  326. data/package/src/utils/__tests__/events.spec.js +38 -0
  327. data/package/src/utils/ajax.js +48 -0
  328. data/package/src/utils/events.js +16 -0
  329. data/vendor/assets/fonts/fa-regular-400.eot +0 -0
  330. data/vendor/assets/fonts/fa-regular-400.svg +798 -358
  331. data/vendor/assets/fonts/fa-regular-400.ttf +0 -0
  332. data/vendor/assets/fonts/fa-regular-400.woff +0 -0
  333. data/vendor/assets/fonts/fa-regular-400.woff2 +0 -0
  334. data/vendor/assets/fonts/fa-solid-900.eot +0 -0
  335. data/vendor/assets/fonts/fa-solid-900.svg +4933 -1408
  336. data/vendor/assets/fonts/fa-solid-900.ttf +0 -0
  337. data/vendor/assets/fonts/fa-solid-900.woff +0 -0
  338. data/vendor/assets/fonts/fa-solid-900.woff2 +0 -0
  339. data/vendor/assets/javascripts/jquery_plugins/jquery.ui.nestedSortable.js +1 -2
  340. data/vendor/assets/stylesheets/fontawesome/_core.scss +5 -0
  341. data/vendor/assets/stylesheets/fontawesome/_fixed-width.scss +1 -1
  342. data/vendor/assets/stylesheets/fontawesome/_icons.scss +651 -2
  343. data/vendor/assets/stylesheets/fontawesome/_mixins.scss +0 -1
  344. data/vendor/assets/stylesheets/fontawesome/_rotated-flipped.scss +3 -2
  345. data/vendor/assets/stylesheets/fontawesome/_stacked.scss +1 -1
  346. data/vendor/assets/stylesheets/fontawesome/_variables.scss +662 -9
  347. data/vendor/assets/stylesheets/fontawesome/fontawesome.scss +2 -2
  348. data/vendor/assets/stylesheets/fontawesome/regular.scss +23 -0
  349. data/vendor/assets/stylesheets/fontawesome/solid.scss +24 -0
  350. metadata +115 -87
  351. data/app/assets/javascripts/alchemy/alchemy.i18n.js.coffee +0 -32
  352. data/app/assets/javascripts/alchemy/alchemy.node_tree.js +0 -66
  353. data/app/assets/javascripts/alchemy/alchemy.translations.js.coffee +0 -29
  354. data/app/assets/javascripts/alchemy/alchemy.utils.js +0 -45
  355. data/app/helpers/alchemy/essences_helper.rb +0 -119
  356. data/app/models/concerns/alchemy/content_touching.rb +0 -23
  357. data/app/serializers/alchemy/legacy_element_serializer.rb +0 -15
  358. data/app/views/alchemy/admin/contents/_missing.html.erb +0 -17
  359. data/app/views/alchemy/admin/pages/_menu_fields.html.erb +0 -33
  360. data/app/views/alchemy/admin/pages/configure_external.html.erb +0 -32
  361. data/app/views/alchemy/elements/_editor_not_found.html.erb +0 -4
  362. data/app/views/alchemy/navigation/_image_link.html.erb +0 -14
  363. data/app/views/alchemy/navigation/_link.html.erb +0 -19
  364. data/app/views/alchemy/navigation/_renderer.html.erb +0 -29
  365. data/db/migrate/20180226123013_alchemy_four_point_zero.rb +0 -363
  366. data/db/migrate/20180227224537_migrate_tags_to_gutentag.rb +0 -41
  367. data/db/migrate/20180519204655_add_fixed_to_alchemy_elements.rb +0 -6
  368. data/db/migrate/20191016073858_create_alchemy_essence_pages.rb +0 -8
  369. data/db/migrate/20191029212236_create_alchemy_nodes.rb +0 -24
  370. data/db/migrate/20200226081535_add_site_id_to_alchemy_nodes.rb +0 -15
  371. data/lib/alchemy/ssl_protection.rb +0 -32
  372. data/lib/alchemy/tasks/helpers.rb +0 -81
  373. data/lib/alchemy/test_support/controller_requests.rb +0 -93
  374. data/lib/alchemy/upgrader/four_point_four.rb +0 -52
  375. data/lib/alchemy/upgrader/four_point_one.rb +0 -42
  376. data/lib/alchemy/upgrader/four_point_two.rb +0 -85
  377. data/lib/alchemy/upgrader/tasks/cells_migration.rb +0 -43
  378. data/lib/alchemy/upgrader/tasks/cells_upgrader.rb +0 -148
  379. data/lib/alchemy/upgrader/tasks/element_partial_name_variable_updater.rb +0 -28
  380. data/lib/alchemy/upgrader/tasks/harden_acts_as_taggable_on_migrations.rb +0 -27
  381. data/lib/alchemy/upgrader/tasks/picture_gallery_migration.rb +0 -65
  382. data/lib/alchemy/upgrader/tasks/picture_gallery_upgrader.rb +0 -210
  383. data/lib/rails/generators/alchemy/essence/templates/editor.html.erb +0 -15
  384. data/lib/rails/generators/alchemy/install/install_generator.rb +0 -60
  385. data/lib/tasks/alchemy/convert.rake +0 -95
  386. data/vendor/assets/javascripts/sortable/Sortable.min.js +0 -2
  387. data/vendor/assets/stylesheets/fontawesome/fa-regular.scss +0 -22
  388. data/vendor/assets/stylesheets/fontawesome/fa-solid.scss +0 -23
@@ -0,0 +1,29 @@
1
+ # frozen_string_literal: true
2
+
3
+ require "thor"
4
+
5
+ module Alchemy::Upgrader::Tasks
6
+ class HardenGutentagMigrations < Thor
7
+ include Thor::Actions
8
+
9
+ no_tasks do
10
+ def patch_migrations
11
+ sentinel = /def up/
12
+
13
+ migration_file = Dir.glob("db/migrate/*_gutentag_tables.gutentag.rb").first
14
+ if migration_file
15
+ inject_into_file migration_file,
16
+ "\n # inserted by Alchemy CMS upgrader\n return if table_exists?(:gutentag_taggings)\n",
17
+ { after: sentinel, verbose: true }
18
+ end
19
+
20
+ migration_file = Dir.glob("db/migrate/*_gutentag_cache_counter.gutentag.rb").first
21
+ if migration_file
22
+ inject_into_file migration_file,
23
+ "\n # inserted by Alchemy CMS upgrader\n return if column_exists?(:gutentag_tags, :taggings_count)\n",
24
+ { after: sentinel, verbose: true }
25
+ end
26
+ end
27
+ end
28
+ end
29
+ end
@@ -1,7 +1,7 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  module Alchemy
4
- VERSION = "4.5.0"
4
+ VERSION = "5.0.0.rc1"
5
5
 
6
6
  def self.version
7
7
  VERSION
@@ -1,61 +1,63 @@
1
+ # frozen_string_literal: true
1
2
  # Instantiate the global Alchemy namespace
2
3
  module Alchemy
3
- Alchemy::YAML_WHITELIST_CLASSES = %w(Symbol Date Regexp)
4
+ YAML_WHITELIST_CLASSES = %w(Symbol Date Regexp)
4
5
  end
5
6
 
6
7
  # Require globally used external libraries
7
- require 'acts_as_list'
8
- require 'action_view/dependency_tracker'
9
- require 'active_model_serializers'
10
- require 'awesome_nested_set'
11
- require 'cancan'
12
- require 'dragonfly'
13
- require 'gutentag'
14
- require 'handlebars_assets'
15
- require 'jquery-rails'
16
- require 'jquery-ui-rails'
17
- require 'kaminari'
18
- require 'non-stupid-digest-assets'
19
- require 'ransack'
20
- require 'request_store'
21
- require 'responders'
22
- require 'sassc-rails'
23
- require 'simple_form'
24
- require 'select2-rails'
25
- require 'turbolinks'
26
- require 'userstamp'
8
+ require "acts_as_list"
9
+ require "action_view/dependency_tracker"
10
+ require "active_model_serializers"
11
+ require "awesome_nested_set"
12
+ require "cancan"
13
+ require "dragonfly"
14
+ require "gutentag"
15
+ require "handlebars_assets"
16
+ require "jquery-rails"
17
+ require "jquery-ui-rails"
18
+ require "kaminari"
19
+ require "non-stupid-digest-assets"
20
+ require "ransack"
21
+ require "request_store"
22
+ require "responders"
23
+ require "sassc-rails"
24
+ require "simple_form"
25
+ require "select2-rails"
26
+ require "turbolinks"
27
+ require "userstamp"
28
+ require "webpacker"
27
29
 
28
30
  # Require globally used Alchemy mixins
29
- require_relative 'alchemy/ability_helper'
30
- require_relative 'alchemy/admin/locale'
31
- require_relative 'alchemy/auth_accessors'
32
- require_relative 'alchemy/cache_digests/template_tracker'
33
- require_relative 'alchemy/config'
34
- require_relative 'alchemy/configuration_methods'
35
- require_relative 'alchemy/controller_actions'
36
- require_relative 'alchemy/deprecation'
37
- require_relative 'alchemy/elements_finder'
38
- require_relative 'alchemy/errors'
39
- require_relative 'alchemy/essence'
40
- require_relative 'alchemy/filetypes'
41
- require_relative 'alchemy/forms/builder'
42
- require_relative 'alchemy/hints'
43
- require_relative 'alchemy/i18n'
44
- require_relative 'alchemy/logger'
45
- require_relative 'alchemy/modules'
46
- require_relative 'alchemy/name_conversions'
47
- require_relative 'alchemy/on_page_layout'
48
- require_relative 'alchemy/on_page_layout/callbacks_runner'
49
- require_relative 'alchemy/page_layout'
50
- require_relative 'alchemy/paths'
51
- require_relative 'alchemy/permissions'
52
- require_relative 'alchemy/ssl_protection'
53
- require_relative 'alchemy/resource'
54
- require_relative 'alchemy/tinymce'
55
- require_relative 'alchemy/taggable'
31
+ require_relative "alchemy/ability_helper"
32
+ require_relative "alchemy/admin/locale"
33
+ require_relative "alchemy/admin/preview_url"
34
+ require_relative "alchemy/auth_accessors"
35
+ require_relative "alchemy/cache_digests/template_tracker"
36
+ require_relative "alchemy/config"
37
+ require_relative "alchemy/configuration_methods"
38
+ require_relative "alchemy/controller_actions"
39
+ require_relative "alchemy/deprecation"
40
+ require_relative "alchemy/elements_finder"
41
+ require_relative "alchemy/errors"
42
+ require_relative "alchemy/essence"
43
+ require_relative "alchemy/filetypes"
44
+ require_relative "alchemy/forms/builder"
45
+ require_relative "alchemy/hints"
46
+ require_relative "alchemy/i18n"
47
+ require_relative "alchemy/logger"
48
+ require_relative "alchemy/modules"
49
+ require_relative "alchemy/name_conversions"
50
+ require_relative "alchemy/on_page_layout"
51
+ require_relative "alchemy/on_page_layout/callbacks_runner"
52
+ require_relative "alchemy/page_layout"
53
+ require_relative "alchemy/paths"
54
+ require_relative "alchemy/permissions"
55
+ require_relative "alchemy/resource"
56
+ require_relative "alchemy/tinymce"
57
+ require_relative "alchemy/taggable"
56
58
 
57
59
  # Require hacks
58
- require_relative 'kaminari/scoped_pagination_url_helper'
60
+ require_relative "kaminari/scoped_pagination_url_helper"
59
61
 
60
62
  # Finally require Alchemy itself
61
- require_relative 'alchemy/engine'
63
+ require_relative "alchemy/engine"
@@ -1,14 +1,15 @@
1
- require 'rails'
1
+ # frozen_string_literal: true
2
+ require "rails"
2
3
 
3
4
  module Alchemy
4
5
  module Generators
5
6
  class Base < ::Rails::Generators::Base
6
- class_option :template_engine, type: :string, aliases: '-e', desc: 'Template engine for the views. Available options are "erb", "haml", and "slim".'
7
+ class_option :template_engine, type: :string, aliases: "-e", desc: 'Template engine for the views. Available options are "erb", "haml", and "slim".'
7
8
 
8
9
  private
9
10
 
10
11
  def conditional_template(source, destination)
11
- files = Dir.glob(destination.gsub(/\.([a-z]+)$/, '*'))
12
+ files = Dir.glob(destination.gsub(/\.([a-z]+)$/, "*"))
12
13
  if files.any?
13
14
  ext = File.extname(files.first)[1..-1]
14
15
 
@@ -28,7 +29,7 @@ module Alchemy
28
29
  # Rails is clever enough to default this to whatever template
29
30
  # engine is configured through its generator configuration,
30
31
  # but we'll default it to erb anyway, just in case.
31
- options[:template_engine] || 'erb'
32
+ options[:template_engine] || "erb"
32
33
  end
33
34
 
34
35
  def load_alchemy_yaml(name)
@@ -1,24 +1,20 @@
1
- require_relative '../base'
1
+ # frozen_string_literal: true
2
+ require_relative "../base"
2
3
 
3
4
  module Alchemy
4
5
  module Generators
5
6
  class ElementsGenerator < Base
6
7
  desc "This generator generates your elements view partials."
7
- source_root File.expand_path('templates', __dir__)
8
+ source_root File.expand_path("templates", __dir__)
8
9
 
9
10
  def create_partials
10
- @elements = load_alchemy_yaml('elements.yml')
11
+ @elements = load_alchemy_yaml("elements.yml")
11
12
  return unless @elements
12
13
 
13
14
  @elements.each do |element|
14
15
  @element = element
15
16
  @contents = element["contents"] || []
16
- if element["name"] =~ /\A[a-z0-9_-]+\z/
17
- @element_name = element["name"].underscore
18
- else
19
- raise "Element name '#{element['name']}' has wrong format. Only lowercase and non whitespace characters allowed."
20
- end
21
-
17
+ @element_name = element_name(element)
22
18
  conditional_template "view.html.#{template_engine}", "#{elements_dir}/_#{@element_name}.html.#{template_engine}"
23
19
  end
24
20
  end
@@ -28,6 +24,14 @@ module Alchemy
28
24
  def elements_dir
29
25
  @_elements_dir ||= "app/views/alchemy/elements"
30
26
  end
27
+
28
+ def element_name(element)
29
+ if element["name"] =~ Alchemy::Element::NAME_REGEXP
30
+ element["name"].underscore
31
+ else
32
+ raise "Element name '#{element["name"]}' has wrong format. Only lowercase and non whitespace characters allowed."
33
+ end
34
+ end
31
35
  end
32
36
  end
33
37
  end
@@ -1,15 +1,16 @@
1
- require 'rails'
1
+ # frozen_string_literal: true
2
+ require "rails"
2
3
 
3
4
  module Alchemy
4
5
  module Generators
5
6
  class EssenceGenerator < ::Rails::Generators::Base
6
7
  desc "This generator generates an Alchemy essence for you."
7
8
  argument :essence_name, banner: "YourEssenceName"
8
- source_root File.expand_path('templates', __dir__)
9
+ source_root File.expand_path("templates", __dir__)
9
10
 
10
11
  def init
11
12
  @essence_name = essence_name.underscore
12
- @essence_view_path = 'app/views/alchemy/essences'
13
+ @essence_view_path = "app/views/alchemy/essences"
13
14
  end
14
15
 
15
16
  def create_model
@@ -19,20 +20,21 @@ module Alchemy
19
20
  def act_as_essence
20
21
  essence_class_file = "app/models/#{@essence_name}.rb"
21
22
  essence_class = @essence_name.classify
22
- inject_into_class essence_class_file, essence_class, <<-CLASSMETHOD
23
- acts_as_essence(
24
- # Your options:
25
- #
26
- # ingredient_column: [String or Symbol] - Specifies the column name you use for storing the content in the database. (Default :body)
27
- # validate_column: [String or Symbol] - Which column should be validated. (Default: ingredient_column)
28
- # preview_text_column: [String or Symbol] - Specifies the column for the preview_text method. (Default: ingredient_column)
29
- # preview_text_method: [String or Symbol] - A method called on ingredient to get the preview text. (Default: ingredient_column)
30
- )
31
- CLASSMETHOD
23
+ inject_into_class essence_class_file, essence_class, <<~CLASSMETHOD
24
+ acts_as_essence(
25
+ # Your options:
26
+ #
27
+ # ingredient_column: [String or Symbol] - Specifies the column name you use for storing the content in the database. (Default :body)
28
+ # validate_column: [String or Symbol] - Which column should be validated. (Default: ingredient_column)
29
+ # preview_text_column: [String or Symbol] - Specifies the column for the preview_text method. (Default: ingredient_column)
30
+ # preview_text_method: [String or Symbol] - A method called on ingredient to get the preview text. (Default: ingredient_column)
31
+ )
32
+ CLASSMETHOD
32
33
  end
33
34
 
34
35
  def copy_templates
35
36
  essence_name = @essence_name.classify.demodulize.underscore
37
+ @essence_editor_local = "#{essence_name}_editor"
36
38
  template "view.html.erb", "#{@essence_view_path}/_#{essence_name}_view.html.erb"
37
39
  template "editor.html.erb", "#{@essence_view_path}/_#{essence_name}_editor.html.erb"
38
40
  end
@@ -0,0 +1,17 @@
1
+ <%%#
2
+ Available locals:
3
+ * <%= @essence_editor_local %> - A Alchemy::ContentEditor instance
4
+
5
+ Please consult Alchemy::Content.rb docs for further methods on the content object
6
+ %>
7
+ <%%= content_tag :div,
8
+ id: <%= @essence_editor_local %>.dom_id,
9
+ class: <%= @essence_editor_local %>.css_classes,
10
+ data: <%= @essence_editor_local %>.data_attributes do %>
11
+ <%%= content_label(<%= @essence_editor_local %>) %>
12
+ <%%= text_field_tag(
13
+ <%= @essence_editor_local %>.form_field_name,
14
+ <%= @essence_editor_local %>.ingredient,
15
+ id: <%= @essence_editor_local %>.form_field_id
16
+ ) %>
17
+ <%% end %>
@@ -0,0 +1 @@
1
+ import "@alchemy_cms/admin"
@@ -0,0 +1,169 @@
1
+ # frozen_string_literal: true
2
+ require "rails/generators"
3
+ require "alchemy/install/tasks"
4
+
5
+ module Alchemy
6
+ module Generators
7
+ class InstallGenerator < ::Rails::Generators::Base
8
+ desc "Installs Alchemy into your App."
9
+
10
+ class_option :auto_accept,
11
+ type: :boolean,
12
+ default: false,
13
+ desc: "Automatically accept defaults."
14
+
15
+ class_option :skip_demo_files,
16
+ type: :boolean,
17
+ default: false,
18
+ desc: "Skip creation of demo element, page and application layout."
19
+
20
+ class_option :skip_webpacker_installer,
21
+ type: :boolean,
22
+ default: false,
23
+ desc: "Skip running the webpacker installer."
24
+
25
+ source_root File.expand_path("files", __dir__)
26
+
27
+ def setup
28
+ header
29
+ say "Welcome to AlchemyCMS!"
30
+ say "Let's begin with some questions.\n\n"
31
+ install_tasks.inject_routes(options[:auto_accept])
32
+ end
33
+
34
+ def copy_config
35
+ copy_file "#{gem_config_path}/config.yml", app_config_path.join("alchemy", "config.yml")
36
+ end
37
+
38
+ def copy_yml_files
39
+ %w(elements page_layouts menus).each do |file|
40
+ template "#{__dir__}/templates/#{file}.yml.tt", app_config_path.join("alchemy", "#{file}.yml")
41
+ end
42
+ end
43
+
44
+ def install_assets
45
+ copy_file "all.js", app_vendor_assets_path.join("javascripts", "alchemy", "admin", "all.js")
46
+ copy_file "all.css", app_vendor_assets_path.join("stylesheets", "alchemy", "admin", "all.css")
47
+ end
48
+
49
+ def copy_demo_views
50
+ return if options[:skip_demo_files]
51
+
52
+ copy_file "application.html.erb", app_views_path.join("layouts", "application.html.erb")
53
+ copy_file "article.scss", app_assets_path.join("stylesheets", "alchemy", "elements", "article.scss")
54
+
55
+ stylesheet_require = " *= require_tree ./alchemy/elements\n"
56
+ if File.exist?(app_assets_path.join("stylesheets", "application.css"))
57
+ insert_into_file app_assets_path.join("stylesheets", "application.css"), stylesheet_require,
58
+ before: " */"
59
+ else
60
+ create_file app_assets_path.join("stylesheets", "application.css"), "/*\n#{stylesheet_require} */\n"
61
+ end
62
+
63
+ copy_file "_article.html.erb", app_views_path.join("alchemy", "elements", "_article.html.erb")
64
+ copy_file "_standard.html.erb", app_views_path.join("alchemy", "page_layouts", "_standard.html.erb")
65
+ copy_file "alchemy.en.yml", app_config_path.join("locales", "alchemy.en.yml")
66
+ end
67
+
68
+ def copy_dragonfly_config
69
+ template(
70
+ "#{__dir__}/templates/dragonfly.rb.tt",
71
+ app_config_path.join("initializers", "dragonfly.rb"),
72
+ skip: options[:auto_accept]
73
+ )
74
+ end
75
+
76
+ def install_gutentag_migrations
77
+ rake "gutentag:install:migrations"
78
+ end
79
+
80
+ def run_webpacker_installer
81
+ unless options[:skip_webpacker_installer]
82
+ # Webpacker does not create a package.json, but we need one
83
+ unless File.exist? app_root.join("package.json")
84
+ in_root { run "echo '{}' > package.json" }
85
+ end
86
+ rake("webpacker:install", abort_on_failure: true)
87
+ end
88
+ end
89
+
90
+ def add_npm_package
91
+ run "yarn add @alchemy_cms/admin"
92
+ end
93
+
94
+ def copy_alchemy_entry_point
95
+ webpack_config = YAML.load_file(app_root.join("config", "webpacker.yml"))[Rails.env]
96
+ copy_file "alchemy_admin.js",
97
+ app_root.join(webpack_config["source_path"], webpack_config["source_entry_path"], "alchemy/admin.js")
98
+ end
99
+
100
+ def set_primary_language
101
+ header
102
+ install_tasks.set_primary_language(options[:auto_accept])
103
+ end
104
+
105
+ def setup_database
106
+ rake("db:create", abort_on_failure: true)
107
+ # We can't invoke this rake task, because Rails will use wrong engine names otherwise
108
+ rake("railties:install:migrations", abort_on_failure: true)
109
+ rake("db:migrate", abort_on_failure: true)
110
+ install_tasks.inject_seeder
111
+ rake("db:seed", abort_on_failure: true)
112
+ end
113
+
114
+ def finalize
115
+ header
116
+ say "Alchemy successfully installed!"
117
+ say "Now start the server with:\n\n"
118
+ say " bin/rails server\n\n"
119
+ say "and point your browser to\n\n"
120
+ say " http://localhost:3000/admin\n\n"
121
+ say "and follow the onscreen instructions to finalize the installation.\n\n"
122
+ end
123
+
124
+ private
125
+
126
+ def header
127
+ return if options[:auto_accept]
128
+
129
+ puts "─────────────────────"
130
+ puts "* Alchemy Installer *"
131
+ puts "─────────────────────"
132
+ end
133
+
134
+ def say(something)
135
+ return if options[:auto_accept]
136
+
137
+ puts " #{something}"
138
+ end
139
+
140
+ def gem_config_path
141
+ @_config_path ||= File.expand_path("../../../../config/alchemy", __dir__)
142
+ end
143
+
144
+ def app_config_path
145
+ @_app_config_path ||= app_root.join("config")
146
+ end
147
+
148
+ def app_views_path
149
+ @_app_views_path ||= app_root.join("app", "views")
150
+ end
151
+
152
+ def app_assets_path
153
+ @_app_assets_path ||= app_root.join("app", "assets")
154
+ end
155
+
156
+ def app_vendor_assets_path
157
+ @_app_vendor_assets_path ||= app_root.join("vendor", "assets")
158
+ end
159
+
160
+ def app_root
161
+ @_app_root ||= Rails.root
162
+ end
163
+
164
+ def install_tasks
165
+ @_install_tasks ||= Alchemy::Install::Tasks.new
166
+ end
167
+ end
168
+ end
169
+ end