alchemy_cms 4.4.4 → 5.0.0.beta2

data/app/models/alchemy/site/layout.rb

@@ -3,7 +3,7 @@
 module Alchemy
   module Site::Layout
     extend ActiveSupport::Concern
-    SITE_DEFINITIONS_FILE = Rails.root.join('config/alchemy/site_layouts.yml')
+    SITE_DEFINITIONS_FILE = Rails.root.join("config/alchemy/site_layouts.yml")
 
     module ClassMethods
       # Returns the site layouts definition defined in +site_layouts.yml+ file
@@ -28,7 +28,7 @@ module Alchemy
     # Returns site's layout definition
     #
     def definition
-      self.class.definitions.detect { |l| l['name'] == partial_name }
+      self.class.definitions.detect { |l| l["name"] == partial_name }
     end
 
     # Returns the name for the layout partial

data/app/models/concerns/alchemy/touch_elements.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module Alchemy
+  # If the model has a +elements+ association,
+  # it updates all their timestamps after save.
+  #
+  # Should only be used on bottom to top relations,
+  # e.g. +Alchemy::Picture+ or +Alchemy::Attachment+
+  # not on top to bottom ones like +Alchemy::Page+.
+  #
+  module TouchElements
+    def self.included(base)
+      base.after_save(:touch_elements)
+    end
+
+    private
+
+    def touch_elements
+      return unless respond_to?(:elements)
+
+      elements.map(&:touch)
+    end
+  end
+end

data/app/serializers/alchemy/content_serializer.rb

@@ -6,9 +6,6 @@ module Alchemy
       :name,
       :ingredient,
       :element_id,
-      :position,
-      :created_at,
-      :updated_at,
       :settings
 
     has_one :essence, polymorphic: true

data/app/serializers/alchemy/essence_boolean_serializer.rb

@@ -2,9 +2,9 @@
 
 module Alchemy
   class EssenceBooleanSerializer < ActiveModel::Serializer
-    attributes :id,
+    attributes(
+      :id,
       :value,
-      :created_at,
-      :updated_at
+    )
   end
 end

data/app/serializers/alchemy/essence_date_serializer.rb

@@ -2,9 +2,9 @@
 
 module Alchemy
   class EssenceDateSerializer < ActiveModel::Serializer
-    attributes :id,
+    attributes(
+      :id,
       :date,
-      :created_at,
-      :updated_at
+    )
   end
 end

data/app/serializers/alchemy/essence_file_serializer.rb

@@ -2,9 +2,11 @@
 
 module Alchemy
   class EssenceFileSerializer < ActiveModel::Serializer
-    attributes :id,
+    attributes(
+      :id,
       :title,
-      :css_class
+      :css_class,
+    )
 
     has_one :attachment
   end

data/app/serializers/alchemy/essence_html_serializer.rb

@@ -2,9 +2,9 @@
 
 module Alchemy
   class EssenceHtmlSerializer < ActiveModel::Serializer
-    attributes :id,
+    attributes(
+      :id,
       :source,
-      :created_at,
-      :updated_at
+    )
   end
 end

data/app/serializers/alchemy/essence_link_serializer.rb

@@ -2,12 +2,12 @@
 
 module Alchemy
   class EssenceLinkSerializer < ActiveModel::Serializer
-    attributes :id,
+    attributes(
+      :id,
       :link,
       :link_title,
       :link_target,
       :link_class_name,
-      :created_at,
-      :updated_at
+    )
   end
 end

data/app/serializers/alchemy/essence_picture_serializer.rb

@@ -2,25 +2,26 @@
 
 module Alchemy
   class EssencePictureSerializer < ActiveModel::Serializer
-    attributes :id,
+    attributes(
+      :id,
       :picture_id,
       :caption,
       :title,
       :alt_tag,
       :css_class,
       :link,
-      :created_at,
-      :updated_at
+    )
 
     has_one :picture
 
     def link
       return if object.link.blank?
+
       {
         url: object.link,
         css_class: object.link_class_name,
         title: object.link_title,
-        target: object.link_target
+        target: object.link_target,
       }
     end
   end

data/app/serializers/alchemy/essence_richtext_serializer.rb

@@ -2,10 +2,10 @@
 
 module Alchemy
   class EssenceRichtextSerializer < ActiveModel::Serializer
-    attributes :id,
+    attributes(
+      :id,
       :body,
       :stripped_body,
-      :created_at,
-      :updated_at
+    )
   end
 end

data/app/serializers/alchemy/essence_select_serializer.rb

@@ -2,9 +2,9 @@
 
 module Alchemy
   class EssenceSelectSerializer < ActiveModel::Serializer
-    attributes :id,
+    attributes(
+      :id,
       :value,
-      :created_at,
-      :updated_at
+    )
   end
 end

data/app/serializers/alchemy/essence_text_serializer.rb

@@ -2,19 +2,20 @@
 
 module Alchemy
   class EssenceTextSerializer < ActiveModel::Serializer
-    attributes :id,
+    attributes(
+      :id,
       :body,
       :link,
-      :created_at,
-      :updated_at
+    )
 
     def link
       return if object.link.blank?
+
       {
         url: object.link,
         title: object.link_title,
         css_class: object.link_class_name,
-        target: object.link_target
+        target: object.link_target,
       }
     end
   end

data/app/serializers/alchemy/node_serializer.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+module Alchemy
+  class NodeSerializer < ActiveModel::Serializer
+    attributes :id,
+      :name,
+      :lft,
+      :rgt,
+      :url,
+      :parent_id
+
+    has_many :ancestors, record_type: :node, serializer: self
+  end
+end

data/app/serializers/alchemy/page_serializer.rb

@@ -13,7 +13,8 @@ module Alchemy
       :tag_list,
       :created_at,
       :updated_at,
-      :status
+      :status,
+      :url_path
 
     has_many :elements
   end

data/app/serializers/alchemy/page_tree_serializer.rb

@@ -3,7 +3,7 @@
 module Alchemy
   class PageTreeSerializer < BaseSerializer
     def attributes
-      {'pages' => nil}
+      {"pages" => nil}
     end
 
     def pages
@@ -53,17 +53,15 @@ module Alchemy
         id: page.id,
         name: page.name,
         public: page.public?,
-        visible: page.visible?,
         restricted: page.restricted?,
         page_layout: page.page_layout,
         slug: page.slug,
-        redirects_to_external: page.definition['redirects_to_external'],
         urlname: page.urlname,
-        external_urlname: page.definition['redirects_to_external'] ? page.external_urlname : nil,
+        url_path: page.url_path,
         level: level,
-        root: level == 1,
-        root_or_leaf: level == 1 || !has_children,
-        children: []
+        root: page.depth == 1,
+        root_or_leaf: page.depth == 1 || !has_children,
+        children: [],
       }
 
       if opts[:elements]
@@ -75,9 +73,9 @@ module Alchemy
           definition_missing: page.definition.blank?,
           folded: folded,
           locked: page.locked?,
-          locked_notice: page.locked? ? Alchemy.t('This page is locked', name: page.locker_name) : nil,
+          locked_notice: page.locked? ? Alchemy.t("This page is locked", name: page.locker_name) : nil,
           permissions: page_permissions(page, opts[:ability]),
-          status_titles: page_status_titles(page)
+          status_titles: page_status_titles(page),
         })
       else
         p_hash
@@ -85,10 +83,10 @@ module Alchemy
     end
 
     def page_elements(page)
-      if opts[:elements] == 'true'
+      if opts[:elements] == "true"
         page.elements
       else
-        page.elements.named(opts[:elements].split(',') || [])
+        page.elements.named(opts[:elements].split(",") || [])
       end
     end
 
@@ -99,15 +97,14 @@ module Alchemy
         copy: ability.can?(:copy, page),
         destroy: ability.can?(:destroy, page),
         create: ability.can?(:create, Alchemy::Page),
-        edit_content: ability.can?(:edit_content, page)
+        edit_content: ability.can?(:edit_content, page),
       }
     end
 
     def page_status_titles(page)
       {
         public: page.status_title(:public),
-        visible: page.status_title(:visible),
-        restricted: page.status_title(:restricted)
+        restricted: page.status_title(:restricted),
       }
     end
   end

data/app/views/alchemy/admin/attachments/_archive_overlay.html.erb

@@ -7,8 +7,7 @@
       in_dialog: true,
       redirect_url: admin_attachments_path(
         element_id: @element.try(:id),
-        content_id: @content.try(:id),
-        options: options_from_params
+        content_id: @content.try(:id)
       ) %>
   <% end %>
   <%= render 'alchemy/admin/partials/remote_search_form' %>

data/app/views/alchemy/admin/attachments/_file_to_assign.html.erb

@@ -1,8 +1,7 @@
 <li class="assign_file_file <%= cycle('even', 'odd') %>">
   <%= link_to alchemy.assign_admin_essence_files_path(
       attachment_id: file_to_assign.id,
-      content_id: @content.id,
-      options: options_from_params
+      content_id: @content.id
     ),
     remote: true,
     method: 'put' do %>

data/app/views/alchemy/admin/attachments/_files_list.html.erb

@@ -11,11 +11,11 @@
     <thead>
       <tr>
         <th class="icon"></th>
-        <th class="name"><%= sort_link(@query, :name, hide_indicator: true) %></th>
-        <th class="file_name"><%= sort_link(@query, :file_name, hide_indicator: true) %></th>
+        <th class="name"><%= sort_link(@query, :name) %></th>
+        <th class="file_name"><%= sort_link(@query, :file_name) %></th>
         <th class="file_type"><%= Alchemy::Attachment.human_attribute_name('file_mime_type') %></th>
-        <th class="file_size"><%= sort_link(@query, :file_size, hide_indicator: true) %></th>
-        <th class="date"><%= sort_link(@query, :created_at, hide_indicator: true) %></th>
+        <th class="file_size"><%= sort_link(@query, :file_size) %></th>
+        <th class="date"><%= sort_link(@query, :created_at, default_order: 'desc') %></th>
         <th class="tools"></th>
       </tr>
     </thead>

data/app/views/alchemy/admin/contents/create.js.erb

@@ -1,6 +1,4 @@
-var editor_html = '<%= j(render "alchemy/essences/#{@content.essence_partial_name}_editor", {
-  content: @content, options: options_from_params, html_options: @html_options
-}) %>';
+var editor_html = '<%= j render(Alchemy::ContentEditor.new(@content)) %>';
 
 $("[data-element-<%= @content.element_id %>-missing-content=\"<%= @content.name %>\"]").replaceWith(editor_html);
 

data/app/views/alchemy/admin/elements/_element.html.erb

@@ -1,7 +1,7 @@
 <%= content_tag :div,
   id: "element_#{element.id}",
   data: {'element-id' => element.id, 'element-name' => element.name},
-  class: element_editor_classes(element) do %>
+  class: element.css_classes do %>
 
   <% unless element.fixed? %>
     <%= render 'alchemy/admin/elements/element_header', element: element %>
@@ -18,24 +18,14 @@
       <%= render_message(:warning, sanitize(warning)) if warning %>
     <% end %>
 
-    <% if element_editable?(element) %>
+    <% if element.editable? %>
       <%= form_for [alchemy, :admin, element], remote: true,
         html: {id: "element_#{element.id}_form".html_safe, class: 'element-content'} do |f| %>
 
         <div id="element_<%= element.id %>_errors" class="element_errors"></div>
 
         <div id="element_<%= element.id %>_content" class="element-content-editors">
-          <% if lookup_context.exists?("#{element.name}_editor", ["alchemy/elements"], true) %>
-            <%= render_editor(element) %>
-          <% else %>
-            <%= element_editor_for(element) do %>
-              <% element.contents.each do |content| %>
-                <%= render "alchemy/essences/#{content.essence_partial_name}_editor", {
-                  content: content
-                } %>
-              <% end %>
-            <% end %>
-          <% end %>
+          <%= render element.contents.map { |content| Alchemy::ContentEditor.new(content) } %>
         </div>
 
         <% if element.taggable? %>
@@ -53,11 +43,12 @@
   <% if element.nestable_elements.any? %>
     <div class="nestable-elements">
       <%= content_tag :div,
-            class: "nested-elements", data: {
-              'droppable-elements' => element.nestable_elements.join(' ')
-            } do %>
-        <%= render partial: 'alchemy/admin/elements/element',
-           collection: element.all_nested_elements %>
+        class: "nested-elements", data: {
+          'droppable-elements' => element.nestable_elements.join(' ')
+        } do %>
+        <%= render element.all_nested_elements.map { |element|
+          Alchemy::ElementEditor.new(element)
+        } %>
       <% end %>
 
       <% if element.expanded? || element.fixed? %>

data/app/views/alchemy/admin/elements/create.js.erb

@@ -1,7 +1,7 @@
 (function() {
   var $el;
   var $element_area;
-  var element_html = '<%= j render("element", element: @element, draggable: true) %>';
+  var element_html = '<%= j render(Alchemy::ElementEditor.new(@element)) %>';
 
 <%- if @cut_element_id -%>
   $('.element-editor[data-element-id="<%= @cut_element_id %>"]').remove();

data/app/views/alchemy/admin/elements/fold.js.erb

@@ -8,7 +8,7 @@
 
 <% else -%>
 
-  $el.replaceWith('<%= j render(partial: "element", object: @element) %>');
+  $el.replaceWith('<%= j render(Alchemy::ElementEditor.new(@element)) %>');
   $el = $('#element_<%= @element.id %>');
   $('#element_area .sortable-elements').sortable('refresh');
 

data/app/views/alchemy/admin/elements/index.html.erb

@@ -15,19 +15,19 @@
       <% end %>
     </ul>
     <div id="main-content-elements" class="sortable-elements" data-droppable-elements="<%= @page.element_definition_names.join(' ') %>">
-      <%= render partial: 'alchemy/admin/elements/element', collection: @elements %>
+      <%= render @elements.map { |element| Alchemy::ElementEditor.new(element) } %>
     </div>
     <% @fixed_elements.each do |element| %>
       <div
         id="fixed-element-<%= element.id %>"
         class="sortable-elements"
         data-droppable-elements="<%= element.nestable_elements.join(' ') %>">
-        <%= render 'alchemy/admin/elements/element', element: element %>
+        <%= render Alchemy::ElementEditor.new(element) %>
       </div>
     <% end %>
   </div>
 <% else %>
   <div id="main-content-elements" class="sortable-elements" data-droppable-elements="<%= @page.element_definition_names.join(' ') %>">
-    <%= render partial: 'alchemy/admin/elements/element', collection: @elements %>
+    <%= render @elements.map { |element| Alchemy::ElementEditor.new(element) } %>
   </div>
 <% end %>