alchemy_cms 3.6.1 → 3.6.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a8743fb03c7e20c7e5843e13f70a7a15b0b6d3c0
-  data.tar.gz: 5edc6d41f2f0931328f8d1f62d9391f1f0096a33
+  metadata.gz: 2d08ddeba7c6d9ee72222fdbd1076a7e15bf0cd7
+  data.tar.gz: f1b8bf8976c1072862a962bbff039a9700aeea3e
 SHA512:
-  metadata.gz: c9edf891ac572e4114b897991df000622ba4703119bc01b9752859ffb8c4ef31130c9c84930605b5bbc8eacc4fdc60d0fd2d155233a3036e081a9a013744db10
-  data.tar.gz: a850e8c5eee3b9f8def3d21201477eaef9217b54937fa3717e8750310c86fe99aade5ed7f72ce9998a08af7c2b1b4b4666d620387bb579a27744859b58a19aa7
+  metadata.gz: 20578df18e78b1f0d54bcaff824f6679b3f929d347d1c2316f85d5cbb956789c15804325cf3fdd7e3993bb9cb2ad8915ec95df157360ce6f4a675778afde1c51
+  data.tar.gz: 656afe41082692275283b7fb664490637f4a536c024bda2c0272525b032a0434c72808e954f6769e1e34cefe7cac9a3c6bcf603f53266aa6a73f55ed33a913e6

data/.travis.yml

@@ -1,13 +1,15 @@
 language: ruby
 sudo: false
+services:
+  - mysql
+  - postgresql
 cache:
   bundler: true
   directories:
     - "travis_phantomjs"
 rvm:
-- 2.1
-- 2.2
-- 2.3.0
+- 2.3
+- 2.4
 branches:
   only:
     - 3.6-stable
@@ -20,7 +22,7 @@ before_install:
   - "if [ $(phantomjs --version) != '2.1.1' ]; then wget https://assets.membergetmember.co/software/phantomjs-2.1.1-linux-x86_64.tar.bz2 -O $PWD/travis_phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2; fi"
   - "if [ $(phantomjs --version) != '2.1.1' ]; then tar -xvf $PWD/travis_phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2 -C $PWD/travis_phantomjs; fi"
   - "phantomjs --version"
-  - gem install bundler
+  - gem install bundler -v "< 2"
 before_script: bundle exec rake alchemy:spec:prepare
 script: bundle exec rspec
 after_success: bundle exec codeclimate-test-reporter

data/CHANGELOG.md

@@ -1,5 +1,27 @@
 # Change Log
 
+## 3.6.6 (2020-10-08)
+
+- Allow AwesomeNestedSet >= 3.0 [#1619](https://github.com/AlchemyCMS/alchemy_cms/pull/1619) by [tvdeyen](https://github.com/tvdeyen)
+
+## 3.6.5 (2018-05-08)
+
+- Fix for drag'n'drop trashed elements into pages with cells [#1430](https://github.com/AlchemyCMS/alchemy_cms/pull/1430) by [tvdeyen](https://github.com/tvdeyen)
+
+## 3.6.4 (2018-04-23)
+
+- Allows `Symbol`, `Regexp` and `Date` in all YAML config files [#1333](https://github.com/AlchemyCMS/alchemy_cms/pull/1333) by [robinboening](https://github.com/robinboening)
+
+## 3.6.3 (2017-10-24)
+
+* Remove `:display` cancan alias [#1318](https://github.com/AlchemyCMS/alchemy_cms/pull/1318) by [tvdeyen](https://github.com/tvdeyen)
+
+## 3.6.2 (2017-09-01)
+
+* Handle custom errors in `Alchemy::Picture#url` [#1305](https://github.com/AlchemyCMS/alchemy_cms/pull/1305) by [tvdeyen](https://github.com/tvdeyen)
+* Do not move elements in tidy cells task [#1303](https://github.com/AlchemyCMS/alchemy_cms/pull/1303) by [tvdeyen](https://github.com/tvdeyen)
+* Add a store image file format rake task [#1302](https://github.com/AlchemyCMS/alchemy_cms/pull/1302) by [tvdeyen](https://github.com/tvdeyen)
+
 ## 3.6.1 (2017-08-16)
 
 * Do not ask `systempage?` everytime we load the page definition [#1239](https://github.com/AlchemyCMS/alchemy_cms/pull/1283) by [tvdeyen](https://github.com/tvdeyen)

data/Gemfile

@@ -5,15 +5,16 @@ gemspec
 # Profiling
 gem 'rack-mini-profiler', group: :development, require: false
 
-gem 'sqlite3' if ENV['DB'].nil? || ENV['DB'] == 'sqlite'
+gem 'sqlite3', '~> 1.3.6' if ENV['DB'].nil? || ENV['DB'] == 'sqlite'
 gem 'mysql2', '~> 0.3.18' if ENV['DB'] == 'mysql'
-gem 'pg'      if ENV['DB'] == 'postgresql'
+gem 'pg',     '~> 0.21'   if ENV['DB'] == 'postgresql'
 gem 'sassc-rails'
 
 group :development, :test do
   gem 'jasmine-rails',        github: 'searls/jasmine-rails'
   gem 'jasmine-jquery-rails', github: 'travisjeffery/jasmine-jquery-rails'
   gem 'simplecov', require: false
+  gem 'sassc', '~> 2.1.0'
   if ENV['TRAVIS']
     gem 'codeclimate-test-reporter', '~> 1.0', require: false
   end
@@ -41,9 +42,3 @@ end
 group :development, :production do
   gem 'quiet_assets'
 end
-
-# We need this if we want to start the dummy app in production, ie on Teatro.io
-group :production do
-  gem 'uglifier', '>= 1.0.3'
-  gem 'therubyracer'
-end

data/alchemy_cms.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency 'active_model_serializers',         ['~> 0.9.0']
   gem.add_runtime_dependency 'acts_as_list',                     ['~> 0.3']
   gem.add_runtime_dependency 'acts-as-taggable-on',              ['~> 4.0']
-  gem.add_runtime_dependency 'awesome_nested_set',               ['~> 3.1']
+  gem.add_runtime_dependency 'awesome_nested_set',               ['~> 3.0']
   gem.add_runtime_dependency 'bourbon',                          ['~> 4.2']
   gem.add_runtime_dependency 'cancancan',                        ['~> 1.9']
   gem.add_runtime_dependency 'coffee-rails',                     ['~> 4.0']

data/app/controllers/alchemy/admin/elements_controller.rb

@@ -145,7 +145,10 @@ module Alchemy
 
       def paste_element_from_clipboard
         @source_element = Element.find(element_from_clipboard['id'])
-        new_attributes = {page_id: @page.id}
+        new_attributes = {
+          parent_element_id: params[:element][:parent_element_id],
+          page_id: @page.id
+        }
         if @page.can_have_cells?
           new_attributes = new_attributes.merge({cell_id: find_or_create_cell.try(:id)})
         end

data/app/models/alchemy/cell.rb

@@ -56,7 +56,7 @@ module Alchemy
       private
 
       def read_yml_file
-        ::YAML.safe_load(ERB.new(File.read(yml_file_path)).result, [], [], true) || []
+        ::YAML.safe_load(ERB.new(File.read(yml_file_path)).result, YAML_WHITELIST_CLASSES, [], true) || []
       end
 
       def yml_file_path

data/app/models/alchemy/element/definitions.rb

@@ -26,7 +26,7 @@ module Alchemy
       #
       def read_definitions_file
         if ::File.exist?(definitions_file_path)
-          ::YAML.safe_load(ERB.new(File.read(definitions_file_path)).result, [Regexp, Date], [], true) || []
+          ::YAML.safe_load(ERB.new(File.read(definitions_file_path)).result, YAML_WHITELIST_CLASSES, [], true) || []
         else
           raise LoadError, "Could not find elements.yml file! Please run `rails generate alchemy:scaffold`"
         end

data/app/models/alchemy/picture/url.rb

@@ -1,5 +1,7 @@
 module Alchemy
   module Picture::Url
+    include Alchemy::Logger
+
     TRANSFORMATION_OPTIONS = [
       :crop,
       :crop_from,
@@ -28,6 +30,9 @@ module Alchemy
       image = encoded_image(image, options)
 
       image.url(options.except(*TRANSFORMATION_OPTIONS).merge(name: name))
+    rescue MissingImageFileError, WrongImageFormatError => e
+      log_warning e.message
+      nil
     end
 
     private
@@ -53,7 +58,10 @@ module Alchemy
     #
     def encoded_image(image, options = {})
       target_format = options[:format] || default_render_format
-      raise WrongImageFormatError if !target_format.in?(Alchemy::Picture.allowed_filetypes)
+
+      unless target_format.in?(Alchemy::Picture.allowed_filetypes)
+        raise WrongImageFormatError.new(self, target_format)
+      end
 
       options = {
         flatten: target_format != 'gif' && image_file_format == 'gif'

data/app/models/alchemy/site.rb

@@ -24,7 +24,7 @@ module Alchemy
     scope :published, -> { where(public: true) }
 
     # Callbacks
-    before_create :create_default_language!, unless: -> { languages.any? }
+    before_create :create_default_language!
 
     # concerns
     include Alchemy::Site::Layout

data/app/views/alchemy/admin/elements/index.html.erb

@@ -10,7 +10,9 @@
         </li>
       <% end %>
     </ul>
-    <div id="cell_for_other_elements" class="sortable_cell for_other_elements_cell">
+    <div id="cell_for_other_elements"
+      class="sortable_cell for_other_elements_cell"
+      data-droppable-elements="<%= @page.element_names_from_definition.join(' ') %>">
       <%= render partial: 'alchemy/admin/elements/element',
         collection: @page.elements.not_trashed.not_in_cell %>
     </div>
@@ -18,7 +20,7 @@
       <%= content_tag :div,
         id: "cell_#{cell.name}",
         class: ["sortable_cell", "#{cell.name}_cell"].join(' '),
-        data: {'cell-id' => cell.id, 'data-droppable-elements' => cell.element_definitions.join(' ')} do %>
+        data: {'cell-id' => cell.id, 'droppable-elements' => cell.element_definitions.join(' ')} do %>
         <%= render partial: 'alchemy/admin/elements/element', collection: elements %>
       <% end %>
     <% end %>

data/app/views/alchemy/admin/elements/new.html.erb

@@ -11,7 +11,8 @@
   </div>
   <div id="paste_element_tab">
     <%= alchemy_form_for([:admin, @element]) do |f| %>
-      <%= f.hidden_field(:page_id) %>
+      <%= f.hidden_field :page_id %>
+      <%= f.hidden_field :parent_element_id, value: @parent_element.try(:id) %>
       <div class="input select">
         <label for="paste_from_clipboard" class="control-label"><%= Alchemy.t("Element") %></label>
         <%= select_tag 'paste_from_clipboard',

data/db/migrate/20160422195310_add_image_file_format_to_alchemy_pictures.rb

@@ -1,18 +1,6 @@
 class AddImageFileFormatToAlchemyPictures < ActiveRecord::Migration
   def up
     add_column :alchemy_pictures, :image_file_format, :string
-
-    say_with_time "Storing file format of existing pictures" do
-      Alchemy::Picture.all.each do |pic|
-        begin
-          format = pic.image_file.identify('-ping -format "%m"')
-          pic.update_column('image_file_format', format.to_s.chomp.downcase)
-        rescue Dragonfly::Job::Fetch::NotFound => e
-          say(e.message, true)
-        end
-      end
-      Alchemy::Picture.count
-    end
   end
 
   def down

data/lib/alchemy/config.rb

@@ -46,7 +46,8 @@ module Alchemy
       # If it does not exist, or its empty, it returns an empty Hash.
       #
       def read_file(file)
-        return YAML.load_file(file) || {} if File.exist?(file) # YAML.load_file returns false if file is empty.
+        YAML.safe_load(ERB.new(File.read(file)).result, YAML_WHITELIST_CLASSES, [], true) || {}
+      rescue Errno::ENOENT
         {}
       end
 

data/lib/alchemy/errors.rb

@@ -55,9 +55,14 @@ module Alchemy
 
   # Raised if calling +image_file+ on a Picture object returns nil.
   class WrongImageFormatError < StandardError
+    def initialize(image, requested_format)
+      @image = image
+      @requested_format = requested_format
+    end
+
     def message
       allowed_filetypes = Alchemy::Picture.allowed_filetypes.map(&:upcase).to_sentence
-      "Requested image format is not one of allowed filetypes (#{allowed_filetypes})."
+      "Requested image format (#{@requested_format.inspect}) for #{@image.inspect} is not one of allowed filetypes (#{allowed_filetypes})."
     end
   end
 

data/lib/alchemy/logger.rb

@@ -7,7 +7,7 @@ module Alchemy
     end
 
     def log_warning(message)
-      Alchemy::Logger.warn(message, caller(0..0))
+      Alchemy::Logger.warn(message, caller(1..1))
     end
   end
 end

data/lib/alchemy/page_layout.rb

@@ -157,7 +157,7 @@ module Alchemy
       #
       def read_definitions_file
         if File.exist?(layouts_file_path)
-          YAML.safe_load(ERB.new(File.read(layouts_file_path)).result, [Date], [], true) || []
+          YAML.safe_load(ERB.new(File.read(layouts_file_path)).result, YAML_WHITELIST_CLASSES, [], true) || []
         else
           raise LoadError, "Could not find page_layouts.yml file! Please run `rails generate alchemy:scaffold`"
         end

data/lib/alchemy/permissions.rb

@@ -35,7 +35,6 @@ module Alchemy
       def alchemy_guest_user_rules
         can([:show, :download], Alchemy::Attachment) { |a| !a.restricted? }
         can :see,               Alchemy::Page,       restricted: false, visible: true
-        can(:display,           Alchemy::Picture)    { |p| !p.restricted? }
 
         can :read, Alchemy::Content, Alchemy::Content.available.not_restricted do |c|
           c.public? && !c.restricted? && !c.trashed?
@@ -65,7 +64,6 @@ module Alchemy
         can [:show, :download], Alchemy::Attachment
         can :read,              Alchemy::Page,      Alchemy::Page.published, &:public?
         can :see,               Alchemy::Page,      restricted: true, visible: true
-        can :display,           Alchemy::Picture
 
         can :read, Alchemy::Content, Alchemy::Content.available do |c|
           c.public? && !c.trashed?
@@ -215,11 +213,6 @@ module Alchemy
         :unlock,
         :visit,
         to: :edit_content
-
-      alias_action :show,
-        :thumbnail,
-        :zoom,
-        to: :display
     end
 
     # Include the role specific permissions.

data/lib/alchemy/tasks/tidy.rb

@@ -0,0 +1,130 @@
+require 'alchemy/shell'
+
+module Alchemy
+  class Tidy
+    extend Shell
+
+    class << self
+      def create_missing_cells(page_layouts, cells)
+        page_layouts.each do |layout|
+          next if layout['cells'].blank?
+          cells_for_layout = cells.select { |cell| layout['cells'].include? cell['name'] }
+          Alchemy::Page.where(page_layout: layout['name']).each do |page|
+            cells_for_layout.each do |cell_for_layout|
+              cell = Alchemy::Cell.find_or_initialize_by(name: cell_for_layout['name'], page_id: page.id)
+              if cell.new_record?
+                log "Creating cell #{cell.name} for page #{page.name}"
+              else
+                log "Cell #{cell.name} for page #{page.name} already present", :skip
+              end
+            end
+          end
+        end
+      end
+
+      def update_element_positions
+        Alchemy::Page.all.each do |page|
+          if page.elements.any?
+            puts "\n## Updating element positions of page `#{page.name}`"
+          end
+          page.elements.group_by(&:cell_id).each do |_cell_id, elements|
+            elements.each_with_index do |element, idx|
+              position = idx + 1
+              if element.position != position
+                log "Updating position for element ##{element.id} to #{position}"
+                element.update_column(:position, position)
+              else
+                log "Position for element ##{element.id} is already correct (#{position})", :skip
+              end
+            end
+          end
+        end
+      end
+
+      def update_content_positions
+        Alchemy::Element.all.each do |element|
+          if element.contents.any?
+            puts "\n## Updating content positions of element `#{element.name}`"
+          end
+          element.contents.group_by(&:essence_type).each do |essence_type, contents|
+            puts "-> Contents of type `#{essence_type}`"
+            contents.each_with_index do |content, idx|
+              position = idx + 1
+              if content.position != position
+                log "Updating position for content ##{content.id} to #{position}"
+                content.update_column(:position, position)
+              else
+                log "Position for content ##{content.id} is already correct (#{position})", :skip
+              end
+            end
+          end
+        end
+      end
+
+      def remove_orphaned_cells
+        puts "\n## Removing orphaned cells"
+        cells = Alchemy::Cell.unscoped.all
+        if cells.any?
+          orphaned_cells = cells.select do |cell|
+            cell.page.nil? && cell.page_id.present?
+          end
+          if orphaned_cells.any?
+            log "Found #{orphaned_cells.size} orphaned cells"
+            destroy_orphaned_records(orphaned_cells, 'cell')
+          else
+            log "No orphaned cells found", :skip
+          end
+        else
+          log "No cells found", :skip
+        end
+      end
+
+      def remove_orphaned_elements
+        puts "\n## Removing orphaned elements"
+        elements = Alchemy::Element.unscoped.all
+        if elements.any?
+          orphaned_elements = elements.select do |element|
+            element.page.nil? && element.page_id.present? ||
+              element.cell.nil? && element.cell_id.present?
+          end
+          if orphaned_elements.any?
+            log "Found #{orphaned_elements.size} orphaned elements"
+            destroy_orphaned_records(orphaned_elements, 'element')
+          else
+            log "No orphaned elements found", :skip
+          end
+        else
+          log "No elements found", :skip
+        end
+      end
+
+      def remove_orphaned_contents
+        puts "\n## Removing orphaned contents"
+        contents = Alchemy::Content.unscoped.all
+        if contents.any?
+          orphaned_contents = contents.select do |content|
+            content.essence.nil? && content.essence_id.present? ||
+              content.element.nil? && content.element_id.present?
+          end
+          if orphaned_contents.any?
+            log "Found #{orphaned_contents.size} orphaned contents"
+            destroy_orphaned_records(orphaned_contents, 'content')
+          else
+            log "No orphaned contents found", :skip
+          end
+        else
+          log "No contents found", :skip
+        end
+      end
+
+      private
+
+      def destroy_orphaned_records(records, class_name)
+        records.each do |record|
+          log "Destroy orphaned #{class_name}: #{record.inspect}"
+          record.destroy
+        end
+      end
+    end
+  end
+end

data/lib/alchemy/upgrader/three_point_four.rb

@@ -6,5 +6,30 @@ module Alchemy
       desc 'Install asset manifests into `vendor/assets`'
       Alchemy::Upgrader::Tasks::InstallAssetManifests.new.install
     end
+
+    def self.store_image_file_format
+      desc 'Store image file format'
+      pictures = Alchemy::Picture.where(image_file_format: nil)
+      count = pictures.size
+      converted_pics = 0
+      errored_pics = 0
+      puts "-- Storing file format of #{count} pictures"
+      pictures.find_each(batch_size: 100).with_index do |pic, i|
+        begin
+          puts "   -> Reading file format of #{pic.image_file_name} (#{i + 1}/#{count})"
+          format = pic.image_file.identify('-ping -format "%m"')
+          pic.update_column('image_file_format', format.to_s.chomp.downcase)
+          converted_pics += 1
+        rescue Dragonfly::Job::Fetch::NotFound => e
+          puts "   -> #{e.message}"
+          errored_pics += 1
+        end
+      end
+      puts "-- Done! Converted #{converted_pics} images."
+      unless errored_pics.zero?
+        puts "   !! But #{errored_pics} images caused errors."
+        puts "      Please check errors above and re-run `rake alchemy:upgrade:3.4:store_image_file_format`"
+      end
+    end
   end
 end

data/lib/alchemy/version.rb

@@ -1,5 +1,5 @@
 module Alchemy
-  VERSION = "3.6.1"
+  VERSION = "3.6.6"
 
   def self.version
     VERSION

data/lib/alchemy_cms.rb

@@ -1,5 +1,6 @@
 # Instantiate the global Alchemy namespace
 module Alchemy
+  Alchemy::YAML_WHITELIST_CLASSES = %w(Symbol Date Regexp)
 end
 
 # Require globally used external libraries

data/lib/rails/generators/alchemy/base.rb

@@ -32,7 +32,7 @@ module Alchemy
       end
 
       def load_alchemy_yaml(name)
-        YAML.safe_load(ERB.new(File.read("#{Rails.root}/config/alchemy/#{name}")).result, [Regexp], [], true)
+        YAML.safe_load(ERB.new(File.read("#{Rails.root}/config/alchemy/#{name}")).result, YAML_WHITELIST_CLASSES, [], true)
       rescue Errno::ENOENT
         puts "\nERROR: Could not read config/alchemy/#{name} file. Please run: rails generate alchemy:scaffold"
       end

data/lib/tasks/alchemy/tidy.rake

@@ -1,4 +1,4 @@
-require 'alchemy/shell'
+require 'alchemy/tasks/tidy'
 
 namespace :alchemy do
   namespace :tidy do
@@ -58,131 +58,3 @@ namespace :alchemy do
     end
   end
 end
-
-module Alchemy
-  class Tidy
-    extend Shell
-
-    class << self
-      def create_missing_cells(page_layouts, cells)
-        page_layouts.each do |layout|
-          next if layout['cells'].blank?
-          cells_for_layout = cells.select { |cell| layout['cells'].include? cell['name'] }
-          Alchemy::Page.where(page_layout: layout['name']).each do |page|
-            cells_for_layout.each do |cell_for_layout|
-              cell = Alchemy::Cell.find_or_initialize_by(name: cell_for_layout['name'], page_id: page.id)
-              cell.elements << page.elements.select { |element| cell_for_layout['elements'].include?(element.name) }
-              if cell.new_record?
-                cell.save
-                log "Creating cell #{cell.name} for page #{page.name}"
-              else
-                log "Cell #{cell.name} for page #{page.name} already present", :skip
-              end
-            end
-          end
-        end
-      end
-
-      def update_element_positions
-        Alchemy::Page.all.each do |page|
-          if page.elements.any?
-            puts "\n## Updating element positions of page `#{page.name}`"
-          end
-          page.elements.group_by(&:cell_id).each do |_cell_id, elements|
-            elements.each_with_index do |element, idx|
-              position = idx + 1
-              if element.position != position
-                log "Updating position for element ##{element.id} to #{position}"
-                element.update_column(:position, position)
-              else
-                log "Position for element ##{element.id} is already correct (#{position})", :skip
-              end
-            end
-          end
-        end
-      end
-
-      def update_content_positions
-        Alchemy::Element.all.each do |element|
-          if element.contents.any?
-            puts "\n## Updating content positions of element `#{element.name}`"
-          end
-          element.contents.group_by(&:essence_type).each do |essence_type, contents|
-            puts "-> Contents of type `#{essence_type}`"
-            contents.each_with_index do |content, idx|
-              position = idx + 1
-              if content.position != position
-                log "Updating position for content ##{content.id} to #{position}"
-                content.update_column(:position, position)
-              else
-                log "Position for content ##{content.id} is already correct (#{position})", :skip
-              end
-            end
-          end
-        end
-      end
-
-      def remove_orphaned_cells
-        puts "\n## Removing orphaned cells"
-        cells = Alchemy::Cell.unscoped.all
-        if cells.any?
-          orphaned_cells = cells.select do |cell|
-            cell.page.nil? && cell.page_id.present?
-          end
-          if orphaned_cells.any?
-            destroy_orphaned_records(orphaned_cells, 'cell')
-          else
-            log "No orphaned cells found", :skip
-          end
-        else
-          log "No cells found", :skip
-        end
-      end
-
-      def remove_orphaned_elements
-        puts "\n## Removing orphaned elements"
-        elements = Alchemy::Element.unscoped.all
-        if elements.any?
-          orphaned_elements = elements.select do |element|
-            element.page.nil? && element.page_id.present? ||
-              element.cell.nil? && element.cell_id.present?
-          end
-          if orphaned_elements.any?
-            destroy_orphaned_records(orphaned_elements, 'element')
-          else
-            log "No orphaned elements found", :skip
-          end
-        else
-          log "No elements found", :skip
-        end
-      end
-
-      def remove_orphaned_contents
-        puts "\n## Removing orphaned contents"
-        contents = Alchemy::Content.unscoped.all
-        if contents.any?
-          orphaned_contents = contents.select do |content|
-            content.essence.nil? && content.essence_id.present? ||
-              content.element.nil? && content.element_id.present?
-          end
-          if orphaned_contents.any?
-            destroy_orphaned_records(orphaned_contents, 'content')
-          else
-            log "No orphaned contents found", :skip
-          end
-        else
-          log "No contents found", :skip
-        end
-      end
-
-      private
-
-      def destroy_orphaned_records(records, class_name)
-        records.each do |record|
-          log "Destroy orphaned #{class_name}: #{record.id}"
-          record.destroy
-        end
-      end
-    end
-  end
-end

data/lib/tasks/alchemy/upgrade.rake

@@ -148,12 +148,20 @@ namespace :alchemy do
     task '3.4' => ['alchemy:upgrade:prepare', 'alchemy:upgrade:3.4:run']
 
     namespace '3.4' do
-      task run: ['alchemy:upgrade:3.4:install_asset_manifests']
+      task run: [
+        'alchemy:upgrade:3.4:install_asset_manifests',
+        'alchemy:upgrade:3.4:store_image_file_format'
+      ]
 
       desc 'Install asset manifests into `vendor/assets`'
       task install_asset_manifests: [:environment] do
         Alchemy::Upgrader::ThreePointFour.install_asset_manifests
       end
+
+      desc 'Store image file format on Alchemy pictures.'
+      task store_image_file_format: [:environment] do
+        Alchemy::Upgrader::ThreePointFour.store_image_file_format
+      end
     end
 
     desc 'Upgrade Alchemy to v3.5'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: alchemy_cms
 version: !ruby/object:Gem::Version
-  version: 3.6.1
+  version: 3.6.6
 platform: ruby
 authors:
 - Thomas von Deyen
@@ -10,10 +10,10 @@ authors:
 - Hendrik Mans
 - Carsten Fregin
 - Martin Meyerhoff
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-08-16 00:00:00.000000000 Z
+date: 2020-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_model_serializers
@@ -63,14 +63,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: bourbon
   requirement: !ruby/object:Gem::Requirement
@@ -847,6 +847,7 @@ files:
 - lib/alchemy/shell.rb
 - lib/alchemy/ssl_protection.rb
 - lib/alchemy/tasks/helpers.rb
+- lib/alchemy/tasks/tidy.rb
 - lib/alchemy/test_support/config_stubbing.rb
 - lib/alchemy/test_support/controller_requests.rb
 - lib/alchemy/test_support/essence_shared_examples.rb
@@ -993,9 +994,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements:
 - ImageMagick (libmagick), v6.6 or greater.
-rubyforge_project: 
-rubygems_version: 2.6.11
-signing_key: 
+rubyforge_project:
+rubygems_version: 2.6.14.4
+signing_key:
 specification_version: 4
 summary: A powerful, userfriendly and flexible CMS for Rails 4
 test_files: []
+...