alchemy_cms 3.0.4 → 3.1.0.beta1

data/spec/models/tag_spec.rb

@@ -10,11 +10,11 @@ module Alchemy
       let(:new_tag) { Tag.new(name: 'green') }
 
       before do
-        picture.stub(:tag_list).and_return(['red'])
-        element.stub(:tag_list).and_return(['red'])
-        picture.stub(:save).and_return(true)
-        element.stub(:save).and_return(true)
-        tag.stub(:taggings).and_return([
+        allow(picture).to receive(:tag_list).and_return(['red'])
+        allow(element).to receive(:tag_list).and_return(['red'])
+        allow(picture).to receive(:save).and_return(true)
+        allow(element).to receive(:save).and_return(true)
+        allow(tag).to receive(:taggings).and_return([
           mock_model(ActsAsTaggableOn::Tagging, taggable: picture),
           mock_model(ActsAsTaggableOn::Tagging, taggable: element)
         ])
@@ -22,8 +22,8 @@ module Alchemy
 
       it "should replace given tag with new one on all models tagged with tag" do
         Tag.replace(tag, new_tag)
-        picture.tag_list.should eq(['green'])
-        element.tag_list.should eq(['green'])
+        expect(picture.tag_list).to eq(['green'])
+        expect(element.tag_list).to eq(['green'])
       end
     end
 

data/spec/routing/api_routing_spec.rb

@@ -0,0 +1,150 @@
+require 'spec_helper'
+
+describe 'The API routes' do
+  routes { Alchemy::Engine.routes }
+
+  describe "for pages" do
+    it "has route to show all pages." do
+      expect({get: "/api/pages.json"}).to route_to(
+        controller: "alchemy/api/pages",
+        action: "index",
+        format: "json"
+      )
+    end
+
+    context 'with missing format' do
+      it "defaults to json." do
+        expect({get: "/api/pages"}).to route_to(
+          controller: "alchemy/api/pages",
+          action: "index",
+          format: "json"
+        )
+      end
+    end
+
+    it "has route to show a page by urlname." do
+      expect({get: "/api/pages/a-page.json"}).to route_to(
+        controller: "alchemy/api/pages",
+        action: "show",
+        urlname: "a-page",
+        format: "json"
+      )
+    end
+
+    it "has route to show a page by nested urlname." do
+      expect({get: "/api/pages/nested/a-page"}).to route_to(
+        controller: "alchemy/api/pages",
+        action: "show",
+        urlname: "nested/a-page",
+        format: "json"
+      )
+    end
+
+    context 'with admin namespace' do
+      it "routes to api pages controller." do
+        expect({get: "/api/admin/pages/8"}).to route_to(
+          controller: "alchemy/api/pages",
+          action: "show",
+          id: "8",
+          format: "json"
+        )
+      end
+    end
+  end
+
+  describe 'for elements' do
+    it "has route to show all elements." do
+      expect({get: "/api/elements.json"}).to route_to(
+        controller: "alchemy/api/elements",
+        action: "index",
+        format: "json"
+      )
+    end
+
+    context 'with missing format' do
+      it "defaults to json." do
+        expect({get: "/api/elements"}).to route_to(
+          controller: "alchemy/api/elements",
+          action: "index",
+          format: "json"
+        )
+      end
+    end
+
+    it "has route to show all elements for page id." do
+      expect({get: "/api/pages/1/elements.json"}).to route_to(
+        controller: "alchemy/api/elements",
+        action: "index",
+        page_id: "1",
+        format: "json"
+      )
+    end
+
+    it "has route to show all elements for page id and name." do
+      expect({get: "/api/pages/1/elements/article.json"}).to route_to(
+        controller: "alchemy/api/elements",
+        action: "index",
+        page_id: "1",
+        named: "article",
+        format: "json"
+      )
+    end
+
+    it "has route to show an element." do
+      expect({get: "/api/elements/1.json"}).to route_to(
+        controller: "alchemy/api/elements",
+        action: "show",
+        id: "1",
+        format: "json"
+      )
+    end
+  end
+
+  describe 'for contents' do
+    it "has route to show all contents." do
+      expect({get: "/api/contents.json"}).to route_to(
+        controller: "alchemy/api/contents",
+        action: "index",
+        format: "json"
+      )
+    end
+
+    context 'with missing format' do
+      it "defaults to json." do
+        expect({get: "/api/contents"}).to route_to(
+          controller: "alchemy/api/contents",
+          action: "index",
+          format: "json"
+        )
+      end
+    end
+
+    it "has route to show all contents for element id." do
+      expect({get: "/api/elements/1/contents.json"}).to route_to(
+        controller: "alchemy/api/contents",
+        action: "index",
+        element_id: "1",
+        format: "json"
+      )
+    end
+
+    it "has route to show all contents for element id and name." do
+      expect({get: "/api/elements/1/contents/headline.json"}).to route_to(
+        controller: "alchemy/api/contents",
+        action: "show",
+        element_id: "1",
+        name: "headline",
+        format: "json"
+      )
+    end
+
+    it "has route to show a content." do
+      expect({get: "/api/contents/1.json"}).to route_to(
+        controller: "alchemy/api/contents",
+        action: "show",
+        id: "1",
+        format: "json"
+      )
+    end
+  end
+end

data/spec/routing/routing_spec.rb

@@ -7,9 +7,9 @@ describe "The Routing" do
   context "for downloads" do
 
     it "should have a named route" do
-      {
+      expect({
         :get => "/attachment/32/download/Presseveranstaltung.pdf"
-      }.should route_to(
+      }).to route_to(
         :controller => "alchemy/attachments",
         :action => "download",
         :id => "32",
@@ -25,9 +25,9 @@ describe "The Routing" do
     context "one level deep nested" do
 
       it "should route to pages show" do
-        {
+        expect({
           :get => "/products/my-product"
-        }.should route_to(
+        }).to route_to(
           :controller => "alchemy/pages",
           :action => "show",
           :urlname => "products/my-product"
@@ -37,9 +37,9 @@ describe "The Routing" do
       context "and language" do
 
         it "should route to pages show" do
-          {
+          expect({
             :get => "/de/products/my-product"
-          }.should route_to(
+          }).to route_to(
             :controller => "alchemy/pages",
             :action => "show",
             :urlname => "products/my-product",
@@ -54,9 +54,9 @@ describe "The Routing" do
     context "two levels deep nested" do
 
       it "should route to pages show" do
-        {
+        expect({
           :get => "/catalog/products/my-product"
-        }.should route_to(
+        }).to route_to(
           :controller => "alchemy/pages",
           :action => "show",
           :urlname => "catalog/products/my-product"
@@ -66,9 +66,9 @@ describe "The Routing" do
       context "and language" do
 
         it "should route to pages show" do
-          {
+          expect({
             :get => "/de/catalog/products/my-product"
-          }.should route_to(
+          }).to route_to(
             :controller => "alchemy/pages",
             :action => "show",
             :urlname => "catalog/products/my-product",
@@ -83,9 +83,9 @@ describe "The Routing" do
     context "with a blog date url" do
 
       it "should route to pages show" do
-        {
+        expect({
           :get => "/2011/12/08/my-post"
-        }.should route_to(
+        }).to route_to(
           :controller => "alchemy/pages",
           :action => "show",
           :urlname => "2011/12/08/my-post"
@@ -95,9 +95,9 @@ describe "The Routing" do
       context "and language" do
 
         it "should route to pages show" do
-          {
+          expect({
             :get => "/de/2011/12/08/my-post"
-          }.should route_to(
+          }).to route_to(
             :controller => "alchemy/pages",
             :action => "show",
             :urlname => "2011/12/08/my-post",
@@ -114,9 +114,9 @@ describe "The Routing" do
   describe "for displaying pictures" do
 
     it "should route to show action" do
-      {
+      expect({
         :get => "/pictures/3/show/900x300/kitten.jpg"
-      }.should route_to(
+      }).to route_to(
         :controller => "alchemy/pictures",
         :action => "show",
         :id => "3",
@@ -127,9 +127,9 @@ describe "The Routing" do
     end
 
     it "should route to cropped show action" do
-      {
+      expect({
         :get => "/pictures/3/show/900x300/crop/kitten.jpg"
-      }.should route_to(
+      }).to route_to(
         :controller => "alchemy/pictures",
         :action => "show",
         :id => "3",
@@ -141,9 +141,9 @@ describe "The Routing" do
     end
 
     it "should route to cropped mask show action" do
-      get(
+      expect(get(
         "/pictures/3/show/300x300/crop/200x50/100x100/kitten.jpg"
-      ).should route_to(
+      )).to route_to(
         :controller => "alchemy/pictures",
         :action => "show",
         :id => "3",
@@ -157,9 +157,9 @@ describe "The Routing" do
     end
 
     it "should route to thumbnail action" do
-      get(
+      expect(get(
         "/pictures/3/thumbnails/small/kitten.jpg"
-      ).should route_to(
+      )).to route_to(
         :controller => "alchemy/pictures",
         :action => "thumbnail",
         :id => "3",
@@ -170,9 +170,9 @@ describe "The Routing" do
     end
 
     it "should route to cropped thumbnail action" do
-      get(
+      expect(get(
         "/pictures/3/thumbnails/small/crop/kitten.jpg"
-      ).should route_to(
+      )).to route_to(
         :controller => "alchemy/pictures",
         :action => "thumbnail",
         :id => "3",
@@ -184,9 +184,9 @@ describe "The Routing" do
     end
 
     it "should route to cropped and masked thumbnail" do
-      get(
+      expect(get(
         "/pictures/3/thumbnails/small/0x0/200x200/kitten.jpg"
-      ).should route_to(
+      )).to route_to(
         :controller => "alchemy/pictures",
         :action => "thumbnail",
         :id => "3",
@@ -199,9 +199,9 @@ describe "The Routing" do
     end
 
     it "should route to zoomed picture" do
-      get(
+      expect(get(
         "/pictures/3/zoom/kitten.jpg"
-      ).should route_to(
+      )).to route_to(
         :controller => "alchemy/pictures",
         :action => "zoom",
         :id => "3",

data/spec/spec_helper.rb

@@ -34,12 +34,13 @@ require 'alchemy/test_support/integration_helpers'
 require 'alchemy/test_support/factories'
 require 'alchemy/test_support/essence_shared_examples'
 require_relative "support/hint_examples.rb"
+require_relative "support/transformation_examples.rb"
 
 # Configure capybara for integration testing
 Capybara.default_driver = :rack_test
 Capybara.default_selector = :css
 Capybara.register_driver :poltergeist do |app|
-  Capybara::Poltergeist::Driver.new(app, js_errors: false)
+  Capybara::Poltergeist::Driver.new(app)
 end
 Capybara.register_driver(:rack_test_translated_header) do |app|
   Capybara::RackTest::Driver.new(app, headers: { 'HTTP_ACCEPT_LANGUAGE' => 'de' })
@@ -48,7 +49,7 @@ Capybara.javascript_driver = :poltergeist
 Capybara.ignore_hidden_elements = false
 
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.infer_spec_type_from_file_location!
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
   config.include Alchemy::Engine.routes.url_helpers
@@ -65,7 +66,7 @@ RSpec.configure do |config|
   end
 
   # All specs are running in transactions, but feature specs not.
-  config.before(:each) do
+  config.before(:each) do |example|
     Alchemy::Site.current = nil
     ::I18n.locale = :en
     if example.metadata[:type] == :feature
@@ -80,8 +81,8 @@ RSpec.configure do |config|
   # After every feature spec the database gets seeded so the next spec can rely on that data.
   config.append_after(:each) do
     DatabaseCleaner.clean
-    if example.metadata[:type] == :feature
-      Alchemy::Seeder.stub(:puts)
+    if RSpec.current_example.metadata[:type] == :feature
+      allow(Alchemy::Seeder).to receive(:puts)
       Alchemy::Seeder.seed!
     end
   end

data/spec/support/hint_examples.rb

@@ -6,22 +6,22 @@ module Alchemy
     describe '#hint' do
       context 'with hint as text' do
         before do
-          subject.stub(definition: {'hint' => 'The hint'})
+          expect(subject).to receive(:definition).and_return({'hint' => 'The hint'})
         end
 
         it "returns the hint" do
-          subject.hint.should == 'The hint'
+          expect(subject.hint).to eq('The hint')
         end
       end
 
       context 'with hint set to true' do
         before do
-          subject.stub(definition: {'hint' => true})
-          I18n.stub(t: 'The hint')
+          expect(subject).to receive(:definition).and_return({'hint' => true})
+          expect(I18n).to receive(:t).and_return('The hint')
         end
 
         it "returns the hint from translation" do
-          subject.hint.should == 'The hint'
+          expect(subject.hint).to eq('The hint')
         end
       end
     end

data/spec/support/transformation_examples.rb

@@ -0,0 +1,173 @@
+require 'spec_helper'
+
+module Alchemy
+  shared_examples_for "has image transformations"  do
+
+    describe "#thumbnail_size" do
+      context "picture is 300x400 and has no crop size" do
+        it "should return the correct recalculated size value" do
+          allow(picture).to receive(:image_file_width) { 400 }
+          allow(picture).to receive(:image_file_height) { 300 }
+
+          expect(picture.thumbnail_size()).to eq('111x83')
+        end
+      end
+
+      context "picture is 300x400 and has no crop size" do
+        it "should return the correct recalculated size value" do
+          allow(picture).to receive(:image_file_width) { 300 }
+          allow(picture).to receive(:image_file_height) { 400 }
+
+          expect(picture.thumbnail_size()).to eq('70x93')
+        end
+      end
+
+      context "picture has crop_size of 400x300" do
+        it "scales to 400x300 if that is the size of the cropped image" do
+          allow(picture).to receive(:crop_size) { "400x300" }
+          expect(picture.thumbnail_size()).to eq('111x83')
+        end
+      end
+    end
+
+    describe '#landscape_format?' do
+      subject { picture.landscape_format? }
+
+      context 'image has landscape format' do
+        before { allow(picture).to receive(:image_file).and_return double(landscape?: true) }
+
+        it { is_expected.to be_truthy }
+      end
+
+      context 'image has portrait format' do
+        before { allow(picture).to receive(:image_file).and_return double(landscape?: false) }
+
+        it { is_expected.to be_falsey }
+      end
+
+      it "is aliased as landscape?" do
+        expect(picture.respond_to?(:landscape?)).to be_truthy
+      end
+    end
+
+    describe '#portrait_format?' do
+      subject { picture.portrait_format? }
+
+      context 'image has portrait format' do
+        before { allow(picture).to receive(:image_file).and_return double(portrait?: true) }
+
+        it { is_expected.to be_truthy }
+      end
+
+      context 'image has landscape format' do
+        before { allow(picture).to receive(:image_file).and_return double(portrait?: false) }
+
+        it { is_expected.to be_falsey }
+      end
+
+      it "is aliased as portrait?" do
+        expect(picture.respond_to?(:portrait?)).to be_truthy
+      end
+    end
+
+    describe '#square_format?' do
+      subject { picture.square_format? }
+
+      context 'image has square format' do
+        before { expect(picture).to receive(:image_file).and_return double(aspect_ratio: 1.0) }
+
+        it { is_expected.to be_truthy }
+      end
+
+      context 'image has rectangle format' do
+        before { expect(picture).to receive(:image_file).and_return double(aspect_ratio: 8.0) }
+
+        it { is_expected.to be_falsey }
+      end
+
+      it "is aliased as square?" do
+        expect(picture.respond_to?(:square?)).to be_truthy
+      end
+    end
+
+    describe '#default_mask' do
+      before do
+        allow(picture).to receive(:image_file_width) { 200 }
+        allow(picture).to receive(:image_file_height) { 100 }
+      end
+
+      it "should return a Hash" do
+        expect(picture.default_mask({ width: 10, height: 10 })).to be_a(Hash)
+      end
+
+      it "should return a Hash with four keys x1, x2, y1, y2" do
+        expect(picture.default_mask({ width: 10, height: 10 }).keys.sort).to eq([:x1, :x2, :y1, :y2])
+      end
+
+      it "should return a Hash where all values are Integer" do
+        expect(picture.default_mask({ width: 13, height: 13 }).all? do |k, v|
+          v.is_a? Integer
+        end).to be_truthy
+      end
+
+      context "making a default cropping mask" do
+        it "to 200x50 pixel, the hash should be {x1: 0, y1: 25, x2: 200, y2: 75}" do
+          expect(picture.default_mask({ width: 200, height: 50 })).to eq({x1: 0, y1: 25, x2: 200, y2: 75})
+        end
+
+        it "to 0x0 pixel, it should not crop the picture" do
+          expect(picture.default_mask({ width: 0, height: 0 })).to eq({x1: 0, y1: 0, x2: 200, y2: 100})
+        end
+
+        it "to 50x100 pixel, the hash should be {x1: 75, y1: 0, x2: 125, y2: 100}" do
+          expect(picture.default_mask({ width: 50, height: 100 })).to eq({x1: 75, y1: 0, x2: 125, y2: 100})
+        end
+
+        it "to 50x50 pixel, the hash should be {x1: 50, y1: 0, x2: 150, y2: 100}" do
+          expect(picture.default_mask({ width: 50, height: 50 })).to eq({x1: 50, y1: 0, x2: 150, y2: 100})
+        end
+
+        it "to 400x200 pixel, the hash should be {x1: 0, y1: 0, x2: 200, y2: 100}" do
+          expect(picture.default_mask({ width: 400, height: 200 })).to eq({x1: 0, y1: 0, x2: 200, y2: 100})
+        end
+
+        it "to 400x100 pixel, the hash should be {x1: 0, y1: 25, x2: 200, y2: 75}" do
+          expect(picture.default_mask({ width: 400, height: 100 })).to eq({x1: 0, y1: 25, x2: 200, y2: 75})
+        end
+
+        it "to 200x200 pixel, the hash should be {x1: 50, y1: 0, x2: 150, y2: 100}" do
+          expect(picture.default_mask({ width: 200, height: 200 })).to eq({x1: 50, y1: 0, x2: 150, y2: 100})
+        end
+      end
+    end
+
+    describe "#can_be_cropped_to" do
+      context "picture is 300x400 and shall be cropped to 200x100" do
+        it "should return true" do
+          allow(picture).to receive(:image_file_width) { 400 }
+          allow(picture).to receive(:image_file_height) { 300 }
+
+          expect(picture.can_be_cropped_to("200x100")).to be_truthy
+        end
+      end
+
+      context "picture is 300x400 and shall be cropped to 600x500" do
+        it "should return false" do
+          allow(picture).to receive(:image_file_width) { 400 }
+          allow(picture).to receive(:image_file_height) { 300 }
+
+          expect(picture.can_be_cropped_to("600x500")).to be_falsey
+        end
+      end
+
+      context "picture is 300x400 and shall be cropped to 600x500 with upsample set to true" do
+        it "should return true" do
+          allow(picture).to receive(:image_file_width) { 400 }
+          allow(picture).to receive(:image_file_height) { 300 }
+
+          expect(picture.can_be_cropped_to("600x500", true)).to be_truthy
+        end
+      end
+    end
+  end
+end