alchemy_cms 2.6.3 → 2.7.0

data/spec/models/picture_spec.rb

@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'spec_helper'
 
 module Alchemy
@@ -7,6 +8,8 @@ module Alchemy
       File.new(File.expand_path('../../support/image.png', __FILE__))
     end
 
+    let(:picture) { Picture.new }
+
     it "is valid with valid attributes" do
       picture = Picture.new(:image_file => image_file)
       picture.should be_valid
@@ -98,6 +101,41 @@ module Alchemy
 
     end
 
+    describe '.filtered_by' do
+
+      let :picture do
+        FactoryGirl.build_stubbed(:picture)
+      end
+
+      context "with 'recent' as argument" do
+        it 'should call the .recent scope' do
+          Picture.should_receive(:recent).and_return(picture)
+          Picture.filtered_by('recent').should eq(picture)
+        end
+      end
+
+      context "with 'last_upload' as argument" do
+        it 'should call the .last_upload scope' do
+          Picture.should_receive(:last_upload).and_return(picture)
+          Picture.filtered_by('last_upload').should eq(picture)
+        end
+      end
+
+      context "with 'without_tag' as argument" do
+        it 'should call the .without_tag scope' do
+          Picture.should_receive(:without_tag).and_return(picture)
+          Picture.filtered_by('without_tag').should eq(picture)
+        end
+      end
+
+      context "with no argument" do
+        it 'should return the scoped collection' do
+          Picture.should_receive(:scoped).and_return(picture)
+          Picture.filtered_by('').should eq(picture)
+        end
+      end
+    end
+
     describe '.last_upload' do
 
       it "should return all pictures that have the same upload-hash as the most recent picture" do
@@ -148,5 +186,65 @@ module Alchemy
       end
     end
 
+    describe '#default_mask' do
+
+      before do
+        picture.stub!(:image_file_width).and_return(200)
+        picture.stub!(:image_file_height).and_return(100)
+      end
+
+      it "should return a Hash" do
+        expect(picture.default_mask('10x10')).to be_a(Hash)
+      end
+
+      context "cropping the picture to 200x50 pixel" do
+        it "should contain the correct coordination values in the hash" do
+          expect(picture.default_mask('200x50')).to eq({x1: 0, y1: 25, x2: 200, y2: 75})
+        end
+      end
+
+      context "if picture´s cropping size is 0x0 pixel" do
+        it "should not crop the picture" do
+          expect(picture.default_mask('0x0')).to eq({x1: 0, y1: 0, x2: 200, y2: 100})
+        end
+      end
+
+      context "cropping the picture to 50x100 pixel" do
+        it "should contain the correct coordination values in the hash" do
+          expect(picture.default_mask('50x100')).to eq({x1: 75, y1: 0, x2: 125, y2: 100})
+        end
+      end
+
+    end
+    
+    describe "#cropped_thumbnail_size" do
+
+      context "if given size is blank or 111x93" do
+        it "should return the default size of '111x93'" do
+          expect(picture.cropped_thumbnail_size('')).to eq('111x93')
+          expect(picture.cropped_thumbnail_size('111x93')).to eq('111x93')
+        end
+      end
+
+      context "if the given width is 400 and the height is 300 because of picture cropping" do
+        it "should return the correct recalculated size value" do
+          expect(picture.cropped_thumbnail_size('400x300')).to eq('111x83')
+        end
+      end
+
+      context "if the given width is 300 and the height is 400 because of picture cropping" do
+        it "should return the correct recalculated size value" do
+          expect(picture.cropped_thumbnail_size('300x400')).to eq('70x93')
+        end
+      end
+    end
+    
+    describe "#image_file_dimensions" do
+      it "should return the width and height in the format of '1024x768'" do
+        picture.image_file = image_file
+        expect(picture.image_file_dimensions).to eq('1 x 1')
+      end
+    end
+
   end
 end

data/spec/models/site_spec.rb

@@ -78,12 +78,43 @@ module Alchemy
     describe '.current' do
       context 'when set to a site' do
         before { Site.current = site }
-        specify "Language should be scoped to that site"
+        specify "Language should be scoped to that site" do
+          Language.scoped.to_sql.should match(/alchemy_languages.+site_id.+#{site.id}/)
+        end
       end
 
       context 'when set to nil' do
         before { Site.current = nil }
-        specify "Language should not be scoped to a site"
+        specify "Language should not be scoped to a site" do
+          Language.scoped.to_sql.should_not match(/alchemy_languages.+site_id.+#{site.id}/)
+        end
+
+        it "should return default site" do
+          Site.current.should_not be_nil
+          Site.current.should == Site.default
+        end
+      end
+    end
+
+    describe '.layout_definitions' do
+      # To prevent memoization across specs
+      before { Site.instance_variable_set("@layout_definitions", nil) }
+
+      subject { Site.layout_definitions }
+
+      context "with file present" do
+        let(:definitions) { [{'name' => 'lala'}] }
+        before { YAML.should_receive(:load_file).and_return(definitions) }
+        it { should == definitions }
+      end
+
+      context "with empty file" do
+        before { YAML.should_receive(:load_file).and_return(false) }
+        it { should == [] }
+      end
+
+      context "with no file present" do
+        it { should == [] }
       end
     end
 
@@ -105,5 +136,32 @@ module Alchemy
         it { should be_false }
       end
     end
+
+    describe '#to_partial_path' do
+      let(:site) {Site.new(name: 'My custom site')}
+
+      it "returns the path to partial" do
+        site.to_partial_path.should == "alchemy/site_layouts/my_custom_site"
+      end
+    end
+
+    describe '#layout_partial_name' do
+      let(:site) {Site.new(name: 'My custom site')}
+
+      it "returns the name for layout partial" do
+        site.layout_partial_name.should == "my_custom_site"
+      end
+    end
+
+    describe '#layout_definition' do
+      let(:site) {Site.new(name: 'My custom site')}
+      let(:definitions) { [{'name' => 'my_custom_site', 'page_layouts' => %w(standard)}] }
+
+      it "returns layout definition from site_layouts.yml file" do
+        Site.stub(:layout_definitions).and_return(definitions)
+        site.layout_definition.should == definitions.first
+      end
+    end
+
   end
 end

data/spec/models/tag_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+module Alchemy
+  describe Tag do
+    
+    describe '.replace' do
+      let(:picture) { Picture.new }
+      let(:element) { Element.new }
+      let(:tag)     { Tag.new(name: 'red') }
+      let(:new_tag) { Tag.new(name: 'green') }
+
+      before do
+        picture.stub!(:tag_list).and_return(['red'])
+        element.stub!(:tag_list).and_return(['red'])
+        picture.stub!(:save).and_return(true)
+        element.stub!(:save).and_return(true)
+        tag.stub!(:taggings).and_return([
+          mock_model(ActsAsTaggableOn::Tagging, taggable: picture),
+          mock_model(ActsAsTaggableOn::Tagging, taggable: element)
+        ])
+      end
+
+      it "should replace given tag with new one on all models tagged with tag" do
+        Tag.replace(tag, new_tag)
+        picture.tag_list.should eq(['green'])
+        element.tag_list.should eq(['green'])
+      end
+    end
+
+  end
+end

data/spec/models/user_spec.rb

@@ -15,8 +15,8 @@ module Alchemy
     context ".after_save" do
       let(:user) { FactoryGirl.build(:admin_user) }
 
-      context "with send_credentials set to true" do
-        before { user.send_credentials = true }
+      context "with send_credentials set to '1'" do
+        before { user.send_credentials = '1' }
 
         it "delivers the admin welcome mail." do
           Notifications.should_receive(:admin_user_created).and_return(OpenStruct.new(deliver: true))
@@ -186,7 +186,7 @@ module Alchemy
     describe "#pages_locked_by_me" do
       it "should return all pages that are locked by user" do
         user.save!
-        page.lock(user)
+        page.lock!(user)
         user.locked_pages.should include(page)
       end
     end
@@ -194,7 +194,7 @@ module Alchemy
     describe '#unlock_pages' do
       before do
         user.save!
-        page.lock(user)
+        page.lock!(user)
       end
 
       it "should unlock all users lockes pages" do

data/spec/spec_helper.rb

@@ -1,71 +1,62 @@
 require 'simplecov'
 require 'coveralls'
 
-SimpleCov.formatter = Coveralls::SimpleCov::Formatter
-SimpleCov.start do
-  add_filter '/spec/'
-end
-
-begin
-  require 'spork'
-rescue LoadError => e
+if ENV['CI']
+  SimpleCov.formatter = Coveralls::SimpleCov::Formatter
+else
+  SimpleCov.formatter = SimpleCov::Formatter::HTMLFormatter
 end
+SimpleCov.start 'alchemy'
 
-def configure
-  # Configure Rails Environment
-  ENV["RAILS_ENV"] = "test"
+# Configure Rails Environment
+ENV["RAILS_ENV"] = "test"
 
-  require File.expand_path("../dummy/config/environment.rb", __FILE__)
+require File.expand_path("../dummy/config/environment.rb", __FILE__)
 
-  require "rails/test_help"
-  require "rspec/rails"
-  require 'factory_girl'
-  require 'factories.rb'
+require "rails/test_help"
+require "rspec/rails"
+require 'factory_girl'
 
-  ActionMailer::Base.delivery_method = :test
-  ActionMailer::Base.perform_deliveries = true
-  ActionMailer::Base.default_url_options[:host] = "test.com"
+ActionMailer::Base.delivery_method = :test
+ActionMailer::Base.perform_deliveries = true
+ActionMailer::Base.default_url_options[:host] = "test.com"
 
-  Rails.backtrace_cleaner.remove_silencers!
-  # Disable rails loggin for faster IO. Remove this if you want to have a test.log
-  Rails.logger.level = 4
+Rails.backtrace_cleaner.remove_silencers!
+# Disable rails loggin for faster IO. Remove this if you want to have a test.log
+Rails.logger.level = 4
 
-  # Configure capybara for integration testing
-  require "capybara/rails"
-  require 'capybara/poltergeist'
-  Capybara.default_driver = :rack_test
-  Capybara.default_selector = :css
-  Capybara.register_driver(:rack_test_translated_header) do |app|
-    Capybara::RackTest::Driver.new(app, :headers => { 'HTTP_ACCEPT_LANGUAGE' => 'de' })
+# Configure capybara for integration testing
+require "capybara/rails"
+require 'capybara/poltergeist'
+Capybara.default_driver = :rack_test
+Capybara.default_selector = :css
+Capybara.register_driver(:rack_test_translated_header) do |app|
+  Capybara::RackTest::Driver.new(app, :headers => { 'HTTP_ACCEPT_LANGUAGE' => 'de' })
+end
+Capybara.javascript_driver = :poltergeist
+
+# Load support files
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+
+require 'alchemy/seeder'
+
+RSpec.configure do |config|
+  config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.run_all_when_everything_filtered = true
+  config.filter_run :focus
+  config.include Alchemy::Engine.routes.url_helpers
+  config.include Devise::TestHelpers, :type => :controller
+  config.include Alchemy::Specs::ControllerHelpers, :type => :controller
+  config.include Alchemy::Specs::IntegrationHelpers, :type => :feature
+  config.use_transactional_fixtures = true
+  # Make sure the database is clean and ready for test
+  config.before(:suite) do
+    truncate_all_tables
+    Alchemy::Seeder.seed!
   end
-  Capybara.javascript_driver = :poltergeist
-
-  # Load support files
-  Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
-
-  RSpec.configure do |config|
-    require 'rspec/expectations'
-    config.include RSpec::Matchers
-    config.include Alchemy::Engine.routes.url_helpers
-    config.include Devise::TestHelpers, :type => :controller
-    config.mock_with :rspec
-    config.use_transactional_fixtures = true
-    # Make sure the database is clean and ready for test
-    config.before(:suite) do
-      truncate_all_tables
-      Alchemy::Seeder.seed!
-    end
-    # Ensuring that the locale is always resetted to :en before running any tests
-    config.before(:each) do
-      Alchemy::Site.current = nil
-      ::I18n.locale = :en
-    end
+  # Ensuring that the locale is always resetted to :en before running any tests
+  config.before(:each) do
+    Alchemy::Site.current = nil
+    ::I18n.locale = :en
   end
-
-end
-
-if defined?(Spork)
-  Spork.prefork { configure }
-else
-  configure
 end

data/spec/support/alchemy/controller_helpers.rb

@@ -0,0 +1,35 @@
+module Alchemy
+  module Specs
+
+    # Helpers for controller specs
+    #
+    # This file is included in rspec controller tests.
+    #
+    module ControllerHelpers
+
+      def sign_in(user=admin_user)
+        request.env['warden'].stub :authenticate! => user
+        request.env['warden'].set_user(user, store: false, run_callbacks: false)
+        controller.stub :current_user => user
+      end
+
+      def admin_user
+        mock_user([:admin])
+      end
+
+      def registered_user
+        mock_user([:registered])
+      end
+
+      def mock_user(roles)
+        mock_model(User,
+          name: 'Hermes Trismegistus',
+          roles: roles.map(&:to_sym),
+          store_request_time!: nil
+        )
+      end
+
+    end
+
+  end
+end

data/spec/support/alchemy/{specs_helpers.rb → integration_helpers.rb}

@@ -5,10 +5,10 @@ module Alchemy
 
     # Helpers for integration specs
     #
-    # This file is auto included in rspec integration/request tests.
+    # This file is included in rspec integration/request tests.
     #
-    module Helpers
-      include Authorization::TestHelper
+    module IntegrationHelpers
+      include ::Authorization::TestHelper
 
       # Shortcut method for:
       #
@@ -42,7 +42,7 @@ module Alchemy
       # For some strange reason, this isn't done automatically while running the specs
       #
       def load_authorization_rules
-        instance = Alchemy::AuthEngine.get_instance
+        instance = Alchemy::Auth::Engine.get_instance
         instance.load(File.join(File.dirname(__FILE__), '../../dummy', 'config/authorization_rules.rb'))
       end
 
@@ -64,7 +64,3 @@ module Alchemy
 
   end
 end
-
-RSpec.configure do |c|
-  c.include Alchemy::Specs::Helpers, :type => :feature
-end

data/spec/{factories.rb → support/factories.rb}

@@ -82,6 +82,11 @@ FactoryGirl.define do
       language nil
     end
 
+    factory :restricted_page do
+      name "Restricted page"
+      restricted true
+    end
+
   end
 
   factory :cell, :class => 'Alchemy::Cell' do
@@ -92,10 +97,15 @@ FactoryGirl.define do
   factory :element, :class => 'Alchemy::Element' do
     name 'article'
     create_contents_after_create false
+
+    factory :unique_element do
+      unique true
+      name 'header'
+    end
   end
 
   factory :picture, :class => 'Alchemy::Picture' do
-    image_file File.new(File.expand_path('../support/image.png', __FILE__))
+    image_file File.new(File.expand_path('../image.png', __FILE__))
     name 'image'
     image_file_name 'image.png'
     upload_hash Time.now.hash