alchemy_cms 2.1.beta6 → 2.1.rc2

data/spec/integration/pages_controller_spec.rb

@@ -4,7 +4,7 @@ describe Alchemy::PagesController do
 	
 	before(:each) do
 		@default_language = Alchemy::Language.get_default
-		@default_language_root = Factory(:language_root_page, :language => @default_language, :name => 'Home', :public => true)
+		@default_language_root = Factory(:language_root_page, :language => @default_language, :name => 'Home')
 	end
 
 	describe "#show" do
@@ -28,7 +28,7 @@ describe Alchemy::PagesController do
 
 	end
 
-	context "fulltext search" do
+	describe "fulltext search" do
 
 		before(:each) do
 			@page = Factory(:public_page, :language => @default_language, :visible => true, :name => 'Page 1', :parent_id => @default_language_root.id)
@@ -55,16 +55,38 @@ describe Alchemy::PagesController do
 				within('div#content .search_result') { page.should have_content('Petshop') }
 			end
 
+			it "should not find contents placed on global-pages (layoutpage => true)" do
+				@page.update_attributes(:layoutpage => true)
+				@element.content_by_name('intro').essence.update_attributes(:body => 'Welcome to Peters Petshop', :public => true)
+				visit('/alchemy/suche?query=Petshop')
+				within('div#content') { page.should have_css('h2.no_search_results') }
+			end
+
+			it "should not find contents placed on unpublished pages (public => false)" do
+				@page.update_attributes(:public => false)
+				@element.content_by_name('intro').essence.update_attributes(:body => 'Welcome to Peters Petshop', :public => true)
+				visit('/alchemy/suche?query=Petshop')
+				within('div#content') { page.should have_css('h2.no_search_results') }
+			end
+
+			it "should not find contents placed on restricted pages (restricted => true)" do
+				@page.update_attributes(:restricted => true)
+				@element.content_by_name('intro').essence.update_attributes(:body => 'Welcome to Peters Petshop', :public => true)
+				visit('/alchemy/suche?query=Petshop')
+				within('div#content') { page.should have_css('h2.no_search_results') }
+			end
+
 		end
 
 	end
 
-	context "redirecting" do
+	describe "redirecting" do
 
-		context "in multi language mode" do
+		context "in multi language mode", :focus => true do
 
 			before(:each) do
 				@page = Factory(:public_page)
+				Alchemy::Config.stub!(:get) { |arg| arg == :url_nesting ? true : Alchemy::Config.parameter(arg) }
 			end
 
 			it "should redirect to url with nested language code" do
@@ -77,9 +99,10 @@ describe Alchemy::PagesController do
 				before(:each) do
 					@page.update_attributes(:public => false, :name => 'Not Public', :urlname => '')
 					@child = Factory(:public_page, :name => 'Public Child', :parent_id => @page.id)
+					Alchemy::Config.stub!(:get) { |arg| arg == :url_nesting ? false : Alchemy::Config.parameter(arg) }
 				end
 
-				it ", if requested page is unpublished" do
+				it "if requested page is unpublished" do
 					visit '/alchemy/kl/not-public'
 					page.current_path.should == '/alchemy/kl/public-child'
 				end
@@ -106,12 +129,63 @@ describe Alchemy::PagesController do
 				page.current_url.should match(/\?query=Peter/)
 			end
 
+			context "url nesting" do
+
+				before(:each) do
+					@level1 = Factory(:public_page, :parent_id => @default_language_root.id, :name => 'catalog', :language => @default_language)
+					@level2 = Factory(:public_page, :parent_id => @level1.id, :name => 'products', :language => @default_language)
+					@level3 = Factory(:public_page, :parent_id => @level2.id, :name => 'screwdriver', :language => @default_language)
+				end
+
+				context "enabled" do
+
+					before(:each) do
+						Alchemy::Config.stub!(:get) { |arg| arg == :url_nesting ? true : Alchemy::Config.parameter(arg) }
+					end
+
+					context "requesting a non nested url" do
+
+						it "should redirect to nested url" do
+							visit "/alchemy/de/screwdriver"
+							page.current_path.should == '/alchemy/de/catalog/products/screwdriver'
+						end
+
+						it "should only redirect to nested url if page is nested" do
+							visit "/alchemy/de/catalog"
+							page.status_code.should == 200
+							page.current_path.should == "/alchemy/de/catalog"
+						end
+
+					end
+
+				end
+
+				context "disabled" do
+
+					before(:each) do
+						Alchemy::Config.stub!(:get) { |arg| arg == :url_nesting ? false : Alchemy::Config.parameter(arg) }
+					end
+
+					context "requesting a nested url" do
+
+						it "should redirect to not nested url" do
+							visit "/alchemy/de/catalog/products/screwdriver"
+							page.current_path.should == "/alchemy/de/screwdriver"
+						end
+
+					end
+
+				end
+
+			end
+
 		end
 
 		context "not in multi language mode" do
 
 			before(:each) do
 				@page = Factory(:public_page, :language => @default_language, :parent_id => @default_language_root.id)
+				Alchemy::Config.stub!(:get) { |arg| arg == :url_nesting ? false : Alchemy::Config.parameter(arg) }
 			end
 
 			it "should redirect from nested language code url to normal url" do
@@ -140,7 +214,7 @@ describe Alchemy::PagesController do
 					@child = Factory(:public_page, :name => 'Public Child', :parent_id => @page.id, :language => @default_language)
 				end
 
-				it ", if requested page is unpublished" do
+				it "if requested page is unpublished" do
 					visit '/alchemy/not-public'
 					page.current_path.should == '/alchemy/public-child'
 				end

data/spec/integration/security_spec.rb

@@ -12,7 +12,7 @@ describe "Security: " do
 		
 		it "render the signup view" do
 			visit '/alchemy/'
-			within('#alchemy_greeting') { page.should have_content('signup') }
+			within('#alchemy_greeting') { page.should have_content('Signup') }
 		end
 	end
 	
@@ -39,7 +39,7 @@ describe "Security: " do
 				visit '/alchemy/admin/login'
 				fill_in('alchemy_user_session_login', :with => 'jdoe')
 				fill_in('alchemy_user_session_password', :with => 's3cr3t')
-				click_on('Login')
+				click_on('login')
 			end
 			
 			it "should be redirected to dashboard" do

data/spec/models/content_spec.rb

@@ -48,4 +48,28 @@ describe Alchemy::Content do
 
 	end
 
+	describe '#update_essence' do
+
+		it "should update the attributes of related essence and return true" do
+			@element = Factory(:element, :name => 'text')
+			@content = @element.contents.first
+			@content.update_essence(:body => 'Mikes Petshop')
+			@content.ingredient.should == "Mikes Petshop"
+		end
+
+		it "should add error messages if save fails and return false" do
+			@element = Factory(:element, :name => 'contactform')
+			@content = @element.contents.first
+			@content.update_essence
+			@content.errors[:essence].should have(1).item
+		end
+
+		it "should raise error if essence is missing" do
+			@element = Factory(:element, :name => 'text')
+			@content = @element.contents.first
+			@content.update_essence
+		end
+
+	end
+
 end

data/spec/models/page_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 describe Alchemy::Page do
 	
 	before(:each) do
-		@rootpage = Alchemy::Page.rootpage
+		@rootpage = Alchemy::Page.root
 		@language = Alchemy::Language.get_default
-		@language_root = Factory(:page, :parent_id => @rootpage.id, :language => @language, :language_root => true, :page_layout => 'intro')
+		@language_root = Factory(:language_root_page, :name => 'Default Language Root', :language => @language)
 	end
 	
 	describe ".layout_description" do
@@ -104,46 +104,37 @@ describe Alchemy::Page do
 		end
 	
 	end
-	
-	context "create" do
-		it "the rootpage with page_layout rootpage does not need a parent_id" do
-			@rootpage.rootpage?.should be_true
-		end
-		
-		it "all pages except the rootpage must have a parent_id" do
-			page = Factory.build(:page, :page_layout => "anypage", :parent_id => nil, :language => @language)
-			page.valid?
-			page.should have(1).error_on(:parent_id)
-		end
-		
-		it "must not be created if the page_layout is set to 'rootpage' and a page already exists with this page_layout and parent_id = nil" do
-		  page = Factory.build(:page, :name => "anypage", :page_layout => "rootpage", :parent_id => @language_root.id, :language => @language)
-			page.valid?
-			page.should have(1).error_on(:page_layout)
-		end
-		
-		it "should get a webfriendly urlname on create" do
-			page = Factory(:page, :name => 'klingon$&stößel ', :language => @language, :parent_id => @language_root.id)
-			page.urlname.should == 'klingon-stoessel'
-		end
 
-	  it "should generate a three letter urlname from two letter name" do
-	    page = Factory(:page, :name => 'Au', :language => @language, :parent_id => @language_root.id)
-	    page.urlname.should == '-au'
-	  end
+	describe '#create' do
 
-	  it "should generate a three letter urlname from two letter name with umlaut" do
-	    page = Factory(:page, :name => 'Aü', :language => @language, :parent_id => @language_root.id)
-	    page.urlname.should == 'aue'
-	  end
+		context "generate urlnames" do
+
+			it "should get a webfriendly urlname" do
+				page = Factory(:page, :name => 'klingon$&stößel ', :language => @language, :parent_id => @language_root.id)
+				page.urlname.should == 'klingon-stoessel'
+			end
+
+			it "should generate a three letter urlname from two letter name" do
+				page = Factory(:page, :name => 'Au', :language => @language, :parent_id => @language_root.id)
+				page.urlname.should == '-au'
+			end
+
+			it "should generate a three letter urlname from two letter name with umlaut" do
+				page = Factory(:page, :name => 'Aü', :language => @language, :parent_id => @language_root.id)
+				page.urlname.should == 'aue'
+			end
+
+			it "should generate a three letter urlname from one letter name" do
+				page = Factory(:page, :name => 'A', :language => @language, :parent_id => @language_root.id)
+				page.urlname.should == '--a'
+			end
+
+		end
 
-	  it "should generate a three letter urlname from one letter name" do
-	    page = Factory(:page, :name => 'A', :language => @language, :parent_id => @language_root.id)
-	    page.urlname.should == '--a'
-	  end
 	end
-	
+
 	context "with children" do
+
 		before(:each) do
 			@first_child = Factory(:page, :name => "First child", :language => @language, :public => false, :parent_id => @language_root.id)
 			@first_child.move_to_child_of(@language_root)
@@ -151,7 +142,7 @@ describe Alchemy::Page do
 			@first_public_child = Factory(:page, :name => "First public child", :language => @language, :parent_id => @language_root.id, :public => true)
 			@first_public_child.move_to_child_of(@language_root)
 		end
-		
+
 		it "should return a page object (or nil if no public child exists) for first_public_child" do
 			if @language_root.children.any?
 				@language_root.first_public_child.should == @first_public_child
@@ -159,23 +150,28 @@ describe Alchemy::Page do
 				@language_root.first_public_child.should == nil
 			end
 		end
+
 	end
-	
+
 	context ".public" do
-	  it "should return 2 pages that are public" do
+
+		it "should return pages that are public" do
 			Factory(:public_page, :name => 'First Public Child', :parent_id => @language_root.id, :language => @language)
 			Factory(:public_page, :name => 'Second Public Child', :parent_id => @language_root.id, :language => @language)
-	    Alchemy::Page.published.should have(2).pages
-	  end
+			Alchemy::Page.published.should have(3).pages
+		end
+
 	end
-		
+
 	context ".not_locked" do
-	  it "should return 3 pages that are not blocked by a user at the moment" do
-	    Factory(:public_page, :locked => true, :name => 'First Public Child', :parent_id => @language_root.id, :language => @language)
+
+		it "should return pages that are not blocked by a user at the moment" do
+			Factory(:public_page, :locked => true, :name => 'First Public Child', :parent_id => @language_root.id, :language => @language)
 			Factory(:public_page, :name => 'Second Public Child', :parent_id => @language_root.id, :language => @language)
-	    Alchemy::Page.not_locked.should have(3).pages
-	  end
+			Alchemy::Page.not_locked.should have(3).pages
+		end
 	end
+
 	context ".all_locked" do
 	  it "should return 1 page that is blocked by a user at the moment" do
 	    Factory(:public_page, :locked => true, :name => 'First Public Child', :parent_id => @language_root.id, :language => @language)
@@ -307,4 +303,135 @@ describe Alchemy::Page do
 
 	end
 
+	describe "validations" do
+
+		context "creating a normal content page" do
+
+			before(:each) do
+				@contentpage = Factory.build(:page, :parent_id => nil, :page_layout => nil)
+			end
+
+			it "should validate the page_layout" do
+				@contentpage.save
+				@contentpage.should have(1).error_on(:page_layout)
+			end
+
+			it "should validate the parent_id" do
+				@contentpage.save
+				@contentpage.should have(1).error_on(:parent_id)
+			end
+
+		end
+
+		context "creating the rootpage without parent_id and page_layout" do
+
+			before(:each) do
+				Alchemy::Page.delete_all
+				@rootpage = Factory.build(:page, :parent_id => nil, :page_layout => nil, :name => 'Rootpage')
+			end
+
+			it "should be valid" do
+				@rootpage.save
+				@rootpage.should be_valid
+			end
+
+		end
+
+		context "saving a systempage" do
+
+			before(:each) do
+				@systempage = Factory.build(:systempage)
+			end
+
+			it "should not validate the page_layout" do
+				@systempage.save
+				@systempage.should be_valid
+			end
+
+		end
+
+	end
+
+	describe 'before and after filters' do
+
+		context "a normal page" do
+
+			before(:each) do
+				@page = Factory.build(:page, :language_code => nil, :language => Factory(:language))
+			end
+
+			it "should get the language code for language" do
+				@page.save
+				@page.language_code.should == "kl"
+			end
+
+			it "should autogenerate the elements" do
+				@page.save
+				@page.elements.should_not be_empty
+			end
+
+			context "with children getting restricted set to true" do
+
+				before(:each) do
+					@page.save
+					@child1 = Factory(:page, :name => 'Child 1', :parent_id => @page.id)
+					@page.reload
+					@page.restricted = true
+					@page.save
+				end
+
+				it "should restrict all its children" do
+					@child1.reload
+					@child1.restricted?.should be_true
+				end
+
+			end
+
+			context "with restricted parent gets created" do
+
+				before(:each) do
+					@page.save
+					@page.parent.update_attributes(:restricted => true)
+					@new_page = Factory(:page, :name => 'New Page', :parent_id => @page.id)
+				end
+
+				it "should also be restricted" do
+					@new_page.restricted?.should be_true
+				end
+
+			end
+
+			context "with do_not_autogenerate set to true" do
+
+				before(:each) do
+					@page.do_not_autogenerate = true
+				end
+
+				it "should not autogenerate the elements" do
+					@page.save
+					@page.elements.should be_empty
+				end
+
+			end
+
+		end
+
+		context "a systempage" do
+
+			before(:each) do
+				@page = Factory(:systempage)
+			end
+
+			it "should not get the language code for language" do
+				@page.language_code.should be_nil
+			end
+
+			it "should not autogenerate the elements" do
+				@page.elements.should be_empty
+			end
+
+		end
+
+	end
+
 end