albacore 2.8.0 → 3.0.0.pre.alpha

data/spec/nugets_pack_spec.rb

@@ -5,356 +5,4 @@ require 'shared_contexts'
 require 'support/sh_interceptor'
 require 'albacore'
 require 'albacore/task_types/nugets_pack'
-require 'albacore/nuget_model'
-
-include ::Albacore::NugetsPack
-
-# The .NET Framework / .NET Standard specified by default
-DEFAULT_FRAMEWORK = 'net461'
-
-class ConfigFac
-  def self.create id, curr, target, gen_symbols = true
-    cfg = Albacore::NugetsPack::Config.new
-    cfg.target        = target
-    cfg.configuration = 'Debug'
-    cfg.files         = Dir.glob(File.join(curr, 'testdata', 'Project', '*.fsproj'))
-    cfg.out           = 'spec/testdata/pkg'
-    cfg.exe           = 'NuGet.exe'
-    cfg.with_metadata do |m|
-      m.id            = id
-      m.authors       = 'haf'
-      m.owners        = 'haf owner'
-      m.description   = 'a nice lib'
-      m.language      = 'Danish'
-      m.project_url   = 'https://github.com/haf/Reasonable'
-      m.license_url   = 'https://github.com/haf/README.md'
-      m.version       = '0.2.3'
-      m.release_notes = %{
-v10.0.0:
-  - Some notes
-}
-      m.require_license_acceptance = false
-
-      m.add_dependency 'Abc.Package', '>= 1.0.2'
-      m.add_framework_dependency 'System.Transactions', '4.0.0'
-    end
-    cfg.gen_symbols if gen_symbols # files: *.{pdb,dll,all compiled files}
-    cfg
-  end
-end
-
-shared_context 'pack_config' do
-  let :id do
-    'Sample.Nuget'
-  end
-  let :curr do
-    File.dirname(__FILE__)
-  end
-  let :config do
-    cfg = ConfigFac.create id, curr, DEFAULT_FRAMEWORK, true
-  end
-end
-
-shared_context 'pack_config no symbols' do
-  let :id do
-    'Sample.Nuget'
-  end
-  let :curr do
-    File.dirname(__FILE__)
-  end
-  let :config do
-    cfg = ConfigFac.create id, curr, DEFAULT_FRAMEWORK, false
-  end
-end
-
-describe Albacore::NugetsPack::Config, 'when setting #nuget_gem_exe' do
-  it 'should be set to path that exists' do
-    subject.nuget_gem_exe
-    expect(subject.exe).to be_a String
-    expect(File.exists?( subject.exe)).to be true
-  end
-end
-# testing the command for nuget
-
-describe Cmd, "when calling #execute" do
-  
-  include_context 'path testing'
-
-  let :cmd do
-    Cmd.new 'NuGet.exe', config.opts()
-  end
-
-  subject do 
-    cmd.extend ShInterceptor
-    cmd.execute './spec/testdata/example.nuspec', './spec/testdata/example.symbols.nuspec'
-    #puts "## INVOCATIONS:"
-    #cmd.invocations.each do |i|
-    #  puts "#{i}"
-    #end
-    cmd
-  end
-
-  describe "first invocation" do
-    include_context 'pack_config'
-    it "should run the correct executable" do
-      expect(subject.mono_command(0)).to eq('NuGet.exe')
-    end
-    it "should include the correct parameters" do
-      expect(subject.mono_parameters(0)).to eq(%W[Pack -OutputDirectory #{path 'spec/testdata/pkg'} ./spec/testdata/example.nuspec])
-    end
-  end
-
-  describe "second invocation" do
-    include_context 'pack_config'
-    it "should include -Symbols" do
-      expect(subject.mono_parameters(1)).to eq(%W[Pack -OutputDirectory #{path 'spec/testdata/pkg'} -Symbols ./spec/testdata/example.symbols.nuspec])
-    end
-  end
-
-  describe "without symbols" do
-    include_context 'pack_config no symbols'
-    subject do
-      cmd.extend ShInterceptor
-      cmd.execute './spec/testdata/example.nuspec'
-      cmd
-    end
-    it 'should not include -Symbols'  do
-      expect(subject.mono_parameters(0)).to eq(%W[Pack -OutputDirectory #{path 'spec/testdata/pkg'} ./spec/testdata/example.nuspec])
-    end
-    it 'should not have a second invocation' do
-      expect(subject.invocations.length).to eq(1)
-    end
-  end
-end
-
-describe Cmd, 'when calling :get_nuget_path_of' do
-  include_context 'pack_config'
-
-  subject do
-    Cmd.new 'NuGet.exe', config.opts()
-  end
-
-  let :sample1 do
-<<EXAMPLE_OUTPUT
-Attempting to build package from 'MyNuget.Package.nuspec'.
-Successfully created package 'Y:\\Shared\\build\\pkg\\MyNuget.Package.1.0.0.nupkg'.
-Successfully created package 'Y:\\Shared\\build\\pkg\\MyNuget.Package.1.0.0.symbols.nupkg'.
-EXAMPLE_OUTPUT
-  end
-
-  let :sample2 do
-<<EXAMPLE_OUTPUT
-Attempting to build package from 'MyNuget.Package.nuspec'.
-Successfully created package '/home/xyz/Shared/build/pkg/MyNuget.Package.1.0.0.nupkg'.
-Successfully created package '/home/xyz/Shared/build/pkg/MyNuget.Package.1.0.0.symbols.nupkg'.
-EXAMPLE_OUTPUT
-  end
-
-  let :sample3 do
-<<EXAMPLE_OUTPUT
-Attempting to build package from 'MyNuget.Package.nuspec'.
-Successfully created package '/home/xyz/Shared/build/pkg/MyNuget.Package.1.0.0-alpha3.nupkg'.
-Successfully created package '/home/xyz/Shared/build/pkg/MyNuget.Package.1.0.0-alpha3.symbols.nupkg'.
-EXAMPLE_OUTPUT
-  end
-
-  let :sample4 do
-<<EXAMPLE_OUTPUT
-Attempting to build package from 'MyNuget.Package.nuspec'.
-Successfully created package '/home/xyz/Shared/build/pkg/MyNuget.Package.1.0.0-alpha.nupkg'.
-EXAMPLE_OUTPUT
-  end
-
-  let :sample5 do
-<<EXAMPLE_OUTPUT
-Attempting to build package from 'Fröken.nuspec'.
-Successfully created package '/home/xyz/Shared/build/pkg/Fröken.1.0.0-alpha.nupkg'.
-EXAMPLE_OUTPUT
-  end
-
-  it "should match sample1 with last nupkg mentioned" do
-    match = subject.send(:get_nuget_path_of) { sample1 }
-    expect(match).to eq('Y:\\Shared\\build\\pkg\\MyNuget.Package.1.0.0.symbols.nupkg')
-  end
-
-  it 'should match sample2 with last nupkg mentioned' do
-    match = subject.send(:get_nuget_path_of) { sample2 }
-    expect(match).to eq('/home/xyz/Shared/build/pkg/MyNuget.Package.1.0.0.symbols.nupkg')
-  end
-
-  it 'should match sample3 with last nupkg mentioned' do
-    match = subject.send(:get_nuget_path_of) { sample3 }
-    expect(match).to eq('/home/xyz/Shared/build/pkg/MyNuget.Package.1.0.0-alpha3.symbols.nupkg')
-  end
-
-  it 'should match sample4 with last nupkg mentioned' do
-    match = subject.send(:get_nuget_path_of) { sample4 }
-    expect(match).to eq('/home/xyz/Shared/build/pkg/MyNuget.Package.1.0.0-alpha.nupkg')
-  end
-
-  it 'should match sample5 despite non-ASCII' do
-    match = subject.send(:get_nuget_path_of) { sample5 }
-    expect(match).to eq('/home/xyz/Shared/build/pkg/Fröken.1.0.0-alpha.nupkg')
-  end
-end
-
-# testing nuspec task
-
-describe NuspecTask, "when testing public interface" do
-  include_context 'pack_config'
-  include_context 'path testing'
-
-  it "accepts .nuspec files" do
-    expect(NuspecTask.accept?('some.nuspec')).to be true
-  end
-
-  let (:cmd) do
-    Cmd.new 'NuGet.exe', config.opts()
-  end
-
-  subject do
-    cmd
-  end
-
-  before do
-    cmd.extend(ShInterceptor)
-    task = NuspecTask.new cmd, config, './spec/testdata/example.nuspec'
-    task.execute
-  end
-
-  it "should run the correct executable" do
-    expect(subject.mono_command).to eq 'NuGet.exe'
-  end
-  it "should give the correct parameters" do
-    expect(subject.mono_parameters).to eq %W[Pack -OutputDirectory #{path 'spec/testdata/pkg'} ./spec/testdata/example.nuspec]
-  end
-end
-
-# testing project task
-
-describe ProjectTask, 'when target framework is specified' do
-  include_context 'pack_config no symbols'
-  include_context 'package_metadata_dsl'
-
-  it "sanity: should have config with target=#{DEFAULT_FRAMEWORK}" do
-    expect(config.opts().get(:target)).to eq(DEFAULT_FRAMEWORK)
-  end
-
-  let :projfile do
-    curr = File.dirname(__FILE__)
-    File.join curr, "testdata", "Project", "Project.fsproj"
-  end 
-
-  subject do
-    proj = Albacore::Project.new projfile
-    ProjectTask.new( config.opts() ).send(:create_nuspec, proj, [])[0] # index0 first nuspec Alabacore::Package
-  end 
-
-  has_file 'bin/Debug/Project.dll', "lib/#{DEFAULT_FRAMEWORK}"
-end
-
-describe ProjectTask, 'when target framework is unspecified' do
-  include_context 'pack_config no symbols'
-  include_context 'package_metadata_dsl'
-
-  let :projfile do
-    curr = File.dirname(__FILE__)
-    File.join curr, "testdata", "Project", "Project.fsproj"
-  end 
-  let :vanilla_config do
-    cfg = ConfigFac.create id, curr, '', false
-  end
-  subject do
-    proj = Albacore::Project.new projfile
-    ProjectTask.new( vanilla_config.opts() ).send(:create_nuspec, proj, [])[0] # index0 first nuspec Alabacore::Package
-  end 
-
-  has_file 'bin/Debug/Project.dll', 'lib/net45'
-end
-
-describe ProjectTask, "when testing public interface" do
-  let :projfile do
-    curr = File.dirname(__FILE__)
-    File.join curr, "testdata", "Project.fsproj"
-  end
-  it "can be created" do
-    ProjectTask.new(Map.new(:files => [projfile]))
-  end
-  it "rejects .nuspec files" do
-    expect(ProjectTask.accept?('some.nuspec')).to eq false
-  end
-end
-
-describe ProjectTask, "creating nuget from proj file" do
-  let(:cmdo) { Hash.new }
-
-  subject do
-    ProjectTask.new(config.opts()) do |cmd|
-      cmd.extend ShInterceptor
-      cmdo[:cmd] = cmd
-    end
-  end 
-
-  before :each do
-    subject.execute
-  end
-
-  describe 'when generating symbols' do
-    include_context 'pack_config'
-    it 'should have generated a nuspec' do
-      expect(cmdo[:cmd].mono_parameters(0)[-1]).to include('Sample.Nuget.nuspec')
-    end
-    it 'should have generated a symbol nuspec' do
-      expect(cmdo[:cmd].mono_parameters(1)[-1]).to include('Sample.Nuget.symbols.nuspec')
-    end
-  end
-
-  describe 'when not generating symbols' do
-    include_context 'pack_config no symbols'
-    it 'should have generated a nuspec' do
-      expect(cmdo[:cmd].mono_parameters(0)[-1]).to include('Sample.Nuget.nuspec')
-    end
-    it 'should have done no further calls' do
-      expect(cmdo[:cmd].invocations.length).to eq(1)
-    end
-    it 'should have no further invocations' do
-      begin
-        cmdo[:cmd].mono_parameters(1)
-      rescue RuntimeError
-      end
-    end
-  end
-end
-
-describe ProjectTask, "path_to should accept both relative and absolute paths" do
-  let :proj_task do
-    curr = File.dirname(__FILE__)
-    ProjectTask.new(Map.new(
-      :files => [File.join( curr, "testdata", "Project.fsproj")], 
-      :original_path => "/original_path/"))
-  end
-  it "should use original_path to resolve path" do
-    expect(proj_task.path_to( "./bin/something.exe", "./tmp/")).to eq "/original_path/bin/something.exe"
-  end
-  it "should return the absolute path when the path to the exe is absolute" do
-    expect(proj_task.path_to( "/bin/something.exe", "./tmp/")).to eq "/bin/something.exe"
-  end
-end
-
-describe 'encoding functions' do
-  it 'should throw InvalidByteSequenceError by default' do
-    # http://www.ruby-doc.org/core-2.1.3/String.html#method-i-encode
-    begin
-      # it's "valid US-ASCII" from the POV of #encode unless
-      # #force_encoding is used
-      [0xef].pack('C*').force_encoding('US-ASCII').encode 'utf-8'
-      fail 'should throw invalid byte sequence error, because it\'s NOT US-ASCII'
-    rescue Encoding::InvalidByteSequenceError
-      # yep
-    end
-  end
-  it 'should be replaceable' do
-    subj =  [0xef].pack('C*').encode 'utf-8', undef: :replace, invalid: :replace, replace: ''
-    expect(subj).to eq ''
-  end
-end
+require 'albacore/nuget_model'

data/spec/paket_spec.rb

@@ -1,6 +1,6 @@
 require 'albacore/paket'
 
-describe Albacore::Paket do
+describe Albacore::Paket, "simple example" do
   let :file do
     %{NUGET
   remote: https://www.nuget.org/api/v2
@@ -20,10 +20,13 @@ describe Albacore::Paket do
     NuGet.CommandLine (2.8.5)
 }
   end
-  describe 'parsing paket.lock file' do
+  describe 'old lockfile' do
     let :references do
       Hash[subject.parse_paket_lock(file.split(/\n|\r\n/))]
     end
+    it 'has Aether' do
+      expect(references['Aether'].version).to eq '6.0'
+    end
     it 'has FParsec' do
       expect(references['FParsec'].version).to eq '1.0.1'
     end
@@ -48,3 +51,49 @@ describe Albacore::Paket do
     end
   end
 end
+
+describe Albacore::Paket, "netcore lockfile" do
+  let :path do
+    File.expand_path('../testdata/console-core-argu/paket.lock', __FILE__)
+  end
+
+  let :references do
+    arr = File.open(path, 'r') do |io|
+      Albacore::Paket.parse_paket_lock(io.readlines.map(&:chomp))
+    end
+    Hash[arr]
+  end
+
+  it "file exists" do
+    expect(File.exists?(path)).to be true
+  end
+
+  it "has items" do
+    expect(references.length).to_not be_zero
+  end
+
+  %w|Argu FSharp.Core|.each do |r|
+    it "has #{r}" do
+      expect(references[r]).to_not be_nil
+    end
+  end
+end
+
+describe Albacore::Paket, "dependencies file" do
+  let :path do
+    File.expand_path('../testdata/console-core-argu/paket.dependencies', __FILE__)
+  end
+
+  let :references do
+    arr = File.open(path, 'r') do |io|
+      Albacore::Paket.parse_dependencies_file(io.readlines.map(&:chomp))
+    end
+    Hash[arr.map{ |x| [x,x] }]
+  end
+
+  %w|Argu FSharp.Core|.each do |r|
+    it "has #{r}" do
+      expect(references[r]).to_not be_nil
+    end
+  end
+end

data/spec/project_spec.rb

@@ -3,58 +3,72 @@ require 'albacore/semver'
 require 'albacore/project'
 require 'albacore/paths'
 
-describe Albacore::Project, "when loading packages.config" do
+describe Albacore::Project do
   subject do
     p = File.expand_path('../testdata/Project/Project.fsproj', __FILE__)
     #puts "path: #{p}"
     Albacore.create_project(p)
   end
-  let :nlog do
-    subject.declared_packages.find { |p| p.id == 'NLog' }
-  end
 
-  it 'should have a guid' do
+  it 'has #guid' do
     expect(subject.guid).to match /^[A-F0-9]{8}(?:-[A-F0-9]{4}){3}-[A-F0-9]{12}$/i
   end
 
+  it 'has xmldoc?' do
+    expect(subject.xmldoc?).to be true
+  end
+
   it 'assumption: can gsub("[\{\}]", "")' do
     expect('{a}'.gsub(/[\{\}]/, '')).to eq 'a'
   end
 
-  it 'should have an OutputPath' do
-    expect(subject.output_path('Debug')).to_not be_nil
-  end
-  it 'should have the correct OutputPath' do
-    expect(subject.output_path('Debug')).to eq('bin\\Debug\\')
-  end
-  it 'should also have a Release OutputPath' do
-    expect(subject.output_path('Release')).to eq('bin\\Release\\')
-    expect(subject.try_output_path('Release')).to eq('bin\\Release\\')
-  end
-  it 'should raise "ConfigurationNotFoundEror" if not found' do
-    begin
-      subject.output_path('wazaaa')
-    rescue ::Albacore::ConfigurationNotFoundError
+  describe "#outputs" do
+    let :outputs do
+      subject.outputs 'Debug', 'net45'
+    end
+
+    it 'non-empty array' do
+      expect(outputs).to_not be_empty
+    end
+
+    it 'a DLL' do
+      expect(outputs).to include(
+        Albacore::OutputArtifact.new 'bin/Debug/Project.dll', Albacore::OutputArtifact::LIBRARY
+      )
+    end
+
+    it 'should raise "ConfigurationNotFoundEror" if not found' do
+      begin
+        subject.outputs('UNKNOWN_Configuration', 'net451')
+      rescue ::Albacore::ConfigurationNotFoundError
+      end
     end
   end
-  it 'should return nil with #try_output_path(conf)' do
-    expect(subject.try_output_path('weeeo')).to be_nil
-  end
-  it "should have three packages" do
-    expect(subject.declared_packages.length).to eq 3
-  end
-  it "should contain NLog" do
-    expect(nlog).to_not be_nil
-  end
-  it "should have a four number on NLog" do
-    expect(nlog.version).to eq("2.0.0.2000")
-  end
-  it "should have a semver number" do
-    expect(nlog.semver).to eq(Albacore::SemVer.new(2, 0, 0))
+
+  describe "#declared_packages" do
+    it "has three" do
+      expect(subject.declared_packages.length).to eq 3
+    end
+
+    let :nlog do
+      subject.declared_packages.find { |p| p.id == 'NLog' }
+    end
+
+    it "contains NLog" do
+      expect(nlog).to_not be_nil
+    end
+
+    it "should have a four number on NLog" do
+      expect(nlog.version).to eq("2.0.0.2000")
+    end
+
+    it "should have a semver number" do
+      expect(nlog.semver).to eq(Albacore::SemVer.new(2, 0, 0))
+    end
   end
 end
 
-describe Albacore::Project, "when reading project file" do
+describe Albacore::Project, "reading project file" do
   def project_path
     File.expand_path('../testdata/Project/Project.fsproj', __FILE__)
   end
@@ -62,14 +76,18 @@ describe Albacore::Project, "when reading project file" do
   subject do
     Albacore.create_project project_path
   end
+
   let :library1 do
     subject.included_files.find { |p| p.include == 'Library1.fs' }
   end
+
   it "should contain library1" do
     expect(library1).to_not be_nil
   end
+
   it 'should contain the target framework' do
-    expect(subject.target_framework).to eq "v4.5"
+    expect(subject.target_framework).to eq "net451"
+    expect(subject.target_frameworks).to eq %w|net451|
   end
   
   describe 'public API' do
@@ -100,33 +118,87 @@ describe Albacore::Project, "when reading project file" do
     it 'should have five referenced assemblies' do
       expect(subject.find_refs.length).to eq 5
     end
+
     it 'knows about referenced packages' do
       expect(subject).to respond_to :declared_packages
     end
+
     it 'knows about referenced projects' do
       expect(subject).to respond_to :declared_projects
     end
+
     it 'should have three referenced packages' do
       expected = %w|Intelliplan.Util Newtonsoft.Json NLog|
       expect(subject.find_packages.map(&:id)).to eq(expected)
     end
+  end
+end
 
-    # TODO: check whether output is DLL or EXE or something else
-    it 'should know its output dll' do
-      should respond_to :output_dll
-      expect(subject.output_dll('Release')).to eq(Paths.join 'bin', 'Release', 'Project.dll')
-    end
+describe Albacore::Project, "for netcore" do
+  def project_path
+    File.expand_path('../testdata/console-core-argu/ConsoleArgu.fsproj', __FILE__)
+  end
+
+  subject do
+    Albacore.create_project project_path
+  end
+
+  it "#id" do
+    expect(subject.id).to eq 'ConsoleArgu'
+  end
+
+  it "#name" do
+    expect(subject.name).to eq 'ConsoleArgu'
+  end
+
+  it "#asmname" do
+    expect(subject.asmname).to eq 'ConsoleArgu'
+  end
+
+  it "#proj_filename_noext" do
+    expect(subject.proj_filename_noext).to eq 'ConsoleArgu'
+  end
+
+  it '#netcore?' do
+    expect(subject.netcore?).to eq true
+  end
+
+  it '#target_frameworks' do
+    expect(subject.target_frameworks).to eq %w|netstandard2.0 net461|
+  end
+
+  it '#outputs' do
+    expected = [
+      Albacore::OutputArtifact.new(
+        'bin/Release/netstandard2.0/ConsoleArgu.dll',
+        Albacore::OutputArtifact::LIBRARY),
+
+      Albacore::OutputArtifact.new(
+        'bin/Release/netstandard2.0/ConsoleArgu.xml',
+        Albacore::OutputArtifact::XMLDOC)
+    ]
+    expect(subject.outputs('Release', 'netstandard2.0')).to eq expected
+  end
+
+  it '#paket_packages' do
+    dps = subject.declared_packages.group_by { |d| d.id }
+    expect(dps).to_not be_empty
+
+    h = Hash[dps]
+    expect(h).to_not be_empty
+    expect(h['FSharp.Core'].length).to eq(2)
+    expect(h['Argu'].length).to eq(2)
   end
 end
 
-describe Albacore::Project, 'when given a PathnameWrap' do
+describe Albacore::Project, 'with PathnameWrap' do
   it 'should allow argument of PathnameWrap' do
     require 'albacore/paths'
     Albacore.create_project(Paths::PathnameWrap.new(File.expand_path('../testdata/Project/Project.fsproj', __FILE__)))
   end
 end
-describe Albacore::Project do
 
+describe Albacore::Project, "with AssemblyInfo.cs" do
   it 'should read version from AssemblyInfo.cs' do
     p        = '../testdata/csharp/Exemplar/Exemplar/Exemplar.csproj'
     project  = Albacore.create_project(Paths::PathnameWrap.new(File.expand_path(p, __FILE__)))
@@ -134,6 +206,7 @@ describe Albacore::Project do
     expected = '1.0.0.0'
     expect(expected).to eq(result)
   end
+
   it 'should read version from AssemblyInfo.cs in ModifiedAssemblyVersion' do
     p        = '../testdata/csharp/ModifiedAssemblyVersion/ModifiedAssemblyVersion/ModifiedAssemblyVersion.csproj'
     project  = Albacore.create_project(Paths::PathnameWrap.new(File.expand_path(p, __FILE__)))
@@ -141,6 +214,7 @@ describe Albacore::Project do
     expected = '2.0.0.0'
     expect(expected).to eq(result)
   end
+
   it 'should return 1.0.0.0 when AssemblyVersion is not found' do
     p        = '../testdata/Project/Project.fsproj'
     project  = Albacore.create_project(Paths::PathnameWrap.new(File.expand_path(p, __FILE__)))
@@ -148,14 +222,15 @@ describe Albacore::Project do
     expected = '1.0.0.0'
     expect(expected).to eq(result)
   end
+
   it 'properties_path should return project base path if assemblyinfo not found' do
     p        = '../testdata/Project/Project.fsproj'
     project  = Albacore.create_project(Paths::PathnameWrap.new(File.expand_path(p, __FILE__)))
     result   = project.assembly_info_path
     expected = File.dirname(project.path)
     expect(expected).to eq(result)
-
   end
+
   it 'properties path should return project base path if both are equivalent' do
     p        = '../testdata/Project/Project.fsproj'
     project  = Albacore.create_project(Paths::PathnameWrap.new(File.expand_path(p, __FILE__)))