ajax_pagination 0.3.0 → 0.4.0

data/spec/SLOWPORT

@@ -0,0 +1 @@
+3002

data/spec/ajax_pagination/integration/ajaxpaginate_spec.rb

@@ -1,92 +1,142 @@
 require 'spec_helper'
 
 describe 'paginating with javascript on', :js => true do
+  def ajaxCount
+    page.evaluate_script("document.getElementById('countajaxloading').innerHTML").to_i # using javascript to get content because selenium cannot get content of non-visible elements
+  end
+
   it 'displays a loading image' do
     # following 3 lines to warm up loading image
-    visit("http://localhost:#{SERVERPORT}") # goes to welcome page
-    click_link 'About'
-    sleep(2)
+    visit("http://localhost:#{SERVERSLOWPORT}") # goes to welcome page
+    sleep(3)
+    click_link 'Changelog'
+    sleep(3)
 
-    visit("http://localhost:#{SERVERPORT}") # goes to welcome page
-    page.should have_no_selector('.ajaxloader')
-    sleep(1)
+    visit("http://localhost:#{SERVERSLOWPORT}") # goes to welcome page
+    page.should have_no_selector('.ajaxpagination-loader')
+    sleep(1.5)
     click_link 'About'
-    page.should have_selector('.ajaxloader')
-    sleep(1)
-    page.should have_no_selector('.ajaxloader')
+    page.should have_selector('.ajaxpagination-loader')
+    sleep(1.5)
+    page.should have_no_selector('.ajaxpagination-loader')
     click_link 'Readme'
-    page.should have_selector('.ajaxloader')
-    sleep(1)
-    page.should have_no_selector('.ajaxloader')
+    page.should have_selector('.ajaxpagination-loader')
+    sleep(1.5)
+    page.should have_no_selector('.ajaxpagination-loader')
   end
   it 'displays a loading image with nested and multiple paginated sections' do
-    visit("http://localhost:#{SERVERPORT}/changelog")
+    visit("http://localhost:#{SERVERSLOWPORT}/changelog")
+    sleep(2)
+    page.should have_selector('#changelogpagetitle')
     find('#_paginated_section').find('.next_page').click
-    page.should have_selector('.ajaxloader')
-    sleep(1)
-    page.should have_no_selector('.ajaxloader')
+    page.should have_selector('.ajaxpagination-loader')
+    sleep(1.5)
+    page.should have_no_selector('.ajaxpagination-loader')
     find('#signin').click
-    visit("http://localhost:#{SERVERPORT}/posts")
     sleep(2)
+    visit("http://localhost:#{SERVERSLOWPORT}/posts")
+    sleep(2)
+    page.should have_selector('#postspagetitle')
     find('#page_paginated_section').find('.next_page').click
-    page.should have_selector('.ajaxloader')
-    sleep(1)
-    page.should have_no_selector('.ajaxloader')
+    page.should have_selector('.ajaxpagination-loader')
+    sleep(1.5)
+    page.should have_no_selector('.ajaxpagination-loader')
     find('#upcomingpage_paginated_section').find('.next_page').click
-    page.should have_selector('.ajaxloader')
-    sleep(1)
-    page.should have_no_selector('.ajaxloader')
+    page.should have_selector('.ajaxpagination-loader')
+    sleep(1.5)
+    page.should have_no_selector('.ajaxpagination-loader')
   end
   it 'shows the configured loading image' do
-    visit("http://localhost:#{SERVERPORT}/changelog")
-    find('#_paginated_section').find('.next_page').click
-    page.should have_xpath("//img[@class='ajaxloader' and @src = '/assets/myajax-loader.gif']")
-    sleep(1)
-    visit("http://localhost:#{SERVERPORT}/posts")
-    find('#_paginated_section').find('.next_page').click
-    page.should have_xpath("//img[@class='ajaxloader' and @src = '/assets/ajax-loader.gif']")
+    # warmup images
+    visit("http://localhost:#{SERVERSLOWPORT}/changelog")
+    find('#page_paginated_section').find('.next_page').click
+    sleep(3)
+    visit("http://localhost:#{SERVERSLOWPORT}/posts")
+    find('#page_paginated_section').find('.next_page').click
+    sleep(3)
+
+
+    visit("http://localhost:#{SERVERSLOWPORT}/changelog")
+    find('#page_paginated_section').find('.next_page').click
+    page.should have_xpath("//img[@class='ajaxpagination-loader' and @src = '/assets/myajax-loader.gif']")
+    sleep(1.5)
+    visit("http://localhost:#{SERVERSLOWPORT}/posts")
+    find('#page_paginated_section').find('.next_page').click
+    page.should have_xpath("//img[@class='ajaxpagination-loader' and @src = '/assets/ajax-loader.gif']")
   end
   it 'works with browser back and forward buttons' do
+    visit("http://localhost:#{SERVERPORT}/pages/about") # warmup serverport
+    sleep(3)
+    page.should have_selector('#aboutpagetitle')
+
+    # actual test
     visit("http://localhost:#{SERVERPORT}/changelog")
-    find('#_paginated_section').find('.next_page').click
     sleep(1)
+    page.should have_selector('#changelogpagetitle')
     click_link 'About'
     sleep(1)
+    page.should have_selector('#aboutpagetitle')
     click_link 'Readme'
-    sleep(2)
-    page.should have_no_selector('.ajaxloader')
+    sleep(1)
     page.should have_selector('#readmepagetitle')
+    count = ajaxCount
     page.evaluate_script('window.history.back();') # back to About
-    page.should have_selector('.ajaxloader')
-    sleep(1)
-    page.should have_no_selector('.ajaxloader')
     page.should have_selector('#aboutpagetitle')
+    ajaxCount.should == count + 1
     page.evaluate_script('window.history.forward();') # forward to readme
-    sleep(1)
     page.should have_selector('#readmepagetitle')
-    page.evaluate_script('window.history.go(-2);') # back to changelog page 2
-    sleep(1)
+    page.evaluate_script('window.history.go(-2);') # back to changelog
     page.should have_no_selector('#aboutpagetitle')
     page.evaluate_script('window.history.forward();') # forward to about
+    page.should have_selector('#aboutpagetitle')
+  end
+  it 'has correct reload behaviour on history' do
+    visit("http://localhost:#{SERVERPORT}/pages/about")
+    sleep(3) # rbx has long warmup time
+    page.should have_selector('#aboutpagetitle')
+    click_link 'Readme' # History will have [about,readme]
     sleep(1)
+    page.should have_selector('#readmepagetitle')
+    click_link 'Readme' # should not add readme to history again - behaviour should be like a page refresh
+    sleep(0.5)
+    page.should have_no_selector('.ajaxpagination-loader')
+    page.evaluate_script('window.history.back();') # back to About (if readme not added to history twice)
     page.should have_selector('#aboutpagetitle')
   end
+  it 'has correct reload behaviour when jumping between history with the same url' do
+    visit("http://localhost:#{SERVERPORT}/pages/about")
+    sleep(3) # allow warmup time (zzz... rbx)
+    page.should have_selector('#aboutpagetitle')
+    click_link 'Readme' # History will have [about,readme]
+    sleep(1)
+    page.should have_selector('#readmepagetitle')
+    click_link 'About' # History will have [about,readme,about]
+    sleep(1)
+    page.should have_selector('#aboutpagetitle')
+    find("#aboutpagetitle").text.should_not == "ReloadReferenceToken"
+    page.evaluate_script('document.getElementById("aboutpagetitle").innerHTML = "ReloadReferenceToken";') # allows us to tell if it got reloaded
+    find("#aboutpagetitle").text.should == "ReloadReferenceToken"
+    page.evaluate_script('window.history.go(-2);') # back from about page to about page again
+
+    sleep(1)
+    find("#aboutpagetitle").text.should == "ReloadReferenceToken" # hasn't reloaded if token is still there
+  end
   it 'displays error pages within div' do
     visit("http://localhost:#{SERVERPORT}") # goes to welcome page
+    sleep(1)
     click_link("AJAX Pagination Example Application")
-    sleep(2)
     page.current_url.should == "http://localhost:#{SERVERPORT}/broken%20link"
     page.should have_content("AJAX Pagination Example Application")
     page.should have_content("No route matches")
   end
   it 'changes url to match redirection' do
     visit("http://localhost:#{SERVERPORT}")
+    sleep(1)
     click_link("Posts")
     sleep(1)
     page.should have_content("New Post")
     myurl = page.current_url # to get the canonical url
     click_link("New Post")
-    sleep(2)
     page.should have_content("Access Denied")
     page.current_url.should == myurl
   end
@@ -94,7 +144,6 @@ describe 'paginating with javascript on', :js => true do
     visit("http://localhost:#{SERVERPORT}/pages/about")
     count = page.find("#submits").html.to_i
     click_button("Submit")
-    sleep(1)
     page.should have_content("#{count+1} submit")
     page.should have_selector('#aboutpagetitle') # ensures loading was via AJAX Pagination
   end
@@ -103,11 +152,10 @@ describe 'paginating with javascript on', :js => true do
     myurl = page.current_url # to get the canonical url
     count = page.find("#submits").html.to_i
     click_button("Submit")
-    sleep(1)
     page.should have_content("#{count+1} submit")
     page.current_url.should == myurl # url remains the same (so history has not changed)
   end
-  it 'submits ajax_form_for form via POST and PUT and DELETE link' do
+  it 'submits ajax_form_for form via POST and DELETE link' do
     visit("http://localhost:#{SERVERPORT}")
     find('#signin').click
     click_link("Posts")
@@ -115,34 +163,48 @@ describe 'paginating with javascript on', :js => true do
     page.should have_content("New Post")
     myurl = page.current_url # to get the canonical url
     visit("http://localhost:#{SERVERPORT}/posts/new")
+    sleep(1)
     within("#new_post") do
       fill_in 'Title', :with => 'very unique title for test'
       fill_in 'Content', :with => 'my supercontent'
     end
+    count = ajaxCount
     click_button("Create Post");
-    page.should have_selector('.ajaxloader')
     sleep(2)
     page.should have_content("Post was successfully created.")
+    ajaxCount.should == count + 1
     page.current_url.should_not == myurl # means we have gotten redirected
-    click_link("Edit");
-    within(".edit_post") do
-      fill_in 'Content', :with => 'my supercontent again'
-    end
-    click_button("Update Post");
-    page.should have_selector('.ajaxloader')
-    sleep(2)
-    page.should have_content("my supercontent again")
+
+    count = ajaxCount
     click_link("Destroy");
     page.driver.browser.switch_to.alert.accept
-    page.should have_selector('.ajaxloader')
     sleep(2)
     page.should have_content("Post destroyed.")
+    ajaxCount.should == count + 1
   end
+  ## This spec does not work in rbx on travis.
+  ## Tested to work in rbx-1.2.4 on local machine. Also works using MRI ruby on travis.
+  #it 'submits ajax_form_for form via PUT link' do
+  #  visit("http://localhost:#{SERVERPORT}")
+  #  find('#signin').click
+  #  sleep(2)
+  #  visit("http://localhost:#{SERVERPORT}/posts/2")
+  #  click_link("Edit");
+  #  sleep(2)
+  #  within(".edit_post") do
+  #    fill_in 'Content', :with => 'some supercontent'
+  #  end
+  #  count = ajaxCount
+  #  click_button("Update Post");
+  #  sleep(3)
+  #  # page.should have_content("Post was successfully updated.") # does not work in rbx on travis (????)
+  #  page.should have_content("some supercontent")
+  #  ajaxCount.should == count + 1
+  #end
   it 'changes title' do
     visit("http://localhost:#{SERVERPORT}")
     title = page.evaluate_script("document.title") # because what is between the <title> tags and what is shown in the window title can differ (document.title gets set by javascript)
     click_link("About");
-    sleep(1)
     page.should have_selector('#aboutpagetitle') # ensures loading was via AJAX Pagination
     page.evaluate_script("document.title").should_not == title
   end

data/spec/ajax_pagination/integration/disabled_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe 'disabled with javascript', :js => true do
+  before :each do
+    visit("http://localhost:#{SERVERPORT}/pages/warnings")
+    find("#disablehistoryjslink").click
+    page.driver.browser.switch_to.alert.accept
+  end
+  it 'link within action still works' do
+    find("#fullpagelink").click
+    page.should have_content("You are on page 2")
+  end
+
+  it 'site navigation still works' do
+    click_link("Readme")
+    page.should have_selector('#readmepagetitle')
+  end
+end

data/spec/ajax_pagination/integration/paginate_spec.rb

@@ -20,10 +20,11 @@ describe 'paginating with javascript on', :type => :request, :driver => :seleniu
     visit("http://localhost:#{SERVERPORT}/posts")
     page.should have_selector('#page_paginated_section .previous_page.disabled')
     find('#page_paginated_section').find('.next_page').click
+    sleep(1)
     page.should have_no_selector('#page_paginated_section .previous_page.disabled')
     page.should have_selector('#upcomingpage_paginated_section .previous_page.disabled')
     find('#upcomingpage_paginated_section').find('.next_page').click
-    sleep(0.5)
+    sleep(1)
     page.should have_no_selector('#upcomingpage_paginated_section .previous_page.disabled')
     page.should have_no_selector('#page_paginated_section .previous_page.disabled')
   end

data/spec/ajax_pagination/integration/warnings_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+describe 'javascript warnings', :js => true do
+  it 'warns about excess page content' do
+    visit("http://localhost:#{SERVERPORT}/pages/warnings")
+    find("#fullpagelink").click
+    sleep(0.5)
+    alertmsg = page.driver.browser.switch_to.alert.text
+    alertmsg.should include("EXTRA_CONTENT_DISCARDED")
+    page.driver.browser.switch_to.alert.accept
+    page.should have_content("You are on page 2")
+  end
+
+  it 'warns about missing dependencies' do
+    visit("http://localhost:#{SERVERPORT}/pages/warnings")
+    find("#disablehistoryjslink").click
+    sleep(0.5)
+    alertmsg = page.driver.browser.switch_to.alert.text
+    alertmsg.should include("MISSING_DEPENDENCIES")
+    page.driver.browser.switch_to.alert.accept
+    page.should have_content("Disabled")
+  end
+
+  it 'warns about missing reference' do
+    visit("http://localhost:#{SERVERPORT}/pages/warnings")
+    find("#missingreferencelink").click
+    alertmsg = page.driver.browser.switch_to.alert.text
+    alertmsg.should include("MISSING_REFERENCE")
+    page.driver.browser.switch_to.alert.accept
+  end
+
+  it 'warns about reference to more than one section of same id' do
+    visit("http://localhost:#{SERVERPORT}/pages/warnings")
+    find("#doublesectionlink").click
+    alertmsg = page.driver.browser.switch_to.alert.text
+    alertmsg.should include("UNIQUE_SECTION_NOT_FOUND")
+    page.driver.browser.switch_to.alert.accept
+  end
+
+  it 'warns about reference to section which does not exist' do
+    visit("http://localhost:#{SERVERPORT}/pages/warnings")
+    find("#nosectionlink").click
+    alertmsg = page.driver.browser.switch_to.alert.text
+    alertmsg.should include("UNIQUE_SECTION_NOT_FOUND")
+    page.driver.browser.switch_to.alert.accept
+  end
+end

data/spec/rails_app/Gemfile

@@ -39,4 +39,4 @@ gem 'ajax_pagination', :path => "../.."
 # gem 'capistrano'
 
 # To use debugger
-gem 'ruby-debug'
+# gem 'ruby-debug' # requires MRI Ruby

data/spec/rails_app/app/assets/stylesheets/application.css

@@ -9,6 +9,7 @@
  * compiled file, but it's generally better to create a new file per style scope.
  *
  *= require_self
+ *= require ajax_pagination
  *= require_tree .
 */
 

data/spec/rails_app/app/controllers/application_controller.rb

@@ -3,8 +3,10 @@ class ApplicationController < ActionController::Base
   before_filter :slowajaxload
   ajax_pagination :pagination => "", :render => { :layout => "ajax" }
   def slowajaxload
-    if params[:pagination] && Rails.env == "test"
-      sleep(1)
+    if (request.GET[:pagination] || params[:pagination]) && Rails.env == "test"
+      delay = 0
+      delay = ENV['AJAX_DELAY'] if ENV['AJAX_DELAY']
+      sleep(delay.to_f)
     end
   end
 

data/spec/rails_app/app/controllers/pages_controller.rb

@@ -18,4 +18,11 @@ class PagesController < ApplicationController
       ajax_pagination format, :pagination => "", :render => { :layout => "ajax" }
     end
   end
+
+  def warnings
+    respond_to do |format|
+      format.html
+      ajax_pagination format, :pagination => "disable", :render => { :layout => "ajax" }
+    end
+  end
 end

data/spec/rails_app/app/views/changelog/index.html.erb

@@ -1,3 +1,3 @@
-<h2>Changelog</h2>
+<h2 id="changelogpagetitle">Changelog</h2>
 
 <%= ajax_pagination %>

data/spec/rails_app/app/views/layouts/application.html.erb

@@ -7,6 +7,18 @@
   <%= csrf_meta_tags %>
 </head>
 <body>
+<div id="countajaxloading" style="display: none;">0</div>
+<script type="text/javascript">
+$(document).ready(function () {
+  $(document).on("ajaxp:loading", function() { // increment hidden div every time something loads
+    $("#countajaxloading").text((parseInt($("#countajaxloading").text(),10) + 1).toString());
+  });
+});
+/*jQuery(document).ready(function () {
+  alert($.ajax_pagination.version);
+  $.ajax_pagination("").get("http://localhost:3000/pages/about");
+});*/
+</script>
 <div style="float: right;">
   <% if session[:admin] %>
     <%= link_to "Sign out", sessions_signout_url, :id => "signout" %>
@@ -26,6 +38,7 @@
     <li><%= link_to "Posts", posts_url %></li>
     <li><%= link_to "Changelog", changelog_url %></li>
     <li><%= link_to "Readme", pages_readme_url %></li>
+    <li><%= link_to "Warnings", pages_warnings_url %></li>
     <li><%= link_to "About", pages_about_url %></li>
   </ul>
 </div>

data/spec/rails_app/app/views/pages/warnings.html.erb

@@ -0,0 +1,43 @@
+
+This page gives examples of the warnings that may be given, from AJAX Pagination, when some configuration or otherwise is suboptimal, or prevents proper functioning of the gem.
+
+<%= content_tag :div, :style => "display: inline-block; width: 300px; height: 100px; border: 1px solid black; margin: 10px; padding: 10px; vertical-align: middle;" do %>
+  <%= ajax_pagination do %>
+    <p>You are on page <%= params[:page] ||= 1 %>.</p>
+
+    <p><%= ajax_link_to "Reload whole page just to refresh this content", pages_warnings_path(:page => (params[:page].to_i+1)), :pagination => "page", :id => "fullpagelink" %></p>
+  <% end %>
+<% end %>
+
+<%= content_tag :div, :style => "display: inline-block; width: 300px; height: 100px; border: 1px solid black; margin: 10px; padding: 10px; vertical-align: middle;" do %>
+  <p>AJAX Pagination Status: <%= raw (params[:disable] ||= false)?"<span style=\"color:red;\">Disabled":"<span style=\"color:green;\">Enabled" %></span></p>
+  <% if params[:disable] %>
+    <script type="text/javascript">History = null;</script>
+    <p><%= link_to "Enable History.js", pages_warnings_path %></p>
+  <% else %>
+    <p><%= link_to "Disable History.js", pages_warnings_path(:disable => true), :id => "disablehistoryjslink" %></p>
+  <% end %>
+  <p><i>Note: History.js is an AJAX Pagination dependency.</i></p>
+<% end %>
+
+<%= content_tag :div, :style => "display: inline-block; width: 300px; height: 100px; border: 1px solid black; margin: 10px; padding: 10px; vertical-align: middle;" do %>
+  <p>AJAX Links need to reference a valid pagination section, otherwise AJAX Pagination doesn't know where the new content should go.</p>
+  <p><%= ajax_link_to "Link without valid AJAX Pagination section", pages_warnings_path, :pagination => "RANDOM", :id => "nosectionlink" %></p>
+<% end %>
+
+<%= content_tag :div, :style => "display: inline-block; width: 300px; height: 100px; border: 1px solid black; margin: 10px; padding: 10px; vertical-align: middle;" do %>
+  <%= content_tag :div, :style => "border: 1px solid black; margin: 10px;" do %>
+    <%= ajax_pagination :pagination => "double" do %>My section name is "double".<% end %>
+  <% end %>
+  <%= content_tag :div, :style => "border: 1px solid black; margin: 10px;" do %>
+    <%= ajax_pagination :pagination => "double" do %>My section name is "double".<% end %>
+  <% end %>
+  <p><%= ajax_link_to "Load stuff in section named \"double\"", pages_warnings_path, :pagination => "double", :id => "doublesectionlink" %></p>
+<% end %>
+
+<%= content_tag :div, :class => "paginated_section", :style => "display: inline-block; width: 300px; height: 100px; border: 1px solid black; margin: 10px; padding: 10px; vertical-align: middle;" do %>
+  <%= content_tag :div, :class => "ajaxpagination" do %>
+    <p>If a link does not reference a section into which content can be loaded, AJAX will be cancelled, and the link will load in the whole window.</p>
+    <p><%= link_to "Link without reference to any section", pages_warnings_path, :id => "missingreferencelink" %></p>
+  <% end %>
+<% end %>