ajax-datatables-rails 1.3.0 → 1.4.0

data/spec/ajax-datatables-rails/orm/active_record_filter_records_spec.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-describe AjaxDatatablesRails::ORM::ActiveRecord do
+RSpec.describe AjaxDatatablesRails::ORM::ActiveRecord do
 
   let(:datatable) { ComplexDatatable.new(sample_params) }
   let(:records) { User.all }
 
   describe '#filter_records' do
     it 'requires a records collection as argument' do
-      expect { datatable.filter_records() }.to raise_error(ArgumentError)
+      expect { datatable.filter_records }.to raise_error(ArgumentError)
     end
 
     it 'performs a simple search first' do
@@ -24,14 +26,14 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
   end
 
   describe '#build_conditions' do
-    before(:each) do
+    before do
       create(:user, username: 'johndoe', email: 'johndoe@example.com')
       create(:user, username: 'msmith',  email: 'mary.smith@example.com')
       create(:user, username: 'hsmith',  email: 'henry.smith@example.net')
     end
 
     context 'with column and global search' do
-      before(:each) do
+      before do
         datatable.params[:search] = { value: 'example.com', regex: 'false' }
         datatable.params[:columns]['0'][:search][:value] = 'smith'
       end
@@ -47,7 +49,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
   end
 
   describe '#build_conditions_for_datatable' do
-    before(:each) do
+    before do
       create(:user, username: 'johndoe', email: 'johndoe@example.com')
       create(:user, username: 'msmith', email: 'mary.smith@example.com')
     end
@@ -66,12 +68,12 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
     end
 
     context 'when none of columns are connected' do
-      before(:each) do
+      before do
         allow(datatable).to receive(:searchable_columns) { [] }
       end
 
       context 'when search value is a string' do
-        before(:each) do
+        before do
           datatable.params[:search] = { value: 'msmith' }
         end
 
@@ -87,7 +89,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       end
 
       context 'when search value is space-separated string' do
-        before(:each) do
+        before do
           datatable.params[:search] = { value: 'foo bar' }
         end
 
@@ -105,7 +107,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
 
     context 'with search query' do
       context 'when search value is a string' do
-        before(:each) do
+        before do
           datatable.params[:search] = { value: 'john', regex: 'false' }
         end
 
@@ -118,7 +120,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       end
 
       context 'when search value is space-separated string' do
-        before(:each) do
+        before do
           datatable.params[:search] = { value: 'john doe', regex: 'false' }
         end
 
@@ -134,7 +136,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       context 'when column.search_query returns nil' do
         let(:datatable) { DatatableCondUnknown.new(sample_params) }
 
-        before(:each) do
+        before do
           datatable.params[:search] = { value: 'john doe', regex: 'false' }
         end
 
@@ -150,7 +152,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
   end
 
   describe '#build_conditions_for_selected_columns' do
-    before(:each) do
+    before do
       create(:user, username: 'johndoe', email: 'johndoe@example.com')
       create(:user, username: 'msmith', email: 'mary.smith@example.com')
     end
@@ -166,7 +168,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
         expect(result).to be_a(Arel::Nodes::And)
       end
 
-      if ENV['DB_ADAPTER'] == 'postgresql'
+      if RunningSpec.postgresql?
         context 'when db_adapter is postgresql' do
           it 'can call #to_sql on returned object' do
             result = datatable.build_conditions_for_selected_columns
@@ -178,7 +180,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
         end
       end
 
-      if ENV['DB_ADAPTER'] == 'oracle_enhanced'
+      if RunningSpec.oracle?
         context 'when db_adapter is oracle' do
           it 'can call #to_sql on returned object' do
             result = datatable.build_conditions_for_selected_columns
@@ -190,7 +192,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
         end
       end
 
-      if ENV['DB_ADAPTER'] == 'mysql2'
+      if RunningSpec.mysql?
         context 'when db_adapter is mysql2' do
           it 'can call #to_sql on returned object' do
             result = datatable.build_conditions_for_selected_columns
@@ -209,7 +211,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
     end
 
     context 'with search values in columns' do
-      before(:each) do
+      before do
         datatable.params[:columns]['0'][:search][:value] = 'doe'
       end
 
@@ -227,14 +229,14 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with condition :date_range' do
         let(:datatable) { DatatableCondDate.new(sample_params) }
 
-        before(:each) do
+        before do
           create(:user, username: 'johndoe', email: 'johndoe@example.com', last_name: 'Doe', created_at: '01/01/2000')
           create(:user, username: 'msmith', email: 'mary.smith@example.com', last_name: 'Smith', created_at: '01/02/2000')
         end
 
         context 'when range is empty' do
-          it 'should not filter records' do
-            datatable.params[:columns]['5'][:search][:value] = '-'
+          it 'does not filter records' do
+            datatable.params[:columns]['6'][:search][:value] = '-'
             expect(datatable.data.size).to eq 2
             item = datatable.data.first
             expect(item[:last_name]).to eq 'Doe'
@@ -242,31 +244,31 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
         end
 
         context 'when start date is filled' do
-          it 'should filter records created after this date' do
-            datatable.params[:columns]['5'][:search][:value] = '31/12/1999-'
+          it 'filters records created after this date' do
+            datatable.params[:columns]['6'][:search][:value] = '31/12/1999-'
             expect(datatable.data.size).to eq 2
           end
         end
 
         context 'when end date is filled' do
-          it 'should filter records created before this date' do
-            datatable.params[:columns]['5'][:search][:value] = '-31/12/1999'
+          it 'filters records created before this date' do
+            datatable.params[:columns]['6'][:search][:value] = '-31/12/1999'
             expect(datatable.data.size).to eq 0
           end
         end
 
         context 'when both date are filled' do
-          it 'should filter records created between the range' do
-            datatable.params[:columns]['5'][:search][:value] = '01/12/1999-15/01/2000'
+          it 'filters records created between the range' do
+            datatable.params[:columns]['6'][:search][:value] = '01/12/1999-15/01/2000'
             expect(datatable.data.size).to eq 1
           end
         end
 
         context 'when another filter is active' do
           context 'when range is empty' do
-            it 'should filter records' do
+            it 'filters records' do
               datatable.params[:columns]['0'][:search][:value] = 'doe'
-              datatable.params[:columns]['5'][:search][:value] = '-'
+              datatable.params[:columns]['6'][:search][:value] = '-'
               expect(datatable.data.size).to eq 1
               item = datatable.data.first
               expect(item[:last_name]).to eq 'Doe'
@@ -274,9 +276,9 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
           end
 
           context 'when start date is filled' do
-            it 'should filter records' do
+            it 'filters records' do
               datatable.params[:columns]['0'][:search][:value] = 'doe'
-              datatable.params[:columns]['5'][:search][:value] = '01/12/1999-'
+              datatable.params[:columns]['6'][:search][:value] = '01/12/1999-'
               expect(datatable.data.size).to eq 1
               item = datatable.data.first
               expect(item[:last_name]).to eq 'Doe'
@@ -284,9 +286,9 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
           end
 
           context 'when end date is filled' do
-            it 'should filter records' do
+            it 'filters records' do
               datatable.params[:columns]['0'][:search][:value] = 'doe'
-              datatable.params[:columns]['5'][:search][:value] = '-15/01/2000'
+              datatable.params[:columns]['6'][:search][:value] = '-15/01/2000'
               expect(datatable.data.size).to eq 1
               item = datatable.data.first
               expect(item[:last_name]).to eq 'Doe'
@@ -294,9 +296,9 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
           end
 
           context 'when both date are filled' do
-            it 'should filter records' do
+            it 'filters records' do
               datatable.params[:columns]['0'][:search][:value] = 'doe'
-              datatable.params[:columns]['5'][:search][:value] = '01/12/1999-15/01/2000'
+              datatable.params[:columns]['6'][:search][:value] = '01/12/1999-15/01/2000'
               expect(datatable.data.size).to eq 1
               item = datatable.data.first
               expect(item[:last_name]).to eq 'Doe'
@@ -307,16 +309,16 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
     end
 
     context 'numeric condition' do
+      before do
+        create(:user, first_name: 'john', post_id: 1)
+        create(:user, first_name: 'mary', post_id: 2)
+      end
+
       describe 'it can filter records with condition :eq' do
         let(:datatable) { DatatableCondEq.new(sample_params) }
 
-        before(:each) do
-          create(:user, first_name: 'john', post_id: 1)
-          create(:user, first_name: 'mary', post_id: 2)
-        end
-
-        it 'should filter records matching' do
-          datatable.params[:columns]['4'][:search][:value] = 1
+        it 'filters records matching' do
+          datatable.params[:columns]['5'][:search][:value] = 1
           expect(datatable.data.size).to eq 1
           item = datatable.data.first
           expect(item[:first_name]).to eq 'john'
@@ -326,13 +328,8 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with condition :not_eq' do
         let(:datatable) { DatatableCondNotEq.new(sample_params) }
 
-        before(:each) do
-          create(:user, first_name: 'john', post_id: 1)
-          create(:user, first_name: 'mary', post_id: 2)
-        end
-
-        it 'should filter records matching' do
-          datatable.params[:columns]['4'][:search][:value] = 1
+        it 'filters records matching' do
+          datatable.params[:columns]['5'][:search][:value] = 1
           expect(datatable.data.size).to eq 1
           item = datatable.data.first
           expect(item[:first_name]).to eq 'mary'
@@ -342,13 +339,8 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with condition :lt' do
         let(:datatable) { DatatableCondLt.new(sample_params) }
 
-        before(:each) do
-          create(:user, first_name: 'john', post_id: 1)
-          create(:user, first_name: 'mary', post_id: 2)
-        end
-
-        it 'should filter records matching' do
-          datatable.params[:columns]['4'][:search][:value] = 2
+        it 'filters records matching' do
+          datatable.params[:columns]['5'][:search][:value] = 2
           expect(datatable.data.size).to eq 1
           item = datatable.data.first
           expect(item[:first_name]).to eq 'john'
@@ -358,13 +350,8 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with condition :gt' do
         let(:datatable) { DatatableCondGt.new(sample_params) }
 
-        before(:each) do
-          create(:user, first_name: 'john', post_id: 1)
-          create(:user, first_name: 'mary', post_id: 2)
-        end
-
-        it 'should filter records matching' do
-          datatable.params[:columns]['4'][:search][:value] = 1
+        it 'filters records matching' do
+          datatable.params[:columns]['5'][:search][:value] = 1
           expect(datatable.data.size).to eq 1
           item = datatable.data.first
           expect(item[:first_name]).to eq 'mary'
@@ -374,13 +361,8 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with condition :lteq' do
         let(:datatable) { DatatableCondLteq.new(sample_params) }
 
-        before(:each) do
-          create(:user, first_name: 'john', post_id: 1)
-          create(:user, first_name: 'mary', post_id: 2)
-        end
-
-        it 'should filter records matching' do
-          datatable.params[:columns]['4'][:search][:value] = 2
+        it 'filters records matching' do
+          datatable.params[:columns]['5'][:search][:value] = 2
           expect(datatable.data.size).to eq 2
         end
       end
@@ -388,13 +370,8 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with condition :gteq' do
         let(:datatable) { DatatableCondGteq.new(sample_params) }
 
-        before(:each) do
-          create(:user, first_name: 'john', post_id: 1)
-          create(:user, first_name: 'mary', post_id: 2)
-        end
-
-        it 'should filter records matching' do
-          datatable.params[:columns]['4'][:search][:value] = 1
+        it 'filters records matching' do
+          datatable.params[:columns]['5'][:search][:value] = 1
           expect(datatable.data.size).to eq 2
         end
       end
@@ -402,13 +379,8 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with condition :in' do
         let(:datatable) { DatatableCondIn.new(sample_params) }
 
-        before(:each) do
-          create(:user, first_name: 'john', post_id: 1)
-          create(:user, first_name: 'mary', post_id: 2)
-        end
-
-        it 'should filter records matching' do
-          datatable.params[:columns]['4'][:search][:value] = [1]
+        it 'filters records matching' do
+          datatable.params[:columns]['5'][:search][:value] = [1]
           expect(datatable.data.size).to eq 1
           item = datatable.data.first
           expect(item[:first_name]).to eq 'john'
@@ -418,14 +390,9 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with condition :in with regex' do
         let(:datatable) { DatatableCondInWithRegex.new(sample_params) }
 
-        before(:each) do
-          create(:user, first_name: 'john', post_id: 1)
-          create(:user, first_name: 'mary', post_id: 2)
-        end
-
-        it 'should filter records matching' do
-          datatable.params[:columns]['4'][:search][:value] = '1|2'
-          datatable.params[:order]['0'] = { column: '4', dir: 'asc' }
+        it 'filters records matching' do
+          datatable.params[:columns]['5'][:search][:value] = '1|2'
+          datatable.params[:order]['0'] = { column: '5', dir: 'asc' }
           expect(datatable.data.size).to eq 2
           item = datatable.data.first
           expect(item[:first_name]).to eq 'john'
@@ -434,27 +401,27 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
 
       describe 'Integer overflows' do
         let(:datatable) { DatatableCondEq.new(sample_params) }
-        let(:largest_postgresql_integer_value) { 2147483647 }
-        let(:smallest_postgresql_integer_value) { -2147483648 }
+        let(:largest_postgresql_integer_value) { 2_147_483_647 }
+        let(:smallest_postgresql_integer_value) { -2_147_483_648 }
 
-        before(:each) do
+        before do
           create(:user, first_name: 'john', post_id: 1)
           create(:user, first_name: 'mary', post_id: 2)
           create(:user, first_name: 'phil', post_id: largest_postgresql_integer_value)
         end
 
-        it 'Returns an empty result if input value is too large' do
-          datatable.params[:columns]['4'][:search][:value] = largest_postgresql_integer_value + 1
+        it 'returns an empty result if input value is too large' do
+          datatable.params[:columns]['5'][:search][:value] = largest_postgresql_integer_value + 1
           expect(datatable.data.size).to eq 0
         end
 
-        it 'Returns an empty result if input value is too small' do
-          datatable.params[:columns]['4'][:search][:value] = smallest_postgresql_integer_value - 1
+        it 'returns an empty result if input value is too small' do
+          datatable.params[:columns]['5'][:search][:value] = smallest_postgresql_integer_value - 1
           expect(datatable.data.size).to eq 0
         end
 
         it 'returns the matching user' do
-          datatable.params[:columns]['4'][:search][:value] = largest_postgresql_integer_value
+          datatable.params[:columns]['5'][:search][:value] = largest_postgresql_integer_value
           expect(datatable.data.size).to eq 1
         end
       end
@@ -464,13 +431,13 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with lambda/proc condition' do
         let(:datatable) { DatatableCondProc.new(sample_params) }
 
-        before(:each) do
+        before do
           create(:user, username: 'johndoe', email: 'johndoe@example.com')
           create(:user, username: 'johndie', email: 'johndie@example.com')
           create(:user, username: 'msmith',  email: 'mary.smith@example.com')
         end
 
-        it 'should filter records matching' do
+        it 'filters records matching' do
           datatable.params[:columns]['0'][:search][:value] = 'john'
           expect(datatable.data.size).to eq 2
           item = datatable.data.first
@@ -483,12 +450,12 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with condition :start_with' do
         let(:datatable) { DatatableCondStartWith.new(sample_params) }
 
-        before(:each) do
+        before do
           create(:user, first_name: 'John')
           create(:user, first_name: 'Mary')
         end
 
-        it 'should filter records matching' do
+        it 'filters records matching' do
           datatable.params[:columns]['2'][:search][:value] = 'Jo'
           expect(datatable.data.size).to eq 1
           item = datatable.data.first
@@ -499,14 +466,14 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with condition :end_with' do
         let(:datatable) { DatatableCondEndWith.new(sample_params) }
 
-        before(:each) do
+        before do
           create(:user, last_name: 'JOHN')
           create(:user, last_name: 'MARY')
         end
 
-        if ENV['DB_ADAPTER'] == 'oracle_enhanced'
+        if RunningSpec.oracle?
           context 'when db_adapter is oracleenhanced' do
-            it 'should filter records matching' do
+            it 'filters records matching' do
               datatable.params[:columns]['3'][:search][:value] = 'RY'
               expect(datatable.data.size).to eq 1
               item = datatable.data.first
@@ -514,7 +481,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
             end
           end
         else
-          it 'should filter records matching' do
+          it 'filters records matching' do
             datatable.params[:columns]['3'][:search][:value] = 'ry'
             expect(datatable.data.size).to eq 1
             item = datatable.data.first
@@ -526,12 +493,12 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with condition :like' do
         let(:datatable) { DatatableCondLike.new(sample_params) }
 
-        before(:each) do
+        before do
           create(:user, email: 'john@foo.com')
           create(:user, email: 'mary@bar.com')
         end
 
-        it 'should filter records matching' do
+        it 'filters records matching' do
           datatable.params[:columns]['1'][:search][:value] = 'foo'
           expect(datatable.data.size).to eq 1
           item = datatable.data.first
@@ -542,12 +509,12 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with condition :string_eq' do
         let(:datatable) { DatatableCondStringEq.new(sample_params) }
 
-        before(:each) do
+        before do
           create(:user, email: 'john@foo.com')
           create(:user, email: 'mary@bar.com')
         end
 
-        it 'should filter records matching' do
+        it 'filters records matching' do
           datatable.params[:columns]['1'][:search][:value] = 'john@foo.com'
           expect(datatable.data.size).to eq 1
           item = datatable.data.first
@@ -558,20 +525,20 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with condition :string_in' do
         let(:datatable) { DatatableCondStringIn.new(sample_params) }
 
-        before(:each) do
+        before do
           create(:user, email: 'john@foo.com')
           create(:user, email: 'mary@bar.com')
           create(:user, email: 'henry@baz.com')
         end
 
-        it 'should filter records matching' do
+        it 'filters records matching' do
           datatable.params[:columns]['1'][:search][:value] = 'john@foo.com'
           expect(datatable.data.size).to eq 1
           item = datatable.data.first
           expect(item[:email]).to eq 'john@foo.com'
         end
 
-        it 'should filter records matching with multiple' do
+        it 'filters records matching with multiple' do
           datatable.params[:columns]['1'][:search][:value] = 'john@foo.com|henry@baz.com'
           expect(datatable.data.size).to eq 2
           items = datatable.data.sort_by { |h| h[:email] }
@@ -581,7 +548,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
           expect(item_last[:email]).to eq 'john@foo.com'
         end
 
-        it 'should filter records matching with multiple contains not found' do
+        it 'filters records matching with multiple contains not found' do
           datatable.params[:columns]['1'][:search][:value] = 'john@foo.com|henry_not@baz.com'
           expect(datatable.data.size).to eq 1
           item = datatable.data.first
@@ -592,13 +559,13 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       describe 'it can filter records with condition :null_value' do
         let(:datatable) { DatatableCondNullValue.new(sample_params) }
 
-        before(:each) do
+        before do
           create(:user, first_name: 'john', email: 'foo@bar.com')
           create(:user, first_name: 'mary', email: nil)
         end
 
         context 'when condition is NULL' do
-          it 'should filter records matching' do
+          it 'filters records matching' do
             datatable.params[:columns]['1'][:search][:value] = 'NULL'
             expect(datatable.data.size).to eq 1
             item = datatable.data.first
@@ -607,7 +574,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
         end
 
         context 'when condition is !NULL' do
-          it 'should filter records matching' do
+          it 'filters records matching' do
             datatable.params[:columns]['1'][:search][:value] = '!NULL'
             expect(datatable.data.size).to eq 1
             item = datatable.data.first
@@ -620,22 +587,44 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
     context 'unknown condition' do
       let(:datatable) { DatatableCondUnknown.new(sample_params) }
 
-      before(:each) do
+      before do
         datatable.params[:search] = { value: 'john doe', regex: 'false' }
       end
 
-      it 'should raise error' do
+      it 'raises error' do
         expect {
           datatable.data.size
         }.to raise_error(AjaxDatatablesRails::Error::InvalidSearchCondition).with_message('foo')
       end
     end
+
+    context 'custom column' do
+      describe 'it can filter records with custom column' do
+        let(:datatable) { DatatableCustomColumn.new(sample_params) }
+
+        before do
+          create(:user, username: 'msmith',  email: 'mary.smith@example.com', first_name: 'Mary', last_name: 'Smith')
+          create(:user, username: 'jsmith',  email: 'john.smith@example.com', first_name: 'John', last_name: 'Smith')
+          create(:user, username: 'johndoe', email: 'johndoe@example.com',    first_name: 'John', last_name: 'Doe')
+        end
+
+        it 'filters records' do
+          skip('unsupported database adapter') if RunningSpec.oracle? || RunningSpec.sqlite?
+
+          datatable.params[:columns]['4'][:search][:value] = 'John'
+          datatable.params[:order]['0'][:column] = '4'
+          expect(datatable.data.size).to eq 2
+          item = datatable.data.first
+          expect(item[:full_name]).to eq 'John Doe'
+        end
+      end
+    end
   end
 
   describe 'formatter option' do
     let(:datatable) { DatatableWithFormater.new(sample_params) }
 
-    before(:each) do
+    before do
       create(:user, username: 'johndoe', email: 'johndoe@example.com', last_name: 'DOE')
       create(:user, username: 'msmith', email: 'mary.smith@example.com', last_name: 'SMITH')
       datatable.params[:columns]['3'][:search][:value] = 'doe'

data/spec/ajax-datatables-rails/orm/active_record_paginate_records_spec.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-describe AjaxDatatablesRails::ORM::ActiveRecord do
+RSpec.describe AjaxDatatablesRails::ORM::ActiveRecord do
 
   let(:datatable) { ComplexDatatable.new(sample_params) }
   let(:records) { User.all }
 
-  before(:each) do
+  before do
     create(:user, username: 'johndoe', email: 'johndoe@example.com')
     create(:user, username: 'msmith', email: 'mary.smith@example.com')
   end
@@ -16,7 +18,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
     end
 
     it 'paginates records properly' do
-      if ENV['DB_ADAPTER'] == 'oracle_enhanced'
+      if RunningSpec.oracle?
         if Rails.version.in? %w[4.2.11]
           expect(datatable.paginate_records(records).to_sql).to include(
             'rownum <= 10'
@@ -34,7 +36,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
 
       datatable.params[:start] = '26'
       datatable.params[:length] = '25'
-      if ENV['DB_ADAPTER'] == 'oracle_enhanced'
+      if RunningSpec.oracle?
         if Rails.version.in? %w[4.2.11]
           expect(datatable.paginate_records(records).to_sql).to include(
             'rownum <= 51'

data/spec/ajax-datatables-rails/orm/active_record_sort_records_spec.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-describe AjaxDatatablesRails::ORM::ActiveRecord do
+RSpec.describe AjaxDatatablesRails::ORM::ActiveRecord do
 
   let(:datatable) { ComplexDatatable.new(sample_params) }
   let(:nulls_last_datatable) { DatatableOrderNullsLast.new(sample_params) }
   let(:records) { User.all }
 
-  before(:each) do
+  before do
     create(:user, username: 'johndoe', email: 'johndoe@example.com')
     create(:user, username: 'msmith', email: 'mary.smith@example.com')
   end
@@ -30,7 +32,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
       )
     end
 
-    it 'should not sort a column which is not orderable' do
+    it 'does not sort a column which is not orderable' do
       datatable.params[:order]['0'] = { column: '0', dir: 'asc' }
       datatable.params[:order]['1'] = { column: '4', dir: 'desc' }
 
@@ -49,7 +51,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
     after  { datatable.nulls_last = false }
 
     it 'can handle multiple sorting columns' do
-      skip('unsupported database adapter') if ENV['DB_ADAPTER'] == 'oracle_enhanced'
+      skip('unsupported database adapter') if RunningSpec.oracle?
 
       # set to order by Users username in ascending order, and
       # by Users email in descending order
@@ -63,7 +65,7 @@ describe AjaxDatatablesRails::ORM::ActiveRecord do
 
   describe '#sort_records with nulls last using column config' do
     it 'can handle multiple sorting columns' do
-      skip('unsupported database adapter') if ENV['DB_ADAPTER'] == 'oracle_enhanced'
+      skip('unsupported database adapter') if RunningSpec.oracle?
 
       # set to order by Users username in ascending order, and
       # by Users email in descending order