aixm 0.3.3 → 0.3.4

data/spec/lib/aixm/f_spec.rb

@@ -72,4 +72,14 @@ describe AIXM::F do
       { subject => true }[dupe].must_equal true
     end
   end
+
+  describe :zero? do
+    it "returns true for zero frequency" do
+      subject.tap { |s| s.freq = 0 }.must_be :zero?
+    end
+
+    it "returns false for non-zero frequency" do
+      subject.tap { |s| s.freq = 1 }.wont_be :zero?
+    end
+  end
 end

data/spec/lib/aixm/feature/address_spec.rb

@@ -0,0 +1,55 @@
+require_relative '../../../spec_helper'
+
+describe AIXM::Feature::Address do
+  subject do
+    AIXM::Factory.address
+  end
+
+  describe :type= do
+    it "fails on invalid values" do
+      -> { subject.type = :foobar }.must_raise ArgumentError
+      -> { subject.type = nil }.must_raise ArgumentError
+    end
+
+    it "looks up valid values" do
+      subject.tap { |s| s.type = :phone }.type.must_equal :phone
+      subject.tap { |s| s.type = :RADIO }.type.must_equal :radio_frequency
+    end
+  end
+
+  describe :remarks= do
+    macro :remarks
+  end
+
+  describe :xml= do
+    it "builds correct OFMX" do
+      AIXM.ofmx!
+      subject.to_xml(as: :Xxx, sequence: 1).must_equal <<~END
+        <!-- Address: RADIO -->
+        <Xxx source="LF|GEN|0.0 FACTORY|0|0">
+          <XxxUid>
+            <codeType>RADIO</codeType>
+            <noSeq>1</noSeq>
+          </XxxUid>
+          <txtAddress>123.35</txtAddress>
+          <txtRmk>A/A (callsign PUJAUT)</txtRmk>
+        </Xxx>
+      END
+    end
+
+    it "builds correct AIXM" do
+      AIXM.aixm!
+      subject = AIXM.address(type: :weather_url, address: 'https://www.foo.bar')
+      subject.to_xml(as: :Xxx, sequence: 1).must_equal <<~END
+        <!-- Address: URL-MET -->
+        <Xxx>
+          <XxxUid>
+            <codeType>URL</codeType>
+            <noSeq>1</noSeq>
+          </XxxUid>
+          <txtAddress>https://www.foo.bar</txtAddress>
+        </Xxx>
+      END
+    end
+  end
+end

data/spec/lib/aixm/feature/airport_spec.rb

@@ -13,6 +13,7 @@ describe AIXM::Feature::Airport do
         name: 'Avignon-Pujaut',
         xy: AIXM.xy(lat: %q(43°59'46"N), long: %q(004°45'16"E))
       )
+      subject.addresses.must_equal []
       subject.runways.must_equal []
       subject.helipads.must_equal []
       subject.usage_limitations.must_equal []
@@ -127,6 +128,18 @@ describe AIXM::Feature::Airport do
     macro :remarks
   end
 
+  describe :add_address do
+    it "fails on invalid arguments" do
+      -> { subject.add_address nil }.must_raise ArgumentError
+    end
+
+    it "adds address to the array" do
+      count = subject.addresses.count
+      subject.add_address(AIXM::Factory.address)
+      subject.addresses.count.must_equal count + 1
+    end
+  end
+
   describe :add_runway do
     it "fails on invalid arguments" do
       -> { subject.add_runway nil }.must_raise ArgumentError
@@ -181,6 +194,8 @@ describe AIXM::Feature::Airport do
   describe :to_xml do
     it "builds correct complete OFMX" do
       AIXM.ofmx!
+      subject.add_address(AIXM.address(source: "LF|GEN|0.0 FACTORY|0|0", type: :url, address: 'https://lfnt.tower.zone'))
+      subject.add_address(AIXM.address(source: "LF|GEN|0.0 FACTORY|0|0", type: :url, address: 'https://planeur-avignon-pujaut.fr'))
       subject.to_xml.must_equal <<~END
         <!-- Airport: LFNT AVIGNON-PUJAUT -->
         <Ahp source="LF|GEN|0.0 FACTORY|0|0">
@@ -214,7 +229,15 @@ describe AIXM::Feature::Airport do
           <valLen>650</valLen>
           <valWid>80</valWid>
           <uomDimRwy>M</uomDimRwy>
-          <codeComposition>GRADE</codeComposition>
+          <codeComposition>ASPH</codeComposition>
+          <codePreparation>PAVED</codePreparation>
+          <codeCondSfc>GOOD</codeCondSfc>
+          <valPcnClass>59</valPcnClass>
+          <codePcnPavementType>F</codePcnPavementType>
+          <codePcnPavementSubgrade>A</codePcnPavementSubgrade>
+          <codePcnMaxTirePressure>W</codePcnMaxTirePressure>
+          <codePcnEvalMethod>T</codePcnEvalMethod>
+          <txtPcnNote>Paved shoulder on 2.5m on each side of the RWY.</txtPcnNote>
           <codeSts>CLSD</codeSts>
           <txtRmk>Markings eroded</txtRmk>
         </Rwy>
@@ -232,8 +255,9 @@ describe AIXM::Feature::Airport do
           <geoLong>004.75216944E</geoLong>
           <valTrueBrg>165</valTrueBrg>
           <valMagBrg>166</valMagBrg>
-          <valElevTdz>147</valElevTdz>
+          <valElevTdz>145</valElevTdz>
           <uomElevTdz>FT</uomElevTdz>
+          <codeVfrPattern>E</codeVfrPattern>
           <txtRmk>forth remarks</txtRmk>
         </Rdn>
         <Rdd>
@@ -268,6 +292,9 @@ describe AIXM::Feature::Airport do
           <geoLong>004.75645556E</geoLong>
           <valTrueBrg>345</valTrueBrg>
           <valMagBrg>346</valMagBrg>
+          <valElevTdz>147</valElevTdz>
+          <uomElevTdz>FT</uomElevTdz>
+          <codeVfrPattern>L</codeVfrPattern>
           <txtRmk>back remarks</txtRmk>
         </Rdn>
         <Rdd>
@@ -303,7 +330,15 @@ describe AIXM::Feature::Airport do
           <valLen>20</valLen>
           <valWid>20</valWid>
           <uomDim>M</uomDim>
-          <codeComposition>GRASS</codeComposition>
+          <codeComposition>CONC</codeComposition>
+          <codePreparation>PAVED</codePreparation>
+          <codeCondSfc>FAIR</codeCondSfc>
+          <valPcnClass>30</valPcnClass>
+          <codePcnPavementType>F</codePcnPavementType>
+          <codePcnPavementSubgrade>A</codePcnPavementSubgrade>
+          <codePcnMaxTirePressure>W</codePcnMaxTirePressure>
+          <codePcnEvalMethod>U</codePcnEvalMethod>
+          <txtPcnNote>Cracks near the center.</txtPcnNote>
           <codeSts>OTHER</codeSts>
           <txtRmk>Authorizaton by AD operator required</txtRmk>
         </Tla>
@@ -334,12 +369,47 @@ describe AIXM::Feature::Airport do
             <txtRmk>reservation remarks</txtRmk>
           </UsageLimitation>
         </Ahu>
+        <!-- Address: RADIO for LFNT -->
+        <Aha source="LF|GEN|0.0 FACTORY|0|0">
+          <AhaUid>
+            <AhpUid>
+              <codeId>LFNT</codeId>
+            </AhpUid>
+            <codeType>RADIO</codeType>
+            <noSeq>1</noSeq>
+          </AhaUid>
+          <txtAddress>123.35</txtAddress>
+          <txtRmk>A/A (callsign PUJAUT)</txtRmk>
+        </Aha>
+        <!-- Address: URL for LFNT -->
+        <Aha source="LF|GEN|0.0 FACTORY|0|0">
+          <AhaUid>
+            <AhpUid>
+              <codeId>LFNT</codeId>
+            </AhpUid>
+            <codeType>URL</codeType>
+            <noSeq>1</noSeq>
+          </AhaUid>
+          <txtAddress>https://lfnt.tower.zone</txtAddress>
+        </Aha>
+        <!-- Address: URL for LFNT -->
+        <Aha source="LF|GEN|0.0 FACTORY|0|0">
+          <AhaUid>
+            <AhpUid>
+              <codeId>LFNT</codeId>
+            </AhpUid>
+            <codeType>URL</codeType>
+            <noSeq>2</noSeq>
+          </AhaUid>
+          <txtAddress>https://planeur-avignon-pujaut.fr</txtAddress>
+        </Aha>
       END
     end
 
     it "builds correct minimal OFMX" do
       AIXM.ofmx!
       subject.z = subject.declination = subject.transition_z = subject.remarks = nil
+      subject.instance_variable_set(:'@addresses', [])
       subject.instance_variable_set(:'@runways', [])
       subject.instance_variable_set(:'@helipads', [])
       subject.instance_variable_set(:'@usage_limitations', [])

data/spec/lib/aixm/feature/navigational_aid/designated_point_spec.rb

@@ -12,13 +12,23 @@ describe AIXM::Feature::NavigationalAid::DesignatedPoint do
 
     it "looks up valid values" do
       subject.tap { |s| s.type = :icao }.type.must_equal :icao
-      subject.tap { |s| s.type = :OTHER }.type.must_equal :other
+      subject.tap { |s| s.type = :'VFR-RP' }.type.must_equal :vfr_reporting_point
+    end
+  end
+
+  describe :airport= do
+    it "fails on invalid values" do
+      [:foobar, 123].wont_be_written_to subject, :airport
+    end
+
+    it "accepts valid values" do
+      [nil, AIXM::Factory.airport].must_be_written_to subject, :airport
     end
   end
 
   describe :kind do
     it "must return class/type combo" do
-      subject.kind.must_equal "DesignatedPoint:ICAO"
+      subject.kind.must_equal "DesignatedPoint:VFR-RP"
     end
   end
 
@@ -26,15 +36,18 @@ describe AIXM::Feature::NavigationalAid::DesignatedPoint do
     it "builds correct complete OFMX" do
       AIXM.ofmx!
       subject.to_xml.must_equal <<~END
-        <!-- NavigationalAid: [DesignatedPoint:ICAO] DESIGNATED POINT NAVAID -->
+        <!-- NavigationalAid: [DesignatedPoint:VFR-RP] DDD / DESIGNATED POINT NAVAID -->
         <Dpn source="LF|GEN|0.0 FACTORY|0|0">
           <DpnUid>
             <codeId>DDD</codeId>
             <geoLat>47.85916667N</geoLat>
             <geoLong>007.56000000E</geoLong>
           </DpnUid>
+          <AhpUidAssoc>
+            <codeId>LFNT</codeId>
+          </AhpUidAssoc>
           <codeDatum>WGE</codeDatum>
-          <codeType>ICAO</codeType>
+          <codeType>VFR-RP</codeType>
           <txtName>DESIGNATED POINT NAVAID</txtName>
           <txtRmk>designated point navaid</txtRmk>
         </Dpn>
@@ -45,15 +58,39 @@ describe AIXM::Feature::NavigationalAid::DesignatedPoint do
       AIXM.ofmx!
       subject.name = subject.remarks = nil
       subject.to_xml.must_equal <<~END
-        <!-- NavigationalAid: [DesignatedPoint:ICAO] UNNAMED -->
+        <!-- NavigationalAid: [DesignatedPoint:VFR-RP] DDD -->
         <Dpn source="LF|GEN|0.0 FACTORY|0|0">
           <DpnUid>
             <codeId>DDD</codeId>
             <geoLat>47.85916667N</geoLat>
             <geoLong>007.56000000E</geoLong>
           </DpnUid>
+          <AhpUidAssoc>
+            <codeId>LFNT</codeId>
+          </AhpUidAssoc>
+          <codeDatum>WGE</codeDatum>
+          <codeType>VFR-RP</codeType>
+        </Dpn>
+      END
+    end
+
+    it "builds correct complete OFMX" do
+      AIXM.aixm!
+      subject.to_xml.must_equal <<~END
+        <!-- NavigationalAid: [DesignatedPoint:VFR-RP] DDD / DESIGNATED POINT NAVAID -->
+        <Dpn>
+          <DpnUid>
+            <codeId>DDD</codeId>
+            <geoLat>475133.00N</geoLat>
+            <geoLong>0073336.00E</geoLong>
+          </DpnUid>
+          <AhpUidAssoc>
+            <codeId>LFNT</codeId>
+          </AhpUidAssoc>
           <codeDatum>WGE</codeDatum>
-          <codeType>ICAO</codeType>
+          <codeType>OTHER</codeType>
+          <txtName>DESIGNATED POINT NAVAID</txtName>
+          <txtRmk>designated point navaid</txtRmk>
         </Dpn>
       END
     end

data/spec/lib/aixm/feature/navigational_aid/dme_spec.rb

@@ -42,7 +42,7 @@ describe AIXM::Feature::NavigationalAid::DME do
     it "builds correct complete OFMX" do
       AIXM.ofmx!
       subject.to_xml.must_equal <<~END
-        <!-- NavigationalAid: [DME] DME NAVAID -->
+        <!-- NavigationalAid: [DME] MMM / DME NAVAID -->
         <Dme source="LF|GEN|0.0 FACTORY|0|0">
           <DmeUid>
             <codeId>MMM</codeId>
@@ -71,7 +71,7 @@ describe AIXM::Feature::NavigationalAid::DME do
       AIXM.ofmx!
       subject.name = subject.z = subject.timetable = subject.remarks = nil
       subject.to_xml.must_equal <<~END
-        <!-- NavigationalAid: [DME] UNNAMED -->
+        <!-- NavigationalAid: [DME] MMM -->
         <Dme source="LF|GEN|0.0 FACTORY|0|0">
           <DmeUid>
             <codeId>MMM</codeId>

data/spec/lib/aixm/feature/navigational_aid/marker_spec.rb

@@ -30,7 +30,7 @@ describe AIXM::Feature::NavigationalAid::Marker do
     it "builds correct complete OFMX" do
       AIXM.ofmx!
       subject.to_xml.must_equal <<~END
-        <!-- NavigationalAid: [Marker:O] MARKER NAVAID -->
+        <!-- NavigationalAid: [Marker:O] --- / MARKER NAVAID -->
         <Mkr source="LF|GEN|0.0 FACTORY|0|0">
           <MkrUid>
             <codeId>---</codeId>
@@ -59,7 +59,7 @@ describe AIXM::Feature::NavigationalAid::Marker do
       AIXM.ofmx!
       subject.type = subject.name = subject.z = subject.timetable = subject.remarks = nil
       subject.to_xml.must_equal <<~END
-        <!-- NavigationalAid: [Marker] UNNAMED -->
+        <!-- NavigationalAid: [Marker] --- -->
         <Mkr source="LF|GEN|0.0 FACTORY|0|0">
           <MkrUid>
             <codeId>---</codeId>

data/spec/lib/aixm/feature/navigational_aid/ndb_spec.rb

@@ -40,7 +40,7 @@ describe AIXM::Feature::NavigationalAid::NDB do
     it "builds correct complete OFMX" do
       AIXM.ofmx!
       subject.to_xml.must_equal <<~END
-        <!-- NavigationalAid: [NDB:B] NDB NAVAID -->
+        <!-- NavigationalAid: [NDB:B] NNN / NDB NAVAID -->
         <Ndb source="LF|GEN|0.0 FACTORY|0|0">
           <NdbUid>
             <codeId>NNN</codeId>
@@ -69,7 +69,7 @@ describe AIXM::Feature::NavigationalAid::NDB do
       AIXM.ofmx!
       subject.name = subject.type = subject.z = subject.timetable = subject.remarks = nil
       subject.to_xml.must_equal <<~END
-        <!-- NavigationalAid: [NDB] UNNAMED -->
+        <!-- NavigationalAid: [NDB] NNN -->
         <Ndb source="LF|GEN|0.0 FACTORY|0|0">
           <NdbUid>
             <codeId>NNN</codeId>

data/spec/lib/aixm/feature/navigational_aid/tacan_spec.rb

@@ -38,7 +38,7 @@ describe AIXM::Feature::NavigationalAid::TACAN do
     it "builds correct complete OFMX" do
       AIXM.ofmx!
       subject.to_xml.must_equal <<~END
-        <!-- NavigationalAid: [TACAN] TACAN NAVAID -->
+        <!-- NavigationalAid: [TACAN] TTT / TACAN NAVAID -->
         <Tcn source="LF|GEN|0.0 FACTORY|0|0">
           <TcnUid>
             <codeId>TTT</codeId>
@@ -67,7 +67,7 @@ describe AIXM::Feature::NavigationalAid::TACAN do
       AIXM.ofmx!
       subject.name = subject.z = subject.timetable = subject.remarks = nil
       subject.to_xml.must_equal <<~END
-        <!-- NavigationalAid: [TACAN] UNNAMED -->
+        <!-- NavigationalAid: [TACAN] TTT -->
         <Tcn source="LF|GEN|0.0 FACTORY|0|0">
           <TcnUid>
             <codeId>TTT</codeId>

data/spec/lib/aixm/feature/navigational_aid/vor_spec.rb

@@ -48,7 +48,7 @@ describe AIXM::Feature::NavigationalAid::VOR do
       it "builds correct complete OFMX" do
         AIXM.ofmx!
         subject.to_xml.must_equal <<~END
-          <!-- NavigationalAid: [VOR:VOR] VOR NAVAID -->
+          <!-- NavigationalAid: [VOR:VOR] VVV / VOR NAVAID -->
           <Vor source="LF|GEN|0.0 FACTORY|0|0">
             <VorUid>
               <codeId>VVV</codeId>
@@ -78,7 +78,7 @@ describe AIXM::Feature::NavigationalAid::VOR do
         AIXM.ofmx!
         subject.name = subject.z = subject.timetable = subject.remarks = nil
         subject.to_xml.must_equal <<~END
-          <!-- NavigationalAid: [VOR:VOR] UNNAMED -->
+          <!-- NavigationalAid: [VOR:VOR] VVV -->
           <Vor source="LF|GEN|0.0 FACTORY|0|0">
             <VorUid>
               <codeId>VVV</codeId>
@@ -118,7 +118,7 @@ describe AIXM::Feature::NavigationalAid::VOR do
       it "builds correct OFMX" do
         AIXM.ofmx!
         subject.to_xml.must_equal <<~END
-          <!-- NavigationalAid: [VOR:VOR] VOR/DME NAVAID -->
+          <!-- NavigationalAid: [VOR:VOR] VVV / VOR/DME NAVAID -->
           <Vor source="LF|GEN|0.0 FACTORY|0|0">
             <VorUid>
               <codeId>VVV</codeId>
@@ -141,7 +141,7 @@ describe AIXM::Feature::NavigationalAid::VOR do
             </Vtt>
             <txtRmk>vor/dme navaid</txtRmk>
           </Vor>
-          <!-- NavigationalAid: [DME] VOR/DME NAVAID -->
+          <!-- NavigationalAid: [DME] VVV / VOR/DME NAVAID -->
           <Dme>
             <DmeUid>
               <codeId>VVV</codeId>
@@ -190,7 +190,7 @@ describe AIXM::Feature::NavigationalAid::VOR do
       it "builds correct OFMX" do
         AIXM.ofmx!
         subject.to_xml.must_equal <<~END
-          <!-- NavigationalAid: [VOR:VOR] VORTAC NAVAID -->
+          <!-- NavigationalAid: [VOR:VOR] VVV / VORTAC NAVAID -->
           <Vor source="LF|GEN|0.0 FACTORY|0|0">
             <VorUid>
               <codeId>VVV</codeId>
@@ -213,7 +213,7 @@ describe AIXM::Feature::NavigationalAid::VOR do
             </Vtt>
             <txtRmk>vortac navaid</txtRmk>
           </Vor>
-          <!-- NavigationalAid: [TACAN] VORTAC NAVAID -->
+          <!-- NavigationalAid: [TACAN] VVV / VORTAC NAVAID -->
           <Tcn>
             <TcnUid>
               <codeId>VVV</codeId>

data/spec/lib/aixm/{component → feature}/service_spec.rb

@@ -1,31 +1,19 @@
 require_relative '../../../spec_helper'
 
-describe AIXM::Component::Service do
+describe AIXM::Feature::Service do
   subject do
     AIXM::Factory.service
   end
 
   describe :initialize do
     it "sets defaults" do
-      subject = AIXM::Component::Service.new(
-        name: "PUJAUT TOWER",
+      subject = AIXM::Feature::Service.new(
         type: :approach_control_service
       )
       subject.frequencies.must_equal []
     end
   end
 
-  describe :name= do
-    it "fails on invalid values" do
-      -> { subject.name = :foobar }.must_raise ArgumentError
-      -> { subject.name = nil }.must_raise ArgumentError
-    end
-
-    it "upcases and transcodes valid values" do
-      subject.tap { |s| s.name = 'Nîmes-Alès' }.name.must_equal 'NIMES-ALES'
-    end
-  end
-
   describe :type= do
     it "fails on invalid values" do
       -> { subject.type = :foobar }.must_raise ArgumentError
@@ -58,4 +46,14 @@ describe AIXM::Component::Service do
     end
   end
 
+  describe :guess_unit_type do
+    it "finds the probably unit type for a matchable service" do
+      subject.tap { |s| s.type = :flight_information_service }.guessed_unit_type.must_equal :flight_information_centre
+    end
+
+    it "returns nil for an unmatchable service" do
+      subject.tap { |s| s.type = :aeronautical_mobile_satellite_service }.guessed_unit_type.must_be_nil
+    end
+  end
+
 end