aitch 1.2.2 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c49091163504e6a6587170951f8e4545b4474b1912c85c5bcfeb102763a214b7
-  data.tar.gz: 7fac91b61ee9ad82e8f880f25758b9f6a433ad8ed3bcc5134b261e64f5da61fc
+  metadata.gz: ac06612095a2a08635037c6113a7cb93ce1e22463192ba8f1381e1c7b5657f85
+  data.tar.gz: 50b0cfb79bc02cf46ff4f4fd4b762fd06bb44d577c6c6afd9640f1a0141f3dfd
 SHA512:
-  metadata.gz: 859bdbfb5f70d99646c628f16a2cea718385299ca1b48d32e0ecfb8c9598ad27b8cf3363498b50eaddf8585901212faa1f588dc9dc29ad1982891f2a3c26b1fa
-  data.tar.gz: a7045d8d2a6c9d172b2b90180cd4d2afb13a5ceac088b74b9cb7ccc63fa9050920df69310e0eef1ae745b44d0edd4c45f6779c9a6fe420c3951878be4ff3fbf1
+  metadata.gz: cfc6752814d6b44d4cf455a8cbb269cf8aaabcf3afa6379e34e7fae3a2bc53f2a3218ec33537a05bc8c5cf50c442f95cb126b0f011452caa811f9c2e74c4df5d
+  data.tar.gz: b2b1bee33eca007e77e36d687476eb8b3c34f6fa0d5d9d434feabeddef13a42a23bddabe2122000a47d5514b3b16581195cbd9f8fc5d4330dfe6b771c38346c1

data/.github/workflows/tests.yml

@@ -15,12 +15,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ["2.7.x", "2.6.x", "2.5.x", "3.0.x", "3.1.x"]
+        ruby: ["3.0", "3.1", "3.2"]
 
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v4
 
-      - uses: actions/cache@v2
+      - uses: actions/cache@v3
         with:
           path: vendor/bundle
           key: >
@@ -31,7 +31,7 @@ jobs:
             hashFiles('aitch.gemspec') }}
 
       - name: Set up Ruby
-        uses: actions/setup-ruby@v1
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
 

data/.rubocop.yml

@@ -3,7 +3,7 @@ inherit_gem:
   rubocop-fnando: .rubocop.yml
 
 AllCops:
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 3.0
   NewCops: enable
 
 Layout/LineLength:

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+- **2.0.0**
+  - Fix error when content type is not available on response.
+  - Stop supporting old ruby versions (require 3.0+).
 - **1.2.2**
   - Transform header key before assigning values.
 - **1.2.1**

data/README.md

@@ -1,6 +1,6 @@
 # Aitch
 
-[![Tests](https://github.com/fnando/aitch/workflows/Tests/badge.svg)](https://github.com/fnando/aitch)
+[![Tests](https://github.com/fnando/aitch/actions/workflows/tests.yml/badge.svg)](https://github.com/fnando/aitch/actions/workflows/tests.yml)
 [![Code Climate](https://codeclimate.com/github/fnando/aitch/badges/gpa.svg)](https://codeclimate.com/github/fnando/aitch)
 [![Gem Version](https://img.shields.io/gem/v/aitch.svg)](https://rubygems.org/gems/aitch)
 [![Gem Downloads](https://img.shields.io/gem/dt/aitch.svg)](https://rubygems.org/gems/aitch)

data/aitch.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
   spec.summary       = spec.description
   spec.homepage      = "http://rubygems.org/gems/aitch"
   spec.license       = "MIT"
-  spec.required_ruby_version = Gem::Requirement.new(">= 2.5.0")
+  spec.required_ruby_version = Gem::Requirement.new(">= 3.0.0")
   spec.metadata["rubygems_mfa_required"] = "true"
 
   spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)

data/lib/aitch/ext/to_query.rb

@@ -70,11 +70,11 @@ class Hash
   #
   # This method is also aliased as +to_param+.
   def to_query(namespace = nil)
-    collect do |key, value|
+    filter_map do |key, value|
       unless (value.is_a?(Hash) || value.is_a?(Array)) && value.empty?
         value.to_query(namespace ? "#{namespace}[#{key}]" : key)
       end
-    end.compact.sort! * "&"
+    end.sort! * "&"
   end
 
   alias to_param to_query

data/lib/aitch/location.rb

@@ -2,7 +2,7 @@
 
 module Aitch
   class Location
-    MATCHER = %r{\A/}.freeze
+    MATCHER = %r{\A/}
 
     attr_reader :redirect_stack, :current_url
 

data/lib/aitch/request.rb

@@ -9,8 +9,8 @@ module Aitch
     ACCEPT_ENCODING = "Accept-Encoding"
     GZIP_DEFLATE = "gzip,deflate"
     HTTPS = "https"
-    HEADER_SEPARATOR_RE = /[-_]/.freeze
-    JSON_RE = /\bjson\b/.freeze
+    HEADER_SEPARATOR_RE = /[-_]/
+    JSON_RE = /\bjson\b/
 
     alias params= data=
     alias body= data=
@@ -102,7 +102,7 @@ module Aitch
       all_headers = options.fetch(:default_headers, {}).merge(headers)
 
       all_headers.each do |name, value|
-        value = value.respond_to?(:call) ? value.call : value
+        value = value.call if value.respond_to?(:call)
         name = name.to_s.split(HEADER_SEPARATOR_RE).map(&:capitalize).join("-")
         request[name] = value.to_s
       end

data/lib/aitch/response.rb

@@ -2,8 +2,6 @@
 
 module Aitch
   class Response
-    extend Forwardable
-
     JSON_STR = "json"
     XML_STR = "xml"
     HTML_STR = "html"
@@ -11,10 +9,9 @@ module Aitch
     DOUBLE_COLON = "::"
     SPACE_STR = " "
     ERROR_SUFFIX = "_error"
-    X_RE = /^x-/.freeze
+    X_RE = /^x-/
 
-    def_delegators :@http_response, :content_type
-    attr_accessor :redirected_from, :url
+    attr_accessor :redirected_from, :url, :content_type
 
     def self.description_for_code(code)
       [code, DESCRIPTION[code]].compact.join(SPACE_STR)
@@ -24,6 +21,7 @@ module Aitch
       @options = options
       @http_response = http_response
       @redirected_from = options.fetch(:redirected_from, [])
+      @content_type = http_response.content_type.to_s
     end
 
     ERRORS.each do |status_code, exception|

data/lib/aitch/utils.rb

@@ -4,7 +4,7 @@ module Aitch
   module Utils
     extend self
 
-    MATCHER = /(?<=.)(URI|[A-Z])/.freeze
+    MATCHER = /(?<=.)(URI|[A-Z])/
 
     def underscore(string)
       string = string.gsub(MATCHER) do |char|

data/lib/aitch/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Aitch
-  VERSION = "1.2.2"
+  VERSION = "2.0.0"
 end

data/test/aitch/request_test.rb

@@ -150,7 +150,7 @@ class RequestTest < Minitest::Test
 
   test "sets basic auth credentials" do
     request = build_request(options: {user: "USER", password: "PASS"}).request
-    credentials = Base64.decode64(request["Authorization"].gsub(/Basic /, ""))
+    credentials = Base64.decode64(request["Authorization"].gsub("Basic ", ""))
 
     assert_equal "USER:PASS", credentials
   end

data/test/aitch/response/errors_test.rb

@@ -8,7 +8,7 @@ class ErrorsTest < Minitest::Test
 
     test "detects response as #{name}" do
       config = {}
-      http_response = stub(code: code)
+      http_response = stub(code: code, content_type: "text/html")
       response = Aitch::Response.new(config, http_response)
 
       assert response.public_send("#{name}?")

data/test/aitch/response/status_3xx_test.rb

@@ -6,11 +6,20 @@ class Status3xxTest < Minitest::Test
   setup { Aitch.configuration.follow_redirect = false }
 
   test "sets default redirected from" do
-    assert_empty Aitch::Response.new({}, stub("response")).redirected_from
+    response =
+      Aitch::Response.new({}, stub("response", content_type: "text/html"))
+
+    assert_empty response.redirected_from
   end
 
   test "uses provided redirected from" do
-    assert_equal ["URL"], Aitch::Response.new({redirected_from: ["URL"]}, stub("response")).redirected_from
+    response =
+      Aitch::Response.new(
+        {redirected_from: ["URL"]},
+        stub("response", content_type: "text/html")
+      )
+
+    assert_equal ["URL"], response.redirected_from
   end
 
   test "has body" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aitch
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 2.0.0
 platform: ruby
 authors:
 - Nando Vieira
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-02-02 00:00:00.000000000 Z
+date: 2023-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -248,14 +248,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.3
+rubygems_version: 3.4.6
 signing_key:
 specification_version: 4
 summary: A simple HTTP client