aitch 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ac6be3c16c842bbd1555aed0de859b6e62bf59f511cce28a6c441efd980e5751
-  data.tar.gz: 2ebc4b41d63c9dd41756bb7fff03b52a6cbca2f56ed310183bc158a822bbdbd9
+  metadata.gz: c49091163504e6a6587170951f8e4545b4474b1912c85c5bcfeb102763a214b7
+  data.tar.gz: 7fac91b61ee9ad82e8f880f25758b9f6a433ad8ed3bcc5134b261e64f5da61fc
 SHA512:
-  metadata.gz: 602da6e2d0aaf3812e7f19b84b48b47eaeac59086345bceb76c601eba64f369ae0833c32980f66b0c026338bb098ad72563d1a4d2fdf8384fe50792856d281a1
-  data.tar.gz: b35ef25d1e59cd76923e626fdd6d60a735977a35d6560a32fe3313a8421eeccbce9524163775651da6fc017fcd47f7ef20c7ec8a40460d4a627e2d75d334fae8
+  metadata.gz: 859bdbfb5f70d99646c628f16a2cea718385299ca1b48d32e0ecfb8c9598ad27b8cf3363498b50eaddf8585901212faa1f588dc9dc29ad1982891f2a3c26b1fa
+  data.tar.gz: a7045d8d2a6c9d172b2b90180cd4d2afb13a5ceac088b74b9cb7ccc63fa9050920df69310e0eef1ae745b44d0edd4c45f6779c9a6fe420c3951878be4ff3fbf1

data/.rubocop.yml

@@ -16,3 +16,9 @@ Naming/AccessorMethodName:
 
 Style/DocumentDynamicEvalDefinition:
   Enabled: false
+
+Gemspec/DevelopmentDependencies:
+  Enabled: false
+
+Minitest/MultipleAssertions:
+  Enabled: false

data/CHANGELOG.md

@@ -1,5 +1,7 @@
 # Changelog
 
+- **1.2.2**
+  - Transform header key before assigning values.
 - **1.2.1**
   - Avoid calling `to_h` when params are array-like.
 - **1.2.0**

data/lib/aitch/location.rb

@@ -2,6 +2,8 @@
 
 module Aitch
   class Location
+    MATCHER = %r{\A/}.freeze
+
     attr_reader :redirect_stack, :current_url
 
     def initialize(redirect_stack, current_url)
@@ -10,7 +12,7 @@ module Aitch
     end
 
     def location
-      return current_url unless current_url.match?(%r{\A/}) # rubocop:disable Performance/StartWith
+      return current_url unless current_url.match?(MATCHER)
 
       uri = find_uri_with_host
       url = ["#{uri.scheme}://#{uri.hostname}"]

data/lib/aitch/request.rb

@@ -4,6 +4,14 @@ module Aitch
   class Request
     attr_accessor :request_method, :url, :data, :headers, :options, :redirects
 
+    CONTENT_TYPE = "Content-Type"
+    USER_AGENT = "User-Agent"
+    ACCEPT_ENCODING = "Accept-Encoding"
+    GZIP_DEFLATE = "gzip,deflate"
+    HTTPS = "https"
+    HEADER_SEPARATOR_RE = /[-_]/.freeze
+    JSON_RE = /\bjson\b/.freeze
+
     alias params= data=
     alias body= data=
 
@@ -30,12 +38,12 @@ module Aitch
     end
 
     def content_type=(content_type)
-      headers["Content-Type"] = content_type
+      headers[CONTENT_TYPE] = content_type
     end
 
     def content_type
-      headers["Content-Type"] ||
-        options.fetch(:default_headers, {})["Content-Type"]
+      headers[CONTENT_TYPE] ||
+        options.fetch(:default_headers, {})[CONTENT_TYPE]
     end
 
     def request
@@ -79,7 +87,7 @@ module Aitch
       body_data = data
       body_data = data.to_h if data.respond_to?(:to_h) && !data.is_a?(Array)
 
-      if content_type.to_s.match?(/\bjson\b/)
+      if content_type.to_s.match?(JSON_RE)
         body_data = ResponseParser::JSONParser.engine.dump(body_data)
       end
 
@@ -95,7 +103,8 @@ module Aitch
 
       all_headers.each do |name, value|
         value = value.respond_to?(:call) ? value.call : value
-        request[name.to_s] = value.to_s
+        name = name.to_s.split(HEADER_SEPARATOR_RE).map(&:capitalize).join("-")
+        request[name] = value.to_s
       end
     end
 
@@ -106,7 +115,7 @@ module Aitch
     end
 
     private def set_https(client)
-      client.use_ssl = uri.scheme == "https"
+      client.use_ssl = uri.scheme == HTTPS
       client.verify_mode = OpenSSL::SSL::VERIFY_PEER
     end
 
@@ -120,11 +129,11 @@ module Aitch
     end
 
     private def set_user_agent(request)
-      request["User-Agent"] = options[:user_agent]
+      request[USER_AGENT] = options[:user_agent]
     end
 
     private def set_gzip(request)
-      request["Accept-Encoding"] = "gzip,deflate"
+      request[ACCEPT_ENCODING] = GZIP_DEFLATE
     end
 
     def timeout_exception

data/lib/aitch/response.rb

@@ -4,11 +4,20 @@ module Aitch
   class Response
     extend Forwardable
 
+    JSON_STR = "json"
+    XML_STR = "xml"
+    HTML_STR = "html"
+    EMPTY_STR = ""
+    DOUBLE_COLON = "::"
+    SPACE_STR = " "
+    ERROR_SUFFIX = "_error"
+    X_RE = /^x-/.freeze
+
     def_delegators :@http_response, :content_type
     attr_accessor :redirected_from, :url
 
     def self.description_for_code(code)
-      [code, DESCRIPTION[code]].compact.join(" ")
+      [code, DESCRIPTION[code]].compact.join(SPACE_STR)
     end
 
     def initialize(options, http_response)
@@ -19,8 +28,8 @@ module Aitch
 
     ERRORS.each do |status_code, exception|
       method_name = Utils
-                    .underscore(exception.name.split("::").last)
-                    .gsub("_error", "")
+                    .underscore(exception.name.split(DOUBLE_COLON).last)
+                    .gsub(ERROR_SUFFIX, EMPTY_STR)
 
       define_method "#{method_name}?" do
         code == status_code
@@ -53,15 +62,15 @@ module Aitch
     end
 
     def json?
-      content_type.include?("json")
+      content_type.include?(JSON_STR)
     end
 
     def xml?
-      content_type.include?("xml")
+      content_type.include?(XML_STR)
     end
 
     def html?
-      content_type.include?("html")
+      content_type.include?(HTML_STR)
     end
 
     def data
@@ -71,7 +80,7 @@ module Aitch
     def headers
       @headers ||= {}.tap do |headers|
         @http_response.each_header do |name, value|
-          headers[name.gsub(/^x-/, "")] = value
+          headers[name.gsub(X_RE, EMPTY_STR)] = value
         end
       end
     end

data/lib/aitch/utils.rb

@@ -3,8 +3,11 @@
 module Aitch
   module Utils
     extend self
+
+    MATCHER = /(?<=.)(URI|[A-Z])/.freeze
+
     def underscore(string)
-      string = string.gsub(/(?<=.)(URI|[A-Z])/) do |char|
+      string = string.gsub(MATCHER) do |char|
         "_#{char}"
       end
 

data/lib/aitch/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Aitch
-  VERSION = "1.2.1"
+  VERSION = "1.2.2"
 end

data/test/aitch/aitch_test.rb

@@ -4,25 +4,25 @@ require "test_helper"
 
 class AitchTest < Minitest::Test
   test "defines public API" do
-    assert Aitch.respond_to?(:get)
-    assert Aitch.respond_to?(:get!)
-    assert Aitch.respond_to?(:post)
-    assert Aitch.respond_to?(:post!)
-    assert Aitch.respond_to?(:put)
-    assert Aitch.respond_to?(:put!)
-    assert Aitch.respond_to?(:patch)
-    assert Aitch.respond_to?(:patch!)
-    assert Aitch.respond_to?(:delete)
-    assert Aitch.respond_to?(:delete!)
-    assert Aitch.respond_to?(:head)
-    assert Aitch.respond_to?(:head!)
-    assert Aitch.respond_to?(:options)
-    assert Aitch.respond_to?(:options!)
-    assert Aitch.respond_to?(:trace)
-    assert Aitch.respond_to?(:trace!)
-    assert Aitch.respond_to?(:execute)
-    assert Aitch.respond_to?(:execute!)
-    assert Aitch.respond_to?(:config)
-    assert Aitch.respond_to?(:configuration)
+    assert_respond_to Aitch, :get
+    assert_respond_to Aitch, :get!
+    assert_respond_to Aitch, :post
+    assert_respond_to Aitch, :post!
+    assert_respond_to Aitch, :put
+    assert_respond_to Aitch, :put!
+    assert_respond_to Aitch, :patch
+    assert_respond_to Aitch, :patch!
+    assert_respond_to Aitch, :delete
+    assert_respond_to Aitch, :delete!
+    assert_respond_to Aitch, :head
+    assert_respond_to Aitch, :head!
+    assert_respond_to Aitch, :options
+    assert_respond_to Aitch, :options!
+    assert_respond_to Aitch, :trace
+    assert_respond_to Aitch, :trace!
+    assert_respond_to Aitch, :execute
+    assert_respond_to Aitch, :execute!
+    assert_respond_to Aitch, :config
+    assert_respond_to Aitch, :configuration
   end
 end

data/test/aitch/configuration_test.rb

@@ -9,6 +9,7 @@ class ConfigurationTest < Minitest::Test
 
   test "sets default user agent" do
     user_agent = "Aitch/#{Aitch::VERSION} (http://rubygems.org/gems/aitch)"
+
     assert_equal user_agent, Aitch::Configuration.new.user_agent
   end
 
@@ -17,7 +18,7 @@ class ConfigurationTest < Minitest::Test
   end
 
   test "sets default headers" do
-    assert_equal({}, Aitch::Configuration.new.default_headers)
+    assert_empty(Aitch::Configuration.new.default_headers)
   end
 
   test "configures aitch" do

data/test/aitch/dsl_test.rb

@@ -7,31 +7,37 @@ class DslTest < Minitest::Test
 
   test "sets url" do
     dsl.url "URL"
+
     assert_equal "URL", dsl.url
   end
 
   test "sets options" do
     dsl.options "OPTIONS"
+
     assert_equal "OPTIONS", dsl.options
   end
 
   test "sets headers" do
     dsl.headers "HEADERS"
+
     assert_equal "HEADERS", dsl.headers
   end
 
   test "sets data" do
     dsl.data "DATA"
+
     assert_equal "DATA", dsl.data
   end
 
   test "sets data through params" do
     dsl.params "PARAMS"
+
     assert_equal "PARAMS", dsl.data
   end
 
   test "sets data through body" do
     dsl.body "BODY"
+
     assert_equal "BODY", dsl.data
   end
 

data/test/aitch/execute_test.rb

@@ -41,6 +41,6 @@ class ExecuteBangTest < Minitest::Test
     response = stub(error?: true, error: "ERROR")
     Aitch::Request.any_instance.stubs(:perform).returns(response)
 
-    assert_raises("ERROR") { Aitch.get!("URL") }
+    assert_raises(StandardError, "ERROR") { Aitch.get!("URL") }
   end
 end

data/test/aitch/request/client_https_test.rb

@@ -7,7 +7,7 @@ class ClientHttpsTest < Minitest::Test
   let(:client) { request.client }
 
   test "sets https" do
-    assert client.use_ssl?
+    assert_predicate client, :use_ssl?
   end
 
   test "sets verification mode" do
@@ -16,6 +16,7 @@ class ClientHttpsTest < Minitest::Test
 
   test "sets timeout" do
     request.options[:timeout] = 20
+
     assert_equal 20, client.read_timeout
   end
 end

data/test/aitch/request/follow_redirect_test.rb

@@ -14,7 +14,7 @@ class FollowRedirectTest < Minitest::Test
 
     response = Aitch.get("http://example.org/")
 
-    refute response.redirect?
+    refute_predicate response, :redirect?
     assert_equal "Hello", response.body
     assert_equal ["http://example.org/", "http://example.com/"], response.redirected_from
     assert_equal "http://www.example.com/", response.url

data/test/aitch/request/request_class_test.rb

@@ -23,6 +23,7 @@ class RequestClassTest < Minitest::Test
   ].each do |method|
     test "instantiates #{method.upcase} method" do
       request = build_request(request_method: method).request
+
       assert_equal "Net::HTTP::#{method.capitalize}", request.class.name
     end
   end

data/test/aitch/request_test.rb

@@ -5,6 +5,7 @@ require "test_helper"
 class RequestTest < Minitest::Test
   test "sets content type" do
     request = build_request(content_type: "application/json")
+
     assert_equal "application/json", request.content_type
   end
 
@@ -35,26 +36,31 @@ class RequestTest < Minitest::Test
 
   test "requests gzip encoding" do
     request = build_request.request
+
     assert_equal "gzip,deflate", request["Accept-Encoding"]
   end
 
   test "sets path" do
     request = build_request(url: "http://example.org/some/path").request
+
     assert_equal "/some/path", request.path
   end
 
   test "sets request body from hash" do
     request = build_request(request_method: "post", data: {a: 1}).request
+
     assert_equal "a=1", request.body
   end
 
   test "sets request body from string" do
     request = build_request(request_method: "post", data: "some body").request
+
     assert_equal "some body", request.body
   end
 
   test "sets request body from params key" do
     request = build_request(request_method: "post", params: "some body").request
+
     assert_equal "some body", request.body
   end
 
@@ -67,6 +73,7 @@ class RequestTest < Minitest::Test
     ).request
 
     expected = {a: 1}.to_json
+
     assert_equal expected, request.body
   end
 
@@ -78,12 +85,14 @@ class RequestTest < Minitest::Test
     ).request
 
     expected = {a: 1}.to_json
+
     assert_equal expected, request.body
   end
 
   test "sets request body from to_h protocol" do
     data = stub(to_h: {a: 1})
     request = build_request(request_method: "post", data: data).request
+
     assert_equal "a=1", request.body
   end
 
@@ -123,11 +132,19 @@ class RequestTest < Minitest::Test
 
   test "sets custom headers" do
     request = build_request(headers: {"HEADER" => "VALUE"}).request
+
     assert_equal "VALUE", request["HEADER"]
   end
 
+  test "sets headers from underscored headers" do
+    request = build_request(headers: {content_type: "text/plain"}).request
+
+    assert_equal "text/plain", request["Content-Type"]
+  end
+
   test "executes headers with callable protocol" do
     request = build_request(headers: {"HEADER" => -> { "VALUE" }}).request
+
     assert_equal "VALUE", request["HEADER"]
   end
 

data/test/aitch/response/html_response_test.rb

@@ -7,7 +7,7 @@ class HtmlResponseTest < Minitest::Test
     register_uri(:get, "http://example.org/", body: "", content_type: "text/html")
     response = Aitch.get("http://example.org/")
 
-    assert response.html?
+    assert_predicate response, :html?
   end
 
   test "returns html" do

data/test/aitch/response/json_response_test.rb

@@ -7,7 +7,7 @@ class JsonResponseTest < Minitest::Test
     register_uri(:get, "http://example.org/", body: "[]", content_type: "application/json")
     response = Aitch.get("http://example.org/")
 
-    assert response.json?
+    assert_predicate response, :json?
   end
 
   test "returns json" do

data/test/aitch/response/status_3xx_test.rb

@@ -6,7 +6,7 @@ class Status3xxTest < Minitest::Test
   setup { Aitch.configuration.follow_redirect = false }
 
   test "sets default redirected from" do
-    assert_equal [], Aitch::Response.new({}, stub("response")).redirected_from
+    assert_empty Aitch::Response.new({}, stub("response")).redirected_from
   end
 
   test "uses provided redirected from" do
@@ -16,6 +16,7 @@ class Status3xxTest < Minitest::Test
   test "has body" do
     register_uri(:get, "http://example.org/", body: "Hello", status: 301)
     response = Aitch.get("http://example.org/")
+
     assert_equal "Hello", response.body
   end
 
@@ -23,20 +24,21 @@ class Status3xxTest < Minitest::Test
     register_uri(:get, "http://example.org/", status: 301)
     response = Aitch.get("http://example.org/")
 
-    assert response.success?
-    assert response.ok?
+    assert_predicate response, :success?
+    assert_predicate response, :ok?
   end
 
   test "detects as redirect" do
     register_uri(:get, "http://example.org/", status: 301)
     response = Aitch.get("http://example.org/")
 
-    assert response.redirect?
+    assert_predicate response, :redirect?
   end
 
   test "returns location" do
     register_uri(:get, "http://example.org/", status: 301, location: "https://example.com/")
     response = Aitch.get("http://example.org/")
+
     assert_equal "https://example.com/", response.location
   end
 

data/test/aitch/response/status_4xx_test.rb

@@ -7,7 +7,7 @@ class Status4xxTest < Minitest::Test
     register_uri(:get, "http://example.org/", status: 404)
     response = Aitch.get("http://example.org/")
 
-    assert response.error?
+    assert_predicate response, :error?
   end
 
   test "sets error" do

data/test/aitch/response/status_5xx_test.rb

@@ -7,7 +7,7 @@ class Status5xxTest < Minitest::Test
     register_uri(:get, "http://example.org/", status: 500)
     response = Aitch.get("http://example.org/")
 
-    assert response.error?
+    assert_predicate response, :error?
   end
 
   test "sets error" do

data/test/aitch/response/xml_response_test.rb

@@ -7,7 +7,7 @@ class XmlResponseTest < Minitest::Test
     register_uri(:get, "http://example.org/", body: "[]", content_type: "application/xml")
     response = Aitch.get("http://example.org/")
 
-    assert response.xml?
+    assert_predicate response, :xml?
   end
 
   test "returns xml" do

data/test/aitch/response_test.rb

@@ -6,12 +6,14 @@ class ResponseTest < Minitest::Test
   test "has body" do
     register_uri(:get, "http://example.org/", body: "Hello")
     response = Aitch.get("http://example.org/")
+
     assert_equal "Hello", response.body
   end
 
   test "sets current url" do
     register_uri(:get, "http://example.org/", body: "Hello")
     response = Aitch.get("http://example.org/")
+
     assert_equal "http://example.org/", response.url
   end
 
@@ -39,19 +41,22 @@ class ResponseTest < Minitest::Test
   test "returns status code" do
     register_uri(:get, "http://example.org/", body: "")
     response = Aitch.get("http://example.org/")
+
     assert_equal 200, response.code
   end
 
   test "returns content type" do
     register_uri(:get, "http://example.org/", content_type: "text/html")
     response = Aitch.get("http://example.org/")
+
     assert_equal "text/html", response.content_type
   end
 
   test "detects as successful response" do
     register_uri(:get, "http://example.org/", content_type: "text/html")
     response = Aitch.get("http://example.org/")
-    assert response.success?
+
+    assert_predicate response, :success?
   end
 
   test "returns headers" do
@@ -74,7 +79,7 @@ class ResponseTest < Minitest::Test
     response = Aitch.get("http://example.org/")
 
     assert_equal "0.003", response.runtime
-    assert response.respond_to?(:runtime)
+    assert_respond_to response, :runtime
   end
 
   test "raises when have no method" do

data/test/aitch/uri_test.rb

@@ -33,6 +33,7 @@ class UriTest < Minitest::Test
 
   test "returns request uri" do
     uri = Aitch::URI.new("http://example.org/some/path?a=1&b=2#hello", c: 3)
+
     assert_equal "/some/path?a=1&b=2&c=3#hello", uri.request_uri
   end
 end

data/test/aitch/utils/symbolize_keys_test.rb

@@ -5,6 +5,7 @@ require "test_helper"
 class SymbolizeKeysTest < Minitest::Test
   test "converts keys to symbols" do
     expected = {a: 1}
+
     assert_equal expected, Aitch::Utils.symbolize_keys("a" => 1)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aitch
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Nando Vieira
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-13 00:00:00.000000000 Z
+date: 2023-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -255,7 +255,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.4.3
 signing_key:
 specification_version: 4
 summary: A simple HTTP client