aitch 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a3f4cd3269e5b709f85e34148b2ed6aad4a9080f9903dc625d4840d8ffc2293a
-  data.tar.gz: d97a344ec31e5f6ba528f1d359b96aa2860ab51e1cdde507d5cbc0557e9a75a4
+  metadata.gz: ac6be3c16c842bbd1555aed0de859b6e62bf59f511cce28a6c441efd980e5751
+  data.tar.gz: 2ebc4b41d63c9dd41756bb7fff03b52a6cbca2f56ed310183bc158a822bbdbd9
 SHA512:
-  metadata.gz: a11acc6e165677b372cd4c9a07b9fd33640611a056fb1c437917ffa1d89ab0520bcaf9943cd5e8f72a3f088942a8f7b9d968a59ec7207dc6a061f54364216aba
-  data.tar.gz: a0228f9d4719ee0fddd2932fece69c454062d40f4526612b41044168198f7ec91478267163e343a995ceb5f8bbcdc1d4d228d8edb73a9845b5aa0d08145581c9
+  metadata.gz: 602da6e2d0aaf3812e7f19b84b48b47eaeac59086345bceb76c601eba64f369ae0833c32980f66b0c026338bb098ad72563d1a4d2fdf8384fe50792856d281a1
+  data.tar.gz: b35ef25d1e59cd76923e626fdd6d60a735977a35d6560a32fe3313a8421eeccbce9524163775651da6fc017fcd47f7ef20c7ec8a40460d4a627e2d75d334fae8

data/.rubocop.yml

@@ -4,6 +4,7 @@ inherit_gem:
 
 AllCops:
   TargetRubyVersion: 2.5
+  NewCops: enable
 
 Layout/LineLength:
   Exclude:
@@ -13,14 +14,5 @@ Naming/AccessorMethodName:
   Exclude:
     - lib/aitch/request.rb
 
-Metrics/ClassLength:
-  Enabled: false
-
-Metrics/AbcSize:
-  Enabled: false
-
-Metrics/MethodLength:
-  Enabled: false
-
-Metrics/ParameterLists:
+Style/DocumentDynamicEvalDefinition:
   Enabled: false

data/CHANGELOG.md

@@ -1,40 +1,52 @@
 # Changelog
 
-* **1.0.1**
-    * Fix a bug when JSON encoding body in a POST request.
-* **1.0.0**
-    * Use frozen string magic comments
-    * 307 redirections will honor the HTTP request method
-    * Fix issue with redirection; it was including the target url for one level redirection.
-    * Methods `Aitch::Response#html`, `Aitch::Response#json`, `Aitch::Response#xml` were removed; use `Aitch::Response#data` instead.
-    * Add support to response parsers
-* **0.5.0** - May 24, 2015
-    * Remove hard dependency on ActiveSupport
-    * Add response validation
-* **0.4.1** - December 20, 2014
-    * Consider default headers when returning content type (fixes issue with body's JSON encoding)
-* **0.4.0** - December 18, 2014
-    * Add accessor method for setting request's content type
-    * Automatically encodes body as JSON when content type matches `json`
-    * JSON encoding now uses a parser
-* **0.3.0** - April 28, 2014
-    * Make list of redirections available
-    * Make the request URL available on responses
-* **0.2.1** - July 30, 2013
-    * Add alias for `response.success?` (`response.ok?`)
-* **0.2.0** - July 28, 2013
-    * Add DSL support
-    * Create aliases for `response.data` (`response.xml` and `response.json`)
-* **0.1.5** - June 26, 2013
-    * Fix issue with jRuby and `to_h` protocol
-* **0.1.4** - June 13, 2013
-    * Accept headers as callable objects
-    * Fix XML encoding, always converting values to UTF-8
-* **0.1.3** - May 12, 2013
-    * Add response HTML parsing into Nokogiri object
-* **0.1.2** - May 10, 2013
-    * Add response error code helpers, like `response.bad_request?` and `response.not_found?`
-* **0.1.1** - April 30, 2013
-    * Add support for namespaces
-* **0.1.0** - April 29, 2013
-    * Initial release
+- **1.2.1**
+  - Avoid calling `to_h` when params are array-like.
+- **1.2.0**
+  - Add support to base url.
+- **1.1.0**
+  - Add keyword argument interface to methods like `Aitch.get` and alike.
+- **1.0.2**
+  - Use `JSON.parse` rather than `JSON.load`.
+- **1.0.1**
+  - Fix a bug when JSON encoding body in a POST request.
+- **1.0.0**
+  - Use frozen string magic comments
+  - 307 redirections will honor the HTTP request method
+  - Fix issue with redirection; it was including the target url for one level
+    redirection.
+  - Methods `Aitch::Response#html`, `Aitch::Response#json`,
+    `Aitch::Response#xml` were removed; use `Aitch::Response#data` instead.
+  - Add support to response parsers
+- **0.5.0** - May 24, 2015
+  - Remove hard dependency on ActiveSupport
+  - Add response validation
+- **0.4.1** - December 20, 2014
+  - Consider default headers when returning content type (fixes issue with
+    body's JSON encoding)
+- **0.4.0** - December 18, 2014
+  - Add accessor method for setting request's content type
+  - Automatically encodes body as JSON when content type matches `json`
+  - JSON encoding now uses a parser
+- **0.3.0** - April 28, 2014
+  - Make list of redirections available
+  - Make the request URL available on responses
+- **0.2.1** - July 30, 2013
+  - Add alias for `response.success?` (`response.ok?`)
+- **0.2.0** - July 28, 2013
+  - Add DSL support
+  - Create aliases for `response.data` (`response.xml` and `response.json`)
+- **0.1.5** - June 26, 2013
+  - Fix issue with jRuby and `to_h` protocol
+- **0.1.4** - June 13, 2013
+  - Accept headers as callable objects
+  - Fix XML encoding, always converting values to UTF-8
+- **0.1.3** - May 12, 2013
+  - Add response HTML parsing into Nokogiri object
+- **0.1.2** - May 10, 2013
+  - Add response error code helpers, like `response.bad_request?` and
+    `response.not_found?`
+- **0.1.1** - April 30, 2013
+  - Add support for namespaces
+- **0.1.0** - April 29, 2013
+  - Initial release

data/aitch.gemspec

@@ -6,16 +6,16 @@ Gem::Specification.new do |spec|
   spec.name          = "aitch"
   spec.version       = Aitch::VERSION
   spec.authors       = ["Nando Vieira"]
-  spec.email         = ["fnando.vieira@gmail.com"]
+  spec.email         = ["me@fnando.com"]
   spec.description   = "A simple HTTP client"
   spec.summary       = spec.description
   spec.homepage      = "http://rubygems.org/gems/aitch"
   spec.license       = "MIT"
   spec.required_ruby_version = Gem::Requirement.new(">= 2.5.0")
+  spec.metadata["rubygems_mfa_required"] = "true"
 
   spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) {|f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
   spec.add_dependency "nokogiri"

data/lib/aitch/request.rb

@@ -77,7 +77,7 @@ module Aitch
 
     private def set_body(request)
       body_data = data
-      body_data = data.to_h if data.respond_to?(:to_h)
+      body_data = data.to_h if data.respond_to?(:to_h) && !data.is_a?(Array)
 
       if content_type.to_s.match?(/\bjson\b/)
         body_data = ResponseParser::JSONParser.engine.dump(body_data)

data/lib/aitch/response.rb

@@ -53,15 +53,15 @@ module Aitch
     end
 
     def json?
-      content_type =~ /json/
+      content_type.include?("json")
     end
 
     def xml?
-      content_type =~ /xml/
+      content_type.include?("xml")
     end
 
     def html?
-      content_type =~ /html/
+      content_type.include?("html")
     end
 
     def data

data/lib/aitch/response_parser/html_parser.rb

@@ -8,7 +8,7 @@ module Aitch
       end
 
       def self.match?(content_type)
-        content_type =~ /html/
+        content_type.include?("html")
       end
 
       def self.load(source)

data/lib/aitch/response_parser/json_parser.rb

@@ -14,7 +14,7 @@ module Aitch
       end
 
       def self.match?(content_type)
-        content_type =~ /json/
+        content_type.include?("json")
       end
 
       def self.load(source)

data/lib/aitch/response_parser/xml_parser.rb

@@ -8,7 +8,7 @@ module Aitch
       end
 
       def self.match?(content_type)
-        content_type =~ /xml/
+        content_type.include?("xml")
       end
 
       def self.load(source)

data/lib/aitch/uri.rb

@@ -27,7 +27,7 @@ module Aitch
     end
 
     def request_uri
-      [path, query, fragment].compact.join("")
+      [path, query, fragment].compact.join
     end
 
     def fragment

data/lib/aitch/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Aitch
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/test/aitch/request_test.rb

@@ -87,6 +87,18 @@ class RequestTest < Minitest::Test
     assert_equal "a=1", request.body
   end
 
+  test "sets json body from array" do
+    data = [1, 2, 3]
+    request = build_request(
+      request_method: "post",
+      data: data,
+      content_type: "application/json",
+      options: {json_parser: JSON}
+    ).request
+
+    assert_equal "[1,2,3]", request.body
+  end
+
   test "sets request body from to_s protocol" do
     data = stub(to_s: "some body")
     request = build_request(request_method: "post", data: data).request
@@ -140,7 +152,7 @@ class RequestTest < Minitest::Test
     assert_equal :post, last_request.method
     assert_equal "a=1&b=2", last_request.body
     assert_equal "0.1", last_request.headers["Rendering"]
-    assert_equal "user:pass", Base64.decode64(last_request.headers["Authorization"].split(" ").last)
+    assert_equal "user:pass", Base64.decode64(last_request.headers["Authorization"].split.last)
   end
 
   test "performs request when using kwargs" do
@@ -157,7 +169,7 @@ class RequestTest < Minitest::Test
     assert_equal :post, last_request.method
     assert_equal "a=1&b=2", last_request.body
     assert_equal "0.1", last_request.headers["Rendering"]
-    assert_equal "user:pass", Base64.decode64(last_request.headers["Authorization"].split(" ").last)
+    assert_equal "user:pass", Base64.decode64(last_request.headers["Authorization"].split.last)
   end
 
   test "uses base url" do

data/test/aitch/response/custom_response_parser_test.rb

@@ -7,7 +7,7 @@ class CustomResponseParserTest < Minitest::Test
   setup do
     parser = Class.new do
       def self.match?(content_type)
-        content_type =~ /csv/
+        content_type.include?("csv")
       end
 
       def self.load(source)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aitch
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Nando Vieira
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-07-18 00:00:00.000000000 Z
+date: 2022-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -166,7 +166,7 @@ dependencies:
         version: '0'
 description: A simple HTTP client
 email:
-- fnando.vieira@gmail.com
+- me@fnando.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -238,7 +238,8 @@ files:
 homepage: http://rubygems.org/gems/aitch
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -254,40 +255,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.17
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: A simple HTTP client
-test_files:
-- test/aitch/aitch_test.rb
-- test/aitch/configuration_test.rb
-- test/aitch/dsl_test.rb
-- test/aitch/execute_test.rb
-- test/aitch/namespace_test.rb
-- test/aitch/request/client_https_test.rb
-- test/aitch/request/follow_redirect_test.rb
-- test/aitch/request/json_request_test.rb
-- test/aitch/request/request_class_test.rb
-- test/aitch/request/status_code_validation_test.rb
-- test/aitch/request_test.rb
-- test/aitch/response/custom_response_parser_test.rb
-- test/aitch/response/default_response_parser_test.rb
-- test/aitch/response/errors_test.rb
-- test/aitch/response/html_response_test.rb
-- test/aitch/response/json_response_test.rb
-- test/aitch/response/raw_response_test.rb
-- test/aitch/response/status_3xx_test.rb
-- test/aitch/response/status_4xx_test.rb
-- test/aitch/response/status_5xx_test.rb
-- test/aitch/response/xml_response_test.rb
-- test/aitch/response_parser/html_parser_test.rb
-- test/aitch/response_parser/json_parser_test.rb
-- test/aitch/response_parser/xml_parser_test.rb
-- test/aitch/response_test.rb
-- test/aitch/to_query_test.rb
-- test/aitch/uri_test.rb
-- test/aitch/utils/symbolize_keys_test.rb
-- test/aitch/utils/underscore_test.rb
-- test/fixtures/iso8859-1.xml
-- test/support/helpers.rb
-- test/test_helper.rb
+test_files: []