aitch 0.5.0 → 1.0.0

data/test/test_helper.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+require "codeclimate-test-reporter"
+CodeClimate::TestReporter.start
+
+require "bundler/setup"
+
+require "minitest/utils"
+require "minitest/autorun"
+
+require "aitch"
+
+require "base64"
+require "nokogiri"
+
+require_relative "support/helpers"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aitch
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Nando Vieira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-24 00:00:00.000000000 Z
+date: 2016-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: minitest-utils
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: test_notifier
+  name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -116,8 +116,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -128,7 +128,6 @@ files:
 - lib/aitch/dsl.rb
 - lib/aitch/errors.rb
 - lib/aitch/ext/to_query.rb
-- lib/aitch/html_parser.rb
 - lib/aitch/location.rb
 - lib/aitch/namespace.rb
 - lib/aitch/redirect.rb
@@ -137,24 +136,43 @@ files:
 - lib/aitch/response/body.rb
 - lib/aitch/response/description.rb
 - lib/aitch/response/errors.rb
+- lib/aitch/response_parser.rb
+- lib/aitch/response_parser/default_parser.rb
+- lib/aitch/response_parser/html_parser.rb
+- lib/aitch/response_parser/json_parser.rb
+- lib/aitch/response_parser/xml_parser.rb
 - lib/aitch/uri.rb
 - lib/aitch/utils.rb
 - lib/aitch/version.rb
-- lib/aitch/xml_parser.rb
-- spec/aitch/aitch_spec.rb
-- spec/aitch/configuration_spec.rb
-- spec/aitch/dsl_spec.rb
-- spec/aitch/html_parser_spec.rb
-- spec/aitch/namespace_spec.rb
-- spec/aitch/request_spec.rb
-- spec/aitch/response_spec.rb
-- spec/aitch/uri_spec.rb
-- spec/aitch/utils_spec.rb
-- spec/aitch/xml_parser_spec.rb
-- spec/fixtures/iso8859-1.xml
-- spec/spec_helper.rb
-- spec/support/request_uri.rb
-- spec/support/webmock.rb
+- test/aitch/aitch_test.rb
+- test/aitch/configuration_test.rb
+- test/aitch/dsl_test.rb
+- test/aitch/execute_test.rb
+- test/aitch/namespace_test.rb
+- test/aitch/request/client_https_test.rb
+- test/aitch/request/follow_redirect_test.rb
+- test/aitch/request/request_class_test.rb
+- test/aitch/request/status_code_validation_test.rb
+- test/aitch/request_test.rb
+- test/aitch/response/custom_response_parser_test.rb
+- test/aitch/response/errors_test.rb
+- test/aitch/response/html_response_test.rb
+- test/aitch/response/json_response_test.rb
+- test/aitch/response/raw_response_test.rb
+- test/aitch/response/status_3xx_test.rb
+- test/aitch/response/status_4xx_test.rb
+- test/aitch/response/status_5xx_test.rb
+- test/aitch/response/xml_response_test.rb
+- test/aitch/response_parser/html_parser_test.rb
+- test/aitch/response_parser/json_parser_test.rb
+- test/aitch/response_parser/xml_parser_test.rb
+- test/aitch/response_test.rb
+- test/aitch/uri_test.rb
+- test/aitch/utils/symbolize_keys_test.rb
+- test/aitch/utils/underscore_test.rb
+- test/fixtures/iso8859-1.xml
+- test/support/helpers.rb
+- test/test_helper.rb
 homepage: http://rubygems.org/gems/aitch
 licenses:
 - MIT
@@ -167,7 +185,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -175,22 +193,37 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A simple HTTP client
 test_files:
-- spec/aitch/aitch_spec.rb
-- spec/aitch/configuration_spec.rb
-- spec/aitch/dsl_spec.rb
-- spec/aitch/html_parser_spec.rb
-- spec/aitch/namespace_spec.rb
-- spec/aitch/request_spec.rb
-- spec/aitch/response_spec.rb
-- spec/aitch/uri_spec.rb
-- spec/aitch/utils_spec.rb
-- spec/aitch/xml_parser_spec.rb
-- spec/fixtures/iso8859-1.xml
-- spec/spec_helper.rb
-- spec/support/request_uri.rb
-- spec/support/webmock.rb
+- test/aitch/aitch_test.rb
+- test/aitch/configuration_test.rb
+- test/aitch/dsl_test.rb
+- test/aitch/execute_test.rb
+- test/aitch/namespace_test.rb
+- test/aitch/request/client_https_test.rb
+- test/aitch/request/follow_redirect_test.rb
+- test/aitch/request/request_class_test.rb
+- test/aitch/request/status_code_validation_test.rb
+- test/aitch/request_test.rb
+- test/aitch/response/custom_response_parser_test.rb
+- test/aitch/response/errors_test.rb
+- test/aitch/response/html_response_test.rb
+- test/aitch/response/json_response_test.rb
+- test/aitch/response/raw_response_test.rb
+- test/aitch/response/status_3xx_test.rb
+- test/aitch/response/status_4xx_test.rb
+- test/aitch/response/status_5xx_test.rb
+- test/aitch/response/xml_response_test.rb
+- test/aitch/response_parser/html_parser_test.rb
+- test/aitch/response_parser/json_parser_test.rb
+- test/aitch/response_parser/xml_parser_test.rb
+- test/aitch/response_test.rb
+- test/aitch/uri_test.rb
+- test/aitch/utils/symbolize_keys_test.rb
+- test/aitch/utils/underscore_test.rb
+- test/fixtures/iso8859-1.xml
+- test/support/helpers.rb
+- test/test_helper.rb

data/.rspec

@@ -1 +0,0 @@
---color --order random

data/lib/aitch/html_parser.rb

@@ -1,7 +0,0 @@
-module Aitch
-  module HTMLParser
-    def self.load(source)
-      Nokogiri::HTML(source.to_s)
-    end
-  end
-end

data/lib/aitch/xml_parser.rb

@@ -1,7 +0,0 @@
-module Aitch
-  module XMLParser
-    def self.load(source)
-      Nokogiri::XML(source.to_s, nil, "utf-8")
-    end
-  end
-end

data/spec/aitch/aitch_spec.rb

@@ -1,71 +0,0 @@
-require "spec_helper"
-
-describe Aitch do
-  context "request methods" do
-    it { should respond_to(:get) }
-    it { should respond_to(:get!) }
-    it { should respond_to(:post) }
-    it { should respond_to(:post!) }
-    it { should respond_to(:put) }
-    it { should respond_to(:put!) }
-    it { should respond_to(:patch) }
-    it { should respond_to(:patch!) }
-    it { should respond_to(:delete) }
-    it { should respond_to(:delete!) }
-    it { should respond_to(:head) }
-    it { should respond_to(:head!) }
-    it { should respond_to(:options) }
-    it { should respond_to(:options!) }
-    it { should respond_to(:trace) }
-    it { should respond_to(:trace!) }
-    it { should respond_to(:execute) }
-    it { should respond_to(:execute!) }
-    it { should respond_to(:config) }
-    it { should respond_to(:configuration) }
-  end
-
-  describe "#execute" do
-    let(:request) { double.as_null_object }
-
-    it "delegates to Request" do
-      options = {}
-
-      expected = {
-        request_method: "get",
-        url: "URL",
-        data: "DATA",
-        headers: "HEADERS",
-        options: options.merge(Aitch.config.to_h)
-      }
-
-      expect(Aitch::Request).to receive(:new).with(expected).and_return(request)
-
-      Aitch.get("URL", "DATA", "HEADERS", options)
-    end
-
-    it "performs request" do
-      allow(Aitch::Request).to receive(:new).and_return(request)
-      expect(request).to receive(:perform)
-
-      Aitch.get("URL")
-    end
-  end
-
-  describe "#execute!" do
-    it "returns response when successful" do
-      response = double(error?: false)
-      allow_any_instance_of(Aitch::Request).to receive(:perform).and_return(response)
-
-      expect(Aitch.get!("URL")).to eq(response)
-    end
-
-    it "raises when has errors" do
-      response = double(error?: true, error: "ERROR")
-      allow_any_instance_of(Aitch::Request).to receive(:perform).and_return(response)
-
-      expect {
-        Aitch.get!("URL")
-      }.to raise_error("ERROR")
-    end
-  end
-end

data/spec/aitch/configuration_spec.rb

@@ -1,33 +0,0 @@
-require "spec_helper"
-
-describe Aitch::Configuration do
-  it "sets default timeout" do
-    expect(Aitch::Configuration.new.timeout).to eq(10)
-  end
-
-  it "sets default user agent" do
-    user_agent = "Aitch/#{Aitch::VERSION} (http://rubygems.org/gems/aitch)"
-    expect(Aitch::Configuration.new.user_agent).to eq(user_agent)
-  end
-
-  it "sets default maximum redirections" do
-    expect(Aitch::Configuration.new.redirect_limit).to eq(5)
-  end
-
-  it "sets default headers" do
-    expect(Aitch::Configuration.new.default_headers).to eq({})
-  end
-
-  it "sets default XML parser" do
-    expect(Aitch::Configuration.new.xml_parser).to eq(Aitch::XMLParser)
-  end
-
-  it "configures aitch" do
-    Aitch.configure do |config|
-      config.timeout = 15
-    end
-
-    expect(Aitch.configuration.timeout).to eq(15)
-  end
-end
-

data/spec/aitch/dsl_spec.rb

@@ -1,47 +0,0 @@
-require "spec_helper"
-
-describe Aitch::DSL do
-  subject(:dsl) { Aitch::DSL.new }
-
-  it "sets url" do
-    dsl.url "URL"
-    expect(dsl.url).to eq("URL")
-  end
-
-  it "sets options" do
-    dsl.options "OPTIONS"
-    expect(dsl.options).to eq("OPTIONS")
-  end
-
-  it "sets headers" do
-    dsl.headers "HEADERS"
-    expect(dsl.headers).to eq("HEADERS")
-  end
-
-  it "sets data" do
-    dsl.data "DATA"
-    expect(dsl.data).to eq("DATA")
-  end
-
-  it "sets data through params" do
-    dsl.params "PARAMS"
-    expect(dsl.data).to eq("PARAMS")
-  end
-
-  it "sets data through body" do
-    dsl.body "BODY"
-    expect(dsl.data).to eq("BODY")
-  end
-
-  it "returns hash" do
-    dsl.options "OPTIONS"
-    dsl.headers "HEADERS"
-    dsl.url "URL"
-    dsl.data "DATA"
-
-    expect(dsl.to_h).to include(data: "DATA")
-    expect(dsl.to_h).to include(headers: "HEADERS")
-    expect(dsl.to_h).to include(url: "URL")
-    expect(dsl.to_h).to include(options: "OPTIONS")
-  end
-end

data/spec/aitch/html_parser_spec.rb

@@ -1,8 +0,0 @@
-require "spec_helper"
-
-describe Aitch::HTMLParser do
-  it "instantiates Nokogiri" do
-    expect(Nokogiri).to receive(:HTML).with("HTML")
-    Aitch::HTMLParser.load("HTML")
-  end
-end

data/spec/aitch/namespace_spec.rb

@@ -1,11 +0,0 @@
-require "spec_helper"
-
-describe Aitch::Namespace do
-  it "isolates namespace configuration" do
-    ns = Aitch::Namespace.new
-    ns.config.user_agent = "MyLib/1.0.0"
-
-    expect(ns.config.user_agent).to eq("MyLib/1.0.0")
-    expect(Aitch.config.user_agent).to match(%r[^Aitch])
-  end
-end

data/spec/aitch/request_spec.rb

@@ -1,261 +0,0 @@
-require "spec_helper"
-
-describe Aitch::Request do
-  def build_request(options = {})
-    Aitch::Request.new({
-      request_method: "get",
-      url: "http://example.org",
-      options: {}
-    }.merge(options))
-  end
-
-  it "sets content type" do
-    request = build_request(content_type: 'application/json')
-    expect(request.content_type).to eq('application/json')
-  end
-
-  it "raises with invalid uri" do
-    expect {
-      build_request(url: "\\").uri
-    }.to raise_error(Aitch::InvalidURIError)
-  end
-
-  it "raises on timeout", ruby: 2.0 do
-    request = build_request(request_method: "post", url: "http://example.org")
-    allow(request).to receive_message_chain(:client, :request).and_raise(Net::ReadTimeout)
-
-    expect {
-      request.perform
-    }.to raise_error(Aitch::RequestTimeoutError)
-  end
-
-  it "raises on timeout", ruby: 1.9 do
-    request = build_request(request_method: "post", url: "http://example.org")
-    allow(request).to receive_message_chain(:client, :request).and_raise(Timeout::Error)
-
-    expect {
-      request.perform
-    }.to raise_error(Aitch::RequestTimeoutError)
-  end
-
-  it "raises exception for invalid http method" do
-    request = build_request(request_method: "invalid", url: "http://example.org")
-
-    expect {
-      request.perform
-    }.to raise_error(Aitch::InvalidHTTPMethodError)
-  end
-
-  it "sets user agent" do
-    requester = build_request
-    request = requester.request
-    expect(request["User-Agent"]).to eq(requester.options[:user_agent])
-  end
-
-  it "requests gzip encoding" do
-    request = build_request.request
-    expect(request["Accept-Encoding"]).to eq("gzip,deflate")
-  end
-
-  it "sets path" do
-    request = build_request(url: "http://example.org/some/path").request
-    expect(request.path).to eq("/some/path")
-  end
-
-  it "sets request body from hash" do
-    request = build_request(request_method: "post", data: {a: 1}).request
-    expect(request.body).to eq("a=1")
-  end
-
-  it "sets request body from string" do
-    request = build_request(request_method: "post", data: "some body").request
-    expect(request.body).to eq("some body")
-  end
-
-  it "sets json body from object" do
-    request = build_request(
-      request_method: "post",
-      data: {a: 1},
-      content_type: "application/json",
-      options: {json_parser: JSON}
-    ).request
-
-    expect(request.body).to eq({a: 1}.to_json)
-  end
-
-  it "sets json body from object (default headers)" do
-    request = build_request(
-      request_method: "post",
-      data: {a: 1},
-      options: {json_parser: JSON, default_headers: {'Content-Type' => 'application/json'}}
-    ).request
-
-    expect(request.body).to eq({a: 1}.to_json)
-  end
-
-  it "sets request body from to_h protocol" do
-    data = double(to_h: {a: 1})
-    request = build_request(request_method: "post", data: data).request
-    expect(request.body).to eq("a=1")
-  end
-
-  it "sets request body from to_s protocol" do
-    data = double(to_s: "some body")
-    request = build_request(request_method: "post", data: data).request
-
-    expect(request.body).to eq("some body")
-  end
-
-  it "sets query string from hash data" do
-    register_uri :get, "http://example.org/?a=1&b=2", body: "hello"
-    requester = build_request(data: {a: 1, b: 2})
-
-    expect(requester.perform.body).to eq("hello")
-  end
-
-  it "sets default headers" do
-    requester = build_request
-    requester.options[:default_headers] = {"HEADER" => "VALUE"}
-    request = requester.request
-
-    expect(request["HEADER"]).to eq("VALUE")
-  end
-
-  it "sets custom headers" do
-    request = build_request(headers: {"HEADER" => "VALUE"}).request
-    expect(request["HEADER"]).to eq("VALUE")
-  end
-
-  it "executes headers with callable protocol" do
-    request = build_request(headers: {"HEADER" => -> { "VALUE" }}).request
-    expect(request["HEADER"]).to eq("VALUE")
-  end
-
-  it "sets basic auth credentials" do
-    request = build_request(options: {user: "USER", password: "PASS"}).request
-    credentials = Base64.decode64(request["Authorization"].gsub(/Basic /, ""))
-
-    expect(credentials).to eq("USER:PASS")
-  end
-
-  describe "#client" do
-    context "https" do
-      let(:request) { build_request(url: "https://example.org") }
-      subject(:client) { request.client }
-
-      it "sets https" do
-        expect(client.use_ssl?).to be_truthy
-      end
-
-      it "sets verification mode" do
-        expect(client.verify_mode).to eq(OpenSSL::SSL::VERIFY_PEER)
-      end
-
-      it "sets timeout" do
-        request.options[:timeout] = 20
-        expect(client.read_timeout).to eq(20)
-      end
-    end
-  end
-
-  describe "Request class" do
-    it "raises with invalid method" do
-      expect {
-        build_request(request_method: "invalid").request
-      }.to raise_error(Aitch::InvalidHTTPMethodError, %[unexpected HTTP verb: "invalid"])
-    end
-
-    %w[
-      get
-      post
-      put
-      patch
-      delete
-      head
-      options
-      trace
-    ].each do |method|
-      it "instantiates #{method.upcase} method" do
-        request = build_request(request_method: method).request
-        expect(request.class.name).to eq("Net::HTTP::#{method.capitalize}")
-      end
-    end
-  end
-
-  describe "follow redirection" do
-    before { Aitch.configuration.follow_redirect = true }
-
-    it "follows redirect" do
-      Aitch.configuration.redirect_limit = 5
-
-      register_uri(:get, "http://example.org/", location: "http://example.com/", status: 301)
-      register_uri(:get, "http://example.com/", location: "http://www.example.com/", status: 301)
-      register_uri(:get, "http://www.example.com/", body: "Hello")
-
-      response = Aitch.get("http://example.org/")
-
-      expect(response).not_to be_redirect
-      expect(response.body).to eq("Hello")
-      expect(response.redirected_from).to eq(["http://example.org/", "http://example.com/"])
-      expect(response.url).to eq("http://www.example.com/")
-    end
-
-    it "raises when doing too many redirects" do
-      Aitch.configuration.redirect_limit = 1
-
-      register_uri(:get, "http://example.org/", location: "http://example.com/", status: 301)
-      register_uri(:get, "http://example.com/", location: "https://example.com/", status: 301)
-
-      expect {
-        Aitch.get("http://example.org/")
-      }.to raise_error(Aitch::TooManyRedirectsError)
-    end
-  end
-
-  describe "GET requests" do
-    it "sets data as query string" do
-      register_uri(:get, /.+/)
-      Aitch.get("http://example.org/", a: 1, b: 2)
-
-      expect(last_request.uri.request_uri).to eq("/?a=1&b=2")
-    end
-  end
-
-  describe "using the DSL" do
-    it "performs request" do
-      register_uri(:post, /.+/)
-
-      response = Aitch.post do
-        url "http://example.org/some/path"
-        params a: 1, b: 2
-        headers Rendering: "0.1"
-        options user: "user", password: "pass"
-      end
-
-      expect(last_request.uri.request_uri).to eq("/some/path")
-      expect(last_request.method).to eq(:post)
-      expect(last_request.body).to eq("a=1&b=2")
-      expect(last_request.headers["Rendering"]).to eq("0.1")
-      expect(last_request.uri.user).to eq("user")
-      expect(last_request.uri.password).to eq("pass")
-    end
-  end
-
-  describe "status code validation" do
-    it "raises exception when status code isn't valid" do
-      register_uri(:get, "http://example.org/", status: 404)
-
-      expect {
-        Aitch.get("http://example.org/", {}, {}, expect: [200])
-      }.to raise_error(Aitch::StatusCodeError, "Expected(200 OK) <=> Actual(404 Not Found)")
-    end
-
-    it "accepts valid status code" do
-      register_uri(:get, "http://example.org/", status: 200)
-
-      expect {
-        Aitch.get("http://example.org/", {}, {}, expect: [200])
-      }.not_to raise_error
-    end
-  end
-end