airservice_build_tools 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: adea1ed03567c9a482ac46df1fcb5b7ff650feb3
-  data.tar.gz: 70e7c0ebf663f25a242b83f68eceaf69773ace46
+  metadata.gz: bef2301134341d74dcc3311b844206b2c993de09
+  data.tar.gz: de76dee7b4bf8f797f68589cda79e75cfd63adae
 SHA512:
-  metadata.gz: 3dd9995bdac6bed771c2d94697fccf36b30fde7a1cac949cf1aee61b2d67670b28ad7347f86de1f8b501498097e80a4e3d79d16bf1e81b45385dddbd920e1d0b
-  data.tar.gz: bcc9fa3bae2798a65bdffc18fba09b218f4cbccc2c1b9d6574dec1b0a5a06dfd0dbf25d363b72e667edf4f3c8ee5fecab63da17057b189fbd8099da91420896f
+  metadata.gz: c956d3e129bedd7aeb6b6e5455b6ea67ecb62b325f7334f7186f569943c5065c52a65395a2fb0f2b898b8f081ce81a35ce85a842f204c4e5bf68cb8d9bf439e2
+  data.tar.gz: 854871514802cb2c10cb3a7fe47374b3184b0cb1d6be7034ca91c66c495c8204f1cce2e3540eac21ba352446f897ea06a003217a322b9d7e5f385eeb32213b94

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    airservice_build_tools (0.0.2)
+    airservice_build_tools (0.0.4)
       plist
 
 GEM

data/lib/airservice/build_tools/obj_c.rb

@@ -12,9 +12,9 @@ module AirService
         plist = Plist::parse_xml(plist_file_path)
 
         build_version = options[:build_version]
-        plist['CFBundleVersion'] = build_version
+        plist['CFBundleVersion'] = build_version if build_version
         version = options[:version]
-        plist['CFBundleShortVersionString'] = version
+        plist['CFBundleShortVersionString'] = version if version
 
         log "Updating plist to #{plist.inspect}"
         new_plist_content = plist.to_plist

data/lib/airservice/build_tools/version.rb

@@ -1,5 +1,5 @@
 module AirService
   module BuildTools
-    VERSION = "0.0.3"
+    VERSION = "0.0.4"
   end
 end

data/spec/airservice/build_tools/obj_c_spec.rb

@@ -15,8 +15,9 @@ describe AirService::BuildTools::ObjC do
         expect(error.message).to include('exists')
       end
     end
-    it 'adds version and build number in plist' do
-      plist_file = <<-plist
+    context 'when updating without errors' do
+      let(:plist_file) {
+        <<-plist
       <?xml version="1.0" encoding="UTF-8"?>
       <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
       <plist version="1.0">
@@ -25,15 +26,29 @@ describe AirService::BuildTools::ObjC do
         <string>en</string>
       </dict>
       </plist>
-      plist
-      file_path = 'test_plist.plist'
-      File.open(file_path, 'w+') {|f| f.write( plist_file) }
+        plist
+      }
 
-      update_plist_version(file_path: file_path, build_version: '345', version: '1.1.345')
+      it 'adds version and build number in plist' do
+        file_path = 'test_plist.plist'
+        File.open(file_path, 'w+') { |f| f.write(plist_file) }
 
-      actual = Plist::parse_xml(file_path)
-      actual['CFBundleVersion'].should eq('345')
-      actual['CFBundleShortVersionString'].should eq('1.1.345')
+        update_plist_version(file_path: file_path, build_version: '345', version: '1.1.345')
+
+        actual = Plist::parse_xml(file_path)
+        actual['CFBundleVersion'].should eq('345')
+        actual['CFBundleShortVersionString'].should eq('1.1.345')
+      end
+      it 'ignores not specified version' do
+        file_path = 'test_plist.plist'
+        File.open(file_path, 'w+') { |f| f.write(plist_file) }
+
+        update_plist_version(file_path: file_path)
+
+        actual = File.read(file_path)
+        actual.should_not include('CFBundleVersion')
+        actual.should_not include('CFBundleShortVersionString')
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: airservice_build_tools
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - AirService