airbrake_tools 1.1.2 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e92b3c3cba97f5cd88111d87a977ae81f41cbaf4
-  data.tar.gz: aa24e7dee7bcb334d17c567c42a0d9de2664638e
+  metadata.gz: bdd1c1131520b79c11f048ba998705943ab95bc2
+  data.tar.gz: 29a5a90cc97973dbb2bed66ac01d66cd9a7a56f6
 SHA512:
-  metadata.gz: e53ff74c73685daff36e1ab3e6df5381da368a1ccd754273aa1efc6fc41322e9eba4c0c10ff97f26a37bb4f5f7e81b56ccdcde596bfd5c5a400ec33769130682
-  data.tar.gz: faf6a0cff78f8f5c6d199a7914b77b2bd615a4b42739528f52bafdc98af2d85d4ea0cd52cdc0333ff59be2dcc596252459ae50cdf46f51ebd755bf9a41fc99d4
+  metadata.gz: 15526a3a2541bbee47b30bb81235bc585eb80ccba968226c3c0d40cf44bf39e9cf51e6f023a81a0866490dc51a38b67f61431778e65d70b4a7bb634589d94973
+  data.tar.gz: 2f0a069e6fcf7e78a934d2d630c13af0b53530bbfd78a36b95cb6aaa76f93189776a3f33b0005aa0badf1cbe995a4271f1f78263a869403027ced6a7cb960906

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    airbrake_tools (1.1.2)
+    airbrake_tools (1.1.3)
       airbrake-api (>= 4.5.1)
 
 GEM

data/lib/airbrake_tools/version.rb

@@ -1,3 +1,3 @@
 module AirbrakeTools
-  VERSION = "1.1.2"
+  VERSION = "1.1.3"
 end

data/lib/airbrake_tools.rb

@@ -6,6 +6,7 @@ require "launchy"
 module AirbrakeTools
   DEFAULT_HOT_PAGES = 1
   DEFAULT_NEW_PAGES = 1
+  DEFAULT_LIST_PAGES = 10
   DEFAULT_SUMMARY_PAGES = 10
   DEFAULT_COMPARE_DEPTH_ADDITION = 3 # first line in project is 6 -> compare at 6 + x depth
   DEFAULT_ENVIRONMENT = "production"
@@ -15,6 +16,7 @@ module AirbrakeTools
     :bold => "\e[1m",
     :clear => "\e[0m"
   }
+  HOUR = 60*60
 
   class << self
     def cli(argv)
@@ -63,8 +65,9 @@ module AirbrakeTools
     end
 
     def list(options)
+      list_pages = options[:pages] ? options[:pages] : DEFAULT_LIST_PAGES
       page = 1
-      while errors = AirbrakeAPI.errors(:page => page) and page <= DEFAULT_SUMMARY_PAGES
+      while errors = AirbrakeAPI.errors(page: page) and page <= list_pages
         select_env(errors, options).each do |error|
           puts "#{error.id} -- #{error.error_class} -- #{error.error_message} -- #{error.created_at}"
         end
@@ -160,7 +163,7 @@ module AirbrakeTools
       Parallel.map(errors, :in_threads => 10) do |error|
         begin
           pages = 1
-          notices = AirbrakeAPI.notices(error.id, :pages => pages, :raw => true).compact
+          notices = AirbrakeAPI.notices(error.id, pages: pages, raw: true).compact
           print "."
           [error, notices, frequency(notices, pages * AirbrakeAPI::Client::PER_PAGE)]
         rescue Faraday::Error::ParsingError
@@ -194,13 +197,13 @@ module AirbrakeTools
     # we only have a limited sample size, so we do not know how many errors occurred in total
     def frequency(notices, expected_notices)
       return 0 if notices.empty?
-      range = if notices.size < expected_notices
-        60 * 60 # we got less notices then we wanted -> very few errors -> low frequency
+      range = if notices.size < expected_notices && notices.last.created_at > (Time.now - HOUR)
+        HOUR # we got less notices then we wanted -> very few errors -> low frequency
       else
         Time.now - notices.map{ |n| n.created_at }.min
       end
       errors_per_second = notices.size / range.to_f
-      (errors_per_second * 60 * 60).round(2) # errors_per_hour
+      (errors_per_second * HOUR).round(2) # errors_per_hour
     end
 
     def hot_summary(error)

data/spec/airbrake_tools_spec.rb

@@ -178,6 +178,10 @@ describe "airbrake-tools" do
     it "calculates low if notices are smaller then expected notices" do
       AirbrakeTools.send(:frequency, [stub(:created_at => Time.now)], 10).should == 1
     end
+
+    it "calculates correct if notices are smaller then expected notices but old" do
+      AirbrakeTools.send(:frequency, [stub(:created_at => (Time.now - 2 * 60 * 60))], 10).should == 0.5
+    end
   end
 
   describe ".select_env" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake_tools
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.3
 platform: ruby
 authors:
 - Jonathan Cheatham
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-18 00:00:00.000000000 Z
+date: 2014-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: airbrake-api