airbrake_proxy 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dcbb01d6954be318e40af6ba4fad1ae5d2b85e30
-  data.tar.gz: b3374ae338faddcaf597ec2c2e46564d6261ba14
+  metadata.gz: 3d9a063f02b1305386b9dce0b93f6838d7597ad0
+  data.tar.gz: 5a954ef60b31a332c9e4f63ac226510ec416f3df
 SHA512:
-  metadata.gz: 4e2a33d568fa85a3fdc3e9d50c39c93191bb1f38bfd082c7f1cf2163b349ec87289c43b0e8b8f56c3dffb66613d57aeb6f1e61186fdf0c33e07152b88d2d7170
-  data.tar.gz: 1de9bca1c47aaf21c67fae25c75df91f174222b16caf7a99178069e87d8a361b6a74c154f79f42b3b46707a74489e5c984c0d20ea7e4c91dd7c47ab67744e78b
+  metadata.gz: 886e7db68b0bd006f60eb1620fc7557ba8d4dfd441b92eca8cebdfbe8b79ec6e97151b1a1bd2e07e9c10a3f0af3cdb39a7c138c525cbdebb57a3d21e846dd723
+  data.tar.gz: 221b42104c51836189ef830e1600dbd9983c564ab5b6b3eec7efd4360d216820cdf922822a5cc046060297a2ebab0a8188abf0e07df4a10bea0d49da36e9fb67

data/.rubocop.yml

@@ -0,0 +1,2 @@
+AllCops:
+  TargetRubyVersion: 2.4

data/README.md

@@ -8,7 +8,7 @@
 
 [![Build Status](https://travis-ci.org/FinalCAD/airbrake_proxy.png?branch=master)](https://travis-ci.org/FinalCAD/airbrake_proxy) (Travis CI)
 
-[![Coverage Status](https://coveralls.io/repos/FinalCAD/airbrake_proxy/badge.png)](https://coveralls.io/r/FinalCAD/airbrake_proxy)
+[![Coverage Status](https://coveralls.io/repos/github/FinalCAD/airbrake_proxy/badge.svg?branch=master)](https://coveralls.io/github/FinalCAD/airbrake_proxy?branch=master)
 
 Basic Circuit Breaker to attempt not reach Airbrake limit for the same exception
 
@@ -20,6 +20,28 @@ Add this line to your application's Gemfile:
 gem 'airbrake_proxy'
 ```
 
+Please add a config file on your project.
+
+Rails sample
+
+`config/initializers/airbrake_proxy.rb`
+
+```ruby
+AirbrakeProxy.configure do |conf|
+  conf.redis  = Resque.redis
+  conf.logger = Rails.logger
+end
+```
+
+in `spec/spec_helper.rb` or `spec/rails_helper.rb`
+
+```ruby
+AirbrakeProxy.configure do |conf|
+  conf.redis  = MockRedis.new
+  conf.logger = Logger.new($stderr)
+end
+```
+
 And then execute:
 
     $ bundle
@@ -30,6 +52,7 @@ Or install it yourself as:
 
 ## Usage
 
+Simply use `AirbrakeProxy.notify(exception)` in your code instead of `Airbrake.notify exception`
 
 ## Development
 

data/lib/airbrake_proxy.rb

@@ -59,24 +59,34 @@ module AirbrakeProxy
     unless authorized_to_notify?(redis_key)
       raise TooManyNotification.new("#{redis_key} was notified too many times")
     end
+
     yield
   end
 
-  def key(exception)
-    "#{KEY_PREFIX}#{(exception&.message || exception.inspect).parameterize}"
+  def key(exception_or_message)
+    msg = case exception_or_message
+    when String
+      exception_or_message
+    when StandardError, Exception
+      exception_or_message.message
+    else
+      exception_or_message.to_s
+    end
+    "#{KEY_PREFIX}#{msg.parameterize}"
   end
 
   def authorized_to_notify?(key)
     return false if RedisProxy.get(key).to_i >= THRESHOLD # We won't hint Redis#incr(key) to not reset timelife of key
-    mark_as_notify(key) # return value is a true predicate
+    mark_as_notify!(key) # return value is a true predicate
+    true
   end
 
-  def mark_as_notify(key)
-    unless RedisProxy.exists(key)
-      RedisProxy.set(key, 0)
-      RedisProxy.expire(key, T_5_HOURS)
-    end
+  def mark_as_notify!(key)
+    RedisProxy.multi
     RedisProxy.incr(key)
+    RedisProxy.expire(key, T_1_HOUR)
+    RedisProxy.exec
+    nil
   end
 
   private

data/lib/airbrake_proxy/version.rb

@@ -1,3 +1,3 @@
 module AirbrakeProxy
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: airbrake_proxy
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Joel AZEMAR
@@ -118,6 +118,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md