airbrake_handler 0.2.1 → 0.3.0

data/.travis.yml

@@ -3,3 +3,4 @@ notifications:
 rvm:
   - 1.8.7
   - 1.9.2
+  - 1.9.3

data/Gemfile

@@ -1,4 +1,4 @@
-source :rubygems
+source "https://rubygems.org"
 
 gem "minitest", :platform => :ruby_18
 gem "rake"

data/{README.markdown → README.md}

@@ -1,6 +1,6 @@
 #  Airbrake handler for Chef
 
-Report [Chef](http://www.opscode.com/chef) exceptions to [Airbrake](http://airbrakeapp.com)
+Report [Chef](http://www.opscode.com/chef) exceptions to [Airbrake](http://airbrake.io)
 
 Works fine with chef versions: 0.9.x and 0.10.x
 
@@ -23,10 +23,22 @@ You can pass more options to AirbrakeHander initializer, i.e:
 AirbrakeHandler.new(:api_key => "your-airbrake-api-key", :framework_env => "production")
 ```
 
+If you want to ignore specific exceptions, you can do this like that:
+
+```ruby
+airbrake_handler = AirbrakeHandler.new(:api_key => "your-airbrake-api-key", :framework_env => "production")
+airbrake_handler.ignore << {:class => "SystemExit"}
+airbrake_handler.ignore << {:class => "Errno::ECONNRESET", :message => /Connection reset by peer/}
+```
+
 ## Continuous Integration
 
 [![Build Status](https://secure.travis-ci.org/morgoth/airbrake_handler.png)](http://travis-ci.org/morgoth/airbrake_handler)
 
+## Contributors
+
+* [Anton Mironov](https://github.com/mironov)
+
 ## Copyright
 
-Copyright (c) 2011 Adam Jacob, Wojciech Wnętrzak See LICENSE for details.
+Copyright (c) 2012 Adam Jacob, Wojciech Wnętrzak See LICENSE for details.

data/airbrake_handler.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "airbrake_handler"
-  s.version     = "0.2.1"
+  s.version     = "0.3.0"
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Adam Jacob", "Wojciech Wnętrzak"]
   s.email       = ["w.wnetrzak@gmail.com"]

data/lib/airbrake_handler.rb

@@ -20,23 +20,30 @@ require "chef/handler"
 require "toadhopper"
 
 class AirbrakeHandler < Chef::Handler
-  VERSION = "0.2.1"
+  VERSION = "0.3.0"
 
-  attr_accessor :options, :api_key
+  attr_accessor :options, :api_key, :ignore
 
   def initialize(options={})
     @api_key = options.delete(:api_key)
+    @ignore  = options.delete(:ignore) || []
     @options = options
   end
 
   def report
-    if run_status.failed?
+    if run_status.failed? && !ignore_exception?(run_status.exception)
       Chef::Log.error("Creating Airbrake exception report")
 
       client.post!(run_status.exception, airbrake_params)
     end
   end
 
+  def ignore_exception?(exception)
+    ignore.any? do |ignore_case|
+      ignore_case[:class] == exception.class.name && (!ignore_case.key?(:message) || !!ignore_case[:message].match(exception.message))
+    end
+  end
+
   def airbrake_params
     {
       :notifier_name => "Chef Airbrake Notifier", :notifier_version => VERSION, :notifier_url => "https://github.com/morgoth/airbrake_handler",

data/test/airbrake_notifier_test.rb

@@ -17,17 +17,65 @@ describe AirbrakeHandler do
   end
 
   it "should report exception using client" do
-    run_status = stub(:failed? => true, :exception => "Exception")
+    exception = Exception.new
+    run_status = stub(:failed? => true, :exception => exception)
     client = mock
     handler = AirbrakeHandler.new(:api_key => "fake")
     handler.stubs(:run_status).returns(run_status)
     handler.stubs(:client).returns(client)
     handler.stubs(:airbrake_params).returns({})
 
-    client.expects(:post!).with("Exception", {})
+    client.expects(:post!).with(exception, {})
     handler.report
   end
 
+  it "should not report ignored exception" do
+    run_status = stub(:failed? => true, :exception => Exception.new)
+    client = mock
+    handler = AirbrakeHandler.new(:api_key => "fake")
+    handler.ignore << {:class => "Exception"}
+    handler.stubs(:run_status).returns(run_status)
+    handler.stubs(:client).returns(client)
+    handler.stubs(:airbrake_params).returns({})
+
+    client.expects(:post!).never
+    handler.report
+  end
+
+  it "should not report ignored exception with specific message" do
+    run_status = stub(:failed? => true, :exception => Exception.new("error"))
+    client = mock
+    handler = AirbrakeHandler.new(:api_key => "fake")
+    handler.ignore << {:class => "Exception", :message => /error/}
+    handler.stubs(:run_status).returns(run_status)
+    handler.stubs(:client).returns(client)
+    handler.stubs(:airbrake_params).returns({})
+
+    client.expects(:post!).never
+    handler.report
+  end
+
+  it "should report exception if its message doesn't match any message of ignored exceptions" do
+    run_status = stub(:failed? => true, :exception => Exception.new("important error"))
+    client = mock
+    handler = AirbrakeHandler.new(:api_key => "fake")
+    handler.ignore << {:class => "Exception", :message => /not important error/}
+    handler.ignore << {:class => "Exception", :message => /some error/}
+    handler.stubs(:run_status).returns(run_status)
+    handler.stubs(:client).returns(client)
+    handler.stubs(:airbrake_params).returns({})
+
+    client.expects(:post!).once
+    handler.report
+  end
+
+  it "should ignore exception by message regexp" do
+    handler = AirbrakeHandler.new(:api_key => "fake")
+    handler.ignore << {:class => "Exception", :message => /catch me if you can/}
+
+    assert handler.ignore_exception?(Exception.new("catch me if you can"))
+  end
+
   it "should return Airbrake params" do
     node = stub(:name => "node-name", :run_list => "cookbook::recipe")
     run_status = stub(:node => node, :start_time => Time.mktime(2011,1,1),

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: airbrake_handler
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-08-27 00:00:00.000000000Z
+date: 2012-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chef
-  requirement: &8231860 !ruby/object:Gem::Requirement
+  requirement: &72635450 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,10 @@ dependencies:
         version: 0.9.0
   type: :runtime
   prerelease: false
-  version_requirements: *8231860
+  version_requirements: *72635450
 - !ruby/object:Gem::Dependency
   name: toadhopper
-  requirement: &8227860 !ruby/object:Gem::Requirement
+  requirement: &72634600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +33,10 @@ dependencies:
         version: '2.0'
   type: :runtime
   prerelease: false
-  version_requirements: *8227860
+  version_requirements: *72634600
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &8226840 !ruby/object:Gem::Requirement
+  requirement: &72634200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,7 +44,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *8226840
+  version_requirements: *72634200
 description: Chef handler for sending exceptions to Airbrake
 email:
 - w.wnetrzak@gmail.com
@@ -52,12 +52,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .document
 - .gitignore
 - .travis.yml
 - Gemfile
 - LICENSE
-- README.markdown
+- README.md
 - Rakefile
 - airbrake_handler.gemspec
 - lib/airbrake_handler.rb
@@ -83,7 +82,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: airbrake_handler
-rubygems_version: 1.8.10
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: Chef handler for sending exceptions to Airbrake

data/.document

@@ -1,5 +0,0 @@
-README.rdoc
-lib/**/*.rb
-bin/*
-features/**/*.feature
-LICENSE