airbrake 8.3.2 → 9.0.0

data/spec/apps/sinatra/sinatra_test_app.rb

@@ -10,3 +10,5 @@ class SinatraTestApp < Sinatra::Base
     raise AirbrakeTestError
   end
 end
+
+Airbrake::Rack.add_default_filters

data/spec/unit/rack/middleware_spec.rb

@@ -1,4 +1,20 @@
 RSpec.describe Airbrake::Rack::Middleware do
+  # The list of Rack filters that read Rack request information and append it to
+  # notices.
+  [
+    Airbrake::Rack::ContextFilter,
+    Airbrake::Rack::UserFilter,
+    Airbrake::Rack::SessionFilter,
+    Airbrake::Rack::HttpParamsFilter,
+    Airbrake::Rack::HttpHeadersFilter,
+    Airbrake::Rack::RouteFilter,
+
+    # Optional filters (must be included by users):
+    # Airbrake::Rack::RequestBodyFilter
+  ].each do |filter|
+    Airbrake.add_filter(filter.new)
+  end
+
   let(:app) { proc { |env| [200, env, 'Bingo bango content'] } }
   let(:faulty_app) { proc { raise AirbrakeTestError } }
   let(:endpoint) { 'https://api.airbrake.io/api/v3/projects/113743/notices' }

data/spec/unit/rack/route_filter_spec.rb

@@ -6,4 +6,47 @@ RSpec.describe Airbrake::Rack::RouteFilter do
       expect(notice[:context][:route]).to be_nil
     end
   end
+
+  context "when Sinatra route is unavailable" do
+    before { stub_const('Sinatra::Request', Class.new) }
+
+    let(:notice) do
+      notice = Airbrake.build_notice('oops')
+
+      request_mock = instance_double(Sinatra::Request)
+      expect(request_mock)
+        .to receive(:instance_of?).with(Sinatra::Request).and_return(true)
+      expect(request_mock).to receive(:env).and_return({})
+
+      notice.stash[:rack_request] = request_mock
+      notice
+    end
+
+    it "doesn't add context/route" do
+      subject.call(notice)
+      expect(notice[:context][:route]).to be_nil
+    end
+  end
+
+  context "when Sinatra route is available" do
+    before { stub_const('Sinatra::Request', Class.new) }
+
+    let(:notice) do
+      notice = Airbrake.build_notice('oops')
+
+      request_mock = instance_double(Sinatra::Request)
+      expect(request_mock)
+        .to receive(:instance_of?).with(Sinatra::Request).and_return(true)
+      expect(request_mock)
+        .to receive(:env).and_return('sinatra.route' => 'GET /test-route')
+
+      notice.stash[:rack_request] = request_mock
+      notice
+    end
+
+    it "doesn't add context/route" do
+      subject.call(notice)
+      expect(notice[:context][:route]).to eq('/test-route')
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake
 version: !ruby/object:Gem::Version
-  version: 8.3.2
+  version: 9.0.0
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-12 00:00:00.000000000 Z
+date: 2019-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: airbrake-ruby
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement