airbrake 8.3.1 → 8.3.2

data/spec/apps/rails/logs/52.log

@@ -5235,3 +5235,70 @@ F, [2019-03-04T11:51:38.615804 #68997] FATAL -- :
 F, [2019-03-04T11:51:38.615841 #68997] FATAL -- : lib/airbrake/rails/active_record.rb:25:in `run_callbacks'
 lib/airbrake/rack/middleware.rb:33:in `call!'
 lib/airbrake/rack/middleware.rb:21:in `call'
+D, [2019-03-12T19:42:38.960392 #88782] DEBUG -- :    (1.2ms)  SELECT sqlite_version(*)
+D, [2019-03-12T19:42:38.961228 #88782] DEBUG -- :    (0.3ms)  CREATE TABLE "books" ("id" integer PRIMARY KEY AUTOINCREMENT NOT NULL, "title" varchar)
+D, [2019-03-12T19:42:38.964471 #88782] DEBUG -- :    (0.1ms)  DROP TABLE IF EXISTS "delayed_jobs"
+D, [2019-03-12T19:42:38.965019 #88782] DEBUG -- :    (0.1ms)  CREATE TABLE "delayed_jobs" ("id" integer PRIMARY KEY AUTOINCREMENT NOT NULL, "priority" integer DEFAULT 0 NOT NULL, "attempts" integer DEFAULT 0 NOT NULL, "handler" text NOT NULL, "last_error" text, "run_at" datetime, "locked_at" datetime, "failed_at" datetime, "locked_by" varchar, "queue" varchar, "created_at" datetime, "updated_at" datetime)
+D, [2019-03-12T19:42:38.965503 #88782] DEBUG -- :    (0.1ms)  CREATE  INDEX "delayed_jobs_priority" ON "delayed_jobs" ("priority", "run_at")
+D, [2019-03-12T19:42:38.967065 #88782] DEBUG -- :    (0.1ms)  CREATE TABLE "ar_internal_metadata" ("key" varchar NOT NULL PRIMARY KEY, "value" varchar, "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL)
+D, [2019-03-12T19:42:38.978927 #88782] DEBUG -- :   ActiveRecord::InternalMetadata Load (0.1ms)  SELECT  "ar_internal_metadata".* FROM "ar_internal_metadata" WHERE "ar_internal_metadata"."key" = ? LIMIT ?  [["key", "environment"], ["LIMIT", 1]]
+D, [2019-03-12T19:42:38.982180 #88782] DEBUG -- :    (0.0ms)  begin transaction
+D, [2019-03-12T19:42:38.983081 #88782] DEBUG -- :   ActiveRecord::InternalMetadata Create (0.1ms)  INSERT INTO "ar_internal_metadata" ("key", "value", "created_at", "updated_at") VALUES (?, ?, ?, ?)  [["key", "environment"], ["value", "test"], ["created_at", "2019-03-12 17:42:38.982510"], ["updated_at", "2019-03-12 17:42:38.982510"]]
+D, [2019-03-12T19:42:38.983263 #88782] DEBUG -- :    (0.0ms)  commit transaction
+I, [2019-03-12T19:42:39.024681 #88782]  INFO -- : Started GET "/breakdown" for 127.0.0.1 at 2019-03-12 19:42:39 +0200
+I, [2019-03-12T19:42:39.026626 #88782]  INFO -- : Processing by DummyController#breakdown as HTML
+D, [2019-03-12T19:42:39.033707 #88782] DEBUG -- :    (0.1ms)  begin transaction
+D, [2019-03-12T19:42:39.035674 #88782] DEBUG -- :   Book Create (0.2ms)  INSERT INTO "books" ("title") VALUES (?)  [["title", "breakdown"]]
+D, [2019-03-12T19:42:39.037407 #88782] DEBUG -- :    (0.1ms)  commit transaction
+I, [2019-03-12T19:42:39.039134 #88782]  INFO -- : Completed 500 Internal Server Error in 12ms (ActiveRecord: 0.7ms)
+F, [2019-03-12T19:42:42.169356 #88782] FATAL -- :   
+F, [2019-03-12T19:42:42.169479 #88782] FATAL -- : RSpec::Mocks::MockExpectationError (Airbrake received :notify_performance_breakdown with unexpected arguments
+  expected: (hash_including(:route=>"/breakdown(.:format)", :method=>"GET", :response_type=>:html, :groups=>{:db=>...chers::BuiltIn::BeAnInstanceOf:0x00007fb3b5f1d158 @expected=Float, @matcher_name=:an_instance_of>>}))
+       got: ({:groups=>{:db=>0.6869998760521412}, :method=>"GET", :response_type=>:html, :route=>"/breakdown(.:format)", :start_time=>2019-03-12 19:42:39.026763000 +0200})
+Diff:
+@@ -1,2 +1,6 @@
+-["hash_including(:route=>\"/breakdown(.:format)\", :method=>\"GET\", :response_type=>:html, :groups=>{:db=>#<RSpec::Matchers::AliasedMatcher:0x00007fb3b5f1d1d0 @description_block=#<Proc:0x00007fb3b7a2ea00@/Users/kyrylo/.gem/ruby/2.4.2/gems/rspec-expectations-3.8.2/lib/rspec/matchers/dsl.rb:31 (lambda)>, @base_matcher=#<RSpec::Matchers::BuiltIn::BeAnInstanceOf:0x00007fb3b5f1d1f8 @expected=Float, @matcher_name=:an_instance_of>>, :view=>#<RSpec::Matchers::AliasedMatcher:0x00007fb3b5f1d130 @description_block=#<Proc:0x00007fb3b7a2ea00@/Users/kyrylo/.gem/ruby/2.4.2/gems/rspec-expectations-3.8.2/lib/rspec/matchers/dsl.rb:31 (lambda)>, @base_matcher=#<RSpec::Matchers::BuiltIn::BeAnInstanceOf:0x00007fb3b5f1d158 @expected=Float, @matcher_name=:an_instance_of>>})"]
++[{:groups=>{:db=>0.6869998760521412},
++  :method=>"GET",
++  :response_type=>:html,
++  :route=>"/breakdown(.:format)",
++  :start_time=>2019-03-12 19:42:39.026763000 +0200}]
+):
+F, [2019-03-12T19:42:42.169506 #88782] FATAL -- :   
+F, [2019-03-12T19:42:42.169532 #88782] FATAL -- : lib/airbrake/rails/action_controller_performance_breakdown_subscriber.rb:15:in `block in call'
+lib/airbrake/rails/action_controller_performance_breakdown_subscriber.rb:12:in `each'
+lib/airbrake/rails/action_controller_performance_breakdown_subscriber.rb:12:in `call'
+lib/airbrake/rack/middleware.rb:33:in `call!'
+lib/airbrake/rack/middleware.rb:21:in `call'
+D, [2019-03-12T19:42:59.909131 #88797] DEBUG -- :    (0.8ms)  SELECT sqlite_version(*)
+D, [2019-03-12T19:42:59.909524 #88797] DEBUG -- :    (0.3ms)  CREATE TABLE "books" ("id" integer PRIMARY KEY AUTOINCREMENT NOT NULL, "title" varchar)
+D, [2019-03-12T19:42:59.912071 #88797] DEBUG -- :    (0.0ms)  DROP TABLE IF EXISTS "delayed_jobs"
+D, [2019-03-12T19:42:59.912581 #88797] DEBUG -- :    (0.1ms)  CREATE TABLE "delayed_jobs" ("id" integer PRIMARY KEY AUTOINCREMENT NOT NULL, "priority" integer DEFAULT 0 NOT NULL, "attempts" integer DEFAULT 0 NOT NULL, "handler" text NOT NULL, "last_error" text, "run_at" datetime, "locked_at" datetime, "failed_at" datetime, "locked_by" varchar, "queue" varchar, "created_at" datetime, "updated_at" datetime)
+D, [2019-03-12T19:42:59.913133 #88797] DEBUG -- :    (0.1ms)  CREATE  INDEX "delayed_jobs_priority" ON "delayed_jobs" ("priority", "run_at")
+D, [2019-03-12T19:42:59.914464 #88797] DEBUG -- :    (0.1ms)  CREATE TABLE "ar_internal_metadata" ("key" varchar NOT NULL PRIMARY KEY, "value" varchar, "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL)
+D, [2019-03-12T19:42:59.923832 #88797] DEBUG -- :   ActiveRecord::InternalMetadata Load (0.1ms)  SELECT  "ar_internal_metadata".* FROM "ar_internal_metadata" WHERE "ar_internal_metadata"."key" = ? LIMIT ?  [["key", "environment"], ["LIMIT", 1]]
+D, [2019-03-12T19:42:59.926882 #88797] DEBUG -- :    (0.0ms)  begin transaction
+D, [2019-03-12T19:42:59.927728 #88797] DEBUG -- :   ActiveRecord::InternalMetadata Create (0.1ms)  INSERT INTO "ar_internal_metadata" ("key", "value", "created_at", "updated_at") VALUES (?, ?, ?, ?)  [["key", "environment"], ["value", "test"], ["created_at", "2019-03-12 17:42:59.927165"], ["updated_at", "2019-03-12 17:42:59.927165"]]
+D, [2019-03-12T19:42:59.927934 #88797] DEBUG -- :    (0.0ms)  commit transaction
+D, [2019-03-12T19:43:20.290859 #88811] DEBUG -- :    (0.9ms)  SELECT sqlite_version(*)
+D, [2019-03-12T19:43:20.291315 #88811] DEBUG -- :    (0.3ms)  CREATE TABLE "books" ("id" integer PRIMARY KEY AUTOINCREMENT NOT NULL, "title" varchar)
+D, [2019-03-12T19:43:20.293885 #88811] DEBUG -- :    (0.1ms)  DROP TABLE IF EXISTS "delayed_jobs"
+D, [2019-03-12T19:43:20.294437 #88811] DEBUG -- :    (0.1ms)  CREATE TABLE "delayed_jobs" ("id" integer PRIMARY KEY AUTOINCREMENT NOT NULL, "priority" integer DEFAULT 0 NOT NULL, "attempts" integer DEFAULT 0 NOT NULL, "handler" text NOT NULL, "last_error" text, "run_at" datetime, "locked_at" datetime, "failed_at" datetime, "locked_by" varchar, "queue" varchar, "created_at" datetime, "updated_at" datetime)
+D, [2019-03-12T19:43:20.294918 #88811] DEBUG -- :    (0.1ms)  CREATE  INDEX "delayed_jobs_priority" ON "delayed_jobs" ("priority", "run_at")
+D, [2019-03-12T19:43:20.296287 #88811] DEBUG -- :    (0.1ms)  CREATE TABLE "ar_internal_metadata" ("key" varchar NOT NULL PRIMARY KEY, "value" varchar, "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL)
+D, [2019-03-12T19:43:20.306138 #88811] DEBUG -- :   ActiveRecord::InternalMetadata Load (0.1ms)  SELECT  "ar_internal_metadata".* FROM "ar_internal_metadata" WHERE "ar_internal_metadata"."key" = ? LIMIT ?  [["key", "environment"], ["LIMIT", 1]]
+D, [2019-03-12T19:43:20.309355 #88811] DEBUG -- :    (0.0ms)  begin transaction
+D, [2019-03-12T19:43:20.310168 #88811] DEBUG -- :   ActiveRecord::InternalMetadata Create (0.1ms)  INSERT INTO "ar_internal_metadata" ("key", "value", "created_at", "updated_at") VALUES (?, ?, ?, ?)  [["key", "environment"], ["value", "test"], ["created_at", "2019-03-12 17:43:20.309653"], ["updated_at", "2019-03-12 17:43:20.309653"]]
+D, [2019-03-12T19:43:20.310345 #88811] DEBUG -- :    (0.0ms)  commit transaction
+I, [2019-03-12T19:43:20.349159 #88811]  INFO -- : Started GET "/breakdown" for 127.0.0.1 at 2019-03-12 19:43:20 +0200
+I, [2019-03-12T19:43:20.351473 #88811]  INFO -- : Processing by DummyController#breakdown as HTML
+D, [2019-03-12T19:43:20.359979 #88811] DEBUG -- :    (0.1ms)  begin transaction
+D, [2019-03-12T19:43:20.361506 #88811] DEBUG -- :   Book Create (0.1ms)  INSERT INTO "books" ("title") VALUES (?)  [["title", "breakdown"]]
+D, [2019-03-12T19:43:20.362713 #88811] DEBUG -- :    (0.0ms)  commit transaction
+I, [2019-03-12T19:43:20.364005 #88811]  INFO -- : Completed 500 Internal Server Error in 12ms (ActiveRecord: 0.8ms)
+F, [2019-03-12T19:43:21.585482 #88811] FATAL -- :   
+F, [2019-03-12T19:43:21.585588 #88811] FATAL -- : AirbrakeTestError (after_commit):
+F, [2019-03-12T19:43:21.585619 #88811] FATAL -- :   
+F, [2019-03-12T19:43:21.585656 #88811] FATAL -- : lib/airbrake/rails/active_record.rb:25:in `run_callbacks'
+lib/airbrake/rack/middleware.rb:33:in `call!'
+lib/airbrake/rack/middleware.rb:21:in `call'

data/spec/integration/rails/rails_spec.rb

@@ -296,17 +296,14 @@ RSpec.describe "Rails integration specs" do
     it "sends performance breakdown info to Airbrake" do
       expect(Airbrake).to receive(:notify_performance_breakdown).with(
         hash_including(
-          route: '/crash(.:format)',
+          route: '/breakdown(.:format)',
           method: 'GET',
           response_type: :html,
-          groups: {
-            db: anything,
-            view: anything
-          }
+          groups: hash_including(db: an_instance_of(Float))
         )
       ).at_least(:once)
 
-      get '/crash'
+      get '/breakdown'
     end
   end
 end

data/spec/unit/rails/action_controller_performance_breakdown_subscriber_spec.rb

@@ -1,7 +1,7 @@
 require 'airbrake/rails/action_controller_performance_breakdown_subscriber'
 
 RSpec.describe Airbrake::Rails::ActionControllerPerformanceBreakdownSubscriber do
-  after { Airbrake::Rack::RequestStore[:routes] = nil }
+  after { Airbrake::Rack::RequestStore.clear }
 
   context "when routes are not set in the request store" do
     before { Airbrake::Rack::RequestStore[:routes] = nil }
@@ -26,8 +26,8 @@ RSpec.describe Airbrake::Rails::ActionControllerPerformanceBreakdownSubscriber d
       OpenStruct.new(
         payload: {
           format: :html,
-          view_runtime: 1.0,
-          db_runtime: 1.0
+          view_runtime: 0.5,
+          db_runtime: 0.5
         }
       )
     end
@@ -46,7 +46,7 @@ RSpec.describe Airbrake::Rails::ActionControllerPerformanceBreakdownSubscriber d
           route: '/test-route',
           method: 'GET',
           response_type: :html,
-          groups: { db: 1.0, view: 1.0 }
+          groups: { db: 0.5, view: 0.5 }
         )
       )
       subject.call([])
@@ -55,13 +55,13 @@ RSpec.describe Airbrake::Rails::ActionControllerPerformanceBreakdownSubscriber d
     context "and when view_runtime is nil" do
       before { event.payload[:view_runtime] = nil }
 
-      it "sets the view group runtime to 0" do
+      it "omits view_runtime" do
         expect(Airbrake).to receive(:notify_performance_breakdown).with(
           hash_including(
             route: '/test-route',
             method: 'GET',
             response_type: :html,
-            groups: { db: 1.0, view: 0 }
+            groups: { db: 0.5 }
           )
         )
         subject.call([])
@@ -71,17 +71,61 @@ RSpec.describe Airbrake::Rails::ActionControllerPerformanceBreakdownSubscriber d
     context "and when db_runtime is nil" do
       before { event.payload[:db_runtime] = nil }
 
-      it "sets the view group runtime to 0" do
+      it "omits db_runtime" do
         expect(Airbrake).to receive(:notify_performance_breakdown).with(
           hash_including(
             route: '/test-route',
             method: 'GET',
             response_type: :html,
-            groups: { db: 0, view: 1.0 }
+            groups: { view: 0.5 }
           )
         )
         subject.call([])
       end
     end
+
+    context "when db_runtime is zero" do
+      before { event.payload[:db_runtime] = 0 }
+
+      it "omits db_runtime" do
+        expect(Airbrake).to receive(:notify_performance_breakdown).with(
+          hash_including(
+            route: '/test-route',
+            method: 'GET',
+            response_type: :html,
+            groups: { view: 0.5 }
+          )
+        )
+        subject.call([])
+      end
+    end
+
+    context "when view_runtime is zero" do
+      before { event.payload[:view_runtime] = 0 }
+
+      it "omits view_runtime" do
+        expect(Airbrake).to receive(:notify_performance_breakdown).with(
+          hash_including(
+            route: '/test-route',
+            method: 'GET',
+            response_type: :html,
+            groups: { db: 0.5 }
+          )
+        )
+        subject.call([])
+      end
+    end
+
+    context "when db_runtime and view_runtime are both zero" do
+      before do
+        event.payload[:db_runtime] = 0
+        event.payload[:view_runtime] = 0
+      end
+
+      it "doesn't notify Airbrake" do
+        expect(Airbrake).not_to receive(:notify_performance_breakdown)
+        subject.call([])
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake
 version: !ruby/object:Gem::Version
-  version: 8.3.1
+  version: 8.3.2
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-11 00:00:00.000000000 Z
+date: 2019-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: airbrake-ruby