airbrake 5.7.0 → 5.7.1

data/spec/integration/rails/rails_spec.rb

@@ -169,13 +169,32 @@ RSpec.describe "Rails integration specs" do
   end
 
   describe "Resque workers" do
-    it "reports exceptions occurring in Resque workers" do
-      with_resque { get '/resque' }
+    context "when Airbrake is configured" do
+      it "reports exceptions occurring in Resque workers" do
+        with_resque { get '/resque' }
 
-      wait_for_a_request_with_body(
-        /"message":"resque\serror".*"params":{.*
+        wait_for_a_request_with_body(
+          /"message":"resque\serror".*"params":{.*
          "class":"BingoWorker","args":\["bango","bongo"\].*}/x
-      )
+        )
+      end
+    end
+
+    context "when Airbrake is not configured" do
+      it "doesn't report errors" do
+        allow(Airbrake).to receive(:build_notice).and_return(nil)
+        allow(Airbrake).to receive(:notify)
+
+        with_resque { get '/resque' }
+
+        wait_for(
+          a_request(:post, endpoint).
+            with(body: /"message":"resque error"/)
+        ).not_to have_been_made
+
+        expect(Airbrake).to have_received(:build_notice)
+        expect(Airbrake).not_to have_received(:notify)
+      end
     end
   end
 
@@ -195,6 +214,32 @@ RSpec.describe "Rails integration specs" do
       # elsewhere.
       sleep 2
     end
+
+    context "when Airbrake is not configured" do
+      it "doesn't report errors" do
+        allow(Airbrake).to receive(:build_notice).and_return(nil)
+        allow(Airbrake).to receive(:notify)
+
+        # Make sure we don't call `build_notice` more than 1 time. Rack
+        # integration will try to handle error 500 and we want to prevent
+        # that: https://github.com/airbrake/airbrake/pull/583
+        allow_any_instance_of(Airbrake::Rack::Middleware).to(
+          receive(:notify_airbrake).
+            and_return(nil)
+        )
+
+        get '/delayed_job'
+        sleep 2
+
+        wait_for(
+          a_request(:post, endpoint).
+            with(body: /"message":"delayed_job error"/)
+        ).not_to have_been_made
+
+        expect(Airbrake).to have_received(:build_notice)
+        expect(Airbrake).not_to have_received(:notify)
+      end
+    end
   end
 
   describe "notice payload when a user is authenticated without Warden" do

data/spec/spec_helper.rb

@@ -5,6 +5,7 @@ require 'rspec/wait'
 require 'rack'
 require 'rack/test'
 require 'rake'
+require 'pry'
 
 require 'airbrake'
 require 'airbrake/rake/tasks'

data/spec/unit/sidekiq/error_handler_spec.rb

@@ -14,20 +14,35 @@ if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.0')
       wait_for(a_request(:post, endpoint).with(body: body)).to have_been_made.once
     end
 
-    before do
-      stub_request(:post, endpoint).to_return(status: 201, body: '{}')
-    end
-
-    it "sends a notice to Airbrake" do
+    def call_handler
       handler = Sidekiq.error_handlers.last
       handler.call(
         AirbrakeTestError.new('sidekiq error'),
         'class' => 'HardSidekiqWorker', 'args' => %w(bango bongo)
       )
+    end
+
+    before do
+      stub_request(:post, endpoint).to_return(status: 201, body: '{}')
+    end
+
+    it "sends a notice to Airbrake" do
+      expect(call_handler).to be_a(Airbrake::Promise)
 
       wait_for_a_request_with_body(/"message":"sidekiq\serror"/)
       wait_for_a_request_with_body(/"params":{.*"args":\["bango","bongo"\]/)
       wait_for_a_request_with_body(/"component":"sidekiq","action":"HardSidekiqWorker"/)
     end
+
+    context "when Airbrake is not configured" do
+      it "returns nil" do
+        allow(Airbrake).to receive(:build_notice).and_return(nil)
+        allow(Airbrake).to receive(:notify)
+
+        expect(call_handler).to be_nil
+        expect(Airbrake).to have_received(:build_notice)
+        expect(Airbrake).not_to have_received(:notify)
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake
 version: !ruby/object:Gem::Version
-  version: 5.7.0
+  version: 5.7.1
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-26 00:00:00.000000000 Z
+date: 2017-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: airbrake-ruby