airbrake 3.1.1 → 3.1.2

data/CHANGELOG

@@ -1,3 +1,14 @@
+Version 3.1.2 - 2012-06-23 02:27:01 +0200
+===============================================================================
+
+Hrvoje Šimić (5):
+      routing errors ignored by default, for #92
+      use simplecov for test coverage
+      fix features for javascript
+      ignore user agents in rack, closes #61
+      error out if controller is undefined
+
+
 Version 3.1.1 - 2012-06-06 20:35:00 -0700
 ===============================================================================
 
@@ -821,3 +832,4 @@ Nick Quaranto (3):
 
 
 
+

data/Gemfile

@@ -7,5 +7,6 @@ if true
     gem 'pry'
     gem 'guard'
     gem 'guard-test'
+    gem 'simplecov'
   end
-end
+end

data/features/rack.feature

@@ -21,3 +21,36 @@ Feature: Use the notifier in a plain Rack app
     When I perform a Rack request to "http://example.com:123/test/index?param=value"
     Then I should receive a Airbrake notification
 
+  Scenario: Ignore user agents
+    Given the following Rack app:
+      """
+      require 'rack'
+      require 'airbrake'
+
+      Airbrake.configure do |config|
+        config.api_key = 'my_api_key'
+        config.ignore_user_agent << /ignore/
+      end
+
+      class Mock
+        class AppendUserAgent
+          def initialize(app)
+            @app = app
+          end
+
+          def call(env)
+            env["HTTP_USER_AGENT"] = "ignore"
+            @app.call(env)
+          end
+        end
+      end
+
+      app = Rack::Builder.app do
+        use Airbrake::Rack
+        use Mock::AppendUserAgent
+        run lambda { |env| raise "Rack down" }
+      end
+      """
+    When I perform a Rack request to "http://example.com:123/test/index?param=value"
+    Then I should not see "** [Airbrake] Response from Airbrake:"
+

data/features/rails.feature

@@ -202,6 +202,10 @@ Feature: Install the Gem in a Rails application
   Scenario: Reporting 404s
     When I configure the Airbrake shim
     And I configure usage of Airbrake
+    And I configure the notifier to use the following configuration lines:
+    """
+    config.ignore_only = []
+    """
     And I perform a request to "http://example.com:123/this/route/does/not/exist"
-    And I should see "The page you were looking for doesn't exist."
+    Then I should see "The page you were looking for doesn't exist."
     And I should receive a Airbrake notification

data/features/support/rails.rb

@@ -122,6 +122,9 @@ module RailsHelpers
         env      = Rack::MockRequest.env_for(#{uri.inspect})
         response = RailsRoot::Application.call(env)
 
+
+        response = response.last if response.last.is_a?(ActionDispatch::Response)
+
         if response.is_a?(Array)
           puts response.join
         else

data/features/support/rake/Rakefile

@@ -44,7 +44,7 @@ task :airbrake_not_yet_configured do
 end
 
 module Airbrake
-  def self.notify(*args)
+  def self.notify_or_ignore(*args)
     # TODO if you need to check more params, you'll have to use json.dump or something
     $stderr.puts "airbrake #{args[1][:component]}"
   end

data/lib/airbrake/rack.rb

@@ -25,18 +25,28 @@ module Airbrake
       Airbrake.configuration.logger ||= Logger.new STDOUT
     end
 
+    def ignored_user_agent?(env)
+      true if Airbrake.
+        configuration.
+        ignore_user_agent.
+        flatten.
+        any? { |ua| ua === env['HTTP_USER_AGENT'] }
+    end
+
+    def notify_airbrake(exception,env)
+      Airbrake.notify_or_ignore(exception,:rack_env => env) unless ignored_user_agent?(env)
+    end
+
     def call(env)
       begin
         response = @app.call(env)
       rescue Exception => raised
-        error_id = Airbrake.notify_or_ignore(raised, :rack_env => env)
-        env['airbrake.error_id'] = error_id
+        env['airbrake.error_id'] = notify_airbrake(raised,env)
         raise
       end
 
       if env['rack.exception']
-        error_id = Airbrake.notify_or_ignore(env['rack.exception'], :rack_env => env)
-        env['airbrake.error_id'] = error_id
+        env['airbrake.error_id'] = notify_airbrake(env['rack.exception'],env)
       end
 
       response

data/lib/airbrake/rails/middleware/exceptions_catcher.rb

@@ -16,8 +16,8 @@ module Airbrake
         def render_exception_with_airbrake(env,exception)
           controller = env['action_controller.instance']
           env['airbrake.error_id'] = Airbrake.
-            notify(exception,
-                   controller.try(:airbrake_request_data) || :rack_env => env) unless skip_user_agent?(env)
+            notify_or_ignore(exception,
+                   controller.try(:airbrake_request_data) || {:rack_env => env}) unless skip_user_agent?(env)
           if defined?(controller.rescue_action_in_public_without_airbrake)
             controller.rescue_action_in_public_without_airbrake(exception)
           end

data/lib/airbrake/version.rb

@@ -1,3 +1,3 @@
 module Airbrake
-  VERSION = "3.1.1".freeze
+  VERSION = "3.1.2".freeze
 end

data/test/helper.rb

@@ -1,3 +1,5 @@
+require 'simplecov'
+SimpleCov.start
 require 'test/unit'
 require 'rubygems'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: airbrake
 version: !ruby/object:Gem::Version
-  version: 3.1.1
+  version: 3.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-07 00:00:00.000000000Z
+date: 2012-06-29 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
-  requirement: &70339779074320 !ruby/object:Gem::Requirement
+  requirement: &70111147519640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70339779074320
+  version_requirements: *70111147519640
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70339779073820 !ruby/object:Gem::Requirement
+  requirement: &70111147517460 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70339779073820
+  version_requirements: *70111147517460
 - !ruby/object:Gem::Dependency
   name: actionpack
-  requirement: &70339779073120 !ruby/object:Gem::Requirement
+  requirement: &70111147515340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 2.3.8
   type: :development
   prerelease: false
-  version_requirements: *70339779073120
+  version_requirements: *70111147515340
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70339779071900 !ruby/object:Gem::Requirement
+  requirement: &70111147514720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: 2.3.8
   type: :development
   prerelease: false
-  version_requirements: *70339779071900
+  version_requirements: *70111147514720
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70339779071440 !ruby/object:Gem::Requirement
+  requirement: &70111147514140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: 2.3.8
   type: :development
   prerelease: false
-  version_requirements: *70339779071440
+  version_requirements: *70111147514140
 - !ruby/object:Gem::Dependency
   name: bourne
-  requirement: &70339779070860 !ruby/object:Gem::Requirement
+  requirement: &70111147513560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '1.0'
   type: :development
   prerelease: false
-  version_requirements: *70339779070860
+  version_requirements: *70111147513560
 - !ruby/object:Gem::Dependency
   name: cucumber
-  requirement: &70339779070400 !ruby/object:Gem::Requirement
+  requirement: &70111147512980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -87,10 +87,10 @@ dependencies:
         version: 0.10.6
   type: :development
   prerelease: false
-  version_requirements: *70339779070400
+  version_requirements: *70111147512980
 - !ruby/object:Gem::Dependency
   name: fakeweb
-  requirement: &70339779069940 !ruby/object:Gem::Requirement
+  requirement: &70111147494720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,10 +98,10 @@ dependencies:
         version: 1.3.0
   type: :development
   prerelease: false
-  version_requirements: *70339779069940
+  version_requirements: *70111147494720
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &70339779069460 !ruby/object:Gem::Requirement
+  requirement: &70111147494200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -109,10 +109,10 @@ dependencies:
         version: 1.4.3.1
   type: :development
   prerelease: false
-  version_requirements: *70339779069460
+  version_requirements: *70111147494200
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70339779069000 !ruby/object:Gem::Requirement
+  requirement: &70111147493680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -120,10 +120,10 @@ dependencies:
         version: 2.6.0
   type: :development
   prerelease: false
-  version_requirements: *70339779069000
+  version_requirements: *70111147493680
 - !ruby/object:Gem::Dependency
   name: sham_rack
-  requirement: &70339779068540 !ruby/object:Gem::Requirement
+  requirement: &70111147493100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -131,10 +131,10 @@ dependencies:
         version: 1.3.0
   type: :development
   prerelease: false
-  version_requirements: *70339779068540
+  version_requirements: *70111147493100
 - !ruby/object:Gem::Dependency
   name: shoulda
-  requirement: &70339779068080 !ruby/object:Gem::Requirement
+  requirement: &70111147492520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -142,10 +142,10 @@ dependencies:
         version: 2.11.3
   type: :development
   prerelease: false
-  version_requirements: *70339779068080
+  version_requirements: *70111147492520
 - !ruby/object:Gem::Dependency
   name: capistrano
-  requirement: &70339779067620 !ruby/object:Gem::Requirement
+  requirement: &70111147491960 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -153,7 +153,7 @@ dependencies:
         version: 2.8.0
   type: :development
   prerelease: false
-  version_requirements: *70339779067620
+  version_requirements: *70111147491960
 description: 
 email: support@airbrake.io
 executables: []