airbrake-ruby 5.2.0-java → 6.0.2-java

data/spec/filters/sql_filter_spec.rb

@@ -20,14 +20,14 @@ RSpec.describe Airbrake::Filters::SqlFilter do
     end
   end
 
-  ALL_DIALECTS = %i[mysql postgres sqlite cassandra oracle].freeze
+  all_dialects = %i[mysql postgres sqlite cassandra oracle].freeze
 
   # rubocop:disable Layout/LineLength
   [
     {
       input: 'SELECT * FROM things;',
       output: 'SELECT * FROM things;',
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT `t001`.`c2` FROM `t001` WHERE `t001`.`c2` = 'value' AND c3=\"othervalue\" LIMIT ?",
       output: "SELECT `t001`.`c2` FROM `t001` WHERE `t001`.`c2` = ? AND c3=? LIMIT ?",
@@ -39,7 +39,7 @@ RSpec.describe Airbrake::Filters::SqlFilter do
     }, {
       input: "SELECT * FROM t WHERE foo='bar/*' AND baz='whatever */qux'",
       output: "SELECT * FROM t WHERE foo=? AND baz=?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT \"t001\".\"c2\" FROM \"t001\" WHERE \"t001\".\"c2\" = 'value' AND c3=1234 LIMIT 1",
       output: "SELECT \"t001\".\"c2\" FROM \"t001\" WHERE \"t001\".\"c2\" = ? AND c3=? LIMIT ?",
@@ -51,19 +51,19 @@ RSpec.describe Airbrake::Filters::SqlFilter do
     }, {
       input: "SELECT * FROM t WHERE foo='bar--' AND\n  baz='qux--'",
       output: "SELECT * FROM t WHERE foo=? AND\n  baz=?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT * FROM foo WHERE bar='baz' /* Hide Me */",
       output: "SELECT * FROM foo WHERE bar=? ?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT * FROM foobar WHERE password='hunter2'\n-- No peeking!",
       output: "SELECT * FROM foobar WHERE password=?\n?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT foo, bar FROM baz WHERE password='hunter2' # Secret",
       output: "SELECT foo, bar FROM baz WHERE password=? ?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT \"col1\", \"col2\" from \"table\" WHERE \"col3\"=E'foo\\'bar\\\\baz' AND country=e'foo\\'bar\\\\baz'",
       output: "SELECT \"col1\", \"col2\" from \"table\" WHERE \"col3\"=E?",
@@ -79,11 +79,11 @@ RSpec.describe Airbrake::Filters::SqlFilter do
     }, {
       input: "SELECT c11.col1, c22.col2 FROM table c11, table c22 WHERE value='nothing'",
       output: "SELECT c11.col1, c22.col2 FROM table c11, table c22 WHERE value=?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "INSERT INTO X VALUES(1, 23456, 123.456, 99+100)",
       output: "INSERT INTO X VALUES(?)",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT * FROM table WHERE name=\"foo\" AND value=\"don't\"",
       output: "SELECT * FROM table WHERE name=? AND value=?",
@@ -91,19 +91,19 @@ RSpec.describe Airbrake::Filters::SqlFilter do
     }, {
       input: "SELECT * FROM table WHERE name='foo' AND value = 'bar'",
       output: "SELECT * FROM table WHERE name=? AND value = ?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT * FROM table WHERE col='foo\\''bar'",
       output: "SELECT * FROM table WHERE col=?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT * FROM table WHERE col1='foo\"bar' AND col2='what\"ever'",
       output: "SELECT * FROM table WHERE col1=? AND col2=?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "select * from accounts where accounts.name != 'dude\n newline' order by accounts.name",
       output: "select * from accounts where accounts.name != ? order by accounts.name",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT * FROM table WHERE col1=\"don't\" AND col2=\"won't\"",
       output: "SELECT * FROM table WHERE col1=? AND col2=?",
@@ -115,7 +115,7 @@ RSpec.describe Airbrake::Filters::SqlFilter do
     }, {
       input: "SELECT * FROM table WHERE name='foo\\' AND color='blue'",
       output: "SELECT * FROM table WHERE name=?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT * FROM table WHERE foo=\"this string ends with a backslash\\\\\"",
       output: "SELECT * FROM table WHERE foo=?",
@@ -123,36 +123,36 @@ RSpec.describe Airbrake::Filters::SqlFilter do
     }, {
       input: "SELECT * FROM table WHERE foo='this string ends with a backslash\\\\'",
       output: "SELECT * FROM table WHERE foo=?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       # TODO: fix this example.
       input: "SELECT * FROM table WHERE name='foo\'' AND color='blue'",
       output: "Error: Airbrake::Query was not filtered",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "INSERT INTO X values('', 'a''b c',0, 1 , 'd''e f''s h')",
       output: "INSERT INTO X values(?)",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT * FROM t WHERE -- '\n  bar='baz' -- '",
       output: "SELECT * FROM t WHERE ?\n  bar=? ?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT * FROM t WHERE /* ' */\n  bar='baz' -- '",
       output: "SELECT * FROM t WHERE ?\n  bar=? ?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT * FROM t WHERE -- '\n  /* ' */ c2='xxx' /* ' */\n  c='x\n  xx' -- '",
       output: "SELECT * FROM t WHERE ?\n  ? c2=? ?\n  c=? ?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT * FROM t WHERE -- '\n  c='x\n  xx' -- '",
       output: "SELECT * FROM t WHERE ?\n  c=? ?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT * FROM foo WHERE col='value1' AND /* don't */ col2='value1' /* won't */",
       output: "SELECT * FROM foo WHERE col=? AND ? col2=? ?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT * FROM table WHERE foo='bar' AND baz=\"nothing to see here'",
       output: "Error: Airbrake::Query was not filtered",
@@ -160,7 +160,7 @@ RSpec.describe Airbrake::Filters::SqlFilter do
     }, {
       input: "SELECT * FROM table WHERE foo='bar' AND baz='nothing to see here",
       output: "Error: Airbrake::Query was not filtered",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "SELECT * FROM \"foo\" WHERE \"foo\" = $a$dollar quotes can be $b$nested$b$$a$ and bar = 'baz'",
       output: "SELECT * FROM \"foo\" WHERE \"foo\" = ? and bar = ?",
@@ -172,11 +172,11 @@ RSpec.describe Airbrake::Filters::SqlFilter do
     }, {
       input: "select * from foo where bar = 'some\\tthing' and baz = 10",
       output: "select * from foo where bar = ? and baz = ?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "select * from users where user = 'user1\\' password = 'hunter 2' -- ->don't count this quote",
       output: "select * from users where user = ?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "select * from foo where bar=q'[baz's]' and x=5",
       output: "select * from foo where bar=? and x=?",
@@ -204,7 +204,7 @@ RSpec.describe Airbrake::Filters::SqlFilter do
     }, {
       input: "select * from foo where bar=1.234e-5 and x=5",
       output: "select * from foo where bar=? and x=?",
-      dialects: ALL_DIALECTS,
+      dialects: all_dialects,
     }, {
       input: "select * from foo where bar=01234567-89ab-cdef-0123-456789abcdef and x=5",
       output: "select * from foo where bar=? and x=?",

data/spec/filters/system_exit_filter_spec.rb

@@ -1,7 +1,9 @@
 RSpec.describe Airbrake::Filters::SystemExitFilter do
+  subject(:system_exit_filter) { described_class.new }
+
   it "marks SystemExit exceptions as ignored" do
     notice = Airbrake::Notice.new(SystemExit.new)
-    expect { subject.call(notice) }.to(
+    expect { system_exit_filter.call(notice) }.to(
       change { notice.ignored? }.from(false).to(true),
     )
   end
@@ -9,6 +11,6 @@ RSpec.describe Airbrake::Filters::SystemExitFilter do
   it "doesn't mark non SystemExit exceptions as ignored" do
     notice = Airbrake::Notice.new(AirbrakeTestError.new)
     expect(notice).not_to be_ignored
-    expect { subject.call(notice) }.not_to(change { notice.ignored? })
+    expect { system_exit_filter.call(notice) }.not_to(change { notice.ignored? })
   end
 end

data/spec/filters/thread_filter_spec.rb

@@ -1,4 +1,6 @@
 RSpec.describe Airbrake::Filters::ThreadFilter do
+  subject(:thread_filter) { described_class.new }
+
   let(:notice) { Airbrake::Notice.new(AirbrakeTestError.new) }
 
   def new_thread
@@ -17,7 +19,7 @@ RSpec.describe Airbrake::Filters::ThreadFilter do
       it "attaches the thread variable" do
         new_thread do |th|
           th.thread_variable_set(:bingo, var)
-          subject.call(notice)
+          thread_filter.call(notice)
         end
 
         expect(notice[:params][:thread][:thread_variables][:bingo]).to eq(var)
@@ -60,7 +62,7 @@ RSpec.describe Airbrake::Filters::ThreadFilter do
       it "converts it to a String and attaches" do
         new_thread do |th|
           th.thread_variable_set(:bingo, Object.new)
-          subject.call(notice)
+          thread_filter.call(notice)
         end
 
         vars = notice[:params][:thread][:thread_variables]
@@ -90,7 +92,7 @@ RSpec.describe Airbrake::Filters::ThreadFilter do
       it "converts objects to a safe objects" do
         new_thread do |th|
           th.thread_variable_set(:bingo, var)
-          subject.call(notice)
+          thread_filter.call(notice)
         end
 
         vars = notice[:params][:thread][:thread_variables]
@@ -121,7 +123,7 @@ RSpec.describe Airbrake::Filters::ThreadFilter do
 
       new_thread do |th|
         th.thread_variable_set(var, :bingo)
-        subject.call(notice)
+        thread_filter.call(notice)
       end
 
       thread_variables = notice[:params][:thread][:thread_variables]
@@ -134,7 +136,7 @@ RSpec.describe Airbrake::Filters::ThreadFilter do
       it "attaches the fiber variable" do
         new_thread do |th|
           th[:bingo] = var
-          subject.call(notice)
+          thread_filter.call(notice)
         end
 
         expect(notice[:params][:thread][:fiber_variables][:bingo]).to eq(var)
@@ -177,7 +179,7 @@ RSpec.describe Airbrake::Filters::ThreadFilter do
       it "converts it to a String and attaches" do
         new_thread do |th|
           th[:bingo] = Object.new
-          subject.call(notice)
+          thread_filter.call(notice)
         end
 
         vars = notice[:params][:thread][:fiber_variables]
@@ -207,7 +209,7 @@ RSpec.describe Airbrake::Filters::ThreadFilter do
       it "converts objects to a safe objects" do
         new_thread do |th|
           th[:bingo] = var
-          subject.call(notice)
+          thread_filter.call(notice)
         end
 
         vars = notice[:params][:thread][:fiber_variables]
@@ -237,31 +239,31 @@ RSpec.describe Airbrake::Filters::ThreadFilter do
   it "appends name" do
     new_thread do |th|
       th.name = 'bingo'
-      subject.call(notice)
+      thread_filter.call(notice)
     end
 
     expect(notice[:params][:thread][:name]).to eq('bingo')
   end
 
   it "appends thread inspect (self)" do
-    subject.call(notice)
+    thread_filter.call(notice)
     expect(notice[:params][:thread][:self]).to match(/\A#<Thread:.+>\z/)
   end
 
   it "appends thread group" do
-    subject.call(notice)
+    thread_filter.call(notice)
     expect(notice[:params][:thread][:group][0]).to match(/\A#<Thread:.+>\z/)
   end
 
   it "appends priority" do
-    subject.call(notice)
+    thread_filter.call(notice)
     expect(notice[:params][:thread][:priority]).to eq(0)
   end
 
   it "appends safe_level", skip: (
     "Not supported on this version of Ruby." unless Airbrake::HAS_SAFE_LEVEL
   ) do
-    subject.call(notice)
+    thread_filter.call(notice)
     expect(notice[:params][:thread][:safe_level]).to eq(0)
   end
 
@@ -270,7 +272,7 @@ RSpec.describe Airbrake::Filters::ThreadFilter do
 
     new_thread do |th|
       th[key] = :bingo
-      subject.call(notice)
+      thread_filter.call(notice)
     end
 
     fiber_variables = notice[:params][:thread][:fiber_variables]

data/spec/loggable_spec.rb

@@ -6,12 +6,12 @@ RSpec.describe Airbrake::Loggable do
   end
 
   describe "#logger" do
-    let(:subject) do
+    subject(:class_with_logger) do
       Class.new { include Airbrake::Loggable }.new
     end
 
     it "returns a logger that has Logger::WARN severity" do
-      expect(subject.logger.level).to eq(Logger::WARN)
+      expect(class_with_logger.logger.level).to eq(Logger::WARN)
     end
   end
 end

data/spec/monotonic_time_spec.rb

@@ -1,23 +1,25 @@
 RSpec.describe Airbrake::MonotonicTime do
+  subject(:monotonic_time) { described_class }
+
   describe ".time_in_ms" do
     it "returns monotonic time in milliseconds" do
-      expect(subject.time_in_ms).to be_a(Float)
+      expect(monotonic_time.time_in_ms).to be_a(Float)
     end
 
     it "always returns time in the future" do
-      old_time = subject.time_in_ms
-      expect(subject.time_in_ms).to be > old_time
+      old_time = monotonic_time.time_in_ms
+      expect(monotonic_time.time_in_ms).to be > old_time
     end
   end
 
   describe ".time_in_s" do
     it "returns monotonic time in seconds" do
-      expect(subject.time_in_s).to be_a(Float)
+      expect(monotonic_time.time_in_s).to be_a(Float)
     end
 
     it "always returns time in the future" do
-      old_time = subject.time_in_s
-      expect(subject.time_in_s).to be > old_time
+      old_time = monotonic_time.time_in_s
+      expect(monotonic_time.time_in_s).to be > old_time
     end
   end
 end

data/spec/nested_exception_spec.rb

@@ -1,73 +1,73 @@
 RSpec.describe Airbrake::NestedException do
   describe "#as_json" do
     context "given exceptions with backtraces" do
+      # rubocop:disable RSpec/MultipleExpectations
       it "unwinds nested exceptions" do
         begin
-          begin
-            raise AirbrakeTestError
-          rescue AirbrakeTestError
-            Ruby21Error.raise_error('bingo')
-          end
-        rescue Ruby21Error => ex
-          nested_exception = described_class.new(ex)
-          exceptions = nested_exception.as_json
-
-          expect(exceptions.size).to eq(2)
-          expect(exceptions[0][:message]).to eq('bingo')
-          expect(exceptions[1][:message]).to eq('App crashed!')
-          expect(exceptions[0][:backtrace]).not_to be_empty
-          expect(exceptions[1][:backtrace]).not_to be_empty
+          raise AirbrakeTestError
+        rescue AirbrakeTestError
+          Ruby21Error.raise_error('bingo')
         end
+      rescue Ruby21Error => ex
+        nested_exception = described_class.new(ex)
+        exceptions = nested_exception.as_json
+
+        expect(exceptions.size).to eq(2)
+        expect(exceptions[0][:message]).to eq('bingo')
+        expect(exceptions[1][:message]).to eq('App crashed!')
+        expect(exceptions[0][:backtrace]).not_to be_empty
+        expect(exceptions[1][:backtrace]).not_to be_empty
       end
+      # rubocop:enable RSpec/MultipleExpectations
 
+      # rubocop:disable RSpec/MultipleExpectations
       it "unwinds no more than 3 nested exceptions" do
         begin
+          raise AirbrakeTestError
+        rescue AirbrakeTestError
           begin
-            raise AirbrakeTestError
-          rescue AirbrakeTestError
+            Ruby21Error.raise_error('bongo')
+          rescue Ruby21Error
             begin
-              Ruby21Error.raise_error('bongo')
+              Ruby21Error.raise_error('bango')
             rescue Ruby21Error
-              begin
-                Ruby21Error.raise_error('bango')
-              rescue Ruby21Error
-                Ruby21Error.raise_error('bingo')
-              end
+              Ruby21Error.raise_error('bingo')
             end
           end
-        rescue Ruby21Error => ex
-          nested_exception = described_class.new(ex)
-          exceptions = nested_exception.as_json
-
-          expect(exceptions.size).to eq(3)
-          expect(exceptions[0][:message]).to eq('bingo')
-          expect(exceptions[1][:message]).to eq('bango')
-          expect(exceptions[2][:message]).to eq('bongo')
-          expect(exceptions[0][:backtrace]).not_to be_empty
-          expect(exceptions[1][:backtrace]).not_to be_empty
         end
+      rescue Ruby21Error => ex
+        nested_exception = described_class.new(ex)
+        exceptions = nested_exception.as_json
+
+        expect(exceptions.size).to eq(3)
+        expect(exceptions[0][:message]).to eq('bingo')
+        expect(exceptions[1][:message]).to eq('bango')
+        expect(exceptions[2][:message]).to eq('bongo')
+        expect(exceptions[0][:backtrace]).not_to be_empty
+        expect(exceptions[1][:backtrace]).not_to be_empty
       end
+      # rubocop:enable RSpec/MultipleExpectations
     end
 
     context "given exceptions without backtraces" do
+      # rubocop:disable RSpec/MultipleExpectations
       it "sets backtrace to nil" do
         begin
-          begin
-            raise AirbrakeTestError
-          rescue AirbrakeTestError => ex2
-            ex2.set_backtrace([])
-            Ruby21Error.raise_error('bingo')
-          end
-        rescue Ruby21Error => ex1
-          ex1.set_backtrace([])
-          nested_exception = described_class.new(ex1)
-          exceptions = nested_exception.as_json
-
-          expect(exceptions.size).to eq(2)
-          expect(exceptions[0][:backtrace]).to be_empty
-          expect(exceptions[1][:backtrace]).to be_empty
+          raise AirbrakeTestError
+        rescue AirbrakeTestError => ex2
+          ex2.set_backtrace([])
+          Ruby21Error.raise_error('bingo')
         end
+      rescue Ruby21Error => ex1
+        ex1.set_backtrace([])
+        nested_exception = described_class.new(ex1)
+        exceptions = nested_exception.as_json
+
+        expect(exceptions.size).to eq(2)
+        expect(exceptions[0][:backtrace]).to be_empty
+        expect(exceptions[1][:backtrace]).to be_empty
       end
+      # rubocop:enable RSpec/MultipleExpectations
     end
   end
 end

data/spec/notice_notifier/options_spec.rb

@@ -1,4 +1,6 @@
 RSpec.describe Airbrake::NoticeNotifier do
+  subject(:notice_notifier) { described_class.new }
+
   let(:project_id) { 105138 }
   let(:project_key) { 'fd04e13d806a90f96614ad8e529b2822' }
   let(:localhost) { 'http://localhost:8080' }
@@ -27,7 +29,7 @@ RSpec.describe Airbrake::NoticeNotifier do
 
           example(title) do
             stub_request(:post, endpoint).to_return(status: 201, body: '{}')
-            subject.notify_sync(ex)
+            notice_notifier.notify_sync(ex)
 
             expect(a_request(:post, endpoint)).to have_been_made.once
           end
@@ -35,7 +37,7 @@ RSpec.describe Airbrake::NoticeNotifier do
 
         path = '/api/v3/projects/105138/notices'
 
-        context "given a full host" do
+        context "given a full host with port" do
           include_examples('endpoint', localhost = 'http://localhost:8080',
                            URI.join(localhost, path),
                            "sends notices to the specified host's endpoint")
@@ -63,13 +65,13 @@ RSpec.describe Airbrake::NoticeNotifier do
 
     describe ":root_directory" do
       before do
-        subject.add_filter(
+        notice_notifier.add_filter(
           Airbrake::Filters::RootDirectoryFilter.new('/home/kyrylo/code'),
         )
       end
 
       it "filters out frames" do
-        subject.notify_sync(ex)
+        notice_notifier.notify_sync(ex)
 
         expect(
           a_request(:post, endpoint)
@@ -82,7 +84,7 @@ RSpec.describe Airbrake::NoticeNotifier do
           before { Airbrake::Config.instance.merge(root_directory: dir) }
 
           it "being included into the notice's payload" do
-            subject.notify_sync(ex)
+            notice_notifier.notify_sync(ex)
             expect(
               a_request(:post, endpoint)
               .with(body: %r{"rootDirectory":"/bingo/bango"}),
@@ -100,6 +102,7 @@ RSpec.describe Airbrake::NoticeNotifier do
       end
     end
 
+    # rubocop:disable RSpec/MultipleMemoizedHelpers
     describe ":proxy" do
       let(:proxy) do
         WEBrick::HTTPServer.new(
@@ -142,7 +145,7 @@ RSpec.describe Airbrake::NoticeNotifier do
             "safe to run this test on 2.6+ once we upgrade to Webmock 3.5+",
           )
         end
-        subject.notify_sync(ex)
+        notice_notifier.notify_sync(ex)
 
         proxied_request = requests.pop(true)
 
@@ -155,13 +158,14 @@ RSpec.describe Airbrake::NoticeNotifier do
         # rubocop:enable Layout/LineLength
       end
     end
+    # rubocop:enable RSpec/MultipleMemoizedHelpers
 
     describe ":environment" do
       context "when present" do
         before { Airbrake::Config.instance.merge(environment: :production) }
 
         it "being included into the notice's payload" do
-          subject.notify_sync(ex)
+          notice_notifier.notify_sync(ex)
           expect(
             a_request(:post, endpoint)
             .with(body: /"context":{.*"environment":"production".*}/),
@@ -175,7 +179,7 @@ RSpec.describe Airbrake::NoticeNotifier do
         before { Airbrake::Config.instance.merge(params) }
 
         it "sends a notice" do
-          subject.notify_sync(ex)
+          notice_notifier.notify_sync(ex)
           expect(a_request(:post, endpoint)).to have_been_made
         end
       end
@@ -184,7 +188,7 @@ RSpec.describe Airbrake::NoticeNotifier do
         before { Airbrake::Config.instance.merge(params) }
 
         it "ignores exceptions occurring in envs that were not configured" do
-          subject.notify_sync(ex)
+          notice_notifier.notify_sync(ex)
           expect(a_request(:post, endpoint)).not_to have_been_made
         end
       end
@@ -207,9 +211,15 @@ RSpec.describe Airbrake::NoticeNotifier do
         include_examples 'ignored notice', params
 
         it "returns early and doesn't try to parse the given exception" do
-          expect(Airbrake::Notice).not_to receive(:new)
-          expect(subject.notify_sync(ex))
+          allow(Airbrake::Notice).to receive(:new)
+
+          expect(notice_notifier.notify_sync(ex))
             .to eq('error' => "current environment 'development' is ignored")
+
+          expect(Airbrake::Notice).not_to have_received(:new)
+        end
+
+        it "doesn't make an HTTP request" do
           expect(a_request(:post, endpoint)).not_to have_been_made
         end
       end
@@ -246,9 +256,9 @@ RSpec.describe Airbrake::NoticeNotifier do
           end
 
           it "sends a notice" do
-            notice = subject.build_notice(ex)
+            notice = notice_notifier.build_notice(ex)
             notice[:context][:headers] = 'banana'
-            subject.notify_sync(notice)
+            notice_notifier.notify_sync(notice)
 
             expect(a_request(:post, endpoint)).to have_been_made
           end