airbrake-ruby 5.1.0 → 5.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 249098c5348f018ea17258df9ff7bbc4bde71c8e3f0a75c8e6fc00c5f30446b7
-  data.tar.gz: 1936144cbf286ab6e43fbd8874d4093357ee4f7c2a7c43f0d7e507290e081d53
+  metadata.gz: a9438fdfe9308d48989fc04e1f9873c4cab46f7c22487ae1bd3d22e917d73f60
+  data.tar.gz: '08e6b8f6af0fd1ff980e642d9ce540c6c407844d34249bb921b9a15cd5f74ad7'
 SHA512:
-  metadata.gz: 16fadd2ad3df2deb38208b463fe0df57790e07a47db70d48a01094efc58f5937429042208be4fb2413a91d28ea7e71ab046a898079d9b74060f226de80cdcbc2
-  data.tar.gz: 371aea04d52fef881b2b74c9781f0788b536711e1cfeecfd328ee6778f629e7f19eab793a557f42f6fa1603709ae7e20b1ec1abba527f26149acb3581a633f6c
+  metadata.gz: e6e892017febffa214ab8ea921fa8c09b1a27e6c2b0874d669e0dd64004b21fa27bd13ea65b750505e9c702c7248314e8d77ca6b57cb1ec4332c9157712d866d
+  data.tar.gz: c1ebc53b428eca54eb4c85e4fc094819c9c2972308b97069c6234502159d57c2b5977203fb8a60dd3865e7f8dca2f0430dd0f1500ef2df89f8f059a881433740

data/lib/airbrake-ruby/config.rb

@@ -126,6 +126,8 @@ module Airbrake
 
     # @return [String] the host such as which should be used for fetching remote
     #   configuration options (example: "https://bucket-name.s3.amazonaws.com")
+    # @api private
+    # @since 5.0.0
     attr_accessor :remote_config_host
 
     class << self
@@ -151,7 +153,7 @@ module Airbrake
       self.project_key = user_config[:project_key]
       self.error_host = 'https://api.airbrake.io'
       self.apm_host = 'https://api.airbrake.io'
-      self.remote_config_host = 'https://v1-production-notifier-configs.s3.amazonaws.com'
+      self.remote_config_host = 'https://notifier-configs.airbrake.io'
 
       self.ignore_environments = []
 

data/lib/airbrake-ruby/remote_settings.rb

@@ -22,6 +22,9 @@ module Airbrake
       language: "#{RUBY_ENGINE}/#{RUBY_VERSION}".freeze,
     ).freeze
 
+    # @return [String]
+    HTTP_OK = '200'.freeze
+
     # Polls remote config of the given project.
     #
     # @param [Integer] project_id
@@ -71,22 +74,20 @@ module Airbrake
     def fetch_config
       response = nil
       begin
-        response = Net::HTTP.get(build_config_uri)
+        response = Net::HTTP.get_response(build_config_uri)
       rescue StandardError => ex
         logger.error(ex)
         return {}
       end
 
-      # AWS S3 API returns XML when request is not valid. In this case we just
-      # print the returned body and exit the method.
-      if response.start_with?('<?xml ')
-        logger.error(response)
+      unless response.code == HTTP_OK
+        logger.error(response.body)
         return {}
       end
 
       json = nil
       begin
-        json = JSON.parse(response)
+        json = JSON.parse(response.body)
       rescue JSON::ParserError => ex
         logger.error(ex)
         return {}

data/lib/airbrake-ruby/version.rb

@@ -3,7 +3,7 @@
 module Airbrake
   # @return [String] the library version
   # @api public
-  AIRBRAKE_RUBY_VERSION = '5.1.0'.freeze
+  AIRBRAKE_RUBY_VERSION = '5.1.1'.freeze
 
   # @return [Hash{Symbol=>String}] the information about the notifier library
   # @since 5.0.0

data/spec/config_spec.rb

@@ -28,7 +28,7 @@ RSpec.describe Airbrake::Config do
   its(:error_notifications) { is_expected.to eq(true) }
 
   its(:remote_config_host) do
-    is_expected.to eq('https://v1-production-notifier-configs.s3.amazonaws.com')
+    is_expected.to eq('https://notifier-configs.airbrake.io')
   end
 
   describe "#new" do

data/spec/remote_settings_spec.rb

@@ -83,7 +83,7 @@ RSpec.describe Airbrake::RemoteSettings do
 
     context "when an error is raised while making a HTTP request" do
       before do
-        allow(Net::HTTP).to receive(:get).and_raise(StandardError)
+        allow(Net::HTTP).to receive(:get_response).and_raise(StandardError)
       end
 
       it "doesn't fetch remote settings" do
@@ -117,10 +117,10 @@ RSpec.describe Airbrake::RemoteSettings do
       end
     end
 
-    context "when API returns an XML response" do
+    context "when API returns a non-200 response" do
       let!(:stub) do
         stub_request(:get, Regexp.new(endpoint))
-          .to_return(status: 200, body: '<?xml ...')
+          .to_return(status: 201, body: body.to_json)
       end
 
       it "doesn't update settings data" do
@@ -134,6 +134,29 @@ RSpec.describe Airbrake::RemoteSettings do
         expect(stub).to have_been_requested.once
         expect(settings.interval).to eq(600)
       end
+
+      it "logs error" do
+        expect(Airbrake::Loggable.instance).to receive(:error).with(body.to_json)
+
+        remote_settings = described_class.poll(project_id, host) {}
+        sleep(0.1)
+        remote_settings.stop_polling
+      end
+    end
+
+    context "when API returns a 200 response" do
+      let!(:stub) do
+        stub_request(:get, Regexp.new(endpoint))
+          .to_return(status: 200, body: body.to_json)
+      end
+
+      it "doesn't log errors" do
+        expect(Airbrake::Loggable.instance).not_to receive(:error)
+
+        remote_settings = described_class.poll(project_id, host) {}
+        sleep(0.1)
+        remote_settings.stop_polling
+      end
     end
 
     context "when a config route is specified in the returned data" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake-ruby
 version: !ruby/object:Gem::Version
-  version: 5.1.0
+  version: 5.1.1
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-20 00:00:00.000000000 Z
+date: 2020-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rbtree3