airbrake-ruby 4.6.0 → 6.2.2

data/spec/filters/keys_whitelist_spec.rb

@@ -1,194 +0,0 @@
-RSpec.describe Airbrake::Filters::KeysWhitelist do
-  subject { described_class.new(patterns) }
-
-  let(:notice) { Airbrake::Notice.new(AirbrakeTestError.new) }
-
-  shared_examples 'pattern matching' do |patts, params|
-    let(:patterns) { patts }
-
-    it "filters out the matching values" do
-      notice[:params] = params.first
-      subject.call(notice)
-      expect(notice[:params]).to eq(params.last)
-    end
-  end
-
-  context "when a pattern is a Regexp" do
-    include_examples(
-      'pattern matching',
-      [/\Abin/],
-      [
-        { bingo: 'bango', bongo: 'bish', bash: 'bosh' },
-        { bingo: 'bango', bongo: '[Filtered]', bash: '[Filtered]' }
-      ]
-    )
-  end
-
-  context "when a pattern is a Symbol" do
-    include_examples(
-      'pattern matching',
-      [:bongo],
-      [
-        { bongo: 'bish', bash: 'bosh', bbashh: 'bboshh' },
-        { bongo: 'bish', bash: '[Filtered]', bbashh: '[Filtered]' }
-      ]
-    )
-  end
-
-  context "when a pattern is a String" do
-    include_examples(
-      'pattern matching',
-      ['bash'],
-      [
-        { bingo: 'bango', bongo: 'bish', bash: 'bosh' },
-        { bingo: '[Filtered]', bongo: '[Filtered]', bash: 'bosh' }
-      ]
-    )
-  end
-
-  context "when a Proc pattern was provided" do
-    context "along with normal keys" do
-      include_examples(
-        'pattern matching',
-        [proc { 'bongo' }, :bash],
-        [
-          { bingo: 'bango', bongo: 'bish', bash: 'bosh' },
-          { bingo: '[Filtered]', bongo: 'bish', bash: 'bosh' }
-        ]
-      )
-    end
-
-    context "which doesn't return an array of keys" do
-      include_examples(
-        'pattern matching',
-        [proc { Object.new }],
-        [
-          { bingo: 'bango', bongo: 'bish', bash: 'bosh' },
-          { bingo: '[Filtered]', bongo: '[Filtered]', bash: '[Filtered]' }
-        ]
-      )
-
-      it "logs an error" do
-        expect(Airbrake::Loggable.instance).to receive(:error).with(
-          /KeysWhitelist is invalid.+patterns: \[#<Object:.+>\]/
-        )
-        keys_whitelist = described_class.new(patterns)
-        keys_whitelist.call(notice)
-      end
-    end
-
-    context "which returns another Proc" do
-      let(:patterns) { [proc { proc { ['bingo'] } }] }
-
-      context "and when the filter is called once" do
-        it "logs an error" do
-          expect(Airbrake::Loggable.instance).to receive(:error).with(
-            /KeysWhitelist is invalid.+patterns: \[#<Proc:.+>\]/
-          )
-          keys_whitelist = described_class.new(patterns)
-          keys_whitelist.call(notice)
-        end
-
-        include_examples(
-          'pattern matching',
-          [proc { proc { ['bingo'] } }],
-          [
-            { bingo: 'bango', bongo: 'bish', bash: 'bosh' },
-            { bingo: '[Filtered]', bongo: '[Filtered]', bash: '[Filtered]' }
-          ]
-        )
-      end
-    end
-  end
-
-  context "when a pattern is invalid" do
-    include_examples(
-      'pattern matching',
-      [Object.new],
-      [
-        { bingo: 'bango', bongo: 'bish', bash: 'bosh' },
-        { bingo: '[Filtered]', bongo: '[Filtered]', bash: '[Filtered]' }
-      ]
-    )
-
-    it "logs an error" do
-      expect(Airbrake::Loggable.instance).to receive(:error).with(
-        /KeysWhitelist is invalid.+patterns: \[#<Object:.+>\]/
-      )
-      keys_whitelist = described_class.new(patterns)
-      keys_whitelist.call(notice)
-    end
-  end
-
-  context "when a value contains a nested hash" do
-    context "and it is non-recursive" do
-      include_examples(
-        'pattern matching',
-        %w[bongo bish],
-        [
-          { bingo: 'bango', bongo: { bish: 'bash' } },
-          { bingo: '[Filtered]', bongo: { bish: 'bash' } }
-        ]
-      )
-    end
-
-    context "and it is recursive" do
-      let(:patterns) { ['bingo'] }
-
-      it "raises error (MRI)", skip: (
-        # MRI 2.3 & 2.4 may segfault on Circle CI. Example build:
-        # https://circleci.com/workflow-run/c112358c-e7bf-4789-9eb2-4891ea84da68
-        RUBY_ENGINE == 'ruby' && RUBY_VERSION =~ /\A2\.[34]\.\d+\z/
-      ) do
-        bongo = {}
-        bongo[:bingo] = bongo
-        notice[:params] = bongo
-
-        begin
-          expect { subject.call(notice) }.to raise_error(SystemStackError)
-        rescue RSpec::Expectations::ExpectationNotMetError => ex
-          # JRuby might raise two different exceptions, which represent the same
-          # thing. One is a Java exception, the other is a Ruby exception.
-          # Likely a bug: https://github.com/jruby/jruby/issues/1903
-          raise ex unless RUBY_ENGINE == 'jruby'
-          expect { subject.call(notice) }.to raise_error(java.lang.StackOverflowError)
-        end
-      end
-    end
-  end
-
-  describe "context payload" do
-    describe "URL" do
-      let(:patterns) { ['bish'] }
-
-      context "when it contains query params" do
-        it "filters the params" do
-          notice[:context][:url] = 'http://localhost:3000/crash?foo=bar&baz=bongo&bish=bash'
-          subject.call(notice)
-          expect(notice[:context][:url]).to(
-            eq('http://localhost:3000/crash?foo=[Filtered]&baz=[Filtered]&bish=bash')
-          )
-        end
-      end
-
-      context "when it is invalid" do
-        it "leaves the URL unfiltered" do
-          notice[:context][:url] =
-            'http://localhost:3000/cra]]]sh?foo=bar&baz=bongo&bish=bash'
-          subject.call(notice)
-          expect(notice[:context][:url]).to(
-            eq('http://localhost:3000/cra]]]sh?foo=bar&baz=bongo&bish=bash')
-          )
-        end
-      end
-
-      context "when it is without a query" do
-        it "leaves the URL untouched" do
-          notice[:context][:url] = 'http://localhost:3000/crash'
-          subject.call(notice)
-          expect(notice[:context][:url]).to(eq('http://localhost:3000/crash'))
-        end
-      end
-    end
-  end
-end

data/spec/filters/root_directory_filter_spec.rb

@@ -1,39 +0,0 @@
-RSpec.describe Airbrake::Filters::RootDirectoryFilter do
-  subject { described_class.new(root_directory) }
-
-  let(:root_directory) { '/var/www/project' }
-  let(:notice) { Airbrake::Notice.new(AirbrakeTestError.new) }
-
-  it "replaces root directory in the backtrace with a label" do
-    # rubocop:disable Metrics/LineLength
-    notice[:errors].first[:backtrace] = [
-      { file: "/home/kyrylo/code/airbrake/ruby/spec/spec_helper.rb" },
-      { file: "#{root_directory}/gems/rspec-core-3.3.2/lib/rspec/core/configuration.rb " },
-      { file: "/opt/rubies/ruby-2.2.2/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb" },
-      { file: "#{root_directory}/gems/rspec-core-3.3.2/exe/rspec" }
-    ]
-    # rubocop:enable Metrics/LineLength
-
-    subject.call(notice)
-
-    # rubocop:disable Metrics/LineLength
-    expect(notice[:errors].first[:backtrace]).to(
-      eq(
-        [
-          { file: "/home/kyrylo/code/airbrake/ruby/spec/spec_helper.rb" },
-          { file: "/PROJECT_ROOT/gems/rspec-core-3.3.2/lib/rspec/core/configuration.rb " },
-          { file: "/opt/rubies/ruby-2.2.2/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb" },
-          { file: "/PROJECT_ROOT/gems/rspec-core-3.3.2/exe/rspec" }
-        ]
-      )
-    )
-    # rubocop:enable Metrics/LineLength
-  end
-
-  it "does not filter file when it is nil" do
-    expect(notice[:errors].first[:file]).to be_nil
-    expect { subject.call(notice) }.not_to(
-      change { notice[:errors].first[:file] }
-    )
-  end
-end

data/spec/filters/sql_filter_spec.rb

@@ -1,219 +0,0 @@
-RSpec.describe Airbrake::Filters::SqlFilter do
-  shared_examples "query filtering" do |test|
-    test[:dialects].each do |dialect|
-      it "correctly filters SQL like `#{test[:input]}' (#{dialect} dialect)" do
-        filter = described_class.new(dialect)
-        q = OpenStruct.new(query: test[:input])
-        filter.call(q)
-        expect(q.query).to eq(test[:output])
-      end
-    end
-  end
-
-  ALL_DIALECTS = %i[mysql postgres sqlite cassandra oracle].freeze
-
-  # rubocop:disable Metrics/LineLength
-  [
-    {
-      input: 'SELECT * FROM things;',
-      output: 'SELECT * FROM things;',
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT `t001`.`c2` FROM `t001` WHERE `t001`.`c2` = 'value' AND c3=\"othervalue\" LIMIT ?",
-      output: "SELECT `t001`.`c2` FROM `t001` WHERE `t001`.`c2` = ? AND c3=? LIMIT ?",
-      dialects: %i[mysql]
-    }, {
-      input: "SELECT * FROM t WHERE foo=\"bar/*\" AND baz=\"whatever */qux\"",
-      output: "SELECT * FROM t WHERE foo=? AND baz=?",
-      dialects: %i[mysql]
-    }, {
-      input: "SELECT * FROM t WHERE foo='bar/*' AND baz='whatever */qux'",
-      output: "SELECT * FROM t WHERE foo=? AND baz=?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT \"t001\".\"c2\" FROM \"t001\" WHERE \"t001\".\"c2\" = 'value' AND c3=1234 LIMIT 1",
-      output: "SELECT \"t001\".\"c2\" FROM \"t001\" WHERE \"t001\".\"c2\" = ? AND c3=? LIMIT ?",
-      dialects: %i[postgres oracle]
-    }, {
-      input: "SELECT * FROM t WHERE foo=\"bar--\" AND\n  baz=\"qux--\"",
-      output: "SELECT * FROM t WHERE foo=? AND\n  baz=?",
-      dialects: %i[mysql]
-    }, {
-      input: "SELECT * FROM t WHERE foo='bar--' AND\n  baz='qux--'",
-      output: "SELECT * FROM t WHERE foo=? AND\n  baz=?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT * FROM foo WHERE bar='baz' /* Hide Me */",
-      output: "SELECT * FROM foo WHERE bar=? ?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT * FROM foobar WHERE password='hunter2'\n-- No peeking!",
-      output: "SELECT * FROM foobar WHERE password=?\n?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT foo, bar FROM baz WHERE password='hunter2' # Secret",
-      output: "SELECT foo, bar FROM baz WHERE password=? ?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT \"col1\", \"col2\" from \"table\" WHERE \"col3\"=E'foo\\'bar\\\\baz' AND country=e'foo\\'bar\\\\baz'",
-      output: "SELECT \"col1\", \"col2\" from \"table\" WHERE \"col3\"=E?",
-      dialects: %i[postgres]
-    }, {
-      input: "INSERT INTO `X` values(\"test\",0, 1 , 2, 'test')",
-      output: "INSERT INTO `X` values(?,?, ? , ?, ?)",
-      dialects: %i[mysql]
-    }, {
-      input: "SELECT c11.col1, c22.col2 FROM table c11, table c22 WHERE value='nothing'",
-      output: "SELECT c11.col1, c22.col2 FROM table c11, table c22 WHERE value=?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "INSERT INTO X VALUES(1, 23456, 123.456, 99+100)",
-      output: "INSERT INTO X VALUES(?, ?, ?, ?+?)",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT * FROM table WHERE name=\"foo\" AND value=\"don't\"",
-      output: "SELECT * FROM table WHERE name=? AND value=?",
-      dialects: %i[mysql]
-    }, {
-      input: "SELECT * FROM table WHERE name='foo' AND value = 'bar'",
-      output: "SELECT * FROM table WHERE name=? AND value = ?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT * FROM table WHERE col='foo\\''bar'",
-      output: "SELECT * FROM table WHERE col=?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT * FROM table WHERE col1='foo\"bar' AND col2='what\"ever'",
-      output: "SELECT * FROM table WHERE col1=? AND col2=?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "select * from accounts where accounts.name != 'dude\n newline' order by accounts.name",
-      output: "select * from accounts where accounts.name != ? order by accounts.name",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT * FROM table WHERE col1=\"don't\" AND col2=\"won't\"",
-      output: "SELECT * FROM table WHERE col1=? AND col2=?",
-      dialects: %i[mysql]
-    }, {
-      input: "INSERT INTO X values('', 'jim''s ssn',0, 1 , 'jim''s son''s son', \"\"\"jim''s\"\" hat\", \"\\\"jim''s secret\\\"\")",
-      output: "INSERT INTO X values(?, ?,?, ? , ?, ?, ?",
-      dialects: %i[mysql]
-    }, {
-      input: "SELECT * FROM table WHERE name='foo\\' AND color='blue'",
-      output: "SELECT * FROM table WHERE name=?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT * FROM table WHERE foo=\"this string ends with a backslash\\\\\"",
-      output: "SELECT * FROM table WHERE foo=?",
-      dialects: %i[mysql]
-    }, {
-      input: "SELECT * FROM table WHERE foo='this string ends with a backslash\\\\'",
-      output: "SELECT * FROM table WHERE foo=?",
-      dialects: ALL_DIALECTS
-    }, {
-      # TODO: fix this example.
-      input: "SELECT * FROM table WHERE name='foo\'' AND color='blue'",
-      output: "Error: Airbrake::Query was not filtered",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "INSERT INTO X values('', 'a''b c',0, 1 , 'd''e f''s h')",
-      output: "INSERT INTO X values(?, ?,?, ? , ?)",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT * FROM t WHERE -- '\n  bar='baz' -- '",
-      output: "SELECT * FROM t WHERE ?\n  bar=? ?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT * FROM t WHERE /* ' */\n  bar='baz' -- '",
-      output: "SELECT * FROM t WHERE ?\n  bar=? ?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT * FROM t WHERE -- '\n  /* ' */ c2='xxx' /* ' */\n  c='x\n  xx' -- '",
-      output: "SELECT * FROM t WHERE ?\n  ? c2=? ?\n  c=? ?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT * FROM t WHERE -- '\n  c='x\n  xx' -- '",
-      output: "SELECT * FROM t WHERE ?\n  c=? ?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT * FROM foo WHERE col='value1' AND /* don't */ col2='value1' /* won't */",
-      output: "SELECT * FROM foo WHERE col=? AND ? col2=? ?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT * FROM table WHERE foo='bar' AND baz=\"nothing to see here'",
-      output: "Error: Airbrake::Query was not filtered",
-      dialects: %i[mysql]
-    }, {
-      input: "SELECT * FROM table WHERE foo='bar' AND baz='nothing to see here",
-      output: "Error: Airbrake::Query was not filtered",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "SELECT * FROM \"foo\" WHERE \"foo\" = $a$dollar quotes can be $b$nested$b$$a$ and bar = 'baz'",
-      output: "SELECT * FROM \"foo\" WHERE \"foo\" = ? and bar = ?",
-      dialects: %i[postgres]
-    }, {
-      input: "INSERT INTO \"foo\" (\"bar\", \"baz\", \"qux\") VALUES ($1, $2, $3) RETURNING \"id\"",
-      output: "INSERT INTO \"foo\" (\"bar\", \"baz\", \"qux\") VALUES ($?, $?, $?) RETURNING \"id\"",
-      dialects: %i[postgres]
-    }, {
-      input: "select * from foo where bar = 'some\\tthing' and baz = 10",
-      output: "select * from foo where bar = ? and baz = ?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "select * from users where user = 'user1\\' password = 'hunter 2' -- ->don't count this quote",
-      output: "select * from users where user = ?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "select * from foo where bar=q'[baz's]' and x=5",
-      output: "select * from foo where bar=? and x=?",
-      dialects: %i[oracle]
-    }, {
-      input: "select * from foo where bar=q'{baz's}' and x=5",
-      output: "select * from foo where bar=? and x=?",
-      dialects: %i[oracle]
-    }, {
-      input: "select * from foo where bar=q'<baz's>' and x=5",
-      output: "select * from foo where bar=? and x=?",
-      dialects: %i[oracle]
-    }, {
-      input: "select * from foo where bar=q'(baz's)' and x=5",
-      output: "select * from foo where bar=? and x=?",
-      dialects: %i[oracle]
-    }, {
-      input: "select * from foo where bar=0xabcdef123 and x=5",
-      output: "select * from foo where bar=? and x=?",
-      dialects: %i[cassandra sqlite]
-    }, {
-      input: "select * from foo where bar=0x2F and x=5",
-      output: "select * from foo where bar=? and x=?",
-      dialects: %i[mysql cassandra sqlite]
-    }, {
-      input: "select * from foo where bar=1.234e-5 and x=5",
-      output: "select * from foo where bar=? and x=?",
-      dialects: ALL_DIALECTS
-    }, {
-      input: "select * from foo where bar=01234567-89ab-cdef-0123-456789abcdef and x=5",
-      output: "select * from foo where bar=? and x=?",
-      dialects: %i[postgres cassandra]
-    }, {
-      input: "select * from foo where bar={01234567-89ab-cdef-0123-456789abcdef} and x=5",
-      output: "select * from foo where bar=? and x=?",
-      dialects: %i[postgres]
-    }, {
-      input: "select * from foo where bar=0123456789abcdef0123456789abcdef and x=5",
-      output: "select * from foo where bar=? and x=?",
-      dialects: %i[postgtes]
-    }, {
-      input: "select * from foo where bar={012-345678-9abc-def012345678-9abcdef} and x=5",
-      output: "select * from foo where bar=? and x=?",
-      dialects: %i[postgres]
-    }, {
-      input: "select * from foo where bar=true and x=FALSE",
-      output: "select * from foo where bar=? and x=?",
-      dialects: %i[mysql postgres cassandra sqlite]
-    }
-  ].each do |test|
-    include_examples 'query filtering', test
-  end
-  # rubocop:enable Metrics/LineLength
-end

data/spec/filters/system_exit_filter_spec.rb

@@ -1,14 +0,0 @@
-RSpec.describe Airbrake::Filters::SystemExitFilter do
-  it "marks SystemExit exceptions as ignored" do
-    notice = Airbrake::Notice.new(SystemExit.new)
-    expect { subject.call(notice) }.to(
-      change { notice.ignored? }.from(false).to(true)
-    )
-  end
-
-  it "doesn't mark non SystemExit exceptions as ignored" do
-    notice = Airbrake::Notice.new(AirbrakeTestError.new)
-    expect(notice).not_to be_ignored
-    expect { subject.call(notice) }.not_to(change { notice.ignored? })
-  end
-end