airbrake-ruby 4.4.0 → 4.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0e642b4f41129e726c7f8107ca0d1eeb6880a701
-  data.tar.gz: 01f580af59e4108972b56ea5dd2cc9eb00e40140
+  metadata.gz: b9aea7ecb085e30e5e237e2a2299265d1df6b950
+  data.tar.gz: 7d2a2130e69749306f0792eb786237122b0bd514
 SHA512:
-  metadata.gz: 3fcf97fff4a036e3be64919f31b38c6e195ff71b9e108181026c9a18d11ce89ab32bd59b496563c967d861d89014e60e2d4d84c3d18f81627c916f3628b35c58
-  data.tar.gz: 17923e72b4a4938fff36c4feb68df58fea240a96d957c72866feae53b920c3dcfee5ba3fcf5c3a2354279ef309156c2d7879856035454eccca7e8b0109ff58fc
+  metadata.gz: c78add83dd9ec84df8f1031ba1233a85eac988ce3c57cbd08b419ec67f7f609fe54ceaf16669dd3a0d80d24621a8254693604e264e8213ce9bd826ad1f16588d
+  data.tar.gz: 61587145c472a7be1a62ace1cb426f7aa766318676c4999b3fabb6570aaf813d181f5e553ae17edf7e1c08e8f9b99bda5693f682595c7489b22c55653175bd4b

data/lib/airbrake-ruby/async_sender.rb

@@ -9,6 +9,12 @@ module Airbrake
   class AsyncSender
     include Loggable
 
+    # @return [String]
+    WILL_NOT_DELIVER_MSG =
+      "%<log_label>s AsyncSender has reached its capacity of %<capacity>s " \
+      "and the following notice will not be delivered " \
+      "Error: %<type>s - %<message>s\nBacktrace: %<backtrace>s\n".freeze
+
     # @return [ThreadGroup] the list of workers
     # @note This is exposed for eaiser unit testing
     # @since v4.0.0
@@ -36,7 +42,7 @@ module Airbrake
     #   library
     # @return [Airbrake::Promise]
     def send(notice, promise)
-      return will_not_deliver(notice) if @unsent.size >= @unsent.max
+      return will_not_deliver(notice, promise) if @unsent.size >= @unsent.max
 
       @unsent << [notice, promise]
       promise
@@ -115,17 +121,22 @@ module Airbrake
       end
     end
 
-    def will_not_deliver(notice)
-      backtrace = notice[:errors][0][:backtrace].map do |line|
-        "#{line[:file]}:#{line[:line]} in `#{line[:function]}'"
-      end
+    def will_not_deliver(notice, promise)
+      error = notice[:errors].first
+
       logger.error(
-        "#{LOG_LABEL} AsyncSender has reached its capacity of "                   \
-        "#{@unsent.max} and the following notice will not be delivered "          \
-        "Error: #{notice[:errors][0][:type]} - #{notice[:errors][0][:message]}\n" \
-        "Backtrace: \n" + backtrace.join("\n")
+        format(
+          WILL_NOT_DELIVER_MSG,
+          log_label: LOG_LABEL,
+          capacity: @unsent.max,
+          type: error[:type],
+          message: error[:message],
+          backtrace: error[:backtrace].map do |line|
+            "#{line[:file]}:#{line[:line]} in `#{line[:function]}'"
+          end.join("\n")
+        )
       )
-      nil
+      promise.reject("AsyncSender has reached its capacity of #{@unsent.max}")
     end
   end
 end

data/lib/airbrake-ruby/config.rb

@@ -130,7 +130,7 @@ module Airbrake
       )
 
       self.versions = {}
-      self.performance_stats = false
+      self.performance_stats = true
       self.performance_stats_flush_period = 15
 
       merge(user_config)

data/lib/airbrake-ruby/version.rb

@@ -2,5 +2,5 @@
 # More information: http://semver.org/
 module Airbrake
   # @return [String] the library version
-  AIRBRAKE_RUBY_VERSION = '4.4.0'.freeze
+  AIRBRAKE_RUBY_VERSION = '4.5.0'.freeze
 end

data/spec/async_sender_spec.rb

@@ -49,6 +49,14 @@ RSpec.describe Airbrake::AsyncSender do
         end
         subject.close
       end
+
+      it "returns a rejected promise" do
+        promise = Airbrake::Promise.new
+        200.times { subject.send(notice, promise) }
+        expect(promise.value).to eq(
+          'error' => "AsyncSender has reached its capacity of #{queue_size}"
+        )
+      end
     end
   end
 

data/spec/config_spec.rb

@@ -19,7 +19,7 @@ RSpec.describe Airbrake::Config do
   its(:timeout) { is_expected.to be_nil }
   its(:blacklist_keys) { is_expected.to be_empty }
   its(:whitelist_keys) { is_expected.to be_empty }
-  its(:performance_stats) { is_expected.to be_falsey }
+  its(:performance_stats) { is_expected.to eq(true) }
   its(:performance_stats_flush_period) { is_expected.to eq(15) }
 
   describe "#new" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake-ruby
 version: !ruby/object:Gem::Version
-  version: 4.4.0
+  version: 4.5.0
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-09 00:00:00.000000000 Z
+date: 2019-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rbtree3