airbrake-ruby 4.0.1 → 4.1.0

data/spec/deploy_notifier_spec.rb

@@ -1,13 +1,24 @@
 RSpec.describe Airbrake::DeployNotifier do
-  before { Airbrake::Config.instance = Airbrake::Config.new(project_id: 1) }
+  before do
+    Airbrake::Config.instance = Airbrake::Config.new(project_id: 1, project_key: '123')
+  end
 
   describe "#notify" do
     it "returns a promise" do
-      stub_request(:post, 'https://api.airbrake.io/api/v4/projects/1/deploys').
-        to_return(status: 201, body: '{}')
+      stub_request(:post, 'https://api.airbrake.io/api/v4/projects/1/deploys')
+        .to_return(status: 201, body: '{}')
       expect(subject.notify({})).to be_an(Airbrake::Promise)
     end
 
+    context "when config is invalid" do
+      before { Airbrake::Config.instance.merge(project_id: nil) }
+
+      it "returns a rejected promise" do
+        promise = subject.notify({})
+        expect(promise).to be_rejected
+      end
+    end
+
     context "when environment is configured" do
       before { Airbrake::Config.instance.merge(environment: 'fooenv') }
 

data/spec/filters/git_repository_filter.rb

@@ -7,20 +7,20 @@ RSpec.describe Airbrake::Filters::GitRepositoryFilter do
 
   describe "#initialize" do
     it "parses standard git version" do
-      allow_any_instance_of(Kernel).
-        to receive(:`).and_return('git version 2.18.0')
+      allow_any_instance_of(Kernel)
+        .to receive(:`).and_return('git version 2.18.0')
       expect { subject }.not_to raise_error
     end
 
     it "parses release candidate git version" do
-      allow_any_instance_of(Kernel).
-        to receive(:`).and_return('git version 2.21.0-rc0')
+      allow_any_instance_of(Kernel)
+        .to receive(:`).and_return('git version 2.21.0-rc0')
       expect { subject }.not_to raise_error
     end
 
     it "parses git version with brackets" do
-      allow_any_instance_of(Kernel).
-        to receive(:`).and_return('git version 2.17.2 (Apple Git-113)')
+      allow_any_instance_of(Kernel)
+        .to receive(:`).and_return('git version 2.17.2 (Apple Git-113)')
       expect { subject }.not_to raise_error
     end
   end

data/spec/notice_notifier_spec.rb

@@ -1,4 +1,3 @@
-# rubocop:disable Layout/DotPosition
 RSpec.describe Airbrake::NoticeNotifier do
   before do
     Airbrake::Config.instance = Airbrake::Config.new(
@@ -108,6 +107,15 @@ RSpec.describe Airbrake::NoticeNotifier do
       sleep 1
     end
 
+    context "when config is invalid" do
+      before { Airbrake::Config.instance.merge(project_id: nil) }
+
+      it "returns a rejected promise" do
+        promise = subject.notify({})
+        expect(promise).to be_rejected
+      end
+    end
+
     context "when a notice is not ignored" do
       it "yields the notice" do
         expect { |b| subject.notify('ex', &b) }
@@ -169,7 +177,7 @@ RSpec.describe Airbrake::NoticeNotifier do
 
       it "returns a rejected promise" do
         promise = subject.notify('foo', bingo: 'bango')
-        expect(promise.value).to eq('error' => "The 'test' environment is ignored")
+        expect(promise.value).to eq('error' => "current environment 'test' is ignored")
       end
     end
   end
@@ -253,7 +261,7 @@ RSpec.describe Airbrake::NoticeNotifier do
 
       it "returns an error hash" do
         expect(subject.notify_sync('foo'))
-          .to eq('error' => "The 'test' environment is ignored")
+          .to eq('error' => "current environment 'test' is ignored")
       end
     end
   end
@@ -406,4 +414,3 @@ RSpec.describe Airbrake::NoticeNotifier do
     end
   end
 end
-# rubocop:enable Layout/DotPosition

data/spec/notice_notifier_spec/options_spec.rb

@@ -74,8 +74,8 @@ RSpec.describe Airbrake::NoticeNotifier do
         subject.notify_sync(ex)
 
         expect(
-          a_request(:post, endpoint).
-          with(body: %r|{"file":"/PROJECT_ROOT/airbrake/ruby/spec/airbrake_spec.+|)
+          a_request(:post, endpoint)
+          .with(body: %r|{"file":"/PROJECT_ROOT/airbrake/ruby/spec/airbrake_spec.+|)
         ).to have_been_made.once
       end
 
@@ -86,8 +86,8 @@ RSpec.describe Airbrake::NoticeNotifier do
           it "being included into the notice's payload" do
             subject.notify_sync(ex)
             expect(
-              a_request(:post, endpoint).
-              with(body: %r{"rootDirectory":"/bingo/bango"})
+              a_request(:post, endpoint)
+              .with(body: %r{"rootDirectory":"/bingo/bango"})
             ).to have_been_made.once
           end
         end
@@ -148,12 +148,12 @@ RSpec.describe Airbrake::NoticeNotifier do
 
         proxied_request = requests.pop(true)
 
-        expect(proxied_request.header['proxy-authorization'].first).
-          to eq('Basic dXNlcjpwYXNzd29yZA==')
+        expect(proxied_request.header['proxy-authorization'].first)
+          .to eq('Basic dXNlcjpwYXNzd29yZA==')
 
         # rubocop:disable Metrics/LineLength
-        expect(proxied_request.request_line).
-          to eq("POST http://localhost:#{proxy.config[:Port]}/api/v3/projects/105138/notices HTTP/1.1\r\n")
+        expect(proxied_request.request_line)
+          .to eq("POST http://localhost:#{proxy.config[:Port]}/api/v3/projects/105138/notices HTTP/1.1\r\n")
         # rubocop:enable Metrics/LineLength
       end
     end
@@ -165,8 +165,8 @@ RSpec.describe Airbrake::NoticeNotifier do
         it "being included into the notice's payload" do
           subject.notify_sync(ex)
           expect(
-            a_request(:post, endpoint).
-            with(body: /"context":{.*"environment":"production".*}/)
+            a_request(:post, endpoint)
+            .with(body: /"context":{.*"environment":"production".*}/)
           ).to have_been_made.once
         end
       end
@@ -210,8 +210,8 @@ RSpec.describe Airbrake::NoticeNotifier do
 
         it "returns early and doesn't try to parse the given exception" do
           expect(Airbrake::Notice).not_to receive(:new)
-          expect(subject.notify_sync(ex)).
-            to eq('error' => "The 'development' environment is ignored")
+          expect(subject.notify_sync(ex))
+            .to eq('error' => "current environment 'development' is ignored")
           expect(a_request(:post, endpoint)).not_to have_been_made
         end
       end

data/spec/notice_spec.rb

@@ -85,8 +85,8 @@ RSpec.describe Airbrake::Notice do
 
       context "when truncation failed" do
         it "returns nil" do
-          expect_any_instance_of(Airbrake::Truncator).
-            to receive(:reduce_max_size).and_return(0)
+          expect_any_instance_of(Airbrake::Truncator)
+            .to receive(:reduce_max_size).and_return(0)
 
           encoded = Base64.encode64("\xD3\xE6\xBC\x9D\xBA").encode!('ASCII-8BIT')
           bad_string = Base64.decode64(encoded)
@@ -118,8 +118,8 @@ RSpec.describe Airbrake::Notice do
           let(:backtrace_size) { 1000 }
 
           it "doesn't happen" do
-            expect(notice.to_json).
-              to match(/bingo":\["#<Object:.+>","#<#<Class:.+>:.+>"/)
+            expect(notice.to_json)
+              .to match(/bingo":\["#<Object:.+>","#<#<Class:.+>:.+>"/)
           end
         end
 
@@ -128,8 +128,8 @@ RSpec.describe Airbrake::Notice do
             let(:backtrace_size) { 50_000 }
 
             it "happens" do
-              expect(notice.to_json).
-                to match(/bingo":\[".+Object.+",".+Class.+"/)
+              expect(notice.to_json)
+                .to match(/bingo":\[".+Object.+",".+Class.+"/)
             end
           end
         end
@@ -219,13 +219,13 @@ RSpec.describe Airbrake::Notice do
     it "overwrites the 'notifier' payload with the default values" do
       notice[:notifier] = { name: 'bingo', bango: 'bongo' }
 
-      expect(notice.to_json).
-        to match(/"notifier":{"name":"airbrake-ruby","version":".+","url":".+"}/)
+      expect(notice.to_json)
+        .to match(/"notifier":{"name":"airbrake-ruby","version":".+","url":".+"}/)
     end
 
     it "always contains context/hostname" do
-      expect(notice.to_json).
-        to match(/"context":{.*"hostname":".+".*}/)
+      expect(notice.to_json)
+        .to match(/"context":{.*"hostname":".+".*}/)
     end
 
     it "defaults to the error severity" do
@@ -233,18 +233,18 @@ RSpec.describe Airbrake::Notice do
     end
 
     it "always contains environment/program_name" do
-      expect(notice.to_json).
-        to match(%r|"environment":{"program_name":.+/rspec.*|)
+      expect(notice.to_json)
+        .to match(%r|"environment":{"program_name":.+/rspec.*|)
     end
 
     it "contains errors" do
-      expect(notice.to_json).
-        to match(/"errors":\[{"type":"AirbrakeTestError","message":"App crash/)
+      expect(notice.to_json)
+        .to match(/"errors":\[{"type":"AirbrakeTestError","message":"App crash/)
     end
 
     it "contains a backtrace" do
-      expect(notice.to_json).
-        to match(%r|"backtrace":\[{"file":"/home/.+/spec/spec_helper.rb"|)
+      expect(notice.to_json)
+        .to match(%r|"backtrace":\[{"file":"/home/.+/spec/spec_helper.rb"|)
     end
 
     it "contains params" do
@@ -259,8 +259,8 @@ RSpec.describe Airbrake::Notice do
 
     it "raises error if notice is ignored" do
       notice.ignore!
-      expect { notice[:params] }.
-        to raise_error(Airbrake::Error, 'cannot access ignored Airbrake::Notice')
+      expect { notice[:params] }
+        .to raise_error(Airbrake::Error, 'cannot access ignored Airbrake::Notice')
     end
   end
 
@@ -273,18 +273,18 @@ RSpec.describe Airbrake::Notice do
 
     it "raises error if notice is ignored" do
       notice.ignore!
-      expect { notice[:params] = {} }.
-        to raise_error(Airbrake::Error, 'cannot access ignored Airbrake::Notice')
+      expect { notice[:params] = {} }
+        .to raise_error(Airbrake::Error, 'cannot access ignored Airbrake::Notice')
     end
 
     it "raises error when trying to assign unrecognized key" do
-      expect { notice[:bingo] = 1 }.
-        to raise_error(Airbrake::Error, /:bingo is not recognized among/)
+      expect { notice[:bingo] = 1 }
+        .to raise_error(Airbrake::Error, /:bingo is not recognized among/)
     end
 
     it "raises when setting non-hash objects as the value" do
-      expect { notice[:params] = Object.new }.
-        to raise_error(Airbrake::Error, 'Got Object value, wanted a Hash')
+      expect { notice[:params] = Object.new }
+        .to raise_error(Airbrake::Error, 'Got Object value, wanted a Hash')
     end
   end
 

data/spec/performance_notifier_spec.rb

@@ -217,7 +217,7 @@ RSpec.describe Airbrake::PerformanceNotifier do
       )
 
       expect(a_request(:put, routes)).not_to have_been_made
-      expect(promise.value).to eq('error' => "The 'test' environment is ignored")
+      expect(promise.value).to eq('error' => "current environment 'test' is ignored")
     end
 
     it "sends environment when it's specified" do
@@ -238,6 +238,15 @@ RSpec.describe Airbrake::PerformanceNotifier do
       ).to have_been_made
     end
 
+    context "when config is invalid" do
+      before { Airbrake::Config.instance.merge(project_id: nil) }
+
+      it "returns a rejected promise" do
+        promise = subject.notify({})
+        expect(promise).to be_rejected
+      end
+    end
+
     describe "payload grouping" do
       let(:flush_period) { 0.5 }
 

data/spec/promise_spec.rb

@@ -162,4 +162,36 @@ RSpec.describe Airbrake::Promise do
       expect(array).to match_array([999])
     end
   end
+
+  describe "#rejected?" do
+    context "when it was rejected" do
+      before { subject.reject(1) }
+      it { is_expected.to be_rejected }
+    end
+
+    context "when it wasn't rejected" do
+      it { is_expected.not_to be_rejected }
+    end
+
+    context "when it was resolved" do
+      before { subject.resolve }
+      it { is_expected.not_to be_rejected }
+    end
+  end
+
+  describe "#resolved?" do
+    context "when it was resolved" do
+      before { subject.resolve }
+      it { is_expected.to be_resolved }
+    end
+
+    context "when it wasn't resolved" do
+      it { is_expected.not_to be_resolved }
+    end
+
+    context "when it was rejected" do
+      before { subject.reject(1) }
+      it { is_expected.not_to be_resolved }
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,5 +1,7 @@
 require 'airbrake-ruby'
 
+require 'rspec/its'
+
 require 'webmock'
 require 'webmock/rspec'
 require 'pry'

data/spec/sync_sender_spec.rb

@@ -55,8 +55,8 @@ RSpec.describe Airbrake::SyncSender do
 
     context "when request body is nil" do
       it "doesn't send data" do
-        expect_any_instance_of(Airbrake::Truncator).
-          to receive(:reduce_max_size).and_return(0)
+        expect_any_instance_of(Airbrake::Truncator)
+          .to receive(:reduce_max_size).and_return(0)
 
         encoded = Base64.encode64("\xD3\xE6\xBC\x9D\xBA").encode!('ASCII-8BIT')
         bad_string = Base64.decode64(encoded)
@@ -75,8 +75,8 @@ RSpec.describe Airbrake::SyncSender do
           /truncation failed/
         )
         expect(subject.send(notice, promise)).to be_an(Airbrake::Promise)
-        expect(promise.value).
-          to match('error' => '**Airbrake: data was not sent because of missing body')
+        expect(promise.value)
+          .to match('error' => '**Airbrake: data was not sent because of missing body')
       end
     end
 

data/spec/tdigest_spec.rb

@@ -178,8 +178,8 @@ RSpec.describe Airbrake::TDigest do
 
       it "returns a tdigest with less than or equal centroids" do
         new_tdigest = subject + @other
-        expect(new_tdigest.centroids.size).
-          to be <= subject.centroids.size + @other.centroids.size
+        expect(new_tdigest.centroids.size)
+          .to be <= subject.centroids.size + @other.centroids.size
       end
 
       it "has the size of the two digests combined" do

data/spec/truncator_spec.rb

@@ -104,8 +104,8 @@ RSpec.describe Airbrake::Truncator do
     context "given an arbitrary object that doesn't respond to #to_json" do
       let(:object) do
         obj = Object.new
-        allow(obj).to receive(:to_json).
-          and_raise(Airbrake::Notice::JSON_EXCEPTIONS.first)
+        allow(obj).to receive(:to_json)
+          .and_raise(Airbrake::Notice::JSON_EXCEPTIONS.first)
         obj
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake-ruby
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 4.1.0
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-26 00:00:00.000000000 Z
+date: 2019-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rbtree3