airbrake-ruby 2.9.0 → 2.10.0

data/spec/response_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+
+RSpec.describe Airbrake::Response do
+  describe ".parse" do
+    let(:out) { StringIO.new }
+    let(:logger) { Logger.new(out) }
+
+    context "when response code is 201" do
+      it "logs response body" do
+        described_class.parse(OpenStruct.new(code: 201, body: '{}'), logger)
+        expect(out.string).to match(/Airbrake: {}/)
+      end
+    end
+
+    [400, 401, 403, 420].each do |code|
+      context "when response code is #{code}" do
+        it "logs response message" do
+          described_class.parse(
+            OpenStruct.new(code: code, body: '{"message":"foo"}'), logger
+          )
+          expect(out.string).to match(/Airbrake: foo/)
+        end
+      end
+    end
+
+    context "when response code is 429" do
+      let(:response) { OpenStruct.new(code: 429, body: '{"message":"rate limited"}') }
+      it "logs response message" do
+        described_class.parse(response, logger)
+        expect(out.string).to match(/Airbrake: rate limited/)
+      end
+
+      it "returns an error response" do
+        time = Time.now
+        allow(Time).to receive(:now).and_return(time)
+
+        resp = described_class.parse(response, logger)
+        expect(resp).to include(
+          'error' => '**Airbrake: rate limited',
+          'rate_limit_reset' => time
+        )
+      end
+    end
+
+    context "when response code is unhandled" do
+      let(:response) { OpenStruct.new(code: 500, body: 'foo') }
+
+      it "logs response body" do
+        described_class.parse(response, logger)
+        expect(out.string).to match(/Airbrake: unexpected code \(500\)\. Body: foo/)
+      end
+
+      it "returns an error response" do
+        resp = described_class.parse(response, logger)
+        expect(resp).to eq('error' => 'foo')
+      end
+
+      it "truncates body" do
+        response.body *= 1000
+        resp = described_class.parse(response, logger)
+        expect(resp).to eq('error' => ('foo' * 33) + 'fo...')
+      end
+    end
+
+    context "when response body can't be parsed as JSON" do
+      let(:response) { OpenStruct.new(code: 201, body: 'foo') }
+
+      it "logs response body" do
+        described_class.parse(response, logger)
+        expect(out.string).to match(
+          /Airbrake: error while parsing body \(.*unexpected token.*\)\. Body: foo/
+        )
+      end
+
+      it "returns an error message" do
+        expect(described_class.parse(response, logger)['error']).to match(
+          /\A#<JSON::ParserError.+>/
+        )
+      end
+    end
+  end
+end

data/spec/sync_sender_spec.rb

@@ -25,31 +25,48 @@ RSpec.describe Airbrake::SyncSender do
 
     let(:sender) { described_class.new(config) }
     let(:notice) { Airbrake::Notice.new(config, AirbrakeTestError.new) }
+    let(:endpoint) { 'https://airbrake.io/api/v3/projects/1/notices' }
 
-    it "catches exceptions raised while sending" do
-      https = double("foo")
-      allow(sender).to receive(:build_https).and_return(https)
-      allow(https).to receive(:request).and_raise(StandardError.new('foo'))
-      expect(sender.send(notice, promise)).to be_an(Airbrake::Promise)
-      expect(promise.value).to eq('error' => '**Airbrake: HTTP error: foo')
-      expect(stdout.string).to match(/ERROR -- : .+ HTTP error: foo/)
-    end
+    before { stub_request(:post, endpoint).to_return(body: '{}') }
 
-    it "passes project key as a token in the Authorization header" do
-      stub_request(:post, 'https://airbrake.io/api/v3/projects/1/notices').
-        to_return(body: '{}')
+    it "sets the Content-Type header to JSON" do
       sender.send(notice, promise)
+      expect(
+        a_request(:post, endpoint).with(
+          headers: { 'Content-Type' => 'application/json' }
+        )
+      ).to have_been_made.once
+    end
 
+    it "sets the User-Agent header to the notifier slug" do
+      sender.send(notice, promise)
       expect(
-        a_request(:post, 'https://airbrake.io/api/v3/projects/1/notices').with(
+        a_request(:post, endpoint).with(
           headers: {
-            'Authorization' => 'Bearer banana',
-            'Content-Type' => 'application/json'
+            'User-Agent' => %r{airbrake-ruby/\d+\.\d+\.\d+ Ruby/\d+\.\d+\.\d+}
           }
         )
       ).to have_been_made.once
     end
 
+    it "sets the Authorization header to the project key" do
+      sender.send(notice, promise)
+      expect(
+        a_request(:post, endpoint).with(
+          headers: { 'Authorization' => 'Bearer banana' }
+        )
+      ).to have_been_made.once
+    end
+
+    it "catches exceptions raised while sending" do
+      https = double("foo")
+      allow(sender).to receive(:build_https).and_return(https)
+      allow(https).to receive(:request).and_raise(StandardError.new('foo'))
+      expect(sender.send(notice, promise)).to be_an(Airbrake::Promise)
+      expect(promise.value).to eq('error' => '**Airbrake: HTTP error: foo')
+      expect(stdout.string).to match(/ERROR -- : .+ HTTP error: foo/)
+    end
+
     context "when request body is nil" do
       it "doesn't send a notice" do
         expect_any_instance_of(Airbrake::Truncator).

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake-ruby
 version: !ruby/object:Gem::Version
-  version: 2.9.0
+  version: 2.10.0
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-26 00:00:00.000000000 Z
+date: 2018-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -124,6 +124,8 @@ files:
 - lib/airbrake-ruby/file_cache.rb
 - lib/airbrake-ruby/filter_chain.rb
 - lib/airbrake-ruby/filters/context_filter.rb
+- lib/airbrake-ruby/filters/dependency_filter.rb
+- lib/airbrake-ruby/filters/exception_attributes_filter.rb
 - lib/airbrake-ruby/filters/gem_root_filter.rb
 - lib/airbrake-ruby/filters/keys_blacklist.rb
 - lib/airbrake-ruby/filters/keys_filter.rb
@@ -148,6 +150,8 @@ files:
 - spec/file_cache.rb
 - spec/filter_chain_spec.rb
 - spec/filters/context_filter_spec.rb
+- spec/filters/dependency_filter_spec.rb
+- spec/filters/exception_attributes_filter_spec.rb
 - spec/filters/gem_root_filter_spec.rb
 - spec/filters/keys_blacklist_spec.rb
 - spec/filters/keys_whitelist_spec.rb
@@ -166,6 +170,7 @@ files:
 - spec/notifier_spec.rb
 - spec/notifier_spec/options_spec.rb
 - spec/promise_spec.rb
+- spec/response_spec.rb
 - spec/spec_helper.rb
 - spec/sync_sender_spec.rb
 - spec/truncator_spec.rb
@@ -196,10 +201,12 @@ summary: Ruby notifier for https://airbrake.io
 test_files:
 - spec/truncator_spec.rb
 - spec/helpers.rb
+- spec/filters/exception_attributes_filter_spec.rb
 - spec/filters/root_directory_filter_spec.rb
 - spec/filters/keys_whitelist_spec.rb
 - spec/filters/system_exit_filter_spec.rb
 - spec/filters/thread_filter_spec.rb
+- spec/filters/dependency_filter_spec.rb
 - spec/filters/context_filter_spec.rb
 - spec/filters/keys_blacklist_spec.rb
 - spec/filters/gem_root_filter_spec.rb
@@ -215,6 +222,7 @@ test_files:
 - spec/notifier_spec.rb
 - spec/nested_exception_spec.rb
 - spec/filter_chain_spec.rb
+- spec/response_spec.rb
 - spec/file_cache.rb
 - spec/code_hunk_spec.rb
 - spec/fixtures/notroot.txt