airbrake-ruby 1.7.1 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bbc56120094dd5ebca9b489ba613aca53d696da3
-  data.tar.gz: d0f207390f282a459a2a80f13223b7c61de5be09
+  metadata.gz: bd52bfc797145037c7aa2c4ba9193b860b6a48f4
+  data.tar.gz: 2314e4ba463a99416df04c209c2af159e6b384c8
 SHA512:
-  metadata.gz: a42ae86774fa693ac7678e6e4a9bc0e6014992f4d1c8ba91b08f615b40fbd36cdbaf8bae42163d7bbb574c3f25292c92fc10e3707c13b42a35706a01ca2de682
-  data.tar.gz: 4eb63a597c488410fe44972ab6077b11e7d296788e431fda2e956b5fee9f2f58133d0e172f32667d5d1a56aac7b1478d288d5315541c0f0be37e0c87720f9a23
+  metadata.gz: da90297990ebb7d1b8ba092750a666ef9324cdd6149195d4d143fb9d74d0963793a9696a403bc5011b8675bab3b8ff5c0c881061d89568e225ef0575a0ad0597
+  data.tar.gz: e18299029cd90b600fab49d0867874a3e66f6950c3f882dc1b1c2ab3930846d9de59cb3673afb539926eb1c56c019955d1d3834b51b16d7dea366627e4836b6d

data/lib/airbrake-ruby.rb

@@ -53,7 +53,7 @@ require 'airbrake-ruby/notifier'
 #
 #   # Send an exception via other configured notifier.
 #   params = {}
-#   Airbrake.notify('Oops', params, :my_other_project)
+#   Airbrake[:my_other_project].notify('Oops', params)
 #
 # @see Airbrake::Notifier
 # @since v1.0.0
@@ -77,6 +77,18 @@ module Airbrake
   @notifiers = {}
 
   class << self
+    ##
+    # Retrieves configured notifiers.
+    #
+    # @example
+    #   Airbrake[:my_notifier].notify('oops')
+    #
+    # @return [Airbrake::Notifier, nil]
+    # @since v1.8.0
+    def [](notifier_name)
+      @notifiers[notifier_name]
+    end
+
     ##
     # Configures a new +notifier+ with the given name. If the name is not given,
     # configures the default notifier.
@@ -139,7 +151,8 @@ module Airbrake
     #   tab in your project's dashboard
     # @return [Airbrake::Promise]
     # @see .notify_sync
-    def notify(exception, params = {}, notifier = :default)
+    def notify(exception, params = {}, notifier = (no_arg = true && :default))
+      deprecation_warn(__method__, notifier) unless no_arg
       call_notifier(notifier, __method__, exception, params)
     end
 
@@ -153,7 +166,8 @@ module Airbrake
     #
     # @return [Hash{String=>String}] the reponse from the server
     # @see .notify
-    def notify_sync(exception, params = {}, notifier = :default)
+    def notify_sync(exception, params = {}, notifier = (no_arg = true && :default))
+      deprecation_warn(__method__, notifier) unless no_arg
       call_notifier(notifier, __method__, exception, params)
     end
 
@@ -184,7 +198,8 @@ module Airbrake
     # @yieldreturn [void]
     # @return [void]
     # @note Once a filter was added, there's no way to delete it
-    def add_filter(filter = nil, notifier = :default, &block)
+    def add_filter(filter = nil, notifier = (no_arg = true && :default), &block)
+      deprecation_warn(__method__, notifier) unless no_arg
       call_notifier(notifier, __method__, filter, &block)
     end
 
@@ -204,7 +219,8 @@ module Airbrake
     # @param [Hash] params The additional params attached to the notice
     # @return [Airbrake::Notice] the notice built with help of the given
     #   arguments
-    def build_notice(exception, params = {}, notifier = :default)
+    def build_notice(exception, params = {}, notifier = (no_arg = true && :default))
+      deprecation_warn(__method__, notifier) unless no_arg
       call_notifier(notifier, __method__, exception, params)
     end
 
@@ -219,7 +235,8 @@ module Airbrake
     #   Airbrake.notify('App crashed!') #=> raises Airbrake::Error
     #
     # @return [void]
-    def close(notifier = :default)
+    def close(notifier = (no_arg = true && :default))
+      deprecation_warn(__method__, notifier) unless no_arg
       call_notifier(notifier, __method__)
     end
 
@@ -235,7 +252,8 @@ module Airbrake
     # @option deploy_params [Symbol] :revision
     # @option deploy_params [Symbol] :version
     # @return [void]
-    def create_deploy(deploy_params, notifier = :default)
+    def create_deploy(deploy_params, notifier = (no_arg = true && :default))
+      deprecation_warn(__method__, notifier) unless no_arg
       call_notifier(notifier, __method__, deploy_params)
     end
 
@@ -252,5 +270,15 @@ module Airbrake
     def configured?(notifier)
       @notifiers.key?(notifier)
     end
+
+    def deprecation_warn(method, notifier)
+      warn(
+        "#{LOG_LABEL} `Airbrake.#{method}` method signature was changed. " \
+        "Passing `notifier_name` is deprecated and will be removed in the " \
+        "next MAJOR release.\n" \
+        "Use `Airbrake[:#{notifier}]` to access the :#{notifier} notifier " \
+        "and call same methods directly on it."
+      )
+    end
   end
 end

data/lib/airbrake-ruby/config.rb

@@ -96,6 +96,11 @@ module Airbrake
       self.blacklist_keys = []
       self.whitelist_keys = []
 
+      self.root_directory = (
+        (defined?(Bundler) && Bundler.root) ||
+        File.expand_path(Dir.pwd)
+      )
+
       merge(user_config)
     end
 

data/lib/airbrake-ruby/notifier.rb

@@ -4,7 +4,6 @@ module Airbrake
   # synchronous and asynchronous delivery.
   #
   # @see Airbrake::Config The list of options
-  # @api private
   # @since v1.0.0
   class Notifier
     ##

data/lib/airbrake-ruby/version.rb

@@ -4,5 +4,5 @@
 module Airbrake
   ##
   # @return [String] the library version
-  AIRBRAKE_RUBY_VERSION = '1.7.1'.freeze
+  AIRBRAKE_RUBY_VERSION = '1.8.0'.freeze
 end

data/spec/airbrake_spec.rb

@@ -78,7 +78,7 @@ RSpec.describe Airbrake do
           # rubocop:disable Metrics/LineLength
           expected_body = %r|
             {"errors":\[{"type":"RuntimeError","message":"bingo","backtrace":\[
-            {"file":"[\w/\-\.]+spec/airbrake_spec.rb","line":\d+,"function":"[\w/\s\(\)<>]+"},
+            {"file":"\[PROJECT_ROOT\]/spec/airbrake_spec.rb","line":\d+,"function":"[\w/\s\(\)<>]+"},
             {"file":"\[GEM_ROOT\]/gems/rspec-core-.+/.+","line":\d+,"function":"[\w/\s\(\)<>]+"}
           |x
           # rubocop:enable Metrics/LineLength
@@ -167,11 +167,11 @@ RSpec.describe Airbrake do
       filter_chain = notifier.instance_variable_get(:@filter_chain)
       filters = filter_chain.instance_variable_get(:@filters)
 
-      expect(filters.size).to eq(2)
+      expect(filters.size).to eq(3)
 
       described_class.add_filter {}
 
-      expect(filters.size).to eq(3)
+      expect(filters.size).to eq(4)
       expect(filters.last).to be_a(Proc)
     end
   end

data/spec/config_spec.rb

@@ -51,8 +51,8 @@ RSpec.describe Airbrake::Config do
         expect(config.queue_size).to eq(100)
       end
 
-      it "doesn't set the default root_directory" do
-        expect(config.root_directory).to be_nil
+      it "sets the default root_directory" do
+        expect(config.root_directory).to eq Bundler.root
       end
 
       it "doesn't set the default environment" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake-ruby
 version: !ruby/object:Gem::Version
-  version: 1.7.1
+  version: 1.8.0
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-03 00:00:00.000000000 Z
+date: 2017-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec