airbrake-api 4.2.0 → 4.2.1

data/lib/airbrake-api/client.rb

@@ -98,28 +98,26 @@ module AirbrakeAPI
       hash.notice
     end
 
-    def notices(error_id, notice_options = {}, &block)
-      options     = {}
-      notices     = []
-      page        = notice_options[:page]
-      page_count  = 0
-
+    def notices(error_id, options = {}, &block)
       # a specific page is requested, only return that page
       # if no page is specified, start on page 1
-      if page
-        notice_options[:pages] = 1
+      if options[:page]
+        page = options[:page]
+        options[:pages] = 1
       else
         page = 1
       end
 
-      while !notice_options[:pages] || (page_count + 1) <= notice_options[:pages]
-        options[:page] = page + page_count
-        hash = request(:get, notices_path(error_id), options)
+      notices = []
+      page_count = 0
+      while !options[:pages] || (page_count + 1) <= options[:pages]
+        data = request(:get, notices_path(error_id), :page => page + page_count)
 
         batch = if options[:raw]
-          hash.notices
+          data.notices
         else
-          Parallel.map(hash.notices, :in_threads => PARALLEL_WORKERS) do |notice_stub|
+          # get info like backtraces by doing another api call to notice
+          Parallel.map(data.notices, :in_threads => PARALLEL_WORKERS) do |notice_stub|
             notice(notice_stub.id, error_id)
           end
         end

data/lib/airbrake-api/version.rb

@@ -1,3 +1,3 @@
 module AirbrakeAPI
-  VERSION = '4.2.0'
+  VERSION = '4.2.1'
 end

data/spec/airbrake_api/client_spec.rb

@@ -157,6 +157,7 @@ describe AirbrakeAPI::Client do
       it "finds error notices for a specific page" do
         notices = @client.notices(1696170, :page => 1)
         notices.size.should == 30
+        notices.first.backtrace.should_not == nil
         notices.first.id.should == 1234
       end
 
@@ -176,8 +177,8 @@ describe AirbrakeAPI::Client do
 
       it "can return raw results" do
         notices = @client.notices(1696170, :raw => true)
-        notices[0].line.should == nil
-        notices[0].id.should == 1234
+        notices.first.backtrace.should == nil
+        notices.first.id.should == 1234
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: airbrake-api
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 4.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -294,7 +294,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3073464586304613395
+      hash: 1722762776779864920
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -303,7 +303,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3073464586304613395
+      hash: 1722762776779864920
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24