aidp 0.9.6 → 0.11.0

data/lib/aidp/analyze/steps.rb

@@ -3,51 +3,53 @@
 module Aidp
   module Analyze
     module Steps
+      # Analysis step specifications
+      # Templates are organized by purpose and named with action verbs
       SPEC = {
         "01_REPOSITORY_ANALYSIS" => {
-          "templates" => ["01_repository_analysis.md"],
+          "templates" => ["analysis/analyze_repository.md"],
           "description" => "Initial code-maat based repository mining",
           "outs" => ["docs/analysis/repository_analysis.md"],
           "gate" => false
         },
         "02_ARCHITECTURE_ANALYSIS" => {
-          "templates" => ["02_architecture_analysis.md"],
+          "templates" => ["analysis/analyze_architecture.md"],
           "description" => "Identify architectural patterns, dependencies, and violations",
           "outs" => ["docs/analysis/architecture_analysis.md"],
           "gate" => true
         },
         "03_TEST_ANALYSIS" => {
-          "templates" => ["03_test_analysis.md"],
+          "templates" => ["analysis/analyze_tests.md"],
           "description" => "Analyze existing test coverage and identify gaps",
           "outs" => ["docs/analysis/test_analysis.md"],
           "gate" => false
         },
         "04_FUNCTIONALITY_ANALYSIS" => {
-          "templates" => ["04_functionality_analysis.md"],
+          "templates" => ["analysis/analyze_functionality.md"],
           "description" => "Map features, identify dead code, analyze complexity",
           "outs" => ["docs/analysis/functionality_analysis.md"],
           "gate" => false
         },
         "05_DOCUMENTATION_ANALYSIS" => {
-          "templates" => ["05_documentation_analysis.md"],
+          "templates" => ["analysis/analyze_documentation.md"],
           "description" => "Identify missing documentation and generate what's needed",
           "outs" => ["docs/analysis/documentation_analysis.md"],
           "gate" => false
         },
         "06_STATIC_ANALYSIS" => {
-          "templates" => ["06_static_analysis.md"],
+          "templates" => ["analysis/analyze_static_code.md"],
           "description" => "Check for existing tools and recommend improvements",
           "outs" => ["docs/analysis/static_analysis.md"],
           "gate" => false
         },
         "06A_TREE_SITTER_SCAN" => {
-          "templates" => ["06a_tree_sitter_scan.md"],
+          "templates" => ["analysis/scan_with_tree_sitter.md"],
           "description" => "Tree-sitter powered static analysis to build knowledge base",
           "outs" => [".aidp/kb/symbols.json", ".aidp/kb/seams.json", ".aidp/kb/hotspots.json"],
           "gate" => false
         },
         "07_REFACTORING_RECOMMENDATIONS" => {
-          "templates" => ["07_refactoring_recommendations.md"],
+          "templates" => ["analysis/recommend_refactoring.md"],
           "description" => "Provide actionable refactoring guidance",
           "outs" => ["docs/analysis/refactoring_recommendations.md"],
           "gate" => true

data/lib/aidp/{analysis → analyze}/tree_sitter_grammar_loader.rb

@@ -2,11 +2,14 @@
 
 require "pathname"
 require "tree_sitter"
+require "tty-prompt"
 require "fileutils"
 
 module Aidp
-  module Analysis
+  module Analyze
     class TreeSitterGrammarLoader
+      include Aidp::MessageDisplay
+
       # Default grammar configurations
       GRAMMAR_CONFIGS = {
         "ruby" => {
@@ -61,10 +64,11 @@ module Aidp
         }
       }.freeze
 
-      def initialize(project_dir = Dir.pwd)
+      def initialize(project_dir = Dir.pwd, prompt: TTY::Prompt.new)
         @project_dir = project_dir
         @grammars_dir = File.join(project_dir, ".aidp", "grammars")
         @loaded_grammars = {}
+        @prompt = prompt
       end
 
       # Load grammar for a specific language
@@ -92,7 +96,7 @@ module Aidp
         grammar_path = File.join(@grammars_dir, language)
 
         unless File.exist?(grammar_path)
-          puts "Installing Tree-sitter grammar for #{language}..."
+          display_message("Installing Tree-sitter grammar for #{language}...", type: :info)
           install_grammar(language, config)
         end
       end
@@ -110,7 +114,7 @@ module Aidp
         require "json"
         File.write(File.join(grammar_path, "grammar.json"), JSON.generate(config))
 
-        puts "Grammar for #{language} marked as available"
+        display_message("Grammar for #{language} marked as available", type: :success)
       end
 
       def create_parser(language, config)
@@ -140,7 +144,7 @@ module Aidp
           real: true
         }
       rescue TreeSitter::ParserNotFoundError => e
-        puts "Warning: Tree-sitter parser not found for #{language}: #{e.message}"
+        display_message("Warning: Tree-sitter parser not found for #{language}: #{e.message}", type: :warn)
         create_mock_parser(language)
       end
 
@@ -476,6 +480,8 @@ module Aidp
 
         nodes
       end
+
+      private
     end
   end
 end

data/lib/aidp/{analysis → analyze}/tree_sitter_scan.rb

@@ -4,19 +4,23 @@ require "json"
 require "fileutils"
 require "digest"
 require "etc"
+require "tty-prompt"
 
 require_relative "tree_sitter_grammar_loader"
 require_relative "seams"
 
 module Aidp
-  module Analysis
+  module Analyze
     class TreeSitterScan
-      def initialize(root: Dir.pwd, kb_dir: ".aidp/kb", langs: %w[ruby], threads: Etc.nprocessors)
+      include Aidp::MessageDisplay
+
+      def initialize(root: Dir.pwd, kb_dir: ".aidp/kb", langs: %w[ruby], threads: Etc.nprocessors, prompt: TTY::Prompt.new)
         @root = File.expand_path(root)
         @kb_dir = File.expand_path(kb_dir, @root)
         @langs = Array(langs)
         @threads = threads
-        @grammar_loader = TreeSitterGrammarLoader.new(@root)
+        @prompt = prompt
+        @grammar_loader = TreeSitterGrammarLoader.new(@root, prompt: @prompt)
 
         # Data structures to accumulate analysis results
         @symbols = []
@@ -34,14 +38,14 @@ module Aidp
       end
 
       def run
-        puts "🔍 Starting Tree-sitter static analysis..."
-        puts "📁 Root: #{@root}"
-        puts "🗂️  KB Directory: #{@kb_dir}"
-        puts "🌐 Languages: #{@langs.join(", ")}"
-        puts "🧵 Threads: #{@threads}"
+        display_message("🔍 Starting Tree-sitter static analysis...", type: :highlight)
+        display_message("📁 Root: #{@root}", type: :info)
+        display_message("🗂️  KB Directory: #{@kb_dir}", type: :info)
+        display_message("🌐 Languages: #{@langs.join(", ")}", type: :info)
+        display_message("🧵 Threads: #{@threads}", type: :info)
 
         files = discover_files
-        puts "📄 Found #{files.length} files to analyze"
+        display_message("📄 Found #{files.length} files to analyze", type: :info)
 
         prepare_kb_dir
         load_cache
@@ -49,8 +53,8 @@ module Aidp
         parallel_parse(files)
         write_kb_files
 
-        puts "✅ Tree-sitter analysis complete!"
-        puts "📊 Generated KB files in #{@kb_dir}"
+        display_message("✅ Tree-sitter analysis complete!", type: :success)
+        display_message("📊 Generated KB files in #{@kb_dir}", type: :success)
       end
 
       private
@@ -144,14 +148,14 @@ module Aidp
       end
 
       def parallel_parse(files)
-        puts "🔄 Parsing files in parallel..."
+        display_message("🔄 Parsing files in parallel...", type: :info)
 
         # Group files by language for efficient processing
         files_by_lang = files.group_by { |file| detect_language(file) }
 
         # Process each language group
         files_by_lang.each do |lang, lang_files|
-          puts "📝 Processing #{lang_files.length} #{lang} files..."
+          display_message("📝 Processing #{lang_files.length} #{lang} files...", type: :info)
 
           # Load grammar for this language
           grammar = @grammar_loader.load_grammar(lang)
@@ -614,7 +618,7 @@ module Aidp
       end
 
       def write_kb_files
-        puts "💾 Writing knowledge base files..."
+        display_message("💾 Writing knowledge base files...", type: :info)
 
         prepare_kb_dir
 
@@ -637,7 +641,7 @@ module Aidp
       def write_json_file(filename, data)
         file_path = File.join(@kb_dir, filename)
         File.write(file_path, JSON.pretty_generate(data))
-        puts "📄 Written #{filename} (#{data.length} entries)"
+        display_message("📄 Written #{filename} (#{data.length} entries)", type: :success)
       end
 
       def generate_hotspots
@@ -681,6 +685,8 @@ module Aidp
         # This would analyze test file naming and content
         []
       end
+
+      private
     end
   end
 end

data/lib/aidp/cli/checkpoint_command.rb

@@ -0,0 +1,98 @@
+# frozen_string_literal: true
+
+require "thor"
+require_relative "../execute/checkpoint"
+require_relative "../execute/checkpoint_display"
+
+module Aidp
+  module CLI
+    # CLI command for viewing checkpoint data and progress reports
+    class CheckpointCommand < Thor
+      desc "show", "Show the latest checkpoint data"
+      def show
+        checkpoint = Aidp::Execute::Checkpoint.new(Dir.pwd)
+        display = Aidp::Execute::CheckpointDisplay.new
+
+        latest = checkpoint.latest_checkpoint
+        if latest
+          display.display_checkpoint(latest, show_details: true)
+        else
+          puts "No checkpoint data found."
+        end
+      end
+
+      desc "summary", "Show progress summary with trends"
+      def summary
+        checkpoint = Aidp::Execute::Checkpoint.new(Dir.pwd)
+        display = Aidp::Execute::CheckpointDisplay.new
+
+        summary = checkpoint.progress_summary
+        if summary
+          display.display_progress_summary(summary)
+        else
+          puts "No checkpoint data found."
+        end
+      end
+
+      desc "history [LIMIT]", "Show checkpoint history (default: last 10)"
+      def history(limit = "10")
+        checkpoint = Aidp::Execute::Checkpoint.new(Dir.pwd)
+        display = Aidp::Execute::CheckpointDisplay.new
+
+        history = checkpoint.checkpoint_history(limit: limit.to_i)
+        if history.any?
+          display.display_checkpoint_history(history, limit: limit.to_i)
+        else
+          puts "No checkpoint history found."
+        end
+      end
+
+      desc "clear", "Clear all checkpoint data"
+      option :force, type: :boolean, default: false, desc: "Skip confirmation"
+      def clear
+        unless options[:force]
+          prompt = TTY::Prompt.new
+          confirm = prompt.yes?("Are you sure you want to clear all checkpoint data?")
+          return unless confirm
+        end
+
+        checkpoint = Aidp::Execute::Checkpoint.new(Dir.pwd)
+        checkpoint.clear
+        puts "✓ Checkpoint data cleared."
+      end
+
+      desc "metrics", "Show detailed metrics for the latest checkpoint"
+      def metrics
+        checkpoint = Aidp::Execute::Checkpoint.new(Dir.pwd)
+        latest = checkpoint.latest_checkpoint
+
+        unless latest
+          puts "No checkpoint data found."
+          return
+        end
+
+        puts
+        puts "📊 Detailed Metrics"
+        puts "=" * 60
+
+        metrics = latest[:metrics]
+        puts "Lines of Code: #{metrics[:lines_of_code]}"
+        puts "File Count: #{metrics[:file_count]}"
+        puts "Test Coverage: #{metrics[:test_coverage]}%"
+        puts "Code Quality: #{metrics[:code_quality]}%"
+        puts "PRD Task Progress: #{metrics[:prd_task_progress]}%"
+
+        if metrics[:tests_passing]
+          puts "Tests: #{metrics[:tests_passing] ? "✓ Passing" : "✗ Failing"}"
+        end
+
+        if metrics[:linters_passing]
+          puts "Linters: #{metrics[:linters_passing] ? "✓ Passing" : "✗ Failing"}"
+        end
+
+        puts "=" * 60
+        puts
+      end
+    end
+  end
+end

data/lib/aidp/cli/first_run_wizard.rb

@@ -3,60 +3,52 @@
 
 require "yaml"
 require "tty-prompt"
+require_relative "../harness/provider_factory"
 
 module Aidp
   class CLI
     # Handles interactive first-time project setup when no aidp.yml exists
     class FirstRunWizard
+      include Aidp::MessageDisplay
+
       TEMPLATES_DIR = File.expand_path(File.join(__dir__, "..", "..", "..", "templates"))
 
-      def self.ensure_config(project_dir, input: $stdin, output: $stdout, non_interactive: false, prompt: TTY::Prompt.new)
+      def self.ensure_config(project_dir, non_interactive: false, prompt: TTY::Prompt.new)
         return true if Aidp::Config.config_exists?(project_dir)
 
-        wizard = new(project_dir, input: input, output: output, prompt: prompt)
+        wizard = new(project_dir, prompt: prompt)
 
-        if non_interactive || !input.tty? || !output.tty?
+        if non_interactive
           # Non-interactive environment - create minimal config silently
           path = wizard.send(:write_minimal_config, project_dir)
-          output.puts "Created minimal configuration at #{wizard.send(:relative, path)} (non-interactive default)"
+          wizard.send(:display_message, "Created minimal configuration at #{wizard.send(:relative, path)} (non-interactive default)", type: :success)
           return true
         end
 
         wizard.run
       end
 
-      def self.setup_config(project_dir, input: $stdin, output: $stdout, non_interactive: false, prompt: TTY::Prompt.new)
-        wizard = new(project_dir, input: input, output: output, prompt: prompt)
+      def self.setup_config(project_dir, non_interactive: false, prompt: TTY::Prompt.new)
+        wizard = new(project_dir, prompt: prompt)
 
-        if non_interactive || !input.tty? || !output.tty?
+        if non_interactive
           # Non-interactive environment - skip setup
-          output.puts "Configuration setup skipped in non-interactive environment"
+          wizard.send(:display_message, "Configuration setup skipped in non-interactive environment", type: :info)
           return true
         end
 
         wizard.run_setup_config
       end
 
-      def initialize(project_dir, input: $stdin, output: $stdout, prompt: TTY::Prompt.new)
+      def initialize(project_dir, prompt: TTY::Prompt.new)
         @project_dir = project_dir
-        @input = input
-        @output = output
         @prompt = prompt
       end
 
       def run
         banner
-        loop do
-          choice = ask_choice
-          case choice
-          when "1" then return finish(write_quick_config(@project_dir))
-          when "2" then return finish(run_custom)
-          when "q", "Q" then @output.puts("Exiting without creating configuration.")
-                             return false
-          else
-            @output.puts "Invalid selection. Please choose one of the listed options."
-          end
-        end
+        # Always run the full interactive custom configuration flow.
+        finish(run_custom)
       end
 
       def run_setup_config
@@ -81,31 +73,19 @@ module Aidp
       private
 
       def banner
-        @output.puts "\n🚀 First-time setup detected"
-        @output.puts "No 'aidp.yml' configuration file found in #{relative(@project_dir)}."
-        @output.puts "Let's create one so you can start using AI Dev Pipeline."
-        @output.puts
-      end
-
-      def ask_choice
-        @output.puts "Choose a configuration style:" unless @asking
-
-        options = {
-          "Quick setup (cursor + macos, no API keys needed)" => "1",
-          "Custom setup (choose your own providers and settings)" => "2",
-          "Quit" => "q"
-        }
-
-        @prompt.select("Select an option:", options, default: "Quick setup (cursor + macos, no API keys needed)")
+        display_message("\n🚀 First-time setup detected", type: :highlight)
+        display_message("No 'aidp.yml' configuration file found in #{relative(@project_dir)}.")
+        display_message("Creating a configuration so you can start using AI Dev Pipeline.")
+        display_message("")
       end
 
       def finish(path)
         if path
-          @output.puts "\n✅ Configuration created at #{relative(path)}"
-          @output.puts "You can edit this file anytime. Continuing startup...\n"
+          display_message("\n✅ Configuration created at #{relative(path)}", type: :success)
+          display_message("You can edit this file anytime. Continuing startup...\n")
           true
         else
-          @output.puts "❌ Failed to create configuration file."
+          display_message("❌ Failed to create configuration file.", type: :error)
           false
         end
       end
@@ -113,7 +93,7 @@ module Aidp
       def copy_template(filename)
         src = File.join(TEMPLATES_DIR, filename)
         unless File.exist?(src)
-          @output.puts "Template not found: #{filename}"
+          display_message("Template not found: #{filename}", type: :error)
           return nil
         end
         dest = File.join(@project_dir, "aidp.yml")
@@ -122,7 +102,7 @@ module Aidp
       end
 
       def write_minimal_config(project_dir)
-        dest = File.join(project_dir, "aidp.yml")
+        dest = File.join(project_dir, ".aidp", "aidp.yml")
         return dest if File.exist?(dest)
         data = {
           "harness" => {
@@ -138,31 +118,7 @@ module Aidp
             }
           }
         }
-        File.write(dest, YAML.dump(data))
-        dest
-      end
-
-      def write_quick_config(project_dir)
-        dest = File.join(project_dir, "aidp.yml")
-        return dest if File.exist?(dest)
-        data = {
-          "harness" => {
-            "max_retries" => 2,
-            "default_provider" => "cursor",
-            "fallback_providers" => ["macos"],
-            "no_api_keys_required" => true
-          },
-          "providers" => {
-            "cursor" => {
-              "type" => "subscription",
-              "default_flags" => []
-            },
-            "macos" => {
-              "type" => "usage_based",
-              "default_flags" => []
-            }
-          }
-        }
+        FileUtils.mkdir_p(File.dirname(dest))
         File.write(dest, YAML.dump(data))
         dest
       end
@@ -191,15 +147,11 @@ module Aidp
         provider_name = default_provider.split(" - ").first
 
         # Validate fallback providers
-        fallback_input = @prompt.ask("Fallback providers (comma-separated)?", default: provider_name) do |q|
-          q.validate(/^[a-zA-Z0-9_,\s]+$/, "Invalid characters. Use only letters, numbers, commas, and spaces.")
-          q.validate(->(input) { validate_provider_list(input, available_providers) }, "One or more providers are not supported.")
-        end
+        fallback_providers = select_fallback_providers(available_providers, provider_name)
 
         restrict = @prompt.yes?("Only use providers that don't require API keys?", default: false)
 
-        # Process the inputs
-        fallback_providers = fallback_input.split(/\s*,\s*/).map(&:strip).reject(&:empty?)
+        # Process providers preserving order
         providers = [provider_name] + fallback_providers
         providers.uniq!
 
@@ -248,15 +200,11 @@ module Aidp
         provider_name = default_provider.split(" - ").first
 
         # Validate fallback providers
-        fallback_input = @prompt.ask("Fallback providers (comma-separated)?", default: current_fallbacks.join(", ")) do |q|
-          q.validate(/^[a-zA-Z0-9_,\s]+$/, "Invalid characters. Use only letters, numbers, commas, and spaces.")
-          q.validate(->(input) { validate_provider_list(input, available_providers) }, "One or more providers are not supported.")
-        end
+        fallback_providers = select_fallback_providers(available_providers, provider_name, preselected: current_fallbacks - [provider_name])
 
         restrict_input = @prompt.yes?("Only use providers that don't require API keys?", default: current_restrict)
 
-        # Process the inputs
-        fallback_providers = fallback_input.split(/\s*,\s*/).map(&:strip).reject(&:empty?)
+        # Process providers preserving order
         providers = [provider_name] + fallback_providers
         providers.uniq!
 
@@ -310,14 +258,10 @@ module Aidp
 
       def ask(prompt, default: nil)
         if default
-          @output.print "#{prompt} [#{default}]: "
+          @prompt.ask("#{prompt}:", default: default)
         else
-          @output.print "#{prompt}: "
+          @prompt.ask("#{prompt}:")
         end
-        @output.flush
-        ans = @input.gets&.strip
-        return default if (ans.nil? || ans.empty?) && default
-        ans
       end
 
       def relative(path)
@@ -331,24 +275,25 @@ module Aidp
 
       # Get available providers for validation
       def get_available_providers
-        # Define the available providers based on the system
-        available = ["cursor", "anthropic", "gemini", "macos", "opencode"]
-
-        # Add descriptions for better UX
-        available.map do |provider|
-          case provider
-          when "cursor"
-            "cursor - Cursor AI (no API key required)"
-          when "anthropic"
-            "anthropic - Anthropic Claude (requires API key)"
-          when "gemini"
-            "gemini - Google Gemini (requires API key)"
-          when "macos"
-            "macos - macOS UI Automation (no API key required)"
-          when "opencode"
-            "opencode - OpenCode (no API key required)"
+        # Get all supported providers from the factory (single source of truth)
+        all_providers = Aidp::Harness::ProviderFactory::PROVIDER_CLASSES.keys
+
+        # Filter out providers we don't want to show in the wizard
+        # - "anthropic" is an internal name, we show "claude" instead
+        # - "macos" is disabled (as per issue #73)
+        excluded = ["anthropic", "macos"]
+        available = all_providers - excluded
+
+        # Get display names from the providers themselves
+        available.map do |provider_name|
+          provider_class = Aidp::Harness::ProviderFactory::PROVIDER_CLASSES[provider_name]
+          if provider_class
+            # Instantiate to get display name
+            instance = provider_class.new
+            display_name = instance.display_name
+            "#{provider_name} - #{display_name}"
           else
-            provider
+            provider_name
           end
         end
       end
@@ -364,6 +309,41 @@ module Aidp
         valid_providers = available_providers.map { |p| p.split(" - ").first }
         providers.all? { |provider| valid_providers.include?(provider) }
       end
+
+      # Interactive ordered multi-select for fallback providers
+      def select_fallback_providers(available_with_labels, default_provider, preselected: [])
+        # Extract provider names and exclude the already chosen default
+        options = available_with_labels.map { |o| o.split(" - ").first }
+        candidates = options.reject { |p| p == default_provider }
+
+        return [] if candidates.empty?
+
+        selected = preselected.select { |p| candidates.include?(p) }
+
+        loop do
+          display_message("\nSelect fallback providers in order of preference (first = highest priority).", type: :info)
+          display_message("Current order: #{selected.empty? ? "(none)" : selected.join(" > ")}", type: :muted)
+          choice = @prompt.select("Add provider, or choose an action:", cycle: true) do |menu|
+            (candidates - selected).each { |prov| menu.choice("Add #{prov}", prov) }
+            menu.choice("Done", :done)
+            menu.choice("Clear", :clear) unless selected.empty?
+            menu.choice("Remove last (#{selected.last})", :remove) unless selected.empty?
+          end
+
+          case choice
+          when :done
+            break
+          when :clear
+            selected.clear
+          when :remove
+            selected.pop
+          else
+            selected << choice unless selected.include?(choice)
+          end
+        end
+
+        selected
+      end
     end
   end
 end