aidp 0.8.1 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a295d267b134bc6f1c28aef126969254203d4f07f98d39e686c85c4479954eca
-  data.tar.gz: 23b7bef369a2d423d3e141492f857da0d66640c337d4cd530befa52d6f3c9392
+  metadata.gz: 60b61133b8f3b07ef7fbdd76bce1485bd89b75f78c4130f195c786331f383ded
+  data.tar.gz: e81f6387d6c6941da8b2ae1ff2b3153a3911fd2bb0405c4982f52b166681fc64
 SHA512:
-  metadata.gz: 2544ee1a9ba91033d2b8b9eee057df06c2a15aa3d90725028f72a839c09d3d3f1b95545b937cc9206e360bb8f137174cb495b591ae9890fc26ef5e58e235c0d2
-  data.tar.gz: 4e634535c9cfdcae56400ac073b79334e5a0311342f53e26d6a9b1ace929c5bae5210ae92467e0c47cca3afa902935857d315886bdbc1a6dd07880b55878dd07
+  metadata.gz: 42b8c458bd6dcbfce249d12bb7a1e7eab1d09a61259ea231b935fd4d28c39170baf57d099bb3a5fd3037a3501a4d5daa9abc3696e3c7b91e07137ffce24b22a6
+  data.tar.gz: e2f038cc38c7b32f9bda535ac6bfb8a0bc39c54ef252dc9d7f333f66c71de41dc8e88a6479e8319bad64e5e9dc8adffb2d4dd03febddb82081df2ddf91e8efe0

data/lib/aidp/analyze/progress_visualizer.rb

@@ -4,7 +4,6 @@ require "tty-spinner"
 require "tty-progressbar"
 require "tty-table"
 require "pastel"
-require "colorize"
 
 module Aidp
   class ProgressVisualizer
@@ -295,21 +294,21 @@ module Aidp
     end
 
     def colorize(text, color)
-      return text unless defined?((+"").colorize)
+      return text unless @pastel
 
-      text.to_s.colorize(color)
+      @pastel.decorate(text.to_s, color)
     end
 
     def coverage_colorize(percentage, color)
-      return percentage unless defined?((+"").colorize)
+      return percentage unless @pastel
 
-      percentage.to_s.colorize(color)
+      @pastel.decorate(percentage.to_s, color)
     end
 
     def priority_colorize(text, color)
-      return text unless defined?((+"").colorize)
+      return text unless @pastel
 
-      text.to_s.colorize(color)
+      @pastel.decorate(text.to_s, color)
     end
   end
 end

data/lib/aidp/execute/workflow_selector.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "readline"
+require "tty-prompt"
 
 module Aidp
   module Execute
@@ -8,6 +8,7 @@ module Aidp
     class WorkflowSelector
       def initialize
         @user_input = {}
+        @prompt = TTY::Prompt.new
       end
 
       # Main entry point for interactive workflow selection
@@ -189,22 +190,23 @@ module Aidp
 
       def prompt_required(question)
         loop do
-          response = Readline.readline("#{question}: ", true)&.strip
-          return response unless response.nil? || response.empty?
-          puts "This field is required. Please provide an answer."
+          input = @prompt.ask("#{question}:")
+
+          if input.nil? || input.strip.empty?
+            puts "❌ This field is required. Please provide an answer."
+            next
+          end
+
+          return input.strip
         end
       end
 
       def prompt_optional(question)
-        Readline.readline("#{question} (optional): ", true)&.strip
+        @prompt.ask("#{question} (optional):")
       end
 
       def prompt_choice(question, valid_choices)
-        loop do
-          response = Readline.readline("#{question} (#{valid_choices.join("/")}): ", true)&.strip&.downcase
-          return response if valid_choices.map(&:downcase).include?(response)
-          puts "Please choose one of: #{valid_choices.join(", ")}"
-        end
+        @prompt.select("#{question}:", valid_choices, per_page: valid_choices.length)
       end
     end
   end

data/lib/aidp/harness/runner.rb

@@ -6,7 +6,7 @@ require_relative "configuration"
 require_relative "state_manager"
 require_relative "condition_detector"
 require_relative "provider_manager"
-require_relative "user_interface"
+require_relative "simple_user_interface"
 require_relative "error_handler"
 require_relative "status_display"
 require_relative "completion_checker"
@@ -47,7 +47,7 @@ module Aidp
         @state_manager = StateManager.new(project_dir, @mode)
         @condition_detector = ConditionDetector.new
         @provider_manager = ProviderManager.new(@configuration)
-        @user_interface = UserInterface.new
+        @user_interface = SimpleUserInterface.new
         @error_handler = ErrorHandler.new(@provider_manager, @configuration)
         @status_display = StatusDisplay.new
         @completion_checker = CompletionChecker.new(@project_dir, @workflow_type)

data/lib/aidp/harness/simple_user_interface.rb

@@ -0,0 +1,125 @@
+# frozen_string_literal: true
+
+require "tty-prompt"
+
+module Aidp
+  module Harness
+    # Simple, focused user interface for collecting feedback
+    # Replaces the bloated UserInterface with minimal, clean code
+    class SimpleUserInterface
+      def initialize
+        @prompt = TTY::Prompt.new
+      end
+
+      # Main method - collect responses for questions
+      def collect_feedback(questions, context = nil)
+        show_context(context) if context
+
+        responses = {}
+        questions.each_with_index do |question_data, index|
+          key = "question_#{question_data[:number] || index + 1}"
+          responses[key] = ask_question(question_data)
+        end
+
+        responses
+      end
+
+      private
+
+      def show_context(context)
+        puts "\n🤖 Agent needs feedback"
+        puts "Context: #{context[:description]}" if context[:description]
+        puts ""
+      end
+
+      def ask_question(question_data)
+        question = question_data[:question]
+        type = question_data[:type] || "text"
+        default = question_data[:default]
+        required = question_data[:required] != false
+        options = question_data[:options]
+
+        puts "\n#{question}"
+
+        case type
+        when "text"
+          ask_text(question, default, required)
+        when "choice"
+          @prompt.select("Choose:", options, default: default)
+        when "confirmation"
+          @prompt.yes?("#{question}?", default: default)
+        when "file"
+          ask_file(question, default, required)
+        when "number"
+          ask_number(question, default, required)
+        when "email"
+          ask_email(question, default, required)
+        when "url"
+          ask_url(question, default, required)
+        else
+          ask_text(question, default, required)
+        end
+      end
+
+      def ask_text(question, default, required)
+        options = {}
+        options[:default] = default if default
+        options[:required] = required
+
+        @prompt.ask("Response:", **options)
+      end
+
+      def ask_file(question, default, required)
+        input = @prompt.ask("File path:", default: default, required: required)
+
+        # Handle @ file selection
+        if input&.start_with?("@")
+          search_term = input[1..].strip
+          files = find_files(search_term)
+
+          return nil if files.empty?
+
+          @prompt.select("Select file:", files, per_page: 15)
+        else
+          input
+        end
+      end
+
+      def ask_number(question, default, required)
+        @prompt.ask("Number:", default: default, required: required) do |q|
+          q.convert :int
+          q.validate(/^\d+$/, "Please enter a valid number")
+        end
+      end
+
+      def ask_email(question, default, required)
+        @prompt.ask("Email:", default: default, required: required) do |q|
+          q.validate(/\A[\w+\-.]+@[a-z\d-]+(\.[a-z\d-]+)*\.[a-z]+\z/i, "Please enter a valid email")
+        end
+      end
+
+      def ask_url(question, default, required)
+        @prompt.ask("URL:", default: default, required: required) do |q|
+          q.validate(/\Ahttps?:\/\/.+/i, "Please enter a valid URL (http:// or https://)")
+        end
+      end
+
+      def find_files(search_term)
+        if search_term.empty?
+          # Show common files
+          Dir.glob("**/*").select { |f| File.file?(f) }.first(20)
+        elsif search_term.start_with?(".")
+          # Extension search (e.g., .rb)
+          Dir.glob("**/*#{search_term}").select { |f| File.file?(f) }
+        elsif search_term.end_with?("/")
+          # Directory search (e.g., lib/)
+          dir = search_term.chomp("/")
+          Dir.glob("#{dir}/**/*").select { |f| File.file?(f) }
+        else
+          # Name search
+          Dir.glob("**/*#{search_term}*").select { |f| File.file?(f) }
+        end
+      end
+    end
+  end
+end

data/lib/aidp/harness/ui/enhanced_tui.rb

@@ -28,7 +28,7 @@ module Aidp
           # Headless (non-interactive) detection for test/CI environments:
           # - RSpec defined or RSPEC_RUNNING env set
           # - STDIN not a TTY (captured by PTY/tmux harness)
-          @headless = !!(defined?(RSpec) || ENV["RSPEC_RUNNING"] || !$stdin.tty?)
+          @headless = !!(defined?(RSpec) || ENV["RSPEC_RUNNING"] || $stdin.nil? || !$stdin.tty?)
           @current_mode = nil
           @workflow_active = false
           @current_step = nil
@@ -382,7 +382,7 @@ module Aidp
         # Very lightweight key listener just for spec expectations (F1 help, Ctrl shortcuts)
         def start_key_listener
           return if @key_thread
-          return unless $stdin.tty? || @headless
+          return unless $stdin&.tty? || @headless
 
           @key_thread = Thread.new do
             while @display_active

data/lib/aidp/harness/user_interface.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "readline"
+require "tty-prompt"
 
 module Aidp
   module Harness
@@ -9,6 +9,47 @@ module Aidp
       def initialize
         @input_history = []
         @file_selection_enabled = false
+        @prompt = TTY::Prompt.new
+        @control_mutex = Mutex.new
+        @pause_requested = false
+        @stop_requested = false
+        @resume_requested = false
+        @control_interface_enabled = false
+        @control_thread = nil
+      end
+
+      private
+
+      # Helper method to handle input consistently with TTY::Prompt
+      # Fixed to avoid keystroke loss issues with TTY::Prompt's required validation
+      def get_input_with_prompt(message, required: false, default: nil)
+        loop do
+          # Always use simple ask without built-in validation to avoid echo issues
+          input = if default
+            @prompt.ask("#{message} (default: #{default}): ")
+          else
+            @prompt.ask("#{message}: ")
+          end
+
+          # Handle empty input
+          if input.nil? || input.strip.empty?
+            if default
+              return default
+            elsif required
+              puts "❌ This field is required. Please provide a response."
+              next
+            else
+              return nil
+            end
+          end
+
+          return input.strip
+        end
+      end
+
+      public
+
+      def setup_control_interface
         @control_interface_enabled = true
         @pause_requested = false
         @stop_requested = false
@@ -465,9 +506,14 @@ module Aidp
           puts "  3. Get help"
           puts "  4. Cancel all questions"
 
-          choice = Readline.readline("Your choice (1-4): ", true)
+          choice = @prompt.select("Choose an option:", {
+            "Try again" => "1",
+            "Skip this question" => "2",
+            "Get help" => "3",
+            "Cancel all questions" => "4"
+          })
 
-          case choice&.strip
+          case choice
           when "1"
             puts "🔄 Retrying..."
             :retry
@@ -529,7 +575,7 @@ module Aidp
         end
 
         puts "\nPress Enter to continue..."
-        Readline.readline
+        @prompt.keypress("Press any key to continue...")
       end
 
       # Enhanced error handling and validation display
@@ -563,7 +609,7 @@ module Aidp
           end
           puts "\nPress Enter to continue or type 'fix' to correct..."
 
-          input = Readline.readline("", true)
+          input = @prompt.ask("")
           return input&.strip&.downcase == "fix"
         end
         false
@@ -573,21 +619,16 @@ module Aidp
       def get_text_response(expected_input, default_value, required, options = {})
         prompt = "Your response"
         prompt += " (default: #{default_value})" if default_value
-        prompt += required ? ": " : " (optional): "
+        prompt_text = prompt + (required ? "" : " (optional)")
 
         loop do
-          input = Readline.readline(prompt, true)
+          input = get_input_with_prompt(prompt_text, required: required, default: default_value)
 
-          # Handle empty input
-          if input.nil? || input.strip.empty?
-            if default_value
-              return default_value
-            elsif required
-              puts "❌ This field is required. Please provide a response."
-              next
-            else
-              return nil
-            end
+          # get_input_with_prompt already handles required validation and returns non-empty input
+          # Only validate the type/format if we got input
+          if input.nil?
+            # This should only happen for non-required fields
+            return nil
           end
 
           # Enhanced validation
@@ -622,7 +663,7 @@ module Aidp
           prompt += " (default: #{default_value})" if default_value
           prompt += required ? ": " : " (optional): "
 
-          input = Readline.readline(prompt, true)
+          input = @prompt.ask(prompt)
 
           if input.nil? || input.strip.empty?
             if default_value
@@ -666,7 +707,7 @@ module Aidp
         prompt += required ? ": " : " (optional): "
 
         loop do
-          input = Readline.readline(prompt, true)
+          input = @prompt.ask(prompt)
 
           if input.nil? || input.strip.empty?
             return default
@@ -702,7 +743,7 @@ module Aidp
         prompt += required ? ": " : " (optional): "
 
         loop do
-          input = Readline.readline(prompt, true)
+          input = @prompt.ask(prompt)
 
           if input.nil? || input.strip.empty?
             if default_value
@@ -745,7 +786,7 @@ module Aidp
         prompt += required ? ": " : " (optional): "
 
         loop do
-          input = Readline.readline(prompt, true)
+          input = @prompt.ask(prompt)
 
           if input.nil? || input.strip.empty?
             if default_value
@@ -792,7 +833,7 @@ module Aidp
         prompt += required ? ": " : " (optional): "
 
         loop do
-          input = Readline.readline(prompt, true)
+          input = @prompt.ask(prompt)
 
           if input.nil? || input.strip.empty?
             if default_value
@@ -829,7 +870,7 @@ module Aidp
         prompt += required ? ": " : " (optional): "
 
         loop do
-          input = Readline.readline(prompt, true)
+          input = @prompt.ask(prompt)
 
           if input.nil? || input.strip.empty?
             if default_value
@@ -1278,7 +1319,7 @@ module Aidp
       # Get user input with support for file selection
       def get_user_input(prompt)
         loop do
-          input = Readline.readline(prompt, true)
+          input = @prompt.ask(prompt)
 
           # Handle empty input
           if input.nil? || input.strip.empty?
@@ -1622,7 +1663,7 @@ module Aidp
       # Get advanced file selection from user
       def get_advanced_file_selection(max_files, _search_options)
         loop do
-          input = Readline.readline("Select file (0-#{max_files}, -1=refine, p=preview, h=help): ", true)
+          input = @prompt.ask("Select file (0-#{max_files}, -1=refine, p=preview, h=help): ")
 
           if input.nil? || input.strip.empty?
             puts "Please enter a selection."
@@ -1715,7 +1756,7 @@ module Aidp
         end
 
         puts "\nPress Enter to continue..."
-        Readline.readline
+        @prompt.keypress("Press any key to continue...")
       end
 
       # Get file selection from user (legacy method for compatibility)
@@ -1729,7 +1770,7 @@ module Aidp
         prompt = "#{message} [#{default_text}]: "
 
         loop do
-          input = Readline.readline(prompt, true)
+          input = @prompt.ask(prompt)
 
           if input.nil? || input.strip.empty?
             return default
@@ -1756,7 +1797,7 @@ module Aidp
         end
 
         loop do
-          input = Readline.readline("Your choice (1-#{options.size}): ", true)
+          input = @prompt.ask("Your choice (1-#{options.size}): ")
 
           if input.nil? || input.strip.empty?
             return default if default
@@ -1927,14 +1968,14 @@ module Aidp
         if should_show_help?(questions.first&.dig(:type), seen_types)
           show_help
           puts "\nPress Enter to continue..."
-          Readline.readline
+          @prompt.keypress("Press any key to continue...")
         end
 
         # Display question summary if verbose
         if @verbose_mode
           display_question_summary(questions)
           puts "\nPress Enter to start answering questions..."
-          Readline.readline
+          @prompt.keypress("Press any key to continue...")
         end
 
         # Collect feedback
@@ -2041,17 +2082,17 @@ module Aidp
 
       # Check if pause is requested
       def pause_requested?
-        @control_mutex.synchronize { @pause_requested }
+        @control_mutex.synchronize { !!@pause_requested }
       end
 
       # Check if stop is requested
       def stop_requested?
-        @control_mutex.synchronize { @stop_requested }
+        @control_mutex.synchronize { !!@stop_requested }
       end
 
       # Check if resume is requested
       def resume_requested?
-        @control_mutex.synchronize { @resume_requested }
+        @control_mutex.synchronize { !!@resume_requested }
       end
 
       # Request pause
@@ -2124,7 +2165,7 @@ module Aidp
         puts "=" * 50
 
         loop do
-          input = Readline.readline("Paused> ", true)
+          input = @prompt.ask("Paused>")
 
           case input&.strip&.downcase
           when "r", "resume"
@@ -2189,7 +2230,7 @@ module Aidp
       # Control interface main loop
       def control_interface_loop
         loop do
-          input = Readline.readline("Control> ", true)
+          input = @prompt.ask("Control> ")
 
           case input&.strip&.downcase
           when "p", "pause"
@@ -2253,11 +2294,11 @@ module Aidp
       def get_control_status
         @control_mutex.synchronize do
           {
-            enabled: @control_interface_enabled,
-            pause_requested: @pause_requested,
-            stop_requested: @stop_requested,
-            resume_requested: @resume_requested,
-            control_thread_alive: @control_thread&.alive? || false
+            enabled: !!@control_interface_enabled,
+            pause_requested: !!@pause_requested,
+            stop_requested: !!@stop_requested,
+            resume_requested: !!@resume_requested,
+            control_thread_alive: !!@control_thread&.alive?
           }
         end
       end
@@ -2291,7 +2332,7 @@ module Aidp
         puts "=" * 50
 
         loop do
-          choice = Readline.readline("Select option (1-8): ", true)
+          choice = @prompt.ask("Select option (1-8): ")
 
           case choice&.strip
           when "1"

data/lib/aidp/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Aidp
-  VERSION = "0.8.1"
+  VERSION = "0.8.3"
 end

data/lib/aidp.rb

@@ -51,6 +51,7 @@ require_relative "aidp/harness/config_loader"
 require_relative "aidp/harness/config_manager"
 require_relative "aidp/harness/condition_detector"
 require_relative "aidp/harness/user_interface"
+require_relative "aidp/harness/simple_user_interface"
 require_relative "aidp/harness/provider_manager"
 require_relative "aidp/harness/provider_config"
 require_relative "aidp/harness/provider_factory"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aidp
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.3
 platform: ruby
 authors:
 - Bart Agapinan
@@ -23,20 +23,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.11'
-- !ruby/object:Gem::Dependency
-  name: colorize
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.1'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: csv
   requirement: !ruby/object:Gem::Requirement
@@ -286,6 +272,7 @@ files:
 - lib/aidp/harness/provider_manager.rb
 - lib/aidp/harness/provider_type_checker.rb
 - lib/aidp/harness/runner.rb
+- lib/aidp/harness/simple_user_interface.rb
 - lib/aidp/harness/state/errors.rb
 - lib/aidp/harness/state/metrics.rb
 - lib/aidp/harness/state/persistence.rb