aidp 0.49.9 → 0.49.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 152b6f4bd772dffcdd49bff974dc989b987e16e1d5a2a6cbc28ff0017eb654ad
-  data.tar.gz: 6163f77e46235f25748344bd675e8ccd221a6ce56d0322d63da1e93969ffc903
+  metadata.gz: 2521930bf3c6ad6ed74527be97a75ada7645500392b018335b3063f90e045885
+  data.tar.gz: 332b8f38ea7282420195209d115eb066311f92fac1d481b74fb8c87304df136e
 SHA512:
-  metadata.gz: fcde2af278ae33285b683948d102eecb16b38bd40d121135c80fceab6ed01908be325ce7cb2ff266d5e4399a9f1127b6aae538ad7eedf8442c46bd7630c3bdfe
-  data.tar.gz: a2d8a65e046f8bb81bcb4ec50bbf6838fe6119beb4872bec33f4249db67c107809fa12e65aeaa4452bd8b02e41be3bde74f2956a8faa6b0c70e0bfd4b3240f06
+  metadata.gz: 1f33ce70e9679f0844e008b03856da81f6de8bc0a7820eeedb25d47d5f72b93e0274d03143bd31980348ca4bd08fd0a1ee2888fb86a18a0ace1be47e1b2f322e
+  data.tar.gz: 7ea709e5742560ee4fa8617c1bdbec13143661c67e32417314a4efce07359566c188ae723ae9cc9f597a5de0977b9734077b88a72a5ac3d5578debcfbb20be9f

data/lib/aidp/cli/security_command.rb

@@ -342,12 +342,13 @@ module Aidp
           return 0
         end
 
-        # Run RSpec with timeout protection
-        cmd = "bundle exec rspec #{rspec_path} --format failures"
-        @prompt.say("$ #{cmd}\n")
+        # Run RSpec with timeout protection, passing arguments without shell
+        # interpretation of the library-provided project path
+        command_args = ["bundle", "exec", "rspec", rspec_path, "--format", "failures"]
+        @prompt.say("$ #{command_args.join(" ")}\n")
         @prompt.say("(timeout: #{AUDIT_TIMEOUT_SECONDS / 60} minutes)\n")
 
-        exit_status = run_with_timeout(cmd, AUDIT_TIMEOUT_SECONDS)
+        exit_status = run_with_timeout(command_args, AUDIT_TIMEOUT_SECONDS)
 
         case exit_status
         when 0
@@ -365,11 +366,11 @@ module Aidp
       private
 
       # Run a command with timeout protection
-      # @param cmd [String] The command to execute
+      # @param command_args [Array<String>] The command and its arguments
       # @param timeout [Integer] Timeout in seconds
       # @return [Integer, Symbol] Exit status or :timeout
-      def run_with_timeout(cmd, timeout)
-        pid = spawn(cmd)
+      def run_with_timeout(command_args, timeout)
+        pid = Process.spawn(*command_args)
         start_time = Time.now
 
         loop do

data/lib/aidp/execute/checkpoint.rb

@@ -3,6 +3,7 @@
 require "yaml"
 require "time"
 require "json"
+require "open3"
 require "aidp/rescue_logging"
 
 module Aidp
@@ -183,7 +184,8 @@ module Aidp
       def run_rubocop_check
         # Run rubocop and parse output to get a quality score
         # This is a simplified version - could be enhanced
-        result = `cd #{@project_dir} && rubocop --format json 2>/dev/null`
+        stdout, _stderr, _status = Open3.capture3("rubocop", "--format", "json", chdir: @project_dir)
+        result = stdout
         return nil if result.empty?
 
         data = JSON.parse(result)

data/lib/aidp/execute/interactive_repl.rb

@@ -2,6 +2,7 @@
 
 require "tty-prompt"
 require "tty-spinner"
+require "open3"
 require_relative "async_work_loop_runner"
 require_relative "repl_macros"
 require_relative "../rescue_logging"
@@ -307,9 +308,9 @@ module Aidp
           }
         end
 
-        # Execute reset
-        output = `git reset --hard HEAD~#{count} 2>&1`
-        success = $?.success?
+        # Execute reset without shell interpretation of the rollback count
+        output, status = Open3.capture2e("git", "reset", "--hard", "HEAD~#{count}")
+        success = status.success?
 
         {
           success: success,

data/lib/aidp/execute/work_loop_runner.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require "open3"
 require_relative "prompt_manager"
 require_relative "prompt_evaluator"
 require_relative "checkpoint"
@@ -2359,8 +2360,9 @@ module Aidp
 
         stats = {}
         files.each do |file|
-          # Use git diff to get line counts
-          output = `git diff --numstat HEAD -- "#{file}" 2>/dev/null`.strip
+          # Use git diff to get line counts without shell interpretation of file names
+          stdout, _stderr, _status = Open3.capture3("git", "diff", "--numstat", "HEAD", "--", file.to_s)
+          output = stdout.strip
           next if output.empty?
 
           parts = output.split("\t")

data/lib/aidp/harness/completion_checker.rb

@@ -64,27 +64,27 @@ module Aidp
         test_commands = detect_test_commands
         return true if test_commands.empty?
 
-        test_commands.any? do |cmd|
-          system("cd #{@project_dir} && #{cmd} > /dev/null 2>&1")
-        end
+        test_commands.any? { |cmd| run_project_command(cmd) }
       end
 
       def linting_clean?
         lint_commands = detect_lint_commands
         return true if lint_commands.empty?
 
-        lint_commands.all? do |cmd|
-          system("cd #{@project_dir} && #{cmd} > /dev/null 2>&1")
-        end
+        lint_commands.all? { |cmd| run_project_command(cmd) }
       end
 
       def build_successful?
         build_commands = detect_build_commands
         return true if build_commands.empty?
 
-        build_commands.any? do |cmd|
-          system("cd #{@project_dir} && #{cmd} > /dev/null 2>&1")
-        end
+        build_commands.any? { |cmd| run_project_command(cmd) }
+      end
+
+      # Run a detected command in the project directory without building a
+      # shell command string from the library-provided project path
+      def run_project_command(cmd)
+        system(cmd, chdir: @project_dir, out: File::NULL, err: File::NULL)
       end
 
       def documentation_complete?

data/lib/aidp/init/runner.rb

@@ -357,9 +357,9 @@ module Aidp
 
           next unless tool_command
 
-          # Check if command exists
+          # Check if command exists without shell interpretation
           begin
-            unless system("which #{tool_command} > /dev/null 2>&1")
+            unless system("which", tool_command, out: File::NULL, err: File::NULL)
               warnings << "   ⚠️  #{format_tool(tool_data[:tool])} detected but command '#{tool_command}' not found in PATH"
             end
           rescue IOError

data/lib/aidp/pr_worktree_manager.rb

@@ -1,6 +1,5 @@
 require "json"
 require "fileutils"
-require "shellwords"
 
 module Aidp
   # Manages worktrees specifically for Pull Request branches
@@ -151,17 +150,18 @@ module Aidp
             branch == "* #{base_branch}"
         end
 
-        # Enhance branch tracking and fetching
+        # Enhance branch tracking and fetching; argv execution keeps the
+        # library-provided branch name from being interpreted by a shell
         unless base_branch_exists
           # Try multiple fetch strategies
           fetch_commands = [
-            "git fetch origin #{base_branch}:#{base_branch} 2>/dev/null",
-            "git fetch origin 2>/dev/null",
-            "git fetch --all 2>/dev/null"
+            ["git", "fetch", "origin", "#{base_branch}:#{base_branch}"],
+            ["git", "fetch", "origin"],
+            ["git", "fetch", "--all"]
           ]
 
-          fetch_commands.each do |fetch_cmd|
-            @shell_executor.system(fetch_cmd)
+          fetch_commands.each do |fetch_args|
+            @shell_executor.system(*fetch_args, err: File::NULL)
             branch_list_output = `git branch -a`.split("\n").map(&:strip)
             base_branch_exists = branch_list_output.any? do |branch|
               branch.end_with?("/#{base_branch}", "remotes/origin/#{base_branch}") ||
@@ -174,14 +174,15 @@ module Aidp
 
         raise ArgumentError, "Base branch '#{base_branch}' does not exist in the repository" unless base_branch_exists
 
-        # Robust worktree creation with enhanced error handling and logging
-        worktree_create_command = "git worktree add #{Shellwords.escape(worktree_path)} -b #{Shellwords.escape(head_branch)} #{Shellwords.escape(base_branch)}"
-        unless @shell_executor.system(worktree_create_command)
+        # Robust worktree creation with enhanced error handling and logging;
+        # argv execution keeps library-provided branches and paths literal
+        worktree_create_args = ["git", "worktree", "add", worktree_path, "-b", head_branch, base_branch]
+        unless @shell_executor.system(*worktree_create_args)
           error_details = {
             pr_number: pr_number,
             base_branch: base_branch,
             head_branch: head_branch,
-            command: worktree_create_command
+            command: worktree_create_args.join(" ")
           }
           Aidp.log_error(
             "pr_worktree_manager", "worktree_creation_failed",
@@ -377,9 +378,9 @@ module Aidp
           end
         end
 
-        # Stage only successfully modified files
+        # Stage only successfully modified files without shell interpretation
         unless successful_files.empty?
-          @shell_executor.system("git add #{successful_files.map { |f| Shellwords.escape(f) }.join(" ")}")
+          @shell_executor.system("git", "add", "--", *successful_files)
         end
       end
 
@@ -428,25 +429,22 @@ module Aidp
 
       Dir.chdir(worktree_path) do
         # Check staged changes with more robust capture
-        staged_changes_output = @shell_executor.run("git diff --staged --name-only").strip
+        staged_changes_output = @shell_executor.run_argv("git", "diff", "--staged", "--name-only").stdout.strip
 
         if !staged_changes_output.empty?
           push_result[:git_actions][:staged_changes] = true
           push_result[:changed_files] = staged_changes_output.split("\n")
 
-          # More robust commit command with additional logging
-          commit_message = "Changes applied via AIDP request-changes workflow for PR ##{pr_number}"
-          commit_command = "git commit -m '#{commit_message}' 2>&1"
-          commit_output = @shell_executor.run(commit_command).strip
+          # Commit staged changes without shell interpretation of library input
+          commit_output = commit_staged_changes(pr_number)
 
-          if @shell_executor.success?
+          if commit_output.success?
             push_result[:git_actions][:committed] = true
 
-            # Enhanced push with verbose tracking
-            push_command = "git push origin #{head_branch} 2>&1"
-            push_output = @shell_executor.run(push_command).strip
+            # Push the registry-sourced head branch without shell interpretation
+            push_output = push_head_branch(head_branch)
 
-            if @shell_executor.success?
+            if push_output.success?
               push_result[:git_actions][:pushed] = true
               push_result[:success] = true
 
@@ -458,22 +456,22 @@ module Aidp
               )
             else
               # Detailed push error logging
-              push_result[:errors] << "Push failed: #{push_output}"
+              push_result[:errors] << "Push failed: #{push_output.output.strip}"
               Aidp.log_error(
                 "pr_worktree_manager", "push_changes_failed",
                 pr_number: pr_number,
                 branch: head_branch,
-                error_details: push_output
+                error_details: push_output.output.strip
               )
             end
           else
             # Detailed commit error logging
-            push_result[:errors] << "Commit failed: #{commit_output}"
+            push_result[:errors] << "Commit failed: #{commit_output.output.strip}"
             Aidp.log_error(
               "pr_worktree_manager", "commit_changes_failed",
               pr_number: pr_number,
               branch: head_branch,
-              error_details: commit_output
+              error_details: commit_output.output.strip
             )
           end
         else
@@ -496,8 +494,10 @@ module Aidp
       existing_worktree = @worktrees[pr_number.to_s]
       return false unless existing_worktree
 
-      # Remove git worktree
-      @shell_executor.system("git worktree remove #{existing_worktree["path"]}") if File.exist?(existing_worktree["path"])
+      # Remove git worktree without shell interpretation of registry data
+      if File.exist?(existing_worktree["path"])
+        @shell_executor.system("git", "worktree", "remove", existing_worktree["path"])
+      end
 
       # Remove from registry and save
       @worktrees.delete(pr_number.to_s)
@@ -532,6 +532,19 @@ module Aidp
 
     private
 
+    # Commit currently staged changes; argv execution keeps externally
+    # sourced values (pr_number) from being interpreted by a shell
+    def commit_staged_changes(pr_number)
+      commit_message = "Changes applied via AIDP request-changes workflow for PR ##{pr_number}"
+      @shell_executor.run_argv("git", "commit", "-m", commit_message)
+    end
+
+    # Push the head branch; argv execution keeps registry-sourced branch
+    # names from being interpreted by a shell
+    def push_head_branch(head_branch)
+      @shell_executor.run_argv("git", "push", "origin", "--", head_branch)
+    end
+
     # Load the worktree registry from file
     def load_registry
       return {} unless File.exist?(worktree_registry_path)

data/lib/aidp/shell_executor.rb

@@ -3,8 +3,9 @@
 module Aidp
   # Shell command executor wrapper for testability
   #
-  # Provides two modes of execution:
-  # 1. `run(command)` - Captures output silently via backticks
+  # Commands are always executed in argument form so shell
+  # metacharacters in any value are treated as literal data:
+  # 1. `run_argv(*command)` - Captures output without shell interpretation
   # 2. `system(*args)` - Wraps Kernel.system() with optional output suppression
   #
   # In tests, set `ShellExecutor.suppress_output = true` to suppress all
@@ -25,19 +26,45 @@ module Aidp
     end
     self.suppress_output = false
 
-    # Run a command and capture its output
-    #
-    # @param command [String] The shell command to run
-    # @return [String] The command's stdout output
-    def run(command)
-      `#{command}`
+    # Immutable result of a shell-free command execution
+    class Result
+      attr_reader :stdout, :stderr, :exit_status
+
+      # @param stdout [String] standard output from the command
+      # @param stderr [String] standard error from the command
+      # @param exit_status [Integer] exit status code
+      def initialize(stdout:, stderr:, exit_status:)
+        @stdout = stdout.to_s.freeze
+        @stderr = stderr.to_s.freeze
+        @exit_status = exit_status || 1
+        freeze
+      end
+
+      # @return [Boolean] true if exit_status is 0
+      def success?
+        @exit_status.zero?
+      end
+
+      # Combined output, equivalent to shell `2>&1` redirection
+      # @return [String]
+      def output
+        [@stdout, @stderr].reject(&:empty?).join("\n")
+      end
     end
 
-    # Check if the last command succeeded
+    # Run a command without shell interpretation and capture its output
+    #
+    # The command and its arguments are passed directly to the operating
+    # system, so shell metacharacters in any argument are treated as
+    # literal data. Prefer this over #run whenever an argument may contain
+    # externally supplied values.
     #
-    # @return [Boolean] true if last command exited with status 0
-    def success?
-      $?.success?
+    # @param command [Array<String>] the command and its arguments
+    # @return [Result] captured stdout/stderr with the exit status
+    def run_argv(*command)
+      require "open3"
+      stdout, stderr, status = Open3.capture3(*command.map(&:to_s))
+      Result.new(stdout: stdout, stderr: stderr, exit_status: status.exitstatus)
     end
 
     # Run a command via system(), optionally suppressing output

data/lib/aidp/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Aidp
-  VERSION = "0.49.9"
+  VERSION = "0.49.11"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aidp
 version: !ruby/object:Gem::Version
-  version: 0.49.9
+  version: 0.49.11
 platform: ruby
 authors:
 - Bart Agapinan