aidp 0.49.18 → 0.49.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 72094343c4cb811f45802e8bca991151f1217682bfe9924fdef242f8c8053004
-  data.tar.gz: 80c5d64fa5345ada2c37d957ad1fe9663a5311ae7a4643941c80aececcb1a2d3
+  metadata.gz: 3bcae0816a7d6d049e039d8670fd6b8e21e7e9228af2d0b996853c38f39b2bd6
+  data.tar.gz: f7aeae62f6ce57552d31885a69461ea00c50bf9d4f30056a3f76ea563b174eb6
 SHA512:
-  metadata.gz: 369997eba3b55c78bc6319ea393e4a35a087fa019e7c8592147da40a0514ba859ce9cf74d5724b5a95e9805983fbb3de36cf3eb04623d7c75c645f3db7a77739
-  data.tar.gz: b0e5be3533c78df9ed64a68a1419547e6f73d1b25e601fc4b8f92215040f07224e69d92d771c44fd8196befa0b3a6313c61e7178ee1edea54205185e47fb926f
+  metadata.gz: 81497e0b2050c4e9d06e45a0251123e792993694b64e5015b6a0f907ab1dc22bd576266c11a2254afed433285570cf459152d357c01ea345e0cc99a7279f7d38
+  data.tar.gz: 873e5c878b464542b6a533222db9842bf7303e06d29d868b020588079c6eb957ff51b4b2238b027cf15ce2579588bba8ad8ef4f841f47305eb5cfd71a5a1dfed

data/lib/aidp/harness/completion_checker.rb

@@ -1,12 +1,15 @@
 # frozen_string_literal: true
 
+require_relative "../shell_executor"
+
 module Aidp
   module Harness
     # Checks completion criteria for the workflow
     class CompletionChecker
-      def initialize(project_dir, workflow_type = :exploration)
+      def initialize(project_dir, workflow_type = :exploration, command_executor: Aidp::ShellExecutor.new)
         @project_dir = project_dir
         @workflow_type = workflow_type
+        @command_executor = command_executor
         @completion_results = {}
       end
 
@@ -81,17 +84,20 @@ module Aidp
         build_commands.any? { |cmd| run_project_command(cmd) }
       end
 
-      # Run a detected command in the project directory. The command line is
-      # tokenized with Shellwords and executed in argument form, so the shell
-      # never interprets the library-provided command string. The [cmdname,
-      # argv0] pair forces argument form even for a single-token command,
-      # which system would otherwise execute via /bin/sh -c.
+      # Run a detected command without letting a shell interpret it.
       def run_project_command(cmd)
         require "shellwords"
         argv = Shellwords.split(cmd).flat_map { |arg| expand_arg(arg) }
         return false if argv.empty?
 
-        system([argv[0], argv[0]], *argv.drop(1), chdir: @project_dir, out: File::NULL, err: File::NULL)
+        @command_executor.run_argv(
+          *argv,
+          chdir: @project_dir,
+          out: File::NULL,
+          err: File::NULL
+        ).success?
+      rescue ArgumentError, Errno::ENOENT
+        false
       end
 
       # Expand shell-style glob tokens (e.g. test/**/*_test.rb) within the

data/lib/aidp/shell_executor.rb

@@ -61,9 +61,15 @@ module Aidp
     #
     # @param command [Array<String>] the command and its arguments
     # @return [Result] captured stdout/stderr with the exit status
-    def run_argv(*command)
+    def run_argv(*command, **opts)
       require "open3"
-      stdout, stderr, status = Open3.capture3(*command.map(&:to_s))
+      program, *args = command.map(&:to_s)
+      raise ArgumentError, "command must not be blank" if program.nil? || program.empty?
+
+      # The [program, argv0] form forces direct execution even when a command
+      # has no arguments. Passing one string to Open3 can otherwise invoke a
+      # shell when that string contains shell metacharacters.
+      stdout, stderr, status = Open3.capture3([program, program], *args, **opts)
       Result.new(stdout: stdout, stderr: stderr, exit_status: status.exitstatus)
     end
 
@@ -81,7 +87,6 @@ module Aidp
     # @raise [ArgumentError] when the command line is blank, has
     #   unbalanced quotes, or uses shell operators/redirections
     def run_line(command, **opts)
-      require "open3"
       require "shellwords"
       argv = Shellwords.split(command.to_s)
       raise ArgumentError, "command must not be blank" if argv.empty?
@@ -113,8 +118,7 @@ module Aidp
           "split into program and arguments"
       end
 
-      stdout, stderr, status = Open3.capture3(*argv, **opts)
-      Result.new(stdout: stdout, stderr: stderr, exit_status: status.exitstatus)
+      run_argv(*argv, **opts)
     end
 
     # Run a command via system(), optionally suppressing output

data/lib/aidp/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Aidp
-  VERSION = "0.49.18"
+  VERSION = "0.49.20"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aidp
 version: !ruby/object:Gem::Version
-  version: 0.49.18
+  version: 0.49.20
 platform: ruby
 authors:
 - Bart Agapinan