aidp 0.49.17 → 0.49.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 58a524647b6ac1b6ef0c819508de7693794689414d6f5bde4f1cba5cddf8799f
-  data.tar.gz: 6c7da67512e7c04941c0afa6db927b348fcd9f31809526723a107b419ab91866
+  metadata.gz: 229127ce8581e8c5bdb52bcaf5f29ef631478f6f87c48fcc28feb0ba947288f0
+  data.tar.gz: badaf5c96b27e6fe122725049b8df3ad96b8cdd3bb8048906b3e3938ef88b12a
 SHA512:
-  metadata.gz: 56a49eaffe7e9f81e0fa4457634814622867fb335e54ac182b4fd31b05c3063ad726790c7376820101e6b57bd2b07c7b4ac6c3ac8b0f69220f248681a0ba8e65
-  data.tar.gz: 610e7e0a8e151208fd5c623a3937974ec3cdab2ca72741d421bb6bab003cb6514ff8dc449d35f52c06ca0083dd3e40b2ef114a54269703137ed00cc95bfefe0b
+  metadata.gz: 31350c11a98b2946408390b711dcdac751f679ed9a071bf8c9cff0f025bb0f6bfb04a314994a5863bb1f0d7b29180a475bb8ecc353492c86900f9cc89cfc764d
+  data.tar.gz: 673575daca822c6a84074d93388c94a59b0c39aeff6c3c9f435a483deca2e6fad4ca4ce3d5626b83d0a9cd49f42f465f59e8afe278629826f3cc33530db28267

data/lib/aidp/harness/completion_checker.rb

@@ -1,12 +1,15 @@
 # frozen_string_literal: true
 
+require_relative "../shell_executor"
+
 module Aidp
   module Harness
     # Checks completion criteria for the workflow
     class CompletionChecker
-      def initialize(project_dir, workflow_type = :exploration)
+      def initialize(project_dir, workflow_type = :exploration, command_executor: Aidp::ShellExecutor.new)
         @project_dir = project_dir
         @workflow_type = workflow_type
+        @command_executor = command_executor
         @completion_results = {}
       end
 
@@ -81,10 +84,29 @@ module Aidp
         build_commands.any? { |cmd| run_project_command(cmd) }
       end
 
-      # Run a detected command in the project directory without building a
-      # shell command string from the library-provided project path
+      # Run a detected command without letting a shell interpret it.
       def run_project_command(cmd)
-        system(cmd, chdir: @project_dir, out: File::NULL, err: File::NULL)
+        require "shellwords"
+        argv = Shellwords.split(cmd).flat_map { |arg| expand_arg(arg) }
+        return false if argv.empty?
+
+        @command_executor.run_argv(
+          *argv,
+          chdir: @project_dir,
+          out: File::NULL,
+          err: File::NULL
+        ).success?
+      rescue ArgumentError, Errno::ENOENT
+        false
+      end
+
+      # Expand shell-style glob tokens (e.g. test/**/*_test.rb) within the
+      # project directory, since argument-form execution skips shell globbing.
+      def expand_arg(arg)
+        return [arg] unless arg.match?(/[*?\[{}]/)
+
+        matches = Dir.chdir(@project_dir) { Dir.glob(arg) }
+        matches.empty? ? [arg] : matches
       end
 
       def documentation_complete?

data/lib/aidp/shell_executor.rb

@@ -61,9 +61,15 @@ module Aidp
     #
     # @param command [Array<String>] the command and its arguments
     # @return [Result] captured stdout/stderr with the exit status
-    def run_argv(*command)
+    def run_argv(*command, **opts)
       require "open3"
-      stdout, stderr, status = Open3.capture3(*command.map(&:to_s))
+      program, *args = command.map(&:to_s)
+      raise ArgumentError, "command must not be blank" if program.nil? || program.empty?
+
+      # The [program, argv0] form forces direct execution even when a command
+      # has no arguments. Passing one string to Open3 can otherwise invoke a
+      # shell when that string contains shell metacharacters.
+      stdout, stderr, status = Open3.capture3([program, program], *args, **opts)
       Result.new(stdout: stdout, stderr: stderr, exit_status: status.exitstatus)
     end
 

data/lib/aidp/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Aidp
-  VERSION = "0.49.17"
+  VERSION = "0.49.19"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aidp
 version: !ruby/object:Gem::Version
-  version: 0.49.17
+  version: 0.49.19
 platform: ruby
 authors:
 - Bart Agapinan