aidp 0.49.14 → 0.49.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e0670861e0010f7d691a78995723512362bbc9bc3562c259319e4aec8ae90bec
-  data.tar.gz: 790b9b93cb98ea2dc6c4a9c210d2943e8e78df5e6921fdd7dafdcc3bc62af309
+  metadata.gz: 07a0de360baac2e2fe9bef74c5640816819eb0287c33dedecc841e1796de446d
+  data.tar.gz: 2852544514c863e1ee4fa17ede88416556aef5bc427b216669a8dd2d872de864
 SHA512:
-  metadata.gz: 05d15e5b9a97261dff4cba04fa8b830e594553d0dd0f20a29baa757e3085c076cfe32e3889d2a19f03270483cf746c1329c7127b99ba9e7c16d63b0b81e1f862
-  data.tar.gz: 94d6d3f9393050449c3fe2f1521acb793f09dd27d247422184374a398c6f4fc91f595d889a12b99b765d6475d1a3deb2360831b614df909463a02bdd6c9c86df
+  metadata.gz: c91a1fb45d5f061959443f649d81af1750940bbd4f3699e16f4f8b5ee0402fdc6ff0fb3ef78a8bd555728b06c010debcce49f26a7409cfc838e1fe50e50d3941
+  data.tar.gz: b80d5ff7e95b21507a9a7949a58e5908a7cd659a3155e330210150eac63c11253b41e2d1af1c65d7eb86cd08ec580c99b42a2f8bff02c9cb1e825f7daea7db09

data/lib/aidp/cli/issue_importer.rb

@@ -120,14 +120,15 @@ module Aidp
     end
 
     def fetch_via_gh_cli(owner, repo, number)
-      cmd = [
+      # Keep the gh CLI and its flags as separate argv entries so the
+      # library-provided owner/repo values are never interpreted by a shell.
+      Aidp.log_debug(COMPONENT, "Running gh cli", owner: owner, repo: repo, number: number, command: "gh issue view")
+      stdout, stderr, status = capture3_with_timeout(
         "gh", "issue", "view", number,
         "--repo", "#{owner}/#{repo}",
-        "--json", "title,body,labels,milestone,comments,state,assignees,number,url"
-      ]
-
-      Aidp.log_debug(COMPONENT, "Running gh cli", owner: owner, repo: repo, number: number, command: cmd.join(" "))
-      stdout, stderr, status = capture3_with_timeout(*cmd, timeout: gh_cli_timeout)
+        "--json", "title,body,labels,milestone,comments,state,assignees,number,url",
+        timeout: gh_cli_timeout
+      )
       Aidp.log_debug(COMPONENT, "Completed gh cli", owner: owner, repo: repo, number: number, exitstatus: status.exitstatus)
 
       unless status.success?
@@ -320,14 +321,17 @@ module Aidp
       false
     end
 
-    def capture3_with_timeout(*cmd, timeout:)
+    # Run a command without shell interpretation: the executable is passed as
+    # a separate leading argument, so shell metacharacters in any argument
+    # value are treated as literal data.
+    def capture3_with_timeout(command, *args, timeout:)
       stdout_str = +""
       stderr_str = +""
       status = nil
       wait_thr = nil
 
       Timeout.timeout(timeout) do
-        Open3.popen3(*cmd) do |stdin, stdout_io, stderr_io, thread|
+        Open3.popen3(command, *args) do |stdin, stdout_io, stderr_io, thread|
           wait_thr = thread
           stdin.close
           stdout_str = stdout_io.read

data/lib/aidp/execute/deterministic_unit.rb

@@ -3,6 +3,7 @@
 require "yaml"
 require_relative "../message_display"
 require_relative "../rescue_logging"
+require_relative "../shell_executor"
 require_relative "../util"
 
 module Aidp
@@ -228,24 +229,22 @@ module Aidp
         end
 
         def build_default_command_runner
+          command_executor = ShellExecutor.new
           lambda do |command, _context|
-            require "tty-command"
-
-            cmd = TTY::Command.new(printer: :quiet)
-            result = cmd.run(command, chdir: @project_dir)
-
-            {
-              exit_status: result.exit_status,
-              stdout: result.out,
-              stderr: result.err
-            }
-          rescue TTY::Command::ExitError => e
-            result = e.result
+            result = command_executor.run_line(command, chdir: @project_dir)
             {
               exit_status: result.exit_status,
-              stdout: result.out,
-              stderr: result.err
+              stdout: result.stdout,
+              stderr: result.stderr
             }
+          rescue ArgumentError => e
+            # Rejected shell syntax or an unparseable command line (Shellwords
+            # raises ArgumentError for unbalanced quotes or NUL bytes)
+            {exit_status: 127, stdout: "", stderr: e.message}
+          rescue SystemCallError => e
+            # Spawn failures: missing binary (ENOENT), non-executable file
+            # (EACCES), directory used as command (EISDIR), and similar errnos
+            {exit_status: 127, stdout: "", stderr: e.message}
           end
         end
       end

data/lib/aidp/harness/test_runner.rb

@@ -301,7 +301,7 @@ module Aidp
       def execute_command_line(command)
         result = command_runner.run_line(command, chdir: @project_dir)
         [result.stdout, result.stderr, result]
-      rescue ArgumentError, Errno::ENOENT => e
+      rescue ArgumentError, SystemCallError => e
         result = ShellExecutor::Result.new(stdout: "", stderr: e.message, exit_status: 1)
         [result.stdout, result.stderr, result]
       end

data/lib/aidp/setup/wizard.rb

@@ -650,7 +650,7 @@ module Aidp
           q.validate(/\A[a-z0-9_]+\z/i, "Name must be alphanumeric with underscores")
         end
 
-        command = prompt.ask("Shell command to run:", required: true)
+        command = prompt.ask("Command to run (executed without a shell; no &&, ||, |, ;, redirects, or VAR=value prefixes):", required: true)
 
         category_choices = [
           ["Test (unit, integration, e2e)", :test],

data/lib/aidp/shell_executor.rb

@@ -86,15 +86,33 @@ module Aidp
       argv = Shellwords.split(command.to_s)
       raise ArgumentError, "command must not be blank" if argv.empty?
 
-      # Operator tokens signal an intent to use shell features, which are
-      # intentionally unsupported here; reject them loudly rather than
-      # running them as literal arguments.
-      if argv.any? { |token| %w[&& || ; |].include?(token) || token.match?(/^[<>&]/) }
+      # A leading NAME=value token is a shell environment assignment; without
+      # a shell it would be treated as the program name and fail to run.
+      if argv.first.match?(/\A[A-Za-z_][A-Za-z0-9_]*=/)
+        raise ArgumentError,
+          "environment variable assignments are not supported; " \
+          "prefix the command with env (e.g. env VAR=value command)"
+      end
+
+      # Operator and redirection tokens signal an intent to use shell
+      # features, which are intentionally unsupported here; reject them
+      # loudly rather than running them as literal arguments. A leading file
+      # descriptor digit (e.g. `2>`) still introduces a shell redirect.
+      if argv.any? { |token| %w[&& || ; |].include?(token) || token.match?(/\A\d*[<>&]/) }
         raise ArgumentError,
           "shell operators are not supported in configured commands; " \
           "split into separate commands instead: #{command.inspect}"
       end
 
+      # A single token that still contains shell metacharacters would be
+      # handed to Process.spawn as a lone string, which Ruby routes through
+      # sh -c; reject it rather than let the shell interpret it.
+      if argv.length == 1 && argv.first.match?(/[*?\[\]{}()<>|;&$\\"'`\r\n~#=]/)
+        raise ArgumentError,
+          "shell metacharacters in a single-token command are not supported; " \
+          "split into program and arguments"
+      end
+
       stdout, stderr, status = Open3.capture3(*argv, **opts)
       Result.new(stdout: stdout, stderr: stderr, exit_status: status.exitstatus)
     end

data/lib/aidp/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Aidp
-  VERSION = "0.49.14"
+  VERSION = "0.49.16"
 end

data/lib/aidp/worktree.rb

@@ -344,7 +344,10 @@ module Aidp
             worktree_path: worktree_path,
             base_branch: effective_base_branch
           )
-          stdout, stderr, status = Dir.chdir(project_dir) { Open3.capture3(*cmd) }
+          # Pass the git subcommand as a separate leading argument so the
+          # library-provided branch and path values are never interpreted
+          # by a shell.
+          stdout, stderr, status = Dir.chdir(project_dir) { Open3.capture3("git", *cmd) }
 
           return if status.success?
 
@@ -367,11 +370,13 @@ module Aidp
         end
       end
 
+      # Build the worktree creation arguments (without the leading "git"),
+      # so the caller can pass them as separate argv entries.
       def build_worktree_command(branch_exists:, branch:, worktree_path:, base_branch:)
         if branch_exists
-          ["git", "worktree", "add", worktree_path, branch]
+          ["worktree", "add", worktree_path, branch]
         else
-          cmd = ["git", "worktree", "add", "-b", branch, worktree_path]
+          cmd = ["worktree", "add", "-b", branch, worktree_path]
           cmd << base_branch if base_branch
           cmd
         end

data/lib/aidp/worktree_branch_manager.rb

@@ -68,7 +68,7 @@ module Aidp
         # 3. Use git worktree list for broader search
         -> {
           begin
-            worktree_list_output = run_git_command(["git", "worktree", "list"])
+            worktree_list_output = run_git_command("git", "worktree", "list")
             worktree_list_output.split("\n").each do |line|
               path, branch_info = line.split(" ", 2)
               return path if branch_info&.include?(branch)
@@ -152,7 +152,7 @@ module Aidp
           if force_recreate
             # Attempt to remove existing worktree
             begin
-              run_git_command(["git", "worktree", "remove", existing_worktree])
+              run_git_command("git", "worktree", "remove", existing_worktree)
               Aidp.log_debug("worktree_branch_manager", "existing_worktree_removed",
                 path: existing_worktree)
             rescue => e
@@ -187,8 +187,8 @@ module Aidp
           Aidp.log_debug("worktree_branch_manager", "create_strategy_remote_tracking",
             branch: effective_branch,
             base_branch: resolved_base_branch)
-          run_git_command(["git", "fetch", "origin", resolved_base_branch])
-          run_git_command(["git", "worktree", "add", "-b", effective_branch, worktree_path, "origin/#{resolved_base_branch}"])
+          run_git_command("git", "fetch", "origin", resolved_base_branch)
+          run_git_command("git", "worktree", "add", "-b", effective_branch, worktree_path, "origin/#{resolved_base_branch}")
         },
 
         # Strategy 2: Create without remote tracking
@@ -196,7 +196,7 @@ module Aidp
           Aidp.log_debug("worktree_branch_manager", "create_strategy_local_branch",
             branch: effective_branch,
             base_branch: resolved_base_branch)
-          run_git_command(["git", "worktree", "add", "-b", effective_branch, worktree_path, resolved_base_branch])
+          run_git_command("git", "worktree", "add", "-b", effective_branch, worktree_path, resolved_base_branch)
         },
 
         # Strategy 3: Checkout existing branch (for when branch already exists)
@@ -204,7 +204,7 @@ module Aidp
           Aidp.log_debug("worktree_branch_manager", "create_strategy_existing_branch",
             branch: effective_branch,
             base_branch: resolved_base_branch)
-          run_git_command(["git", "worktree", "add", worktree_path, effective_branch])
+          run_git_command("git", "worktree", "add", worktree_path, effective_branch)
         }
       ]
 
@@ -317,7 +317,7 @@ module Aidp
       # If PR number is provided, try to get base branch from GitHub
       if pr_number
         begin
-          pr_info_output = run_git_command(["gh", "pr", "view", pr_number.to_s, "--json", "baseRefName"])
+          pr_info_output = run_git_command("gh", "pr", "view", pr_number.to_s, "--json", "baseRefName")
           pr_base_branch = JSON.parse(pr_info_output)["baseRefName"]
           return pr_base_branch if pr_base_branch && !pr_base_branch.empty?
         rescue => e
@@ -328,7 +328,7 @@ module Aidp
 
       # Try to fetch origin branches
       begin
-        run_git_command(["git", "fetch", "origin", default_base_branch])
+        run_git_command("git", "fetch", "origin", default_base_branch)
       rescue => e
         Aidp.log_debug("worktree_branch_manager", "base_branch_fetch_failed",
           base_branch: default_base_branch, error: e.message)
@@ -352,11 +352,12 @@ module Aidp
       end
     end
 
-    def run_git_command(cmd)
+    # Run a command with argv execution so shell metacharacters in any
+    # library-provided value (branch names, paths) are treated as literal
+    # data instead of being interpreted by a shell.
+    def run_git_command(command, *args)
       Dir.chdir(@project_dir) do
-        # Convert string command to array for safe execution (no shell interpolation)
-        args = cmd.is_a?(Array) ? cmd : cmd.split
-        output, status = Open3.capture2e(*args)
+        output, status = Open3.capture2e(command, *args)
         raise StandardError, output unless status.success?
         output
       end
@@ -444,7 +445,7 @@ module Aidp
 
       # Fetch pull request information from GitHub
       begin
-        pr_info_output = run_git_command(["gh", "pr", "view", pr_number.to_s, "--json", "headRefName"])
+        pr_info_output = run_git_command("gh", "pr", "view", pr_number.to_s, "--json", "headRefName")
         pr_branch = JSON.parse(pr_info_output)["headRefName"]
 
         if pr_branch.nil? || pr_branch.empty?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aidp
 version: !ruby/object:Gem::Version
-  version: 0.49.14
+  version: 0.49.16
 platform: ruby
 authors:
 - Bart Agapinan