aidp 0.49.12 → 0.49.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7aebc32c94a99c769c32718c0d1831888e9d7e9e16eb2968f64e9fd8e1d04b23
-  data.tar.gz: 10380f1bfa01c5154d3aa19be32a67b8e757a66c27b1e8bb128769787357d194
+  metadata.gz: 5840a5dd1754c05dcb6fb0c8d2b96fecf2a093896caf19704d80397ad97f829c
+  data.tar.gz: '008354478b95ae1e16b8064ae0485c44aa930edec611e0b0aaa1a04da18ccaca'
 SHA512:
-  metadata.gz: e5b4b81a0662bbc8e5d6b2a4ecdbc0104f14cef44898cd01c219ed1a09ae53218afa89cb5178acc2a4361eee3d0ff1081fd32cdf225a4df3862168081b3140d5
-  data.tar.gz: '02699b7be327242d960f268f972b6fd38984d251878bca63b2075dceeae3383ac3ca82a42f182755da16263754e5a701581a5d6eeb3436980df7ff4c1c85384f'
+  metadata.gz: 0a3ca1a4fc8923f0599a85ea630a0d39e429790c1a718891e40e5e56d4d5a9170c72e03bf2d083567686e168391897dc15b8a3e4fc28c83569cb6aa0b2f7bac7
+  data.tar.gz: beb27cca39345af8ed6f546bd284ab1a90dd0b52336479cfe4399a1166ba70aa826f4108556ddbc33522de2a40033dff9791652a7d253043de4a5741cd441114

data/lib/aidp/harness/ai_filter_factory.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "json"
+require_relative "../shell_executor"
 require_relative "filter_definition"
 require_relative "provider_factory"
 require_relative "thinking_depth_manager"
@@ -264,13 +265,11 @@ module Aidp
       end
 
       def capture_sample_output(command, project_dir)
-        # Run command and capture output (with timeout)
-        require "open3"
-
-        stdout, stderr, _ = Open3.capture3(command, chdir: project_dir)
+        # Run command without shell interpretation and capture output
+        result = ShellExecutor.new.run_line(command, chdir: project_dir)
 
         # Combine stdout and stderr for analysis
-        output = stdout + stderr
+        output = result.stdout + result.stderr
         output.empty? ? nil : output
       rescue => e
         Aidp.log_debug("ai_filter_factory", "Failed to capture sample output",

data/lib/aidp/harness/test_runner.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require "open3"
 require_relative "../tooling_detector"
+require_relative "../shell_executor"
 require_relative "output_filter"
 require_relative "output_filter_config"
 require_relative "rspec_command_optimizer"
@@ -267,16 +267,16 @@ module Aidp
           end
         end
 
-        stdout, stderr, status = Open3.capture3(actual_command, chdir: @project_dir)
+        stdout, stderr, result = execute_command_line(actual_command)
 
         # Handle special case: --only-failures with no failures to rerun
         # RSpec exits with 0 and says "All examples were filtered out"
-        if optimization_info&.dig(:optimized) && status.success? && stdout.include?("All examples were filtered out")
+        if optimization_info&.dig(:optimized) && result.success? && stdout.include?("All examples were filtered out")
           Aidp.log_info("test_runner", "rspec_only_failures_empty",
             message: "No failures to rerun, running full suite")
 
           # Fall back to full RSpec run
-          stdout, stderr, status = Open3.capture3(command, chdir: @project_dir)
+          stdout, stderr, result = execute_command_line(command)
           actual_command = command
         end
 
@@ -284,14 +284,32 @@ module Aidp
           command: actual_command,
           original_command: command,
           type: type,
-          success: status.success?,
-          exit_code: status.exitstatus,
+          success: result.success?,
+          exit_code: result.exit_status,
           stdout: stdout,
           stderr: stderr,
           rspec_optimized: optimization_info&.dig(:optimized) || false
         }
       end
 
+      # Execute a configured command line without shell interpretation so
+      # shell metacharacters in configuration values are treated as data.
+      # Execution failures (missing executables, rejected shell operators)
+      # are reported as a failed command rather than raised, so a bad
+      # aidp.yml entry surfaces as a failed check instead of crashing the
+      # work loop.
+      def execute_command_line(command)
+        result = command_runner.run_line(command, chdir: @project_dir)
+        [result.stdout, result.stderr, result]
+      rescue ArgumentError, Errno::ENOENT => e
+        result = ShellExecutor::Result.new(stdout: "", stderr: e.message, exit_status: 1)
+        [result.stdout, result.stderr, result]
+      end
+
+      def command_runner
+        @command_runner ||= ShellExecutor.new
+      end
+
       def aggregate_results(results, category, mode: :full)
         # Separate required and optional command failures
         all_failures = results.reject { |r| r[:success] }

data/lib/aidp/shell_executor.rb

@@ -67,6 +67,38 @@ module Aidp
       Result.new(stdout: stdout, stderr: stderr, exit_status: status.exitstatus)
     end
 
+    # Run a command line without shell interpretation and capture its output
+    #
+    # The line is tokenized with Shellwords, so quoting in the command
+    # string is honored as argument boundaries, but the resulting argv is
+    # passed directly to the operating system. Shell metacharacters
+    # (operators, redirections, substitutions) are never interpreted,
+    # which makes this safe for command lines built from untrusted input.
+    #
+    # @param command [String] the command line to run
+    # @param opts [Hash] options forwarded to Open3.capture3 (e.g. chdir:)
+    # @return [Result] captured stdout/stderr with the exit status
+    # @raise [ArgumentError] when the command line is blank, has
+    #   unbalanced quotes, or uses shell operators/redirections
+    def run_line(command, **opts)
+      require "open3"
+      require "shellwords"
+      argv = Shellwords.split(command.to_s)
+      raise ArgumentError, "command must not be blank" if argv.empty?
+
+      # Operator tokens signal an intent to use shell features, which are
+      # intentionally unsupported here; reject them loudly rather than
+      # running them as literal arguments.
+      if argv.any? { |token| %w[&& || ; |].include?(token) || token.match?(/^[<>&]/) }
+        raise ArgumentError,
+          "shell operators are not supported in configured commands; " \
+          "split into separate commands instead: #{command.inspect}"
+      end
+
+      stdout, stderr, status = Open3.capture3(*argv, **opts)
+      Result.new(stdout: stdout, stderr: stderr, exit_status: status.exitstatus)
+    end
+
     # Run a command via system(), optionally suppressing output
     #
     # When suppress_output is true, output is redirected to /dev/null

data/lib/aidp/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Aidp
-  VERSION = "0.49.12"
+  VERSION = "0.49.13"
 end

data/lib/aidp/watch/build_processor.rb

@@ -8,6 +8,7 @@ require_relative "../message_display"
 require_relative "../execute/prompt_manager"
 require_relative "../harness/runner"
 require_relative "../harness/state_manager"
+require_relative "../shell_executor"
 require_relative "../worktree"
 require_relative "../execute/progress"
 require_relative "github_state_extractor"
@@ -1125,8 +1126,7 @@ module Aidp
             next if command.nil? || command.empty?
 
             Aidp.log_debug("build_processor", "quick_validation_running_test", command: command)
-            _stdout, _stderr, status = Open3.capture3(command)
-            unless status.success?
+            unless quick_validation_runner.run_line(command).success?
               Aidp.log_debug("build_processor", "quick_validation_test_failed", command: command)
               return false
             end
@@ -1141,8 +1141,7 @@ module Aidp
             next if command.nil? || command.empty?
 
             Aidp.log_debug("build_processor", "quick_validation_running_lint", command: command)
-            _stdout, _stderr, status = Open3.capture3(command)
-            unless status.success?
+            unless quick_validation_runner.run_line(command).success?
               Aidp.log_debug("build_processor", "quick_validation_lint_failed", command: command)
               return false
             end
@@ -1155,6 +1154,12 @@ module Aidp
         Aidp.log_warn("build_processor", "quick_validation_error", error: e.message)
         false
       end
+
+      # Commands come from project configuration, so run them through a
+      # shell-free executor that treats metacharacters as literal data
+      def quick_validation_runner
+        @quick_validation_runner ||= ShellExecutor.new
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aidp
 version: !ruby/object:Gem::Version
-  version: 0.49.12
+  version: 0.49.13
 platform: ruby
 authors:
 - Bart Agapinan