aidp 0.47.1 → 0.49.0

data/lib/aidp/database/schema.rb

@@ -321,11 +321,105 @@ module Aidp
         CREATE UNIQUE INDEX IF NOT EXISTS idx_template_versions_unique ON template_versions(project_dir, template_id, version_number);
       SQL
 
+      # Version 4: Add strategy execution experience store
+      V4_STRATEGY_EXECUTION = <<~SQL
+        -- Strategy definitions for orchestration-as-data
+        CREATE TABLE IF NOT EXISTS strategies (
+            id TEXT PRIMARY KEY,
+            project_dir TEXT NOT NULL,
+            name TEXT NOT NULL,
+            spec TEXT NOT NULL,
+            created_at TEXT NOT NULL DEFAULT (datetime('now'))
+        );
+        CREATE INDEX IF NOT EXISTS idx_strategies_project_name ON strategies(project_dir, name);
+
+        -- Replayable task inputs for strategy execution
+        CREATE TABLE IF NOT EXISTS experience_tasks (
+            id TEXT PRIMARY KEY,
+            project_dir TEXT NOT NULL,
+            title TEXT,
+            description TEXT NOT NULL,
+            input_payload TEXT,
+            context TEXT,
+            source_run_id TEXT,
+            created_at TEXT NOT NULL DEFAULT (datetime('now'))
+        );
+        CREATE INDEX IF NOT EXISTS idx_experience_tasks_project ON experience_tasks(project_dir);
+        CREATE INDEX IF NOT EXISTS idx_experience_tasks_source_run ON experience_tasks(source_run_id);
+
+        -- Individual strategy execution runs, including speculative branches
+        CREATE TABLE IF NOT EXISTS experience_runs (
+            id TEXT PRIMARY KEY,
+            project_dir TEXT NOT NULL,
+            task_id TEXT NOT NULL,
+            strategy_id TEXT NOT NULL,
+            workflow_id TEXT,
+            parent_run_id TEXT,
+            branch_key TEXT,
+            status TEXT NOT NULL,
+            depth INTEGER DEFAULT 0,
+            input_payload TEXT,
+            output_payload TEXT,
+            metadata TEXT,
+            started_at TEXT NOT NULL DEFAULT (datetime('now')),
+            completed_at TEXT
+        );
+        CREATE INDEX IF NOT EXISTS idx_experience_runs_project ON experience_runs(project_dir);
+        CREATE INDEX IF NOT EXISTS idx_experience_runs_task ON experience_runs(task_id);
+        CREATE INDEX IF NOT EXISTS idx_experience_runs_parent ON experience_runs(parent_run_id);
+        CREATE INDEX IF NOT EXISTS idx_experience_runs_strategy ON experience_runs(strategy_id);
+
+        -- Evaluation signals captured for each run
+        CREATE TABLE IF NOT EXISTS experience_evaluations (
+            id INTEGER PRIMARY KEY AUTOINCREMENT,
+            project_dir TEXT NOT NULL,
+            run_id TEXT NOT NULL,
+            evaluator_name TEXT NOT NULL,
+            score REAL,
+            passed INTEGER DEFAULT 0 CHECK (passed IN (0, 1)),
+            summary TEXT,
+            metadata TEXT,
+            created_at TEXT NOT NULL DEFAULT (datetime('now'))
+        );
+        CREATE INDEX IF NOT EXISTS idx_experience_evaluations_run ON experience_evaluations(run_id);
+        CREATE INDEX IF NOT EXISTS idx_experience_evaluations_name ON experience_evaluations(project_dir, evaluator_name);
+
+        -- Artifact metadata produced by runs
+        CREATE TABLE IF NOT EXISTS experience_artifacts (
+            id INTEGER PRIMARY KEY AUTOINCREMENT,
+            project_dir TEXT NOT NULL,
+            run_id TEXT NOT NULL,
+            role TEXT NOT NULL,
+            path TEXT NOT NULL,
+            metadata TEXT,
+            created_at TEXT NOT NULL DEFAULT (datetime('now'))
+        );
+        CREATE INDEX IF NOT EXISTS idx_experience_artifacts_run ON experience_artifacts(run_id);
+
+        -- Embeddings are stored as JSON vectors until a dedicated vector store exists
+        CREATE TABLE IF NOT EXISTS experience_embeddings (
+            id INTEGER PRIMARY KEY AUTOINCREMENT,
+            project_dir TEXT NOT NULL,
+            task_id TEXT,
+            run_id TEXT,
+            embedding_type TEXT NOT NULL,
+            vector TEXT NOT NULL,
+            metadata TEXT,
+            created_at TEXT NOT NULL DEFAULT (datetime('now'))
+        );
+        CREATE INDEX IF NOT EXISTS idx_experience_embeddings_task ON experience_embeddings(task_id);
+        CREATE INDEX IF NOT EXISTS idx_experience_embeddings_run ON experience_embeddings(run_id);
+      SQL
+
       # All migrations in order
+      # V4's strategies index is intentionally non-unique so that immutable
+      # versions of a named strategy can coexist for replay and auditability;
+      # StrategyRepository keys rows by a SHA256(project_dir:name:spec) digest.
       MIGRATIONS = {
         1 => V1_INITIAL,
         2 => V2_PROMPT_FEEDBACK,
-        3 => V3_TEMPLATE_VERSIONS
+        3 => V3_TEMPLATE_VERSIONS,
+        4 => V4_STRATEGY_EXECUTION
       }.freeze
 
       # Get SQL for a specific version

data/lib/aidp/database.rb

@@ -3,6 +3,7 @@
 require "sqlite3"
 require "json"
 require "fileutils"
+Kernel.require("set") unless defined?(Set)
 
 module Aidp
   # Database module for SQLite-based storage
@@ -15,6 +16,8 @@ module Aidp
     # Thread-safe connection cache
     @connections = {}
     @mutex = Mutex.new
+    @migrated_projects = Set.new
+    @migration_mutex = Mutex.new
 
     class << self
       # Get or create a database connection for the given project directory
@@ -26,6 +29,8 @@ module Aidp
         db_path = ConfigPaths.database_file(project_dir)
 
         @mutex.synchronize do
+          invalidate_missing_connection!(db_path)
+
           # Return cached connection if valid
           if @connections[db_path]&.closed? == false
             return @connections[db_path]
@@ -53,6 +58,23 @@ module Aidp
         Migrations.run!(project_dir)
       end
 
+      # Run pending migrations at most once per process for each project directory.
+      #
+      # @param project_dir [String] Project directory path
+      # @return [Array<Integer>] List of applied migration versions
+      def migrate_once!(project_dir = Dir.pwd)
+        expanded_project_dir = File.expand_path(project_dir)
+        require_relative "database/migrations"
+
+        @migration_mutex.synchronize do
+          return [] if migration_current?(expanded_project_dir)
+
+          migrate!(expanded_project_dir).tap do
+            @migrated_projects << expanded_project_dir
+          end
+        end
+      end
+
       # Check if database exists and is initialized
       #
       # @param project_dir [String] Project directory path
@@ -134,6 +156,22 @@ module Aidp
         # Set busy timeout to 5 seconds
         db.busy_timeout = 5000
       end
+
+      def invalidate_missing_connection!(db_path)
+        db = @connections[db_path]
+        return unless db
+        return if db.closed?
+        return if File.exist?(db_path)
+
+        db.close
+        @connections.delete(db_path)
+      end
+
+      def migration_current?(project_dir)
+        @migrated_projects.include?(project_dir) &&
+          exists?(project_dir) &&
+          !Migrations.pending?(project_dir)
+      end
     end
   end
 end

data/lib/aidp/harness/configuration.rb

@@ -909,23 +909,28 @@ module Aidp
       # Load commands from configuration, supporting both new generic format
       # and legacy category-specific format for backwards compatibility
       def load_commands
-        commands = []
-
         # Load from new generic commands array if present
         raw_commands = work_loop_config[:commands] || []
-        commands.concat(normalize_generic_commands(raw_commands))
-
-        # Load from legacy category-specific arrays for backwards compatibility
-        commands.concat(load_legacy_commands)
+        generic_commands = normalize_generic_commands(raw_commands)
+        legacy_commands = load_legacy_commands
+        commands = deduplicated_commands(generic_commands, legacy_commands)
 
         Aidp.log_debug("configuration", "loaded_commands",
           total: commands.size,
           from_generic: raw_commands.size,
-          from_legacy: commands.size - raw_commands.size)
+          from_legacy: legacy_commands.size)
 
         commands
       end
 
+      def deduplicated_commands(*command_sets)
+        command_sets.flatten.uniq { |command| deduplication_key(command) }
+      end
+
+      def deduplication_key(command)
+        command.slice(:command, :required, :run_after, :category, :timeout_seconds)
+      end
+
       # Normalize generic command format
       # @param commands [Array] Raw command configurations
       # @return [Array<Hash>] Normalized command configs