aidp 0.34.1 → 0.39.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e481b19f01c0541ffc177baca0a006daa46e50dc458cfb9d009c4ac306f90fe
-  data.tar.gz: 8a6d757cdb1821070298dd4e2aa69847f422bb380f662fdc15c7a057ef40c2ef
+  metadata.gz: 8cd5163981904da173cfeb433c9d866ac8d138f7020701255d6db3e9b024d9c1
+  data.tar.gz: 414b329a3d385dd31a7822af2cb793a974f0ef8e9d231095037c0733fa054c9c
 SHA512:
-  metadata.gz: 5579edf4e50738db997d1f77f4b687192cc40df8fd28b8a03d06639191675d48a17437696d2944d0eef5c29bc836931fd9def38688974c70dcb23542b521e04b
-  data.tar.gz: fc5bf185851a4c1d0a10c0048a48ad86eb82bf5dfdfb232c455116466a50e682055e501f04b1a8abab323061a6ebb52024de69c4cc04a20696d0386917d35f06
+  metadata.gz: 2c0c3826a863f357658f9ff9a6aff38404d9939d6ece54c994b0d658bde2b8025e506f4d6964d61fc37f20f97d3bb6c30a3cb58a65ee01e437d23c93d26d53c2
+  data.tar.gz: b1fcd507b193d0f7748790f4e22604e6c5fe4d7b29f9df50221eb4850288337600ac607e057f203661b1167c966982ca09a1e97a01a216357c1b0ae46867867b

data/README.md

@@ -116,7 +116,7 @@ aidp devcontainer list-backups
 aidp devcontainer restore 0
 ```
 
-See [docs/DEVELOPMENT_CONTAINER.md](docs/DEVELOPMENT_CONTAINER.md) for complete devcontainer management documentation.
+See [docs/how-to/DEVELOPMENT_CONTAINER.md](docs/how-to/DEVELOPMENT_CONTAINER.md) for complete devcontainer management documentation.
 
 ### Devcontainer Detection
 
@@ -133,7 +133,7 @@ AIDP implements **work loops** - an iterative execution pattern where AI agents
 - **Automatic validation**: Tests and linters run after each iteration
 - **Self-correction**: Only failures are fed back for the next iteration
 
-See [Work Loops Guide](docs/WORK_LOOPS_GUIDE.md) for details.
+See [Work Loops Guide](docs/how-to/WORK_LOOPS_GUIDE.md) for details.
 
 ### Waterfall Planning Mode
 
@@ -167,7 +167,7 @@ aidp execute
 - **Mermaid Visualizations** - Gantt charts renderable on GitHub/GitLab
 - **TDD Integration** - Optional test-driven development workflow
 
-See [Waterfall Planning Mode Guide](docs/WATERFALL_PLANNING_MODE.md) for complete documentation.
+See [Waterfall Planning Mode Guide](docs/how-to/WATERFALL_PLANNING_MODE.md) for complete documentation.
 
 ### Agile Development Mode
 
@@ -222,7 +222,7 @@ Analyze existing codebase and create user research plan:
 - **Marketing Focus** - Translate features into customer value
 - **Three New Personas** - Product Manager, UX Researcher, Marketing Strategist
 
-See [Agile Development Mode Guide](docs/AGILE_MODE_GUIDE.md) for complete documentation.
+See [Agile Development Mode Guide](docs/how-to/AGILE_MODE_GUIDE.md) for complete documentation.
 
 ### GitHub Projects V2 Integration
 
@@ -257,7 +257,7 @@ main
       └── aidp/sub-123-126-component-c
 ```
 
-See [GitHub Projects Guide](docs/GITHUB_PROJECTS.md) for complete documentation.
+See [GitHub Projects Guide](docs/how-to/GITHUB_PROJECTS.md) for complete documentation.
 
 ### Job Management
 
@@ -323,7 +323,7 @@ aidp ws rm issue-123-fix-auth --delete-branch
 - Independent state and history
 - Work on multiple features in parallel
 
-See [Workstreams Guide](docs/WORKSTREAMS.md) for detailed usage.
+See [Workstreams Guide](docs/how-to/WORKSTREAMS.md) for detailed usage.
 
 ### Watch Mode (Automated GitHub Integration)
 
@@ -454,10 +454,10 @@ This ensures AIDP never gets stuck - if it needs more information, it will ask f
 
 **Additional Documentation:**
 
-- [Watch Mode Guide](docs/FULLY_AUTOMATIC_MODE.md) - Complete guide to watch mode setup and operation
-- [Watch Mode Safety](docs/WATCH_MODE_SAFETY.md) - Security features and best practices
-- [PR Automation Guide](docs/PR_AUTOMATION.md) - Detailed guide for code review, CI fixes, and PR changes
-- [PR Change Requests](docs/PR_CHANGE_REQUESTS.md) - Comprehensive documentation for automated PR modifications
+- [Watch Mode Guide](docs/how-to/FULLY_AUTOMATIC_MODE.md) - Complete guide to watch mode setup and operation
+- [Watch Mode Safety](docs/explanation/WATCH_MODE_SAFETY.md) - Security features and best practices
+- [PR Automation Guide](docs/how-to/PR_AUTOMATION.md) - Detailed guide for code review, CI fixes, and PR changes
+- [PR Change Requests](docs/how-to/PR_CHANGE_REQUESTS.md) - Comprehensive documentation for automated PR modifications
 
 ## Command Reference
 
@@ -844,10 +844,10 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for development setup and conventional co
 
 For detailed information:
 
-- **[CLI User Guide](docs/CLI_USER_GUIDE.md)** - Complete guide to using AIDP commands
-- **[Work Loops Guide](docs/WORK_LOOPS_GUIDE.md)** - Iterative workflows with automatic validation
-- **[Configuration Guide](docs/harness-configuration.md)** - Detailed configuration options and examples
-- **[Troubleshooting Guide](docs/harness-troubleshooting.md)** - Common issues and solutions
+- **[CLI User Guide](docs/how-to/CLI_USER_GUIDE.md)** - Complete guide to using AIDP commands
+- **[Work Loops Guide](docs/how-to/WORK_LOOPS_GUIDE.md)** - Iterative workflows with automatic validation
+- **[Configuration Guide](docs/reference/CONFIGURATION.md)** - Detailed configuration options and examples
+- **[Debug Guide](docs/how-to/DEBUG_GUIDE.md)** - Debugging and troubleshooting
 
 ## Manual Workflow (Alternative)
 

data/lib/aidp/agent_harness_adapter.rb

@@ -0,0 +1,309 @@
+# frozen_string_literal: true
+
+require "agent_harness"
+
+module Aidp
+  # Wraps AIDP's logger to provide standard Ruby Logger interface
+  # for AgentHarness compatibility
+  class LoggerAdapter
+    def initialize(aidp_logger, component: "agent_harness")
+      @logger = aidp_logger
+      @component = component
+    end
+
+    def debug(message = nil, &block)
+      msg = message || (block ? block.call : "")
+      @logger&.debug(@component, msg.to_s)
+    end
+
+    def info(message = nil, &block)
+      msg = message || (block ? block.call : "")
+      @logger&.info(@component, msg.to_s)
+    end
+
+    def warn(message = nil, &block)
+      msg = message || (block ? block.call : "")
+      @logger&.warn(@component, msg.to_s)
+    end
+
+    def error(message = nil, &block)
+      msg = message || (block ? block.call : "")
+      @logger&.error(@component, msg.to_s)
+    end
+
+    def fatal(message = nil, &block)
+      msg = message || (block ? block.call : "")
+      @logger&.error(@component, msg.to_s)
+    end
+
+    def level
+      :debug
+    end
+
+    def level=(val)
+      # no-op
+    end
+  end
+
+  # Adapter for using the AgentHarness gem within AIDP
+  #
+  # This adapter bridges AIDP's existing provider interface with the
+  # new AgentHarness gem, allowing gradual migration.
+  #
+  # Usage:
+  #   adapter = Aidp::AgentHarnessAdapter.new(config)
+  #   response = adapter.send_message(prompt: "Hello", provider: :claude)
+  #
+  class AgentHarnessAdapter
+    attr_reader :conductor
+
+    # Create a new adapter
+    #
+    # @param aidp_config [Aidp::Config] AIDP configuration
+    # @param logger [Logger] logger instance
+    def initialize(aidp_config, logger: nil)
+      @aidp_config = aidp_config
+      @logger = logger || Aidp.logger
+
+      configure_agent_harness
+    end
+
+    # Send a message through AgentHarness
+    #
+    # @param prompt [String] the prompt to send
+    # @param provider [Symbol, nil] provider to use
+    # @param options [Hash] additional options
+    # @return [Hash] AIDP-compatible response
+    def send_message(prompt:, provider: nil, **options)
+      start_time = Time.now
+
+      # Map AIDP options to AgentHarness options
+      harness_options = map_options(options)
+
+      # Use the conductor for orchestrated requests
+      response = @conductor.send_message(prompt, provider: provider, **harness_options)
+
+      # Convert Response to AIDP-compatible hash
+      convert_response(response, Time.now - start_time)
+    rescue AgentHarness::RateLimitError => e
+      handle_rate_limit(e, provider)
+    rescue AgentHarness::NoProvidersAvailableError => e
+      handle_no_providers(e)
+    rescue AgentHarness::Error => e
+      handle_error(e, provider)
+    end
+
+    # Get a specific provider instance
+    #
+    # @param name [Symbol] provider name
+    # @return [AgentHarness::Providers::Base] provider instance
+    def provider(name)
+      @conductor.provider_manager.get_provider(name)
+    end
+
+    # Check if a provider is available
+    #
+    # @param name [Symbol] provider name
+    # @return [Boolean] true if available
+    def provider_available?(name)
+      provider_class = AgentHarness::Providers::Registry.instance.get(name)
+      provider_class.available?
+    rescue AgentHarness::ConfigurationError
+      false
+    end
+
+    # Get orchestration status
+    #
+    # @return [Hash] status information
+    def status
+      @conductor.status
+    end
+
+    # Get token usage summary
+    #
+    # @return [Hash] token usage
+    def token_summary
+      AgentHarness.token_tracker.summary
+    end
+
+    # Register callback for token events
+    #
+    # @yield [TokenEvent] token event
+    def on_tokens_used(&block)
+      AgentHarness.token_tracker.on_tokens_used(&block)
+    end
+
+    # Reset the adapter (useful for testing)
+    def reset!
+      @conductor.reset!
+      AgentHarness.token_tracker.clear!
+    end
+
+    private
+
+    def configure_agent_harness
+      AgentHarness.configure do |config|
+        config.logger = LoggerAdapter.new(@logger)
+        config.log_level = begin
+          @aidp_config.log_level
+        rescue
+          :info
+        end
+        config.default_timeout = begin
+          @aidp_config.default_timeout
+        rescue
+          300
+        end
+
+        # Set default provider from AIDP config
+        config.default_provider = map_provider_name(@aidp_config.default_provider)
+
+        # Configure fallback providers
+        config.fallback_providers = (@aidp_config.fallback_providers || []).map { |p| map_provider_name(p) }
+
+        # Configure orchestration
+        config.orchestration do |orch|
+          orch.enabled = true
+          orch.auto_switch_on_error = true
+          orch.auto_switch_on_rate_limit = true
+
+          orch.circuit_breaker do |cb|
+            cb.enabled = true
+            cb.failure_threshold = 5
+            cb.timeout = 300
+          end
+
+          orch.retry do |r|
+            r.enabled = true
+            r.max_attempts = 3
+            r.base_delay = 1.0
+          end
+        end
+
+        # Configure providers from AIDP config
+        configure_providers(config)
+
+        # Register token usage callback
+        config.on_tokens_used do |event|
+          Aidp.log_debug("agent_harness_adapter", "token_usage",
+            provider: event.provider,
+            total_tokens: event.total_tokens)
+        end
+
+        # Register provider switch callback
+        config.on_provider_switch do |event|
+          Aidp.log_info("agent_harness_adapter", "provider_switch",
+            from: event[:from],
+            to: event[:to],
+            reason: event[:reason])
+        end
+      end
+
+      @conductor = AgentHarness.conductor
+    end
+
+    def configure_providers(config)
+      # Configure enabled providers from AIDP config
+      provider_configs = begin
+        @aidp_config.providers
+      rescue
+        {}
+      end
+
+      provider_configs.each do |name, provider_config|
+        harness_name = map_provider_name(name)
+
+        config.provider(harness_name) do |p|
+          p.enabled = provider_config[:enabled] != false
+          p.type = provider_config[:type]&.to_sym || :usage_based
+          p.priority = provider_config[:priority] || 10
+          p.timeout = provider_config[:timeout]
+          p.model = provider_config[:model]
+          p.models = provider_config[:models] || []
+        end
+      end
+
+      # Ensure default provider is configured
+      unless config.providers.key?(config.default_provider)
+        config.provider(config.default_provider) { |p| p.enabled = true }
+      end
+    end
+
+    def map_provider_name(name)
+      case name.to_s
+      when "anthropic", "claude"
+        :claude
+      when "github_copilot", "copilot"
+        :github_copilot
+      else
+        name.to_sym
+      end
+    end
+
+    def map_options(options)
+      harness_options = {}
+
+      harness_options[:model] = options[:model] if options[:model]
+      harness_options[:timeout] = options[:timeout] if options[:timeout]
+      harness_options[:session] = options[:session] if options[:session]
+      harness_options[:dangerous_mode] = options[:dangerous] if options[:dangerous]
+      harness_options[:tier] = options[:tier] if options[:tier]
+
+      harness_options
+    end
+
+    def convert_response(response, duration)
+      {
+        output: response.output,
+        success: response.success?,
+        exit_code: response.exit_code,
+        provider: response.provider,
+        model: response.model,
+        duration: duration,
+        tokens: response.tokens,
+        error: response.error
+      }
+    end
+
+    def handle_rate_limit(error, provider)
+      Aidp.log_warn("agent_harness_adapter", "rate_limited",
+        provider: provider,
+        reset_time: error.reset_time)
+
+      {
+        output: nil,
+        success: false,
+        error: error.message,
+        rate_limited: true,
+        reset_time: error.reset_time
+      }
+    end
+
+    def handle_no_providers(error)
+      Aidp.log_error("agent_harness_adapter", "no_providers_available",
+        attempted: error.attempted_providers)
+
+      {
+        output: nil,
+        success: false,
+        error: error.message,
+        no_providers: true,
+        attempted_providers: error.attempted_providers
+      }
+    end
+
+    def handle_error(error, provider)
+      Aidp.log_error("agent_harness_adapter", "provider_error",
+        provider: provider,
+        error: error.class.name,
+        message: error.message)
+
+      {
+        output: nil,
+        success: false,
+        error: error.message,
+        provider: provider
+      }
+    end
+  end
+end

data/lib/aidp/cli/issue_importer.rb

@@ -19,7 +19,8 @@ module Aidp
     # @param gh_available [Boolean, nil] (test-only) forcibly sets whether gh CLI is considered
     #   available. When nil (default) we auto-detect. This enables deterministic specs without
     #   depending on developer environment.
-    def initialize(gh_available: nil, enable_bootstrap: true)
+    # @param project_dir [String] (optional) working directory for the project. Defaults to current directory.
+    def initialize(gh_available: nil, enable_bootstrap: true, project_dir: nil)
       disabled_via_env = ENV["AIDP_DISABLE_GH_CLI"] == "1"
       @gh_available = if disabled_via_env
         false
@@ -27,6 +28,7 @@ module Aidp
         gh_available.nil? ? gh_cli_available? : gh_available
       end
       @enable_bootstrap = enable_bootstrap
+      @project_dir_override = project_dir
       Aidp.log_debug(COMPONENT, "Initialized importer", gh_available: @gh_available, enable_bootstrap: @enable_bootstrap, disabled_via_env: disabled_via_env)
       Aidp.log_debug(COMPONENT, "GitHub CLI disabled via env flag") if disabled_via_env
     end
@@ -244,7 +246,7 @@ module Aidp
       prompt_content = generate_prompt_content(issue_data)
 
       # Use PromptManager to write to .aidp/PROMPT.md and archive immediately
-      prompt_manager = Aidp::Execute::PromptManager.new(Dir.pwd)
+      prompt_manager = Aidp::Execute::PromptManager.new(project_dir)
       step_name = "github_issue_#{issue_data[:number]}"
       prompt_manager.write(prompt_content, step_name: step_name)
 
@@ -261,9 +263,9 @@ module Aidp
 
         ## Instructions
         You are working on a GitHub issue imported into AIDP. Your responsibilities:
-        1. Read this PROMPT.md file to understand what needs to be done
+        1. Read this file (`.aidp/PROMPT.md`) to understand what needs to be done
         2. Complete the work described in the issue below
-        3. **IMPORTANT**: Edit this PROMPT.md file yourself to:
+        3. **IMPORTANT**: Edit this `.aidp/PROMPT.md` file to:
            - Remove completed items
            - Update with current status
            - Keep it concise (remove unnecessary context)
@@ -272,7 +274,7 @@ module Aidp
         5. If tests/linters fail, you'll see the errors in the next iteration
 
         ## Completion Criteria
-        Mark this issue COMPLETE by adding this line to PROMPT.md:
+        Mark this issue COMPLETE by adding this line to `.aidp/PROMPT.md`:
         ```
         STATUS: COMPLETE
         ```
@@ -487,12 +489,24 @@ module Aidp
         + (result.lint_commands.empty? ? "" : "Lint Commands:\n#{result.lint_commands.map { |c| "- #{c}" }.join("\n")}\n")
 
       # Use PromptManager to append to .aidp/PROMPT.md (issue #226)
-      prompt_manager = Aidp::Execute::PromptManager.new(Dir.pwd)
+      prompt_manager = Aidp::Execute::PromptManager.new(project_dir)
       current_prompt = prompt_manager.read
       updated_prompt = current_prompt + "\n---\n\n#{tooling_info}"
       prompt_manager.write(updated_prompt, step_name: "github_issue_tooling")
 
       display_message("🧪 Detected tooling and appended to PROMPT.md", type: :info)
     end
+
+    def project_dir
+      @project_dir_override || safe_pwd
+    end
+
+    def safe_pwd
+      Dir.pwd
+    rescue Errno::ENOENT
+      # If the current directory no longer exists (e.g., in test environment),
+      # use ENV["AIDP_PROJECT_DIR"] or fallback to "."
+      ENV["AIDP_PROJECT_DIR"] || "."
+    end
   end
 end

data/lib/aidp/cli/jobs_command.rb

@@ -311,7 +311,7 @@ module Aidp
 
           jobs << job_info
         rescue JSON::ParserError => e
-          display_message("Warning: Could not parse harness log #{log_file}: #{e.message}", type: :warning) if ENV["AIDP_DEBUG"]
+          display_message("Warning: Could not parse harness log #{log_file}: #{e.message}", type: :warning) if Aidp.debug_env_enabled?
         end
 
         # Sort by creation time (newest first)

data/lib/aidp/cli/models_command.rb

@@ -3,6 +3,7 @@
 require "tty-table"
 require "tty-prompt"
 require "tty-spinner"
+require "agent_harness"
 require_relative "../harness/model_registry"
 require_relative "../harness/ruby_llm_registry"
 
@@ -208,26 +209,19 @@ module Aidp
 
       def find_providers_for_family(family_name)
         providers = []
+        registry = AgentHarness::Providers::Registry.instance
 
-        # Check each provider adapter for support
-        provider_classes = [
-          Aidp::Providers::Anthropic,
-          Aidp::Providers::Cursor,
-          Aidp::Providers::Gemini
-        ]
-
-        provider_classes.each do |provider_class|
+        # Check each registered provider for support
+        registry.all.each do |provider_name|
+          provider_class = registry.get(provider_name)
           next unless provider_class.respond_to?(:supports_model_family?)
 
           if provider_class.supports_model_family?(family_name)
-            # Get the provider name from an instance (need to instantiate to call name method)
-            # Or use a simple name mapping
-            provider_name = provider_class.name.split("::").last.downcase
-            providers << provider_name
+            providers << provider_name.to_s
           end
         rescue => e
           # Log but don't fail if provider check fails
-          Aidp.log_debug("models_command", "provider check failed", provider: provider_class.name, error: e.message)
+          Aidp.log_debug("models_command", "provider check failed", provider: provider_name, error: e.message)
         end
 
         providers
@@ -455,9 +449,8 @@ module Aidp
       end
 
       def get_provider_class(provider_name)
-        class_name = "Aidp::Providers::#{provider_name.capitalize}"
-        Object.const_get(class_name)
-      rescue NameError
+        AgentHarness::Providers::Registry.instance.get(provider_name.to_sym)
+      rescue AgentHarness::ConfigurationError
         nil
       end