aidp 0.33.0 → 0.34.0

data/lib/aidp/harness/ai_decision_engine.rb

@@ -187,6 +187,85 @@ module Aidp
           },
           default_tier: "mini",
           cache_ttl: nil
+        },
+
+        # FIX for issue #391: Prompt effectiveness evaluation for stuck work loops
+        prompt_evaluation: {
+          prompt_template: "{{prompt}}",  # Custom prompt provided by caller
+          schema: {
+            type: "object",
+            properties: {
+              effective: {
+                type: "boolean",
+                description: "True if the prompt is likely to lead to completion"
+              },
+              issues: {
+                type: "array",
+                items: {type: "string"},
+                description: "Specific problems with the current prompt"
+              },
+              suggestions: {
+                type: "array",
+                items: {type: "string"},
+                description: "Actionable suggestions to improve effectiveness"
+              },
+              likely_blockers: {
+                type: "array",
+                items: {type: "string"},
+                description: "Potential blockers preventing progress"
+              },
+              confidence: {
+                type: "number",
+                minimum: 0.0,
+                maximum: 1.0,
+                description: "Confidence in this assessment"
+              }
+            },
+            required: ["effective", "issues", "suggestions", "confidence"]
+          },
+          default_tier: "mini",
+          cache_ttl: nil
+        },
+
+        # FIX for issue #391: Template improvement suggestions for AGD pattern
+        template_improvement: {
+          prompt_template: "{{prompt}}",  # Custom prompt provided by caller
+          schema: {
+            type: "object",
+            properties: {
+              improved_sections: {
+                type: "array",
+                items: {
+                  type: "object",
+                  properties: {
+                    section_name: {type: "string"},
+                    original: {type: "string"},
+                    improved: {type: "string"},
+                    rationale: {type: "string"}
+                  }
+                }
+              },
+              additional_sections: {
+                type: "array",
+                items: {
+                  type: "object",
+                  properties: {
+                    section_name: {type: "string"},
+                    content: {type: "string"},
+                    rationale: {type: "string"}
+                  }
+                }
+              },
+              completion_criteria_improvements: {
+                type: "array",
+                items: {type: "string"},
+                description: "Improvements to completion criteria definitions"
+              }
+            },
+            required: ["improved_sections", "completion_criteria_improvements"]
+          },
+          default_tier: "standard",  # Use standard tier for thoughtful improvements
+          cache_ttl: nil
         }
       }.freeze
 

data/lib/aidp/harness/capability_registry.rb

@@ -21,6 +21,8 @@ module Aidp
       }.freeze
 
       attr_reader :catalog_path
+      # Expose for testability
+      attr_reader :catalog_data
 
       def initialize(catalog_path: nil, root_dir: nil)
         @root_dir = root_dir || Dir.pwd

data/lib/aidp/harness/condition_detector.rb

@@ -6,6 +6,9 @@ module Aidp
   module Harness
     # Detects run conditions (rate limits, user feedback, completion, errors)
     class ConditionDetector
+      # Expose patterns for testability
+      attr_reader :rate_limit_patterns, :user_feedback_patterns, :question_patterns, :reset_time_patterns
+
       def initialize
         # Enhanced rate limit patterns for different providers
         @rate_limit_patterns = {

data/lib/aidp/harness/config_loader.rb

@@ -9,6 +9,9 @@ module Aidp
   module Harness
     # Enhanced configuration loader for harness
     class ConfigLoader
+      # Expose for testability
+      attr_reader :validator
+
       def initialize(project_dir = Dir.pwd, validator: nil)
         @project_dir = project_dir
         @validator = validator || ConfigValidator.new(project_dir)

data/lib/aidp/harness/enhanced_runner.rb

@@ -23,6 +23,15 @@ module Aidp
         error: "error"
       }.freeze
 
+      # Expose state for testability
+      attr_accessor :state, :current_step, :start_time
+      attr_writer :current_provider, :user_input, :execution_log
+      attr_accessor :mode, :project_dir, :selected_steps, :workflow_type
+      attr_reader :provider_manager, :sleeper
+      attr_writer :completion_checker, :workflow_controller, :error_handler
+      attr_accessor :condition_detector
+      attr_writer :state_manager, :configuration
+
       # Simple sleeper abstraction for test control
       class Sleeper
         def sleep(duration)
@@ -75,27 +84,21 @@ module Aidp
         @completion_checker = options[:completion_checker] || CompletionChecker.new(@project_dir, @workflow_type)
       end
 
-      # Get current provider (delegate to provider manager)
+      # Get current provider (delegate to provider manager with fallback)
       def current_provider
         @current_provider || @provider_manager&.current_provider || "unknown"
       end
 
-      # Get current step
-      attr_reader :current_step
-
-      # Get user input
+      # Get user input (with nil safety)
       def user_input
         @user_input || {}
       end
 
-      # Get execution log
+      # Get execution log (with nil safety)
       def execution_log
         @execution_log || []
       end
 
-      # Get provider manager
-      attr_reader :provider_manager
-
       # Main execution method with enhanced TUI
       def run
         @state = STATES[:running]
@@ -354,7 +357,7 @@ module Aidp
           duration: @start_time ? Time.now - @start_time : 0,
           user_input_count: @user_input.size,
           execution_log_count: @execution_log.size,
-          jobs_count: @tui.instance_variable_get(:@jobs).size
+          jobs_count: @tui.jobs.size
         }
       end
 
@@ -530,7 +533,7 @@ module Aidp
 
       def cleanup
         # Cleanup any remaining jobs
-        @tui.instance_variable_get(:@jobs).keys.each do |job_id|
+        @tui.jobs.keys.each do |job_id|
           @tui.remove_job(job_id)
         end
       end

data/lib/aidp/harness/error_handler.rb

@@ -12,6 +12,9 @@ module Aidp
     class ErrorHandler
       include Aidp::DebugMixin
 
+      # Expose internal components for testability
+      attr_reader :retry_strategies, :backoff_calculator, :error_classifier, :recovery_planner
+
       # Simple wrapper to allow dependency injection of sleep behavior in tests
       class Sleeper
         def sleep(seconds)

data/lib/aidp/harness/provider_factory.rb

@@ -15,6 +15,9 @@ module Aidp
   module Harness
     # Factory for creating configured provider instances
     class ProviderFactory
+      # Expose for testability
+      attr_reader :provider_instances, :provider_configs
+
       PROVIDER_CLASSES = {
         "cursor" => Aidp::Providers::Cursor,
         "anthropic" => Aidp::Providers::Anthropic,

data/lib/aidp/harness/provider_manager.rb

@@ -13,6 +13,12 @@ module Aidp
       include Aidp::MessageDisplay
       include Aidp::RescueLogging
 
+      # Expose state for testability
+      attr_accessor :sticky_sessions, :load_balancing_enabled
+      attr_writer :current_model
+      attr_accessor :provider_health, :provider_metrics, :rate_limit_info
+      attr_reader :binary_check_cache, :binary_check_ttl
+
       def initialize(configuration, prompt: TTY::Prompt.new, binary_checker: Aidp::Util)
         @configuration = configuration
         @prompt = prompt

data/lib/aidp/harness/runner.rb

@@ -23,7 +23,11 @@ module Aidp
       }.freeze
 
       # Public accessors for testing and integration
-      attr_reader :current_provider, :current_step, :user_input, :execution_log, :provider_manager, :clarification_questions
+      attr_reader :clarification_questions, :last_error
+      attr_accessor :current_provider, :current_step, :user_input, :execution_log, :provider_manager
+      attr_accessor :state, :mode, :project_dir, :configuration, :condition_detector
+      attr_accessor :state_manager, :user_interface, :error_handler, :status_display
+      attr_writer :completion_checker, :workflow_type, :non_interactive
 
       def initialize(project_dir, mode = :analyze, options = {})
         @project_dir = project_dir

data/lib/aidp/harness/state/persistence.rb

@@ -11,6 +11,9 @@ module Aidp
       class Persistence
         include Aidp::SafeDirectory
 
+        # Expose for testability
+        attr_reader :state_file, :lock_file
+
         def initialize(project_dir, mode, skip_persistence: false)
           @project_dir = project_dir
           @mode = mode

data/lib/aidp/harness/state_manager.rb

@@ -14,6 +14,9 @@ module Aidp
     class StateManager
       include Aidp::SafeDirectory
 
+      # Expose for testability
+      attr_reader :project_dir, :mode
+
       def initialize(project_dir, mode, skip_persistence: false)
         @project_dir = project_dir
         @mode = mode

data/lib/aidp/harness/status_display.rb

@@ -9,6 +9,17 @@ module Aidp
     class StatusDisplay
       include Aidp::MessageDisplay
 
+      # Expose state for testability
+      attr_accessor :current_step, :current_provider, :current_model
+      attr_accessor :start_time, :running
+      attr_accessor :performance_metrics, :error_summary
+      attr_accessor :provider_status, :token_usage, :circuit_breaker_status
+      attr_accessor :rate_limit_status, :recovery_status, :user_feedback_status
+      attr_accessor :work_completion_status, :display_config
+      attr_reader :status_formatter, :metrics_calculator, :alert_manager, :display_animator
+      # Internal status hash (separate from computed status_data method)
+      attr_accessor :internal_status_data
+
       def initialize(provider_manager = nil, metrics_manager = nil, circuit_breaker_manager = nil, error_logger = nil, prompt: TTY::Prompt.new)
         @provider_manager = provider_manager
         @metrics_manager = metrics_manager
@@ -27,6 +38,7 @@ module Aidp
         @update_interval = 2
         @last_update = Time.now
         @status_data = {}
+        @internal_status_data = @status_data # Alias for testability
         @performance_metrics = {}
         @error_summary = {}
         @provider_status = {}
@@ -167,16 +179,24 @@ module Aidp
         @error_summary[:last_updated] = Time.now
       end
 
-      # Set display mode
-      def display_mode(mode)
-        @display_mode = mode
-        @display_config[:mode] = mode
+      # Get or set display mode
+      def display_mode(mode = nil)
+        if mode.nil?
+          @display_mode
+        else
+          @display_mode = mode
+          @display_config[:mode] = mode
+        end
       end
 
-      # Set update interval
-      def update_interval(interval)
-        @update_interval = interval
-        @display_config[:update_interval] = interval
+      # Get or set update interval
+      def update_interval(interval = nil)
+        if interval.nil?
+          @update_interval
+        else
+          @update_interval = interval
+          @display_config[:update_interval] = interval
+        end
       end
 
       # Configure display settings
@@ -686,8 +706,6 @@ module Aidp
         }
       end
 
-      attr_reader :provider_status
-
       def performance_status
         @performance_metrics
       end
@@ -696,20 +714,10 @@ module Aidp
         @error_summary
       end
 
-      attr_reader :circuit_breaker_status
-
       def token_status
         @token_usage
       end
 
-      attr_reader :rate_limit_status
-
-      attr_reader :recovery_status
-
-      attr_reader :user_feedback_status
-
-      attr_reader :work_completion_status
-
       def alerts
         @alert_manager.active_alerts
       end

data/lib/aidp/harness/thinking_depth_manager.rb

@@ -15,7 +15,7 @@ module Aidp
 
       def initialize(configuration, registry: nil, root_dir: nil)
         @configuration = configuration
-        @registry = registry || CapabilityRegistry.new(root_dir: root_dir || configuration.instance_variable_get(:@project_dir))
+        @registry = registry || CapabilityRegistry.new(root_dir: root_dir || configuration.project_dir)
         @current_tier = nil
         @session_max_tier = nil
         @tier_history = []
@@ -243,50 +243,47 @@ module Aidp
               model: model_name)
             return [provider, model_name, model_data]
           end
-
-          # If provider doesn't support tier and switching allowed, try others
-          unless configuration.allow_provider_switch_for_tier?
-            Aidp.log_warn("thinking_depth_manager", "Provider lacks tier in catalog, switching disabled",
-              tier: tier,
-              provider: provider)
-            return nil
-          end
-        end
-
-        # Try all providers in catalog
-        if provider && !configuration.allow_provider_switch_for_tier?
-          return nil
+          # Per issue #323: Don't return nil here - let fallback logic handle missing tiers
         end
 
-        providers_to_try = provider ? [@registry.provider_names - [provider]].flatten : @registry.provider_names
+        # Try all providers in catalog if provider switching is allowed
+        if configuration.allow_provider_switch_for_tier?
+          providers_to_try = provider ? (@registry.provider_names - [provider]) : @registry.provider_names
 
-        providers_to_try.each do |prov_name|
-          model_name, model_data = @registry.best_model_for_tier(tier, prov_name)
-          if model_name
-            Aidp.log_info("thinking_depth_manager", "Selected model from catalog (alternate provider)",
-              tier: tier,
-              original_provider: provider,
-              selected_provider: prov_name,
-              model: model_name)
-            return [prov_name, model_name, model_data]
+          providers_to_try.each do |prov_name|
+            model_name, model_data = @registry.best_model_for_tier(tier, prov_name)
+            if model_name
+              Aidp.log_info("thinking_depth_manager", "Selected model from catalog (alternate provider)",
+                tier: tier,
+                original_provider: provider,
+                selected_provider: prov_name,
+                model: model_name)
+              return [prov_name, model_name, model_data]
+            end
           end
         end
 
         # No model found for requested tier - try fallback to other tiers
-        Aidp.log_warn("thinking_depth_manager", "No model found for requested tier, trying fallback",
+        # Per issue #323: fallback events log at debug level
+        Aidp.log_debug("thinking_depth_manager", "tier_not_found_trying_fallback",
           tier: tier,
           provider: provider)
 
         result = try_fallback_tiers(tier, provider)
 
-        if provider_has_no_tiers && result.nil? && provider
-          Aidp.log_info("thinking_depth_manager", "No configured tiers for provider, deferring to provider auto model selection",
+        # If no model found after fallback, defer to provider auto model selection
+        # This allows providers to select their own model when no explicit tier config exists
+        # Per issue #323: log at debug level, don't constrain model selection
+        if result.nil? && provider
+          Aidp.log_debug("thinking_depth_manager", "no_model_for_tier_deferring_to_provider",
             requested_tier: tier,
-            provider: provider)
-          return [provider, nil, {auto_model: true, reason: "provider_has_no_tiers"}]
+            provider: provider,
+            reason: provider_has_no_tiers ? "provider_has_no_tiers" : "tier_not_configured")
+          return [provider, nil, {auto_model: true, reason: provider_has_no_tiers ? "provider_has_no_tiers" : "tier_not_configured"}]
         end
 
         unless result
+          # This path should only be reached when no provider is specified
           # Enhanced error message with discovery hints
           display_enhanced_tier_error(tier, provider)
 
@@ -452,7 +449,8 @@ module Aidp
 
             if configured_models.any?
               model_name = configured_models.first
-              Aidp.log_warn("thinking_depth_manager", "Falling back to different tier (from config)",
+              # Per issue #323: fallback events log at debug level
+              Aidp.log_debug("thinking_depth_manager", "tier_fallback_from_config",
                 requested_tier: requested_tier,
                 fallback_tier: fallback_tier,
                 provider: provider,
@@ -466,7 +464,8 @@ module Aidp
           if provider
             model_name, model_data = @registry.best_model_for_tier(fallback_tier, provider)
             if model_name
-              Aidp.log_warn("thinking_depth_manager", "Falling back to different tier (from catalog)",
+              # Per issue #323: fallback events log at debug level
+              Aidp.log_debug("thinking_depth_manager", "tier_fallback_from_catalog",
                 requested_tier: requested_tier,
                 fallback_tier: fallback_tier,
                 provider: provider,
@@ -482,7 +481,8 @@ module Aidp
 
               model_name, model_data = @registry.best_model_for_tier(fallback_tier, prov_name)
               if model_name
-                Aidp.log_warn("thinking_depth_manager", "Falling back to different tier and provider (from catalog)",
+                # Per issue #323: fallback events log at debug level
+                Aidp.log_debug("thinking_depth_manager", "tier_fallback_provider_switch",
                   requested_tier: requested_tier,
                   fallback_tier: fallback_tier,
                   requested_provider: provider,

data/lib/aidp/harness/ui/enhanced_tui.rb

@@ -20,6 +20,10 @@ module Aidp
 
         class DisplayError < TUIError; end
 
+        # Expose state for testability
+        attr_accessor :headless, :current_mode, :workflow_active, :current_step
+        attr_reader :jobs
+
         def initialize(prompt: TTY::Prompt.new, tty: $stdin)
           @cursor = TTY::Cursor
           @screen = TTY::Screen

data/lib/aidp/harness/ui/enhanced_workflow_selector.rb

@@ -11,6 +11,10 @@ module Aidp
       class EnhancedWorkflowSelector
         class WorkflowError < StandardError; end
 
+        # Expose state for testability
+        attr_reader :tui, :project_dir, :user_input
+        attr_accessor :workflow_selector
+
         def initialize(tui = nil, project_dir: Dir.pwd)
           @tui = tui || EnhancedTUI.new
           @user_input = {}

data/lib/aidp/harness/ui/error_handler.rb

@@ -18,6 +18,9 @@ module Aidp
 
         class InteractionError < UIError; end
 
+        # Expose for testability
+        attr_reader :logger
+
         def initialize(ui_components = {})
           @logger = ui_components[:logger] || default_logger
           @formatter = ui_components[:formatter] || ErrorFormatter.new

data/lib/aidp/harness/ui/job_monitor.rb

@@ -17,6 +17,10 @@ module Aidp
 
         class MonitorError < JobMonitorError; end
 
+        # Expose for testability
+        attr_accessor :monitor_thread
+        attr_reader :update_callbacks
+
         JOB_STATUSES = {
           pending: "Pending",
           running: "Running",

data/lib/aidp/harness/ui/navigation/submenu.rb

@@ -22,6 +22,8 @@ module Aidp
 
           attr_reader :title, :parent_menu
           attr_accessor :drill_down_enabled, :max_depth
+          # Expose current_level for testability
+          attr_accessor :current_level
 
           def add_submenu_item(item)
             validate_submenu_item(item)

data/lib/aidp/harness/ui/navigation/workflow_selector.rb

@@ -17,6 +17,9 @@ module Aidp
 
           class SelectionError < WorkflowError; end
 
+          # Expose for testability
+          attr_reader :prompt
+
           WORKFLOW_MODES = {
             simple: {
               name: "Simple Mode",
@@ -132,6 +135,9 @@ module Aidp
 
         # Formats workflow selection display
         class WorkflowFormatter
+          # Expose for testability
+          attr_reader :pastel
+
           def initialize
             @pastel = Pastel.new
           end

data/lib/aidp/harness/ui/spinner_helper.rb

@@ -11,6 +11,9 @@ module Aidp
       class SpinnerHelper
         class SpinnerError < StandardError; end
 
+        # Expose for testability
+        attr_accessor :active_spinners
+
         def initialize
           @pastel = Pastel.new
           @active_spinners = []

data/lib/aidp/harness/ui/workflow_controller.rb

@@ -16,6 +16,9 @@ module Aidp
 
         class ControlError < WorkflowError; end
 
+        # Expose for testability
+        attr_accessor :pause_time, :control_thread
+
         WORKFLOW_STATES = {
           running: "Running",
           paused: "Paused",

data/lib/aidp/harness/user_interface.rb

@@ -9,6 +9,9 @@ module Aidp
     class UserInterface
       include Aidp::MessageDisplay
 
+      # Expose for testability
+      attr_reader :auto_confirm_defaults, :show_help_automatically, :verbose_mode, :file_selection_enabled
+
       def initialize(prompt: TTY::Prompt.new)
         @input_history = []
         @file_selection_enabled = false

data/lib/aidp/loader.rb

@@ -21,10 +21,10 @@ module Aidp
   module Loader
     class << self
       # @return [Zeitwerk::Loader, nil] The configured loader instance
-      attr_reader :loader
+      attr_accessor :loader
 
       # @return [Boolean] Whether reloading is enabled
-      attr_reader :reloading_enabled
+      attr_accessor :reloading_enabled
 
       # Set up the Zeitwerk loader for AIDP
       #

data/lib/aidp/logger.rb

@@ -307,6 +307,9 @@ module Aidp
 
   # Module-level logger accessor
   class << self
+    # Expose for testability
+    attr_writer :logger
+
     # Set up global logger instance
     def setup_logger(project_dir = Dir.pwd, config = {})
       @logger = Logger.new(project_dir, config)

data/lib/aidp/message_display.rb

@@ -8,6 +8,11 @@ module Aidp
   #   include Aidp::MessageDisplay
   #   display_message("Hello", type: :success)
   # Supports color types: :error, :success, :warning, :info, :highlight, :muted
+  #
+  # Quiet mode:
+  #   When quiet mode is enabled (via CLI --quiet flag or setting quiet=true on instance),
+  #   only :error, :warning, and :success messages are displayed. Info, highlight, and muted
+  #   messages are suppressed to reduce output noise.
   module MessageDisplay
     COLOR_MAP = {
       error: :red,
@@ -19,12 +24,28 @@ module Aidp
       muted: :bright_black
     }.freeze
 
+    # Message types that are always shown even in quiet mode
+    CRITICAL_TYPES = %i[error warning warn success].freeze
+
     def self.included(base)
       base.extend(ClassMethods)
     end
 
+    # Check if quiet mode is enabled
+    # Priority: instance @quiet variable > CLI.last_options[:quiet]
+    def quiet_mode?
+      return @quiet if instance_variable_defined?(:@quiet) && !@quiet.nil?
+
+      Aidp::CLI.last_options&.dig(:quiet) || false
+    rescue
+      false
+    end
+
     # Instance helper for displaying a colored message via TTY::Prompt
     def display_message(message, type: :info)
+      # In quiet mode, suppress non-critical messages
+      return if quiet_mode? && !CRITICAL_TYPES.include?(type)
+
       # Ensure message is UTF-8 encoded to handle emoji and special characters
       message_str = message.to_s
       message_str = message_str.force_encoding("UTF-8") if message_str.encoding.name == "ASCII-8BIT"
@@ -43,8 +64,18 @@ module Aidp
     end
 
     module ClassMethods
+      # Check if quiet mode is enabled at class level
+      def quiet_mode?
+        Aidp::CLI.last_options&.dig(:quiet) || false
+      rescue
+        false
+      end
+
       # Class-level display helper (uses fresh prompt to respect $stdout changes)
       def display_message(message, type: :info)
+        # In quiet mode, suppress non-critical messages
+        return if quiet_mode? && !CRITICAL_TYPES.include?(type)
+
         # Ensure message is UTF-8 encoded to handle emoji and special characters
         message_str = message.to_s
         message_str = message_str.force_encoding("UTF-8") if message_str.encoding.name == "ASCII-8BIT"